GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/291843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271852 0039d316-1c4b-4281-b951-d872f2087c98

gyp itself treats any whitespace as a delimiter in GYP_DEFINES, this script should behave the same.

NOTRY=true

Review URL: https://codereview.chromium.org/290173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271851 0039d316-1c4b-4281-b951-d872f2087c98

Fix broken Widget::InitParams::activatable logic as a result of https://codereview.chromium.org/286733002

This CL modifies the default return value of WidgetDelegate::CanActivate() based on the type passed into WidgetDelegate::InitParams::type
This allows whether the widget is activatable to change over time. In particular, whether the zoom bubble can be activated can change over its lifetime

BUG=353533,374095
TEST=None

Review URL: https://codereview.chromium.org/293833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271850 0039d316-1c4b-4281-b951-d872f2087c98

This is part 1 (of N) of my rearranging things to make passing FDs
actually work correctly.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/292983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375383

Review URL: https://codereview.chromium.org/292983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338

Review URL: https://codereview.chromium.org/281383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/290343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314805

Review URL: https://codereview.chromium.org/288153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362783

Review URL: https://codereview.chromium.org/292933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271840 0039d316-1c4b-4281-b951-d872f2087c98

Add a device scale factor parameter to SoftwareOutputDevice::Resize and
plumb that parameter through to the contentsScale property of the CALayer
that is used to draw the software frame.

Change the way that RWHVMac draws software frames (both delegated and
non-delegated) so that the CALayer for the software frame has setContents
called on it with a CGImageRef of the software frame, instead of drawing
the CGImageRef to the inside the CALayer's displayInContext function. This
is the way that things should have been done to begin with (it involves a lot
less copying and a lot more idle time in the browser main thread), but wasn't
compatible with the (now-defunct) legacy software path.

Change the software rendering path to set the contentsScale of the software
CALayer at the time that the software frame is received, when the contents
are updated, instead of in RWHVMac::LayoutLayers.

BUG=314190

Review URL: https://codereview.chromium.org/297573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271839 0039d316-1c4b-4281-b951-d872f2087c98

This was introduced in
"Move touch CTM from X into Chrome" for fixing chrome-os-partner:25788.

BUG=chrome-os-partner:25788

Review URL: https://codereview.chromium.org/296003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271838 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271833 0039d316-1c4b-4281-b951-d872f2087c98

Also remove several tests related to testing on neutral channel signals.
Replacement tests will be added when we switch to starting and stopping
GCM on demand in the future patch.

BUG=356716
TEST=tests updated
TBR=kalman@chromium.org,pavely@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/286213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271832 0039d316-1c4b-4281-b951-d872f2087c98

This should also allow the following to be addressed: 
* https://code.google.com/p/webrtc/issues/detail?id=2846
* https://code.google.com/p/webrtc/issues/detail?id=2749

It also addresses (using fixes we pushed upstream to usrsctp):
BUG=crbug.com/360867 (Chromium+Clang+Windows build)

Review URL: https://codereview.chromium.org/266093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=browser_tests --gtest_filter=WebViewTest.*Visib*

Review URL: https://codereview.chromium.org/292923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271829 0039d316-1c4b-4281-b951-d872f2087c98

Flaking on ChromeOS and Windows, so disabling altogether.

BUG=357311
NOTRY=true

Review URL: https://codereview.chromium.org/296703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271828 0039d316-1c4b-4281-b951-d872f2087c98

So CQ works on https://codereview.chromium.org/290713002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/288343008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271827 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271824 0039d316-1c4b-4281-b951-d872f2087c98

Breaks Google Chrome Linux x64 compile:
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=50183

> [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled.
> 
> Also, remove a no longer needed testing pref.
> 
> BUG=374296
> TEST=compiles
> R=asvitkine@chromium.org
> 
> Review URL: https://codereview.chromium.org/284293003

TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/296703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/292583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/292653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/289373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374445
NOTRY=true

Review URL: https://codereview.chromium.org/289233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271818 0039d316-1c4b-4281-b951-d872f2087c98

In android_commands.py's GetFilesChanged function,
realpath command fails when the path does not exist.
Create the path before we call GetFilesChanged.

BUG=374859

Review URL: https://codereview.chromium.org/293803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271817 0039d316-1c4b-4281-b951-d872f2087c98

Rather than route this through RemoteWindowTreeHostWin (which can now
be NULL) I'm routing it through ChromeMetroViewerProcessHost. I'm also
adding a NULL check as it may be possible in some code paths for the
host to have been disconnected and therefor NULL.

BUG=374766
TEST=none
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/297713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271816 0039d316-1c4b-4281-b951-d872f2087c98

This is a followup patch to r271682, where I const-ified GetPreferredSize() and GetMinimumSize(), but deferred this because that patch touched 400 files.

BUG=155363
R=sky@chromium.org
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/296823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271815 0039d316-1c4b-4281-b951-d872f2087c98

SandboxBPF users are now required to always provide a SandboxBPFPolicy
instead of a SyscallEvaluator. CompatibilityPolicy can't be removed
just yet though because it's still used by the deprecated BPF_TEST
macros.

Review URL: https://codereview.chromium.org/286903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271814 0039d316-1c4b-4281-b951-d872f2087c98

Virtual keyboard starts with a height of 0, which makes us wait for a frame at
that size which will never come.
RWHI will skip the resizes for this, hence will not throttle the next (correct)
size, which will come in but then be discarded.

Make sure not to create a resize lock for empty sizes.

BUG=374196

Review URL: https://codereview.chromium.org/284413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271813 0039d316-1c4b-4281-b951-d872f2087c98

Maximize window vertically or horizontally when the maximize button is middle or right clicked on Linux respectively.

BUG=362546
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/288203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367239

Review URL: https://codereview.chromium.org/290413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271811 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/297723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271810 0039d316-1c4b-4281-b951-d872f2087c98

This is a separate change to add the icon for Web MIDI permission.
Following change will use it to show infobar icon.

BUG=339767

Review URL: https://codereview.chromium.org/298753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271809 0039d316-1c4b-4281-b951-d872f2087c98

Original review: https://codereview.chromium.org/267743010/

BUG=364949
Test=MaximizeModeControllerTest.BlockRotationNotifications
TBR=flackr
TBR=sadrul

Review URL: https://codereview.chromium.org/291233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/288923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271807 0039d316-1c4b-4281-b951-d872f2087c98

Simple bit-flipping won't generate negative offsets (e.g. large
positive offsets that overflow), so we add a test where we specifically
create the possibility of such.

Also simplify argument passing in the cpp -> js direction, since there isn't
a need to build lists here.  We're only interested in the other direction.

Remove some stray "explicit" keywords and reduce the echo
test iterations since it doesn't prove much.

Review URL: https://codereview.chromium.org/292243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271806 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

R=rtenneti@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/296433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:796

Review URL: https://codereview.chromium.org/275193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230018
TEST=manual

Review URL: https://codereview.chromium.org/270663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271802 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/292883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271801 0039d316-1c4b-4281-b951-d872f2087c98

This CL extends the separation Factory/device
initiated in the other CLs part of the bug. Aside
from code cleanup, it allows for better testing
(via dependency injection) of the factory parts
(this is specially important for blacklisted devices,
of which there are none in Win ATM). It can also
be used to modify the GetDeviceNames() method to
an asynchronous API.

Both VideoCaptureDeviceWin and VideoCaptureDeviceMFwin 
(using DirectShow and MediaFoundation APIs resp.),
have a number of static methods Create(),
GetDeviceNames() and GetDeviceSupportedFormats().
Plus, there are overarching versions of those
at the VideoCaptureDevice level, that do library
initialisation and appropriate forwarding to one
or the other implementation. This CL extracts all
of those class-static methods and moves them to
a single VideoCaptureDeviceFactoryWin.

ScopedMediaType, previously file-level data type
moves to the public def of VideoCaptureDeviceWin
since is used in the Factory.

Every file-static function and variable that could,
has been moved to the Factory file. Previous 
file-level static functions that are used in the
Factory and the VCD have been changed to VCD
static methods and used in both ends.

TBR= dalecurtis@chromium.org (media/media.gyp)

BUG=323913

Review URL: https://codereview.chromium.org/276383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271800 0039d316-1c4b-4281-b951-d872f2087c98