- 05 Feb, 2020 40 commits
-
-
Joel Hockey authored
Unsharing a crostini folder can fail if a user has a file open in some application. When this happens, we will show a dialog to the user to inform them that unsharing has failed and allow them to retry the unsharing presumably after they have closed associated files. Bug: 920416 Change-Id: I303200f7e0e40fe8c7e1382bf19878d7ed2b31fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037276Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#738462}
-
Ionel Popescu authored
Prior to this CL on platforms where popups don't have drop shadow, the content of the popups is going to blend with the rest of the page. This CL adds border to popups in order to avoid the issue described above. Bug: 1048219 Change-Id: Ifb69fb204239f8d95f6b3feab704505709cbddf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036250 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738461}
-
Yoshisato Yanagisawa authored
Since it is out of src by default, it is not possible for us to provide hermetic compile. Let me make that within Chromium src. Bug: 1015730 Change-Id: I4283a6ccf54d8f30401a6ad3f0084b7fe791b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027015 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#738460}
-
Ben Mason authored
This reverts commit 835cde27. Reason for revert: Causing crash: crbug/1048145 Original change's description: > Add DomainDiversityReporter for domain diversity metrics > > This CL adds DomainDiversityReporter to schedule domain metrics > computation tasks and emit histograms. The reporting task is > executed shortly after startup and then scheduled once per 24 > hours thereafter. > > Bug: 1015424 > Change-Id: Id4b8043c1a9b9ea0ee70d4be68e9c35017a82de1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864522 > Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735713} TBR=sadrul@chromium.org,sky@chromium.org,mpearson@chromium.org,gab@chromium.org,mjzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015424 Change-Id: I8b9d3f2b9866569cf7f55d842cca19bd2c3f65c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037952Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#738459}
-
Austin Eng authored
This test is flaky on Win NVIDIA GTX 1660 - D3D11 TBR=kbr@chromium.org Bug: angleproject:4377 Change-Id: I0bbd316794186d7362790a34dea57a0dc09056c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038270Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#738458}
-
Kevin Marshall authored
Allows embedders to specify a virtual resolution used when rendering web content. Web content will be laid out differently, either supersampled or subsampled depending on whether the overridden resolution is smaller or larger relative to the View's native resolution. The virtual resolution is then scaled to fit the View. The GPU surface resolution will remain unaffected; it is the same as the View's native resolution. Bug: b/144361044,b/144725868 Change-Id: Iefaa0059235319420dc1e050d33d706c1d96ab18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977001 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738457}
-
Toby Huang authored
Child users should not be able to install extensions and themes with mature content from Chrome Web Store (CWS). Add a new disable reason BLOCKED_MATURE to block any extensions or themes marked mature in CWS for child users. Bug: 1037965,1040614 Change-Id: I37cec6efb51e0e88c1714e57be0ef279b1b32ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017646 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#738456}
-
Ankit Kumar authored
The CL enables highlight feature flag kAccessiblePDFHighlight in PDFExtensionAccessibilityTextExtractionTest. The CL updates the test expectation file as well. Bug: 1008775 Change-Id: Ic09596e920e409d4c2290092317bde1510571bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035491Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738455} -
Andrew Grieve authored
We are now generating ID ranges for .grd files as part of the build. The tool was already smart enough to leave padding for each range so that the ranges would not change for every single resource added / removed. However, since it was unconditinoally writing the resource_ids file, ninja was considering all grit targets as stale even when ID ranges did not change. We now write the file only when it is changing so that ninja will not consider grit targets stale in the did-not-change case. Bug: 979886 Change-Id: Ib38620e1be097b31ec876be9b07172a7ff945c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036528 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738454}
-
Koji Ishii authored
Following bot results are included. 1263 1266 1267 1268 1271 1273 1275 1276 8 lines were removed and 12 lines were deflaked by consecutive results since 1255. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I9b26ee7e124c921421664fab8e943c9ef75c5f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035646Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738453}
-
Rafael Cintron authored
Expose kForwardMemoryPressureEventsToGpuProcess in content_features.h so that it can more easily be used by Chromium hosts. Bug: 1048924 Change-Id: I911f44b0274be30d5b33b01a0ec2c338417920a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036801Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738452}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a779c4ef526e..cba278682002 git log a779c4ef526e..cba278682002 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 rwkeane@google.com mDNS: Change Continuous Multicast Query Handling 2020-02-04 rwkeane@google.com Discovery: Recoverable Error Reporting Created with: gclient setdep -r src/third_party/openscreen/src@cba278682002 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id255d24fd7826077ddfc3dbb2c52934662c526e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037194Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738451}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/047cb6914ae5..e22c450dfeb2 git log 047cb6914ae5..e22c450dfeb2 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-04 chshrest@microsoft.com [Elements]: Keyboard and screen reader accessibility of swatch drag element in color picker Created with: gclient setdep -r src/third_party/devtools-frontend/src@e22c450dfeb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iae2d1dc1dab75f5e890e3937269410bf9dbf9a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038175Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738450}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59a29e3c4f03..8e8e1d0dd729 git log 59a29e3c4f03..8e8e1d0dd729 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com Shader: Add missing switch cases to operationString 2020-02-04 bclayton@google.com OpenGL: Fix switch with only a default case. Created with: gclient setdep -r src/third_party/swiftshader@8e8e1d0dd729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If91d956eb882e7d7b5f9d1ef6109fcb0e426b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738449}
-
Demetrios Papadopoulos authored
- Fix a bug in route.js where pageVisibility is undefined in Polymer 3. - Fix a newly found type-check error in global_scroll_target_begavior.js (only happens in the context of a JS module). - Update search_engines_page/ prod and test code as needed. - Update BUILD.gn, grdp files as needed. Bug: 1026426 Change-Id: Ic2229bebdca80d08189943fabd62e1d86f050a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032669 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738448}
-
Daniel Hosseinian authored
Create a header, hb_scoped.h, which contains std::unique_ptr wrappings of commonly used Harfbuzz objects that clean up the objects when they go out of scope. Subsequently, remove calls of hb_*_destroy() functions in harfbuzz_fuzzer.cc. Bug: 1046803 Change-Id: Icbc13201f77336fe3f7e0f6c9191a0e52c2f76cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034111 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#738447}
-
Yi Xu authored
Fix the crashes in the clusterfuzz: SkPaint::computeFastBounds failed to check if the rect it computes on is finite. Bug: 1041787 Change-Id: If7fc827fb20cbc5f23424b0bb087f39a680a7a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008190Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#738446}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4460b2d2..6a299ca2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4f90b81c6dfc1e8c4aa59e1c07af50878ac781ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738445}
-
Xiaoqian Dai authored
Modified based on the new spec: A window has to be dragged toward the direction of the edge of the screen for a minimum of 96dp to a point within 48dp of the edge of the screen, or dragged inside 8dp from edge to be snapped. Bug: 1021294 Change-Id: I2d79854b37bfdf36bcd5319a856b874233159982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037825Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738444}
-
Mitsuru Oshima authored
Add DCHECK to make sure that panel rotation returns the correct value when a display is updated on Android. Bug: 1048294 Change-Id: Iad2747325ea724a23a66ce340c3c3984ace54a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037640Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30f6fc14e50c..bdd9db2010fa git log 30f6fc14e50c..bdd9db2010fa --date=short --first-parent --format='%ad %ae %s' 2020-02-04 oysteine@google.com Fixed category used for JSON exported StackCpuSampling events 2020-02-04 treehugger-gerrit@google.com Merge "tp: add support for non-Perfetto root relative proto imports in metrics" 2020-02-04 treehugger-gerrit@google.com Merge "gn: Make enable_perfetto_trace_processor overrideable" 2020-02-04 treehugger-gerrit@google.com Merge "UI: fix mm_event path" 2020-02-04 treehugger-gerrit@google.com Merge "processor: Translate streaming profile packet timestamps to boottime" 2020-02-04 treehugger-gerrit@google.com Merge "traced_perf: use address-specific loads/stores for ring buffer pointers" 2020-02-04 fmayer@google.com Merge "Mention enabling Perfetto in heapprofd quickstart." 2020-02-04 taylori@google.com Merge "perfetto-ui: Stop accidental area selections" 2020-02-04 treehugger-gerrit@google.com Merge "remove off64_t wrappers + minor unwind class renaming" 2020-02-04 treehugger-gerrit@google.com Merge changes I1686fefc,Ic59c153c Created with: gclient setdep -r src/third_party/perfetto@bdd9db2010fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1046918 Tbr: perfetto-bugs@google.com Change-Id: If09d813a926b9b96efd602c7eae63a14869920a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738442}
-
Eriko Kurimoto authored
This CL adds shared-worker-options-credentials.html for web-platform-test. Bug: 1048966, 824646 Change-Id: Ib35daf5ba96ddd03bb1881757e86e8251c1a3456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037294 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738441}
-
Julian Watson authored
Bug: 1048962 Change-Id: I7db787ea4d42457507962d6e7b359405117015a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035479 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738440}
-
Ken Rockot authored
Removes the last usage of Mojo associated interfaces from DOM Storage code. Prior to this change, associated interfaces are used to synchronize Clone() operations on a StorageNamespace interface with arbitrary mutations on any StorageArea bound through that StorageNamespace. With the introduction of the Mojo async flushing API in r730829 we can enforce such synchronization without associated interfaces. This CL does that with a simple two-phase flush at clone time: - Flush all related StorageArea pipes immediately prior to Clone - Tell the StorageNamespace pipe to pause until said flushes complete - Call StorageNamespace.Clone() - Flush the StorageNamespace pipe immediately after Clone - Tell all related StorageArea pipes to pause until that flush completes This achieves the necessary ordering constraints for Session Storage cloning without requiring strict ordering among all StorageNamespace and StorageArea messages, consequently allowing StorageNamespace and StorageArea to use independent pipes connected to potentially different processes from each other. This satisfies a key requirement for migrating Session Storage to the Storage Service. Bug: 1000959 Change-Id: Ic1ccc2d6cbfa462733c53d2052d616655b49ed53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036885 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#738439}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e4a40aa1bf4..0165beed0829 git log 2e4a40aa1bf4..0165beed0829 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 fancl@chromium.org Removing requirement of notification_email from subscription Created with: gclient setdep -r src/third_party/catapult@0165beed0829 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1048033 Tbr: rmhasan@google.com Change-Id: I83bade8ad8ceb04a5383eda55d01b5a338e6e638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738438}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e93101895e74..44ea3ffa40fe git log e93101895e74..44ea3ffa40fe --date=short --first-parent --format='%ad %ae %s' 2020-02-05 ehmaldonado@chromium.org Revert "presubmit_support: Add --all-files options." 2020-02-04 ehmaldonado@google.com presubmit_support: Pass a gerrit object instead of a cl object to PostUploadHook. 2020-02-04 ehmaldonado@google.com presubmit_support: Add --all-files options. 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@44ea3ffa40fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:1048885 Tbr: agable@chromium.org Change-Id: Icded7207eee771f694ae4555e93c29deaec79018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738437}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I382b2f7eef3897248263a7c7dda8849f58ca1536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035630Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738436}
-
Christopher Thompson authored
This exposes the control config for legacy TLS errors to the network stack. This is loosely based on the same design that the CRLSet component installer uses: 1. Installer passes to network service via Mojo 2. Network service keeps a LegacyTLSConfigDistributor which tracks observers that care about the config 3. SSLConfigServiceMojo registers an observer to get the latest config 4. SSLConfigService exposes an interface to check ShouldSuppressLegacyTLSWarning() This change also moves the tls_deprecation_config.proto into the network service, and adds a ref counted wrapper around it (so that the LegacyTLSConfigDistributor can pass them to the observers without lifetime issues). This currently duplicates the control config set (there is a copy in the browser and a copy in the network service). A followup CL will address this. The new cert error is introduced in https://crrev.com/c/1894616. The new interstitial is introduced in https://crrev.com/c/1940707. Bug: 896013, 1039756 Change-Id: I31fee71c292ffe8b592d3c6f47c3352ed4475892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906779Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#738435}
-
Mei Liang authored
This CL cleans all existing message cards if GTS can be shown quickly, then re-appends them to the end of GTS. These steps are required, since the internal model resets only when the GTS can't be shown quickly. Change-Id: I30fce1a2eda27e38a42bf05fd6090be769e40427 Bug: 1043202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007344 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738434}
-
Jiawei Shao authored
This patch moves the creation of WireServerCommandSerializer from the constructor of WebGPUDecoderImpl to the call of HandleRequestDevice as the preparation of supporting multiple Dawn devices in the server side. This patch also moves SendRequestedDeviceInfo and SendAdapterProperties from WireServerCommandSerializer to WebGPUDecoderImpl as they are independent of Dawn devices and not related to any wire commands. This patch also passes the device_descriptor in adapter.CreateDevice() which was missed unexpectedly. BUG=chromium:996713 Change-Id: Id12367f077cd89ecd032414c00d9172c7b66756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037089Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#738433}
-
Dana Fried authored
See comment in source code linked to this bug for an explanation. Attached bug contains crash report link. Bug: 1048363 Change-Id: I9b6e3cd10bd8fe1ea5466e950a3a47b61659b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037648 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738432}
-
Yoshifumi Inoue authored
This patch marks "external/wpt/selection/idlharness.window.html" slow. TBR=yosin@chromium.org Bug: 1048204 No-Tree-Checks: true No-Try: true Change-Id: Ibce06c7bb63790ff7c97d060e64c99e16e14755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038294Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738431}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia9bbb3db69735738eee7e3495911673f5c0ed90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038350Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738430}
-
gogerald authored
This CL also fixes the issues that 1, MobileStartup.UserEnteredTabSwitcher is not recorded when onStartWithNative is called earlier than createInitialTab Bug: 1048318 Change-Id: I3549ad1fb250046fe293dd2437375abced1254e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036253 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738429}
-
Ben Pastene authored
These tests have started failing after fec354dc. Tbr: guidou@chromium.org Bug: 1048934 Change-Id: Id54e609d286cea6c4b2506edc11c3bc1433d46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038253 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#738428}
-
Anand K. Mistry authored
Also rename to MountPreconfiguredShare() to avoid the confusion between mount/remount/premount. Bug: 939235 Change-Id: If9df3a55b4aea6852468078b2188974adf35af24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035504 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#738427}
-
Ben Joyce authored
See https://chromium-review.googlesource.com/c/chromium/src/+/1830506 -Update build.gn dependencies for androidx update. -Change an import for androidx annotations that should have been when all other annotation imports were migrated to androidx. Bug: 896775 Change-Id: Ie22118da7841fac029aee37a5c1d10b78325b87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036407Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#738426}
-
Daniele Castagna authored
Originally RemoveOverdrawQuads looped trough all the renderpasses and did some computation for the non-root ones, and then executed occlusion logic on the root one. A CL that removed the computation for non-root renderpasses landed, making the loop always skip his body for all the renderpasses but the root one. This CL removes the loop and executes the occlusion logic only for the root renderpass. Test: RemoveOverdrawQuadPerfTest.* Change-Id: Ie92deae2b5fb65e1f5be605f79bc47bfc9de36bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033368Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#738425}
-
Ken Rockot authored
CachedStorageArea is ref-counted and was retaining an unsafe reference to a GCed object which it may outlive. This changes that reference to a WeakPersistent and ensures that we don't dereference it once it's no longer valid. Fixed: 1048234 Change-Id: I9971b35b9aa7db790236f92c353a2320740f7729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036383 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#738424}
-
Ken Rockot authored
The refactoring in r715377 failed to expose general-purpose child process interfaces to the browser from plugin processes. As a result, histogram collection and tracing don't function as expected in plugin processes. This fixes that. Fixed: 1043019 Change-Id: I7d32e0d4de091cd3e6a343d7cf1604ff65a2ff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037345 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738423}
-