GitLab

This CL updates a comment in in test_runner.h to reflect the fact that:
 - imported/ has been renamed to external/.
 - csswg-test/ is being moved to wpt/css/.

Change-Id: I158c6da888b9af8a123047ffe8369e3c88217792
Reviewed-on: https://chromium-review.googlesource.com/462340
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460614}

This change emits a UKM PageLoad metric for the HTTP RTT estimate, and
one for the transport RTT estimate at navigation start.

BUG=706590

Review-Url: https://codereview.chromium.org/2780303002
Cr-Commit-Position: refs/heads/master@{#460613}

Now that a valid WebWidgetClient must always be passed when creating a
WebFrameWidget we can remove some of the redundant m_client == nullptr checks.

m_client can now become nullptr if close() is called on the WebFrameWidget,
but this is generally caught by checking m_layerTreeView.

To be safe if(m_client) checks have been replaced with DCHECK(m_client).

BUG=696895

Review-Url: https://codereview.chromium.org/2775113002
Cr-Commit-Position: refs/heads/master@{#460612}

The current code appeared to work because a DialogDelegate actually
defaults to focusing the default button ("End Task") rather than nothing
(like a default WidgetDelegate). Thus when you press Shift+Escape the
row for the active tab is selected, and "End Task" is focused. This
"fixed" the blue line around the table.

But on ChromeOS it's possible to have no windows open and press
Shift+Escape, and then the Browser row is selected initially. You're not
allowed to end that task, so the button is disabled.
Widget::SetInitialFocus has code to advance focus if the initial focus
View can't actually receive focus, hence the table winds up receiving
focus.

BUG=702489

Review-Url: https://codereview.chromium.org/2784903002
Cr-Commit-Position: refs/heads/master@{#460611}

This change adds a DiscardableHandle class, which acts as the primary
synchronization mechanism for the GPU Discardable Memory system.

This is the first in a sequence of CLs which implement the GPU
Discardable Memory system. This class is currently only created/used by
unit test code.

BUG=706456
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2732223004
Cr-Commit-Position: refs/heads/master@{#460610}

Add a (d)check in data reduction proxy (DRP) code which verifies that
if the CPAT header is present in the request headers, then ECT header
must be present too.

Other checks added: e.g., chrome-proxy header should only
be sent when the resolved proxy is a data saver proxy.

Finally, the CL also modifies few unittests to avoid tripping the
DCHECKs.

BUG=706650

Review-Url: https://codereview.chromium.org/2771413004
Cr-Commit-Position: refs/heads/master@{#460609}

IndexedDBCursor creation can currently cause OOM's in the browser.
Adding lifetime tracing so that this situation is visible.

R=cmumford
BUG=690517

Review-Url: https://codereview.chromium.org/2745703002
Cr-Commit-Position: refs/heads/master@{#460608}

It seems that corruption examples in crbug.com/699420 can cause extension
resource files to go missing or become unreadable.
Fix a bug where we never sent any notification to ContentVerifyJob,
in particular: we never called ContentVerifyJob::DoneReading().

Override URLRequestFileJob::OnOpenComplete in URLRequestExtensionJob
to catch these cases.

Also make ContentHashReader not skip legitimate deleted files: the
files that are listed in verified_contents.json. It will still skip
non-existent resources, e.g. xhrs requesting non-existent file (see
crbug.com/404802 for example).

BUG=703888
Test=Install an extension (not app) in chromeos. Chromeos because you want
content verification enforcement to kick in. Other way could be to use
--extension-content-verification=enforce_strict flag in other platform.
Either:
1) Delete background script file. Content verifcation would kick in when
you try to load/run the extension.
2) Same as above^^^, instead of deleting the file, remove the file
permission. In linux you can just do "chmod -r background.js". Expect
content verification failure.
In both cases extension should be reinstalled in the end.

Review-Url: https://codereview.chromium.org/2771953003
Cr-Commit-Position: refs/heads/master@{#460607}

These properties provide the width, height, and time of the last video
frame uploaded to a WebGL texture via texImage2D.

BUG=639174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2749653003
Cr-Commit-Position: refs/heads/master@{#460606}

This CL changes how the BackgroundFetchJobController interacts with the
requests that have to be made. It'll be given a sequence of requests when
starting a fetch -currently set to a single request-, will fetch them
and will then get the next request from the BackgroundFetchDataManager
once completed.

This significantly simplifies the state we have to maintain, since it
only knows about the in-progress requests, deferring knowledge of which
requests are pending to the DataManager. The tests have been updated to
match this.

In effect, Background Fetch requests made by the developer will now
actually (sequentially) fetch the files. We still have to feed them
back to the developer once all fetches have been completed.

BUG=692540

Review-Url: https://codereview.chromium.org/2782553007
Cr-Commit-Position: refs/heads/master@{#460605}

Adds ActiveProfilePrefService to allow mash, which currently
supports only one profile and runs its services as the root user,
to talk to that profile. Replaces PreferencesConnectionManager,
which achieves the equivalent goal in the old pref service.

BUG=654988

Review-Url: https://codereview.chromium.org/2772673002
Cr-Commit-Position: refs/heads/master@{#460604}

Bug: 705561, 693821
Change-Id: I682573698ac7c053c44962846744c510b88f4e18
Reviewed-on: https://chromium-review.googlesource.com/462042
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#460603}

Same person, just the account name changed.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2780183003
Cr-Commit-Position: refs/heads/master@{#460602}

It exposes DOMModel already, there is no need for the target.
There is also no need to extend from Common.Object, have an extra field for nothing and provide event listening capabilities.

BUG=none

Review-Url: https://codereview.chromium.org/2778283002
Cr-Commit-Position: refs/heads/master@{#460601}

Here comes another small batch of coverage UX fixes.

BUG=697599

Review-Url: https://codereview.chromium.org/2784993002
Cr-Commit-Position: refs/heads/master@{#460600}

This also allows to use <label for='..'> and removes manual click events.

BUG=none

Review-Url: https://codereview.chromium.org/2776263006
Cr-Commit-Position: refs/heads/master@{#460599}

Ensure that the compositor draws these correctly.

BUG=704389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2769063006
Cr-Commit-Position: refs/heads/master@{#460598}

If the window type is EMBED_IN_OWNER, or TOP_LEVEL_IN_WM, then allocate
a cc::LocalSurfaceId on size change and propagate that new LocalSurfaceId
down to the WindowTreeHost of the embedded client. The embedded client
will use that LocalSurfaceId to submit CompositorFrames.

If surface synchronization is enabled (subsequent patch), then the embedder
can immediately embed the surface ID (if the FrameSinkId is available), and
submit its own CompositorFrame with that embedding. The parent's CompositorFrame
will block until the embedded client submits a CompositorFrame or a deadline is
hit.

BUG=672962

Review-Url: https://codereview.chromium.org/2780043002
Cr-Commit-Position: refs/heads/master@{#460597}

This patch starts to cleanup CSS sourcemaps as they get detached from
host stylesheets.

BUG=670180
R=dgozman

Review-Url: https://codereview.chromium.org/2779703004
Cr-Commit-Position: refs/heads/master@{#460596}

third_party/WebKit/Source/platform/wtf/PassRefPtr.h has a typo on line
47:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/wtf/PassRefPtr.h?dr=CSs&l=47

"ReftPtr"

R=esprehn@chromium.org
BUG=706566

Review-Url: https://codereview.chromium.org/2780903005
Cr-Commit-Position: refs/heads/master@{#460595}

Currently, when collapsing a section, to another route that is part of
a section, we scroll to the new section.

This is not desirable for direct subpage->subpage navigations. This CL
limits that scroll behavior to only when navigating to a section route
(and not when navigating to a subpage route).

BUG=705927
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2777013006
Cr-Commit-Position: refs/heads/master@{#460594}

Local changes which were fixed upstream:

Issue 676623
Fixed upstream with
https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75e8154addae5

Issue 670720
The norm:localTime extension function was removed with the following commit:
https://git.gnome.org/browse/libxslt/commit/?id=b9d63e5f53c29be83f72849e4ac93bb42f737b9b

BUG=705944

Review-Url: https://codereview.chromium.org/2777943003
Cr-Commit-Position: refs/heads/master@{#460593}

PolicyWatcher::Create automatically creates an underlying
AsyncPolicyLoader corresponding to the policy storage location of the
current platform. This commit adds an alternative constructor,
CreateFromPolicyLoaderForTesting, which allows a custom
AsyncPolicyLoader to be specified to allow testing other components with
different policy configurations.

Review-Url: https://codereview.chromium.org/2764333003
Cr-Commit-Position: refs/heads/master@{#460592}

This patch starts using fast malloc (aka partition alloc) for the following
paint-related data structures:
 PaintInfo
 PaintLayerRareData
 PaintArtifactCompositor
 GeometryMapper
 GeometryMapperClipCache
 GeometryMapperTransformCache
 PropertyTreeState

For more information about USING_FAST_MALLOC, see the Allocator.md docs.

Review-Url: https://codereview.chromium.org/2783913002
Cr-Commit-Position: refs/heads/master@{#460591}

QUIC HTTP stream, by centralizing the logic into a single method.

Review-Url: https://codereview.chromium.org/2777333002
Cr-Commit-Position: refs/heads/master@{#460590}

With new fromSurface parameter, this should work on all OSes.

BUG=638281

Review-Url: https://codereview.chromium.org/2773173002
Cr-Commit-Position: refs/heads/master@{#460589}

Review-Url: https://codereview.chromium.org/2782953002
Cr-Commit-Position: refs/heads/master@{#460588}

BUG=706486

Review-Url: https://codereview.chromium.org/2779363002
Cr-Commit-Position: refs/heads/master@{#460587}

Update min engagement_threshold_for_flash to 8, to match the external experiment for HTML5ByDefault.

BUG=706532

Review-Url: https://codereview.chromium.org/2772343008
Cr-Commit-Position: refs/heads/master@{#460586}

The logic was accidentally double-counting the size of a memory region, causing
some memory regions to get skipped.

BUG=706547

Review-Url: https://codereview.chromium.org/2786733004
Cr-Commit-Position: refs/heads/master@{#460585}

Interpret throw(undefined) to mean that an error of any type is
expected.  This is the same as throw().

BUG=706558
TEST=audit.html

Review-Url: https://codereview.chromium.org/2783033002
Cr-Commit-Position: refs/heads/master@{#460584}

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2778283003
Cr-Commit-Position: refs/heads/master@{#460583}

Make network quality estimator (NQE) params a class.

Next CL will move the storing of the params to the Params class
from the NQE class to make it simpler to query the params again and
again. This CL does not make any functional change.

BUG=705691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2775223004
Cr-Commit-Position: refs/heads/master@{#460582}

This allows PlzNavigate to only pause fetching the request if it knows that the page has an onbeforeunload handler, where today it currently always goes to the renderer. This avoids delaying the network requests in the 95% cases that don't onbeforeunload handler on a process hop to the renderer.

BUG=365039,705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=dcheng@chromium.org, nasko@chromium.org

Review-Url: https://codereview.chromium.org/2783723002 .
Cr-Commit-Position: refs/heads/master@{#460581}

Bug: internal b/36447710
Change-Id: I5db3d8203d7c7369a48bff45cbaf582a673c57b6
Review-Url: https://codereview.chromium.org/2786723002
Cr-Commit-Position: refs/heads/master@{#460580}

BUG=697921

Review-Url: https://codereview.chromium.org/2782303002
Cr-Commit-Position: refs/heads/master@{#460579}

BUG=

Review-Url: https://codereview.chromium.org/2779973005
Cr-Commit-Position: refs/heads/master@{#460578}

Currently CompositorResizeLock doesn't work unless deferred since the
base class tries to use a virtual method from its constructor which
doesn't know about the subclass yet.

This fixes that and makes the following changes in the process:

I noticed that there are no longer any unit tests that depend on
ResizeLock being an interface. So I made CompositorResizeLock the
concrete type.

I noticed that CompositorResizeLock was in located in files named
compositor_resize_lock_aura.{h,cc} but is not named for aura anymore,
and is in fact used in non-aura cases for mac. So I renamed the files,
and moved the aura pieces out to DelegatedFrameHostClientAura.

In order for DelegatedFrameHostClientAura to know when to release
events however, it needs to know when the resize lock ends. So I
introduced CompositorResizeLockClient, which tells when the lock is
over.

Importantly, the above is not the same as the CompositorLock ending.
That can be done by calling CompositorResizeLock::UnlockCompositor,
which does not end the resize lock, but does release the
CompositorLock inside it. So this doesn't inform the client at
that time until the resize lock actually ends. I've tried to make
this more clear with function names and comments.

In order to unit test everything I've pulled CompositorLock out
of compositor.h and removed the friend relationships between
Compositor and CompositorLock. To do so CompositorLock now has 2
interfaces:
- CompositorLockClient which it informs about timeouts. This is
so that CompositorResizeLock knows when its internal
CompositorLock is released by timeout.
- CompositorLockDelegate which performs actual unlocking. This is
the ui::Compositor outside of tests.

Lastly, CompositorResizeLock has a timeout, and CompositorLock has
a timeout. These happen to be the same number tho
CompositorResizeLock allows you to override it. I've combined these
into a single timeout (with the help of CompositorLockClient). And
will allow GetCompositorLock to request a specific timeout. With
that, Compositor no longer needs SetLocksWillTimeOut which has some
action-at-distance properties. This maintains the property that the
first to grab a lock chooses the timeout for all other locks grabbed
during that time, however Mac code which wants no timeouts now
doesn't cause other parts of the system to also get no timeout unless
the mac lock is currently active without a timeout.

R=piman@chromium.org
BUG=704928
NOTRY=true

Review-Url: https://codereview.chromium.org/2773433003
Cr-Commit-Position: refs/heads/master@{#460577}

This new API is similar to IsSupportedVideoConfig and is strictly-typed
unlike the old MediaCodecSupportShlib::IsSupported, which is going to
be deprecated.

Review-Url: https://codereview.chromium.org/2677143003
Cr-Commit-Position: refs/heads/master@{#460576}

Manually converted these tests to use new Audit from old Audit.

BUG=704967
TEST=Analyser/realtimeanalyser-byte-data.html
Analyser/realtimeanalyser-downmix.html
Analyser/realtimeanalyser-fftsize-reset.html
Analyser/realtimeanalyser-float-data.html
Analyser/realtimeanalyser-freq-data.html
Analyser/realtimeanalyser-freq-data-smoothing.html
Analyser/realtimeanalyser-multiple-calls.html
Analyser/realtimeanalyser-zero.html

Review-Url: https://codereview.chromium.org/2777983002
Cr-Commit-Position: refs/heads/master@{#460575}