- 02 Jun, 2020 37 commits
-
-
Jimmy Gong authored
- Print history will be deleted when a user clears their browser history. - Future CL will include a policy pref to disable this. - Implements PrintJobsObserver Mojo interface. - This CL is the initial work to start supporting automatic updates to the print management app. - Feature is disabled until policy is implemented. Bug: 1053704 Test: browser_tests Change-Id: I283fce0eb1a850bce4b577aeaa71059b11fe1acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204524 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#773942}
-
Charlene Yan authored
Using F6 to cycle to a tab, then using CTRL+LEFT/RIGHT will not move a tab into a collapsed group. Bug: 1018230 Change-Id: I497075710186a8ab0d67971aa9fc203147057dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219402Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#773941}
-
Chong Gu authored
Adds ~6 minutes of bot time and 1 minutes of run time per build. Bug: 1086742 Change-Id: I65d5856723c4c305a8b7c416623e112789f081f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225468Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#773940}
-
François Degros authored
Override loadTimeData.getBoolean() instead of specifying loadTimeData.data, in order to be consistent with other integration tests. BUG=912236 TEST=browser_tests --gtest_filter="Tasks/*" Change-Id: Ib73d17082fb5da6909454cba5d765b9967e791f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224892Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#773939}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ba3e2a3. With Chromium commits locally applied on WPT: 0d109b6c "[ScrollTimeline] Fix null-deref READ when resolved scroll source is null" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8eb13015a9f4aee5a9154e24ac8925058ea0b2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225638Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773938}
-
Adenilson Cavalcanti authored
Use the set of portable code from zlib that shouldn't have extra dependencies (e.g. 'base'). Also allow building the tool for other targets (e.g. Linux, OSX, etc) as that allows easier testing and profiling. Bug: 1076580, 1087999 Change-Id: I3130ba77681ae66dc34c3539c2ed10476e754d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211008 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773937}
-
Charlene Yan authored
Bug: 1018230 Change-Id: I89f5f54b6e1083c7375b1b15f444a86b2a1269a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225376 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#773936}
-
Mike Frysinger authored
This is the core CrOS metrics bucket. We manage lifespan of fields on the platform side rather than creating separate metrics. Bug: 1089268 Change-Id: I526a0c1f9b9171f8afce2a95ff249594c99510c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224829Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#773935}
-
Victor Costan authored
Change-Id: I05361bb4ff2ebf09ef6dfda03b60922b9418264c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225860Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773934}
-
Sam Sebree authored
This change addresses an incorrectly written meta tag in the dateTime pop-up document. Bug: 1087643 Change-Id: Ib2064c48af49487be706c08f7afba882982811da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222461Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773933}
-
nancylingwang@google.com authored
BUG=1068884 Change-Id: Ide76bd5cfc0f1a4ba497f0420a52fcc020f293a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223835Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773932}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590983038-a4f7a567fa946f73734750edaaa09048a986b3e6.profdata to chrome-win64-master-1591041546-66c2ea2b6b7d4112794a73d0a3fdd90d1b4804af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9121b2b7d3ba36538ada41d298f720ca0328069e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225702 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773931}
-
Varun Khaneja authored
histograms.xml updated in https://crrev.com/c/2225380 R=bdea Bug: 1089426 Change-Id: Ib59d2596034a16bbccba18a750515915873d69ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225383 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#773930}
-
Joel Hockey authored
Bug: 1085324 Change-Id: I69984c8fa234da941382779544bbcd90a45f4ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224891 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773929}
-
Nigel Tao authored
Bug: 1086733 Change-Id: I41605429a5b76d9ce0238b31cfedb84c9c9c16a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222243Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773928}
-
Nigel Tao authored
Bug: 1086733 Change-Id: Id166fe2202b50b274a6ce90d3503e0c619994b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222242Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773927}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cfe3be0ee4c5..721d6792f75d 2020-06-01 rwkeane@google.com Force the CI Bots to run If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibbdad9bba92edf322e37810826295cf3936b3c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773926}
-
Nate Fischer authored
No change to logic. This removes the SafeBrowsingCommittedInterstitials switch, which was removed in https://crrev.com/c/2138506. Test: None Change-Id: I464ee374f3656b49d0f973e23b7f2d858cbc34f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223368 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#773925}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I33fbac6c23a0a65d60761ca53c524bcbedf8efeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225352Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773924}
-
Luciano Pacheco authored
Change the spacing between the last form field and the buttons in the bottom. Reduce from 44px (24px from form field margin-bottom and 20px from buttons padding-top). Add 2px padding-bottom for the field because it was cutting the focus ring. Remove the close icon by removing the attribute show-close-button in <cr-dialog>. This change affects both styles FilesNG and non-NG, since these are minor, it shouldn't be a problem. Bug: 992827 Change-Id: I8afc5beb92536d90ddbc007903d7d860edcc59cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224741 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773923}
-
Karandeep Bhatia authored
ExtensionResource::empty() currently checks whether the extension root path is empty. However this is not correct since dummy extension objects are often created with an empty extension root path, for example, this can happen during the webstore install flow. This can cause ExtensionResource::empty() to incorrectly return false for a valid ExtensionResource. Fix this by changing ExtensionResource::empty() to check for the emptiness of the relative path instead. BUG=1087348 Change-Id: I195c6274118ba4bc869027dd6f53fde7199e3d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225896Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#773922}
-
Sammie Quon authored
This is a reland of 3abaa7f0. Changes: Now that the observer observes the new layer, on window destroying or removing from root window we should stop animating the new window as well. Original change's description: > wm: Improve cross fade animation. > > *Destroy old layer when new layer animation is aborted. > *Only log histograms once after animation. > > The old layer is owned by a observer which does not know when the new > layer is being aborted. Change this so that the observer observers the > new layer and destroys the old layer accordingly. > > The pass animations reporter will be used for every LayerAnimationElement, > for cross fade, we animate opacity in addition to transform when the old > bounds is wider than the new bounds. This results in double counting, > which skews the smoothness numbers as animating two properties should be > slower. > > Test: manual, ash_unittests WindowAnimationsTest.CrossFadeHistograms > Bug: 868170, 1087460 > Change-Id: I3bc5b597e8109a3e87f432f6aa352ba94860f8ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218557 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773397} Bug: 868170, 1087460, 1088169 Change-Id: I3a2f6af334ca0cd325e49107e812824f7a39340e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224990Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#773921}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3fb1d569defc..5c91cb1c2f1d 2020-06-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6639b984ef36942a339f8975732054f20ac490e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773920}
-
Renjie Tang authored
Bug: 1088365 Change-Id: Ib5d66b482cba23ae85f44de653caedd3a491c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225349Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773919}
-
Dale Curtis authored
This is allowed by all other streams and should be harmless. R=tguilbert Fixed: 1090119 Change-Id: If9cd5a2a251a37a370b19bfdc541a2bb2eb28377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225592 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773918}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6169aca6f508..5891b0910066 2020-06-01 cclao@google.com Vulkan: acquire swapchain image should use COLOR_ATTACHMENT_OUTPUT_BIT 2020-06-01 amaiorano@google.com Enable CopyTextureVariationsTest.CopyTexture on VK 2020-06-01 jmadill@chromium.org Vulkan: Move "null" buffer to RendererVk. 2020-06-01 lehoangq@gmail.com Metal: Fix array of structs containing array of samplers bug. 2020-06-01 msisov@igalia.com move duplicated SwapControlData to rendergl_utils. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458,chromium:1086532 Tbr: ynovikov@google.com Change-Id: I4d8eaa10aa665bcea0a8fe78c4e28b78c494e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773917}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1088465, 1090059 Change-Id: I82793e2cd0c243566e8943019f66f0dee91b1c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225586Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#773916}
-
shrekshao authored
Given that Issue 949321 is fixed, re-enable the test to get a symbolized stack trace can be pursued. TBR=kbr@chromium.org, kainino@chromium.org Bug: 969013 Change-Id: I6962adfef6ca3d01bd907535cbda2ec0391cfe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225469Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#773915}
-
Thomas Guilbert authored
This newly added test is timing out. TBR=sergeyu@chromium.org Bug: 1090159 Change-Id: I5dcc92935e12664770a17ce9f70ec03c3c9710bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225595Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#773914}
-
John Delaney authored
A number of flaky timeouts are seen in browsertests, both in test harness tear down and during test execution when waiting on asynchronous output from the storage layer. This CL bumps the task priority for the conversion storage task runner from BEST_EFFORT to USER_VISIBLE. It also adds an empty test body to a test with the feature enabled, to verify that the issue is indeed in test harness setup if this fix does not work. This feature is not enabled currently, so this should have no performance impact. Bug: 1087775,1058199,1080764,1058199,1087406,1084201 Change-Id: I7322f9d8139ab14bccbf8dd71365cfda7514cdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225739Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773913}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I5b2158a0af43c64055c3ea60dd74f490e579548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222070Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773912}
-
Brian Sheedy authored
Switches all remaining uses of expected colors in the GPU pixel tests to regular pixel tests. Initially, these are set to use the very permissive Sobel algorithm so that images are auto-triaged until enough data is collected to calculate suitable less permissive parameters. The tests have grace periods defined until June 22nd, so any flakes that are not caught by the permissive algorithm will not affect the bots. Bug: 1078914 Change-Id: Ia59bba2d5117b66a537b4be3894cc9b2725ead56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219585 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#773911}
-
Josh Simmons authored
Bug: 1087123 Change-Id: I7265a9c10261881c196e6e7969ef9937097e1272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223109 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#773910}
-
Greg Thompson authored
BUG=1086769 Change-Id: I546e95c9eb0a2bdf2e9f670412b27a2a46977401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222729 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#773909}
-
Jeevan Shikaram authored
When opening a web app from ARC++, if the web app is associated to a web-only TWA, we want to close the ARC++ associated with the web app. Bug: 1026230 Change-Id: If223f638ba361956a486c52007b953301a78c9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220114Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#773908}
-
Nate Chapin authored
* Remove default constructors for Document and HTMLDocument. Replace them with static CreateForTest() helpers. * Add DocumentInit::ForTest(), which (when DCHECK is enabled) flags the DocumentInit as being for a test case. * DCHECK that every user of DocumentInit calls exactly one of WithDocumentLoader(), WithExecutionContext(), or ForTest(). Change-Id: Ifb40826f2069371959bad386dea40fd039e6b11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224991Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#773907}
-
Jesse McKenna authored
This change updates vscode.md and launch.json5 (a configuration file containing recommended settings) noting that the "type" setting in launch.json needs to be "cppvsdbg" on Windows in order to use the Visual Studio debugger. Attempting to debug on Windows using the default settings provided in launch.json5 results in error "unable to determine path to debugger". Change-Id: I8a8871adc25f6b7bb9a8dd536a19c342e5badf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225780Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#773906}
-
- 01 Jun, 2020 3 commits
-
-
Asanka Herath authored
Metrics from these histograms continue to be useful as Chrome's usage in enterprise fluctuates. Bug: 1089001 Change-Id: I470924bf84550f94ddbe2350ec154dc4b7abf744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225509 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#773905}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie75327ebc50700cf78bb2f87a44dbc0c85cb4909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773904}
-
Julian Watson authored
If file is local but unshared display message: IDS_FILE_BROWSER_UNABLE_TO_OPEN_WITH_PLUGIN_VM_DIRECTORY_NOT_SHARED_MESSAGE. If file is on an external drive (usb/Google Drive) display message: IDS_FILE_BROWSER_UNABLE_TO_OPEN_WITH_PLUGIN_VM_EXTERNAL_DRIVE_MESSAGE TBR=timloh@chromium.org Bug: 1049453 Change-Id: I98a35e51b98d11537c0a675b0a1a28645b60ccfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217512 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#773903}
-