- 28 Oct, 2020 40 commits
-
-
Ye Kuang authored
Design doc: http://go/roll-go-swarming-to-trigger-scripts Bug: 1127205 Change-Id: I8ca8e2bb381f340fc23b91339cdb56374f8eead8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500976Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#821619}
-
Clark DuVall authored
This change moves the stack_unwinder module back out into a DFM since it has no deps on //chrome Java code. After this change, module installer can handle loading Java modules from isolated splits (although assets will still take more work). Native libs are still in the base module, so nothing special needs to be done there. Bug: 1142967 Change-Id: I1af06b3153472581e058f606937de4e32f6a14ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503581Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821618}
-
Luciano Pacheco authored
Add TestDataSource for Files app unittest to be able to serve JS modules using chrome://test/. This is used to load chai_assert.js which provides the assert functions for tests in JS modules. Fix js_test_gen_html() to provide "uses_js_modules" option for the js_type_check() rule when using JS modules. Generate JS modules for volume_manager_types.js and convert its unittest to be JS module. Bug: 1133186 Change-Id: I176e3f16628c99b2d98dc883ad5284d491b825cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491765 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821617}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1c7a0a66e54..d9d752771b77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: Ic9cc669a9e51210ffba1822f9e506e885e440014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504334Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821616}
-
Matt Menke authored
This was reverted once due to an IWYU bug in the internal repo, and then reverted again due to a IWYU issue being landed while the reland while in the CQ. TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org Bug: 492672 Change-Id: I5185296211ffa07e1a8138cdaa308e6387a11a74 Fixed: 1142930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504213Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821615}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/2837c9f0c416..4d14555787ce 2020-10-27 jophba@chromium.org Add remoting proto If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I227ee42092722797e397121b123e422bd4465235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821614}
-
Andrey Kosyakov authored
This only works for browser-level interception, as we still lack support for pushing the updated URLLoader factories to the renderer if interception is enabled late. Change-Id: I8988e2b70c265b2a4476b9c06cef6a73bc4c3100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503398 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821613}
-
Nick Diego Yamane authored
This adds initial support for toplevel window dragging during DND sessions, which is required by Exo's extended-drag protocol impl. To do so, this CL adds ash::ToplevelWindowDragDelegate, a brand new interface which makes ash's DragDropController aware of toplevel window dragging during DND sessions, so allowing it to forward events of interest to its instance, if it's set for a particular DND operation. Context: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. The actual ToplevelWindowDragDelegate implementation will be added in a upcoming CL [2]. Bug: 1099418 Test: ash_unittests --gtest_filter=DragDropControllerTest.ToplevelWIndowDragDelegate [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing [2] https://chromium-review.googlesource.com/c/chromium/src/+/2401280 R=oshima@chromium.org Change-Id: I8d76eb7bfe9086f3a89d0c1b8762ea39dbea69a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483663 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821612}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/daba50861af8..15be7eb5cbfb 2020-10-28 johnchen@chromium.org Update Chrome builds used in Catapult tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1142599 Tbr: zhanliang@google.com Change-Id: I3c93490c04d67d5ef8cee1a745f1949bc28ba777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504697Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821611}
-
Meilin Wang authored
This CL adds handlers for buttons on the Bluetooth disabled view. Misc: test minor refactoring. BUG=1106937,1126208 TEST=unittested. Change-Id: I891d81bb67f3ef7b52cdee8835d66a05f49b8341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495827 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821610}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests and browser_tests. Change-Id: Ib7662537bce5f1b833de91ebfb189d5d71f8c3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467638 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#821609}
-
Hiroki Nakagawa authored
Bug: 1132746 Change-Id: Icbbf7f57b524750cb6cc2dc73506a348891b83ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497347 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821608}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 1142671 Change-Id: I82287d4fa4972fadf79f5336e89d2528521f3c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500557 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821607}
-
Andrew Grieve authored
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/650611720ecc..6907d995c797 $ git log 650611720..6907d995c --date=short --no-merges --format='%ad %ae %s' 2019-10-07 efoo Add "# COMPONENT" to libsrtp OWNERS file Created with: roll-dep src/third_party/libsrtp Bug: None Change-Id: If9cdcf85acb209589c92b28a418872fe183e25ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488547 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#821606}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9418d801118657d4991f25d57e38c8b00bcc639d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504972Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6a23ce4abbfe777cf72a7b62b8de99a6dd52e2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504830Reviewed-by:
-
Satoshi Niwa authored
Bug: 1142323 Test: Check metrics object on JS console Change-Id: I42dbab1600118e0e2af70349d48272aa19fc59ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497905Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#821603}
-
Kent Tamura authored
This CL has no behavior changes. Tbr: masonfreed@chromium.org Bug: 1143074 Change-Id: If6477cfe03b9ec52c770db425a6f0a511bf15d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504432 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#821602}
-
Kent Tamura authored
This CL has no behavior changes. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Change-Id: I7d3f8e060329ad7e6deaa75c7bd76fc18e2b76cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504433Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#821601}
-
Sam Fortiner authored
This reverts commit 8c72e30b. Reason for revert: Breaks overlap detection between non-fixed-pos siblings that are children of fixed-pos layers. See https://crbug.com/1137974 Original change's description: > Move fixed bounds for overlap to absolute space > > When computing the bounding box for fixed-pos layers, the resulting > bounding box was stored on AncestorDependentCompositingInputs in > viewport space (absolute space adjusted by scroll offset). The scroll > offset that was used is the current scroll offset during compositing > inputs update time. Call this ScrollOffsetA. Later during compositing > layer assignment, when computing overlap, the fixed layer bounding box > is converted from viewport space to absolute space by adjusting it by > the current scroll offset. The expectation is that this 2nd scroll > offset is also ScrollOfffsetA. However, in some cases, a compositing > update will be requested that will skip compositing inputs update and > only do overlap and assignment. When the scroll offset changes between > computing the fixed layer's viewport space bounds in the previous > compositing inputs update and the later compositing assignment update, > the wrong scroll offset will be used and the fixed layer bounds will > fail to be converted to true absolute space, leading to overlap testing > errors. > > This change addresses this issue by storing fixed layer bounds in > absolute space instead. Note that this issue does not happen when the > CompositingOptimizations feature is enabled as it doesn't use the cached > bounds from compositing inputs update. > > Bug: 1124753 > Change-Id: I85928386fd43ca0b5a86b34877ef2a4afdabd73a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411693 > Commit-Queue: Sam Fortiner <samfort@microsoft.com> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807955} TBR=pdr@chromium.org,samfort@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1124753 Change-Id: I60fedcd48097a1e71f6ceea14707a01df7c29e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504578Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821600}
-
Nick Diego Yamane authored
This is required to make it possible to use ToplevelWindowEventHandler for handling window dragging in Exo's extended-drag sessions, e.g: LaCrOS Chrome's tab dragging implementation. Extended drag sessions are driven by ash::DragDropController, which sets capture to its internal DragDropTracker instance. This changes ToplevelWindowEventHandler so that it does not assumes capture must be set on the dragged window when its AttemptToStartDrag() functions are called. This CL does not imply in any functional change. It will start to be used in crrev.com/c/2401280 followup change. R=oshima@chromium.org Bug: 1099418 Change-Id: I8d76f72675eb123fbd41093efa1d9643adeb482c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483662Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/fcbc6efa8fd3..adb10d60de32 2020-10-27 bclayton@google.com Add option and target for generating code cov info 2020-10-27 dsinclair@chromium.org [ast] Add AccessControlType. 2020-10-27 bclayton@google.com Fix build for tests on gcc-9 2020-10-27 rharrison@chromium.org Ran 'git cl format' over repo, found some nits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I470d1f6959b1b85ce265f9de1253e03da65d73a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504498Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4280.20-1603104419-benchmark-88.0.4303.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5db8a44d78adfd2abfb9d59b1b921ecc5c1030a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504970Reviewed-by:
-
Hung Vu authored
This CL keeps BookmarkNode tree in sync with ReadingListModel when adding an entry from readling list model. Bug: 1133504 Change-Id: I0ed62fd37ad8e1b282e132b30f51350dafaf2816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490824 Commit-Queue: Hung Vu <vuhung@google.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821596}
-
Hiroki Nakagawa authored
This CL adds prerendering-reviews@ to entries relevant to prerendering in WATCHLISTS. This includes NoStatePrefetch. This drops "html_link_element" from the entries because relevant implementations in the file are small and will be removed by https://crbug.com/839030 soon. Bug: 1132746 Change-Id: I273b0ee8381ea74265883bdf6672718867d66cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494442 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/25d53b85..fa425033 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d7ebab32c00a5e728139a1d057c3aa769dbe357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504650Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821594}
-
James Hollyer authored
This reverts commit 1787bd86. Reason for revert: Relanding with fix for flaky test. Original change's description: > Revert "Separate Core Location flag into 2 flags for backend and permission UI" > > This reverts commit cf5951dd. > > Reason for revert: Likely culprit for GeolocationServiceUnitTest.UrlWithApiKey flakiness on Mac > > Original change's description: > > Separate Core Location flag into 2 flags for backend and permission UI > > > > The Permission UI for getting location permission from mac is completely > > separate from the actual Core Location backend. Furthermore, once we > > have location permission from macOS our Network Location Provider works > > as intended. This CL separates those 2 independent workflows and allows > > the Network Location Provider to monitor permission and act accordingly. > > > > Bug: 1112630 > > Change-Id: I4e3141f756eadcb3d7ecc66c347fc24148505edc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454307 > > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#821050} > > TBR=reillyg@chromium.org,jameshollyer@chromium.org > > Change-Id: Icf38bfb889a62ee4e6d70eff0bc1adc2316d9ed6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1112630 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502368 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821178} TBR=droger@chromium.org,reillyg@chromium.org,jameshollyer@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1112630 Change-Id: I5b8722879d719ef7c5ee4951caf6a4f6341747c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504597Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821593}
-
Asanka Herath authored
Bug: 973801 Change-Id: I80eb6eace8fd62e52876cc8c437fdae0e9b2906a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439494Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821592}
-
Michael Checo authored
- Shows a preview of a scanned document - A follow-up CL will use and style this element Bug: 1059779 Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All Change-Id: Ib5a9fe49f87c14059391900777247615cf7a6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500430 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#821591}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603799921-18f2bb90aa116c4ca4ae138df9ceaff090340372.profdata to chrome-linux-master-1603842982-a956b2994ae58c7a5e5be7f92daab364455a7a77.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5cabc91198b2dd26f5a27252eb12cd1b74d6092b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503655Reviewed-by:
-
Ted Meyer authored
cl https://chromium-review.googlesource.com/c/chromium/src/+/2483862 added a check for the flag, but the flag was never propagated to the gpu process. Change-Id: Ia01b50a0e8caf11bb4b08941fa4eead2c2b4d162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503818Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821589}
-
Kent Tamura authored
This CL does not affect production. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Bug: 1040826 Change-Id: I2d72e0fccd34385846caa7cba8a5c4aee7fbbccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462900 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Nancy Wang authored
When switch users, the 'FetchImage' function is called. However, if the icon image has been loaded, the 'ChromeAppIconLoader::FetchImage' function returns directly, and doesn't reset the icon for the delegate. This might cause the blank icon issue for some extensions, e.g. the Google Hangouts extension. This CL modifies the function 'ChromeAppIconLoader::FetchImage'. If the icon image has been loaded, call OnIconUpdated to set the icon for the delegate. BUG=1142226 Change-Id: I5d698844d72fbb71925d281cc11bc419e19f691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494409Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821587}
-
Richard Chui authored
Drag affordances (drawn circles) are now hidden when the user clicks to start resizing on a corner or when they begin moving the selected capture region. Test: manual Change-Id: I20c701cc6deb894ff8803294ee28e783558fb163 Fixed: 1140787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500450Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#821586}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I3a8aeaa55b43e14bcc12619bce05470d5c3c208e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504651Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821585}
-
Darren Shen authored
This reverts commit 8f09dc30. Reason for revert: Seems to break https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/172912 Might need another file util include in: chrome/browser/ui/ash/holding_space/holding_space_client_impl_browsertest.cc Original change's description: > Reland "Remove SpawnedTestServer from BrowserTestBase." > > This reverts commit 1421dac0. > > Reason for revert: A fix has been landed in the internal repo. > > Original change's description: > > Revert "Remove SpawnedTestServer from BrowserTestBase." > > > > This reverts commit 89540fb3. > > > > Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930) > > > > Original change's description: > > > Remove SpawnedTestServer from BrowserTestBase. > > > > > > The last browser tests using the built-in SpawnedTestServer have > > > finally been migrated the EmbeddedTestServer, so nothing is using it. > > > This also helps reduce visibility of the SpawnedTestServer, so makes > > > accidental use of it harder. > > > > > > This CL also fixes a bunch of IWYU issues that the removal unearthed. > > > > > > Bug: 492672 > > > Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 > > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#821288} > > > > TBR=jam@chromium.org,mmenke@chromium.org > > > > Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 492672, 1142930 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#821375} > > TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 492672 > Bug: 1142930 > Change-Id: I3b0e8ffccf7566c4a96c836d384520f2a08d5a28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503332 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821561} TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org Change-Id: I9adaef72fce7fd6f4675dbf7dbcbdd4033a77ca7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 492672 Bug: 1142930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503991Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821584}
-
Hiroki Nakagawa authored
This CL moves the directory for IsolatedPrerender to chrome/browser/prefetch/prefetch_proxy/ based on the discussion on this design doc: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing This CL doesn't change file names, variable names, implementation comments, etc yet to minimize diffs. Subsequent CLs are going to address them. This CL also contains several changes other than mechanical renames: - Adds "COMPONENT: Internals>Preload>PrefetchProxy" to chrome/browser/prefetch/prefetch_proxy/OWNERS. - Updates annotations.xml using traffic_annotation_auditor tool. - Updates WATCHLISTS based on the new path. Change-Id: I20d33cffde8de7f4ecf8184bfe89c489f8682ede Bug: 1142211 TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494246 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a7b2f5dd. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" e9e1f3fd "Use visual overflow rect for layout shift tracking" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I355e6ec474e40aa898dbc6e8b5522634b6f9397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504091Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821582}
-
Yue Li authored
Bug: b/171435744 Test: Manual Test Change-Id: Iad5b18d1fe2b536e90e6ed6d2edd45f706333b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503825 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821581}
-
David Bokan authored
This CL removes a special case for web test input routing where input is forced to the main thread. Input is now routed through the compositor input handler, as it would be in a normal browser. This now happens even when the compositor doesn't have its own thread. Input can still fallback to the main thread in cases where it needs to; however, this happens in the usual way it would: by first trying the compositor input handler and having it determine whether it can be handled, needs to be routed to the main thread, or should be dropped altogether. This change is a necessary prerequisite for scroll unification, since that'll remove all main-thread scroll handling code. Thus we need to stop unconditionally routing input there. Additionally, it also improves testing code coverage by making web tests work more like the real browser. Case-in-point, the number-wheel-event test here now reveals a real bug since the input now goes through the compositor and the compositor doesn't know about the spin control it drops the wheel events without forwarding them to the main thread. Force-routing input to the main thread covered this bug up. Bug: 915926 Change-Id: Ia26465e47ab50149e06131e99beed2db18856ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281179 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821580}
-
