- 23 Nov, 2019 33 commits
-
-
Daniel Cheng authored
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Notes: - Add a base::PersistentHash() overload that takes a base::span to match base::FastHash(). - Fixes tracing ID generation to use base::PersistentHash(), since the tracing IDs are not always generated in the same process. Bug: 1025358, 1026837 Change-Id: Ibdfe5185c0a8fdb9ab2fd2ee7408ea73e842801b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923499 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718400}
-
David Trainor authored
The test still used System.currentTimeMillis() which could very rarely return a different value even between just a few instructions. Change-Id: I8cc649771cec6506b28decba91bd74a1ed1a7e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929084Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#718399}
-
Maria Villarreal authored
This reverts commit 7be5b8ce Reason for revert: https://crbug.com/1021934 Original change's description: >Hit testing should make use of GetEventHandlerForPoint in Views > >This change intends to fix touch with a screen reader in nested >elements across the browser frame, as the tabs and the location bar. >The issue here is that the focus ring is the first child found and >returned by HitTestSync and does not allow to continue looking for >the nested view child. >For example, if touching the bookmark button inside the location bar, >focus ring (which covers all the area of the location bar) will be >found before the bookmark button. > >This fix adjusts HitTestSync by now calling >View::GetEventHandlerForPoint which returns the hit child on the >view. Then we still iterate the children of this view since >we need to return the deepest-most child it can find. The benefit >on calling now GetEventHandlerForPoint is that this method >already knows how to handle overlapping views. > > >Bug: 990560 >Change-Id: I9076c3dfaa1424b69eb49b83c07b10ebeb26776d >Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817289 >Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> >Reviewed-by: Nektarios Paisios <nektar@chromium.org> >Commit-Queue: Maria Villarreal <mavill@microsoft.com> >Cr-Commit-Position: refs/heads/master@{#705217} Bug: 1021934 Change-Id: Idb8621c728aeff49f5762804c716f8386d228664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928012Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718398}
-
Avery Musbach authored
The present CL fixes how the divider position in clamshell split view is adjusted when the display orientation changes. BEFORE: It is updated in SplitViewController::OnDisplayMetricsChanged, with logic meant for tablet mode, such as subtracting half the thickness of the divider. AFTER: It is updated based on the snapped window bounds after those bounds are updated by good old WindowState::AdjustSnappedBounds. Fixed: 1005501 Change-Id: I9471cf54a5cc0da3e73090716493d5fea34da9d6 Bug: 1005501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925237Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#718397}
-
Johannes Henkel authored
New revision: 7a44a37f66b58358dd8ab85ccde1998fafa95e53 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1899564 Previously, we used a wrapper routines, e.g. those in content/browser/devtools/devtools_protocol_encoding.cc to use this library, by using dependency injection to provide the string<->number conversion routines. With this change, the third_party library depends on the routines in //base via a custom, Chrome-specific .cc file, json_platform_chromium.cc. This does away with the indirection for the library usage. Change-Id: I963b0f962473ce911bfbdfb848863d253bc7dbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922594 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#718396}
-
Tsuyoshi Horo authored
Bug: 1025835 Change-Id: Ie5effc90de1dc7514df9f2d96e2f6ff1cb281278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923215Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718395}
-
siyua authored
Reason for this CL: We did implementation review with Chrome UX and one feedback was the verify pending dialog was too short for a modal dialog. Therefore UX decision is for this dialog, we also reuse the template of the webauthn dialog (adding an illustration on top). So it makes sense to merge the separate MVCs of webauthn_offer_dialog and verify_pending_dialog into one, and show different content for different states (in other words, adding kVerifyPending as a new state in WebauthnDialogModel). This is a renaming CL which is the precursor of the major merging CL. Includes two changes: 1. Rename all WebauthnOffer- to Webauthn- to avoid confusion; 2. In AutofillClient, move all webauthn related functions under build flags to ensure these functions are all on desktop. No other change on flow logic. TBR=michaelbai@chromium.org,mahmadi@chromium.org,martinkr@google.com Change-Id: I80ae00d219cdaf868056a04938c6968ed186ad3d Bug: 949269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925761 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#718394}
-
W. James MacLean authored
CL to continue debugging the cause of flakes in SitePerProcessInteractivePDFTest.LoadingPdfDoesNotStealFocus. Bug: 1024672 Change-Id: Ic2a577a960f5333419aa70f89a5ca1149130e1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929628 Auto-Submit: James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd8cccb7..f72b13cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I258e828a67cb89bb89bf2b0f6562ebbda549afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929529Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718392}
-
Adrienne Walker authored
This is a followup to remove unnecessary thread hops by binding the mojo interface on the correct sequence in the first place. Bug: 1022104 Change-Id: Id69811673d6a14e11a1da4caa452c40868454df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907095 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#718391}
-
Brandon Wylie authored
Chrome would crash when longpressing the url because the padding is adjusted at the same time Editor#selectCurrentWordAndStartDrag is called. This causes a nullptr exception since Editor#getSelectionController() will be null at that time. The fix is to post the padding update which will resolve both the longpress and the padding update without crashing. Bug: 1024994 Change-Id: I7816ffbbe2fff43cf2b1047eee278f8d1ba863a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930066 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718390}
-
Toby Huang authored
When the "Permissions for sites and apps" toggle in Chrome family dashboard is disabled, we should prevent child users from installing new extensions and approving additional permissions for existing extensions. This CL focuses on preventing child users from installing new extensions. The second functionality will be implemented in a future CL. When the toggle is disabled, pref kSupervisedUserExtensionsMayRequestPermissions becomes false, and this is used to implement the desired effects in this CL. Bug: 1018956,1007011 Change-Id: Ida3c53d87da55fd266edc9d021211f5cdc641d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904502 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#718389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/498ba7042fc1..4a0fd75b105f git log 498ba7042fc1..4a0fd75b105f --date=short --no-merges --format='%ad %ae %s' 2019-11-22 primiano@google.com Fix Chromium roll on windows 2019-11-22 primiano@google.com Merge "Minor fixes to IPC proto and build files" 2019-11-22 rtenneti@google.com Merge "Revert "Add proto for recording VkDebugMarkerSetObjectNameEXT"" 2019-11-22 chiur@google.com Merge "Add proto for recording VkDebugMarkerSetObjectNameEXT" 2019-11-22 lalitm@google.com Merge "trace_processor: expose set_name function" 2019-11-22 ilkos@google.com Merge "Add build fingerprint to system info" Created with: gclient setdep -r src/third_party/perfetto@4a0fd75b105f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I79b8a7e92dc1655b878de9ee0c2e0286296a5410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718388}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e32eb6fc6fc..d6140be50ddb Created with: gclient setdep -r src-internal@d6140be50ddb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I6c0f8074a50a1c3cfe1e0bbd0a0c5c1d5ea8bc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931341Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718387}
-
Kevin Qin authored
Some existing tests do not fully verify the API usage. This CL is dedicated to provide a better coverage for OpenXR implementation. And remove some no longer used mock functions. Fixed: 1025404 Change-Id: I7493d5ddc6f00544d8f8474fdaa3ab2fe8d283c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919494 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#718386}
-
Nikita Podguzov authored
Bug: 996785 Change-Id: Ib8d28e3651a9b39107f242883983a13fa13eedb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930811 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718385}
-
Kurt Horimoto authored
This CL updates the JS dialog egtests to work with both modal and non- modal dialog implementations in preparation for updating the non-modal dialog feature to be enabled by default. This required introducing a11y identifier functionality to the AlertConsumer protocol to allow the tests to properly wait for the dialogs to be displayed. Bug: none Change-Id: I26010b73501442db729f8c561d925d70b8c5eca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925775 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#718384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9dabaedfa33c..556c0a2e0f48 git log 9dabaedfa33c..556c0a2e0f48 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@556c0a2e0f48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic4e31ae399af15a7974bbb12e3065d9c2ec86ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931740Reviewed-by:
-
Piotr Pawliczek authored
This patch extends the unittest by adding an entry with incorrect uri. I was not able to reproduce the bug described in the issue. BUG=chromium:1015916 TEST=on my workstation by running unit_tests Change-Id: I989fc9d82956f16b277648ec942de454763fadd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912695 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Errorprone is currently causing javac to crash when warnings are hit. TBR=agrieve # Fixing build Bug: 1027541 Change-Id: I7b95fa3dadd8947d66234c1f6c2490148d7e5d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931742Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718381}
-
Bo Liu authored
Have embedder pass in a profile name rather than a path. * Add USER_DATA_DIR to PathService, and implement it correctly on all platforms. * Add kUserDataDir switch to weblayer, to override the default USER_DATA_DIR location. * Update everything to pass profile "name" rather than "path". * Update ProfileImpl to compute the path as USER_DATA_DIR/profile/path * Need to add to thread restriction since creating the path currently happen on the UI thread. Bug: 1027627 Change-Id: I00119a9874cad055e7ab685fe714b92df95999fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929106Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718380}
-
Yue Zhang authored
Originally, the TabListSceneLayer that shows during tab-to-grid transition puts the tab switcher bitmap right below the top toolbar. This looks correct for normal layout but is no longer true for StartSurface, because for StartSurface there are components that locate above tab switcher. This CL adds a top offset so that we can adjust the position of the tab switcher bitmap based on the real position of tab switcher within the layout. Bug: 995423 Change-Id: I23bf25d3c01a20410a921dcef9a9de947d554c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921704 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718379}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8412598cca10..5459c3891e2c git log 8412598cca10..5459c3891e2c --date=short --no-merges --format='%ad %ae %s' 2019-11-22 crouleau@chromium.org [Telemetry] Exit code 111 indicates no stories were run. Created with: gclient setdep -r src/third_party/catapult@5459c3891e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1019139 Tbr: oysteine@google.com Change-Id: I0fe5a9dc3d3a112eb348dcdee256324a182678de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931640Reviewed-by:
-
Jordy Greenblatt authored
This is just a followup to [1]. It handles the out-and-back routing focus bug for the MultiDevice page and the 'Known Networks' route from the internet subpage. Note that there are a couple minor cleanups from [1] as well. See behavior with CL here: https://drive.google.com/a/google.com/file/d/106hO30ty9-ZmjY5vgrvB-k122EYsIGMg/view?usp=sharing [1] https://chromium-review.googlesource.com/c/chromium/src/+/1919327 Bug: 1003992 Change-Id: I4e5a5dc5807cec2c6e123ab6bc31ff98e85cb58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930540Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#718377}
-
Christopher Thompson authored
Change-Id: I61c0c7b68ceb56313326f96a488f7fa095f3e067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931836Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#718376}
-
meacer authored
This CL blocks the following characters when used next to a non-CJK character: U+4E00 (一), U+3127 (ㄧ), U+4E28 (丨), U+4E5B (乛), U+4E03 (七), U+4E05 (丅), U+5341 (十), U+3007 (〇), U+3112 (ㄒ), U+311A (ㄚ), U+311F (ㄟ), U+3128 (ㄨ), U+3129 (ㄩ), U+3108 (ㄈ), U+31BA (ㆺ), U+31B3 (ㆳ), U+5DE5 (工), U+31B2 (ㆲ), U+8BA0 (讠), U+4E01 (丁) According to usage logs, this change affects a small number of domains (<10) with a small number of users (<300 over 28 days). It does not block U+30A8 (エ) as this converts more domains to punycode (~20). Bug: 990428 Change-Id: Ie8cad20f52446361439ea9e3e0a69b276f8115fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927692 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#718375}
-
Dale Curtis authored
Includes one line fix in audio_device_listener_win.cc to use the DCHECK_CALLED_ON_VALID_THREAD() macro. ----- [ Original Description ] ----- This fixes a TODO in AudioDeviceListenerWin on listening for property value changes... by listening for them in a completely different way. Unfortunately forcing mono audio for accessibility doesn't generate IMMNotificationClient events, so we need to instead use the IAudioSessionEvents interface, but that can only be hung off a fully initialized IAudioClient... which is only done during WASAPI audio output setup. So the original TODO is fixed by adding a 1-to-1 path for device changes (in addition to the 1-to-many path). We still need both paths since just switching your default device won't generate an IAudioSessionEvent notification, only an IMMNotificationClient event. Additionally fake and WaveOut based devices don't have a IAudioSessionEvents interface, so still need the old path. Misc other cleanups: - Expands the AudioDeviceListenerWin unit tests. - Fixes broken --force-wave-audio switch in AudioManagerWin. BUG=1020006 TEST=property changes, mono audio changes, default changes work. TBR=henrika, tguilbert Change-Id: I95f5f439982a68d2b509db10978a570fb98081b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931408Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#718374}
-
Nate Fischer authored
No change to production behavior. This adds a "reset all to default" button for the flags UI. This button updates the visual appearance of the Spinners and sends the new (empty) flag override state to the service (which then stops itself). Fixed: 1026381 Test: Manual - verify the button resets spinners and the services stops Change-Id: Ia3324653471a43d24ed1cd269ddf717af0a89c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925596 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718373}
-
Caleb Rouleau authored
This addresses concerns that came up in https://chromium-review.googlesource.com/c/chromium/src/+/1913287/3#message-a8c363497a19a03f9c10079fa5fca6ed67263935 R=abennetts@google.com, perezju@chromium.org Bug: 949246 Change-Id: I2686272fcfafaafb71b20a5024ec99f2e30e9885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925592 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718372}
-
Sophie Chang authored
Bug: 1001194 Change-Id: I1ea4fa11ba5560ac893cef456c00e104d5748317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931143Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718371}
-
John Abd-El-Malek authored
Change-Id: Ie7a38b77cfcc9a2c0ae6a7a5d5b64181e1614c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919853 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#718370}
-
Donn Denman authored
Disables various Omnibox tests on versions of Android where they are flaky. Some tests are now restricted to KitKat only. Other tests are no longer run on Pie+. BUG=1027549 TBR=cmumford@chromium.org Change-Id: I13c1b1339aba95c66ddfad32d7dd7c2f794f5870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931856Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#718369}
-
https://chromium-review.googlesource.com/c/chromium/src/+/1900520James Hawkins authored
This reverts commit abba56a7. Reason for revert: Break local CrOS all-targets build. Original change's description: > Reland https://chromium-review.googlesource.com/c/chromium/src/+/1900520 > > This was reverted because grit ran out of ID space and builds started failing. > > Creates a WebUI-based Crostini Upgrader > > The UI is behind the new crostini-webui-upgrader flag > (currently disabled by default) > > The main areas for review are > > calamity@: > html/js - chrome/browser/chromeos/crostini_upgrader/ > mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/ > > davidmunro@ > crostini business logic - chrome/browser/chromeos/crostini/ > > In this CL, the optional container backup stage is stubbed, and will be > in a subsequent CL. > > A suite of unit/browser tests are also currently lacking. I intend them for > follow-up CLs. > > > Bug: 930901 > Change-Id: I6d3a63ffb319c762839a830ee76f4dfcc56445bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928383 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718358} TBR=calamity@chromium.org,rockot@google.com,sammc@chromium.org,nverne@chromium.org Change-Id: Id85a83d61155f8fae7fcdd54c92c60b6bd29661a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931797Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#718368}
-
- 22 Nov, 2019 7 commits
-
-
Ken Rockot authored
This header provides a bunch of helper functions for Content processes modeled as Service Manager services. Since those are no longer a thing, this no longer needs to be a thing. Bug: 977637 Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9 Tbr: jam@chromium.org Tbr: erikchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#718367}
-
Reilly Grant authored
Bug: 1007664 Change-Id: I975e8b03330961acc2b7f9dd6b96406e6bdd0ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922734 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#718366}
-
Shivani Sharma authored
This CL fixes net unittests so that they work if append frame origin is enabled by default. Bug: 1026388 Change-Id: Ia307269236e7e58184f4394502eed4e29c0e2246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930945 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#718365}
-
Alex Cooper authored
The notion of a simple "size" for Stage Parameters/bounded was a WebVr concept that did not carry over to WebXr. To simplify the mojom, move the "conversion" of square stages (for those runtimes that only support giving size x/z) down into a utility function in the device process. Bug: 1017843 Change-Id: Ib050a7ea3655a3816f6008e82434435ecb2c4426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918037 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#718364}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/b5f2d72f536f..a89eee387569 $ git log b5f2d72f5..a89eee387 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 wub gfe-relnote: (n/a) In quic::test::TestQuicSpdyServerSession, do not call Initialize() in constructor. Test only, not protected. 2019-11-21 bnc Move NoopQpackStreamSenderDelegate to qpack_test_utils.h. 2019-11-21 renjietang Change window_update frame's byte_offset to max_data to incorporate IETF spec. 2019-11-21 wub gfe-relnote: (n/a) Only enable QUIC MTU discovery in the server->client direction. No behavior change in GFE, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ib3df7f9ef286727cb0f33938db2bd49ac785ebc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931496 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#718363}
-
George Zhang authored
This reverts commit aa147bcb. Reason for revert: Fix compile on Android x64 Original change's description: > Revert "Fill in the first pass of the parser to analyze hprof files." > > This reverts commit b30f46fd. > > Reason for revert: Compile error in hprof_buffer_android_unittest.cc on x64 bot. > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896255126674550192/+/steps/compile/0/stdout > > Original change's description: > > Fill in the first pass of the parser to analyze hprof files. > > > > The main purpose of the java heap profiler is to obtain a heap dump in > > the form of an hprof file and then parse the hprof file. Currently, > > there exists an empty parser that skips over everything in the hprof > > file. > > > > With CL, we first parse each instance for given fields (object_id, > > names, etc..) and then store these values in different instance > > objects. We will be using these instance objects in the next CL which > > is the second pass over. > > > > Bug: 1012072 > > Change-Id: Ibe249056c180dd07b907ada129898248c91cbaec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898481 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716986} > > TBR=nyquist@chromium.org,ssid@chromium.org,zhanggeorge@google.com > > Change-Id: Ic1a61810ab7d669b2f2fbae5786e30c17eff1970 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1012072 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926535 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717040} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012072 Change-Id: I1064dd7e7d33002ae870ad632224fccc7547b09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931264Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#718362}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=jsbell@chromium.org Bug: 1023677 Change-Id: I5a1ecdffd989113476f8e29b6625c2a0894446ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927020 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#718361}
-
