GitLab

This CL removes content_source_id in VisualProperties which is no longer
used. It also renames |local_surface_id_| to |local_surface_id_from_parent_|
in RenderWidget to clarify where the viz::LocalSurfaceId is coming from.

Bug: 672962
Change-Id: I11763addeef9d84eab93be624bacedc40757b616
Reviewed-on: https://chromium-review.googlesource.com/1055470
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560829}

This is a reland of 90f86c11

Original change's description:
> Fuchsia: Stop setting OS_POSIX
>
> Bug: 836416
> Change-Id: Ib59796358ff2109ec0b55686974a84980e18254e
> Reviewed-on: https://chromium-review.googlesource.com/1020375
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Matt Mueller <mattm@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560013}

Bug: 836416
Change-Id: I43f34aa644e51d231c7c131b4be364b6ccee2d38
Reviewed-on: https://chromium-review.googlesource.com/1066711Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560828}

Add the BaseTimeLimitProcessor class, needed to implement the BaseTimeLimit policy. This does not implement the methods logic, but provides the interface needed to unblock the UI development.

Bug: 823536
Change-Id: Ie8adecaea3bb0de8c20396959a6b37fd08cbca47
Reviewed-on: https://chromium-review.googlesource.com/1066830
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560827}

Change-Id: I87f1c473460388606947762060b3c40697f18065
Reviewed-on: https://chromium-review.googlesource.com/1069592Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560826}

The best resolution for FHD(1080p) devices are not the ones where the ui
scale is 1 rather its the mode where the ui scale is 0.8 and the device
scale factor is 1.25.

Bug: 845208
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If3ec352d3edbfb85216f5ee1dd125857d13d1abb
Component: Display settings
Reviewed-on: https://chromium-review.googlesource.com/1067592Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560825}

Before https://chromium-review.googlesource.com/c/chromium/src/+/1038565
these layers would change their contents-opaque state when the
GraphicsLayer did, even though the image layer has its contents-opaque
set when setting the image.

Disallowing that to change created a memory regression, as it must be
that some images are not opaque, but the GraphicsLayer becomes opaque
later and the image layer should be marked as such too.

R=pdr@chromium.org

Bug: 838693, 841252
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97c007b46d0bafcb9ecf19fad77327053e978aa2
Reviewed-on: https://chromium-review.googlesource.com/1069194Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560824}

This way it can be used with other tests.

BUG=837684
TEST=covered by test

Change-Id: Iac388d27fa5be1bcd2b6d7f937dabdc4949dec34
Reviewed-on: https://chromium-review.googlesource.com/1069303
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560823}

The net effect of this change is to explicitly run update.py using sys.executable rather than running os.popen directly on the script.

Bug: 396230
Change-Id: Ie896303ed084f254ab7a7b1da201d108c8718ac5
Reviewed-on: https://chromium-review.googlesource.com/1068530
Commit-Queue: Joey Scarr <jsca@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560822}

In anticipation of making VRDevice a mojo interface, this change
starts to trim back where VRDevice is used.  VRShellDelegate can,
for now, still use GvrDevice, which can maintain current functionality.

BUG=795510

Change-Id: I37b4c9b8c914c5f271464ee7488d0002ffa208ac
Reviewed-on: https://chromium-review.googlesource.com/1068025
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560821}

Better detection of "legitimate" reasons to use many columns. Let the
allowance be based on the amount of "content". The more content (lines
or boxes) inside a multicol container, the more columns will be allowed.
We used to base it on the column height, but it turned out that it
wasn't good enough. Also, there are legitimate reasons to use more than
500 columns in some cases, so increase the limit to 2000. With the
current implementation, this may get very slow, because of quadratic
performance complexity, presumably somewhere in paint code.

One multicol regressed in LayoutNG. Not sure why. It shouldn't have
passed in the first place.

This CL was previously landed as
https://chromium-review.googlesource.com/c/chromium/src/+/1057629 and
then reverted because of test flakiness. This new CL has reduced the
number of columns in those tests, so that the tests don't occasionally
time out on slow bots.

Bug: 808189,845155
Change-Id: I55d560faba73128518a689ae38f628ee89e58568
Reviewed-on: https://chromium-review.googlesource.com/1068929
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560820}

These tests:
* fast/css/resize-corner-tracking.html
* fast/forms/textarea/textarea-align.html
use quirks mode, and relies on non-interoperable behavior of
[line height quirks]. This patch changes it to standard mode
as the difference does not look worth to fix in LayoutNG.

<textarea></textarea><br>
<textarea></textarea><br>
<textarea></textarea><br>
<textarea></textarea>
<div><textarea></textarea></div>

If this test is changed to standard mode, all browsers except
Edge create [strut] for all lines. On the other hand, in
quirks mode:

* <textarea> is a replaced element that it should not create
  a [strut] as per [line height quirks] spec. Blink/LayoutNG
  follows this, while Gecko creates [strut].
  Changing this in Blink causes ~320 tests to fail.
* Not defined, but Blink/WebKit comment says, <br> should
  create [strut] only when it is on the line by itself.
  Blink mistakenly applies this rule in this case, and that
  the first 3 lines have [strut], while LayoutNG does not.
  Changing this in Blink causes ~80 tests to fail.
* Edge does not create [strut] in either mode.

[line height quirks]: https://quirks.spec.whatwg.org/#the-blocks-ignore-line-height-quirk
[strut]: https://drafts.csswg.org/css2/visudet.html#strut

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I010a6f1a003d6c30edaa2318d092f0828d9ce6b7
Reviewed-on: https://chromium-review.googlesource.com/1065832
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560819}

Bug: 843770,843348
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifb8517c90cecd569b6600b896329d713a96c82e7
Reviewed-on: https://chromium-review.googlesource.com/1068074Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560818}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I16199932c7aaafd07f99fa134c6be77b30e29926
Reviewed-on: https://chromium-review.googlesource.com/1068057
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560817}

This CL makes two changes to the scrolling for the new Android non-overlapping
tab switcher:

- Lowers the friction
- Changes the scrolling logic so scrolls always end with a tab centered

This is acccomplished by adding some methods on StackScroller to allow changing
the friction and setting a snap distance, and calling them in
NonOverlappingStack when we construct the StackScroller.

Bug: 828224
Change-Id: I996c6b728dd6805add001be1f294ec65467f9252
Reviewed-on: https://chromium-review.googlesource.com/1066280
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560816}

When in print mode, we don't do 'normal' visual output; painting is done
explicitly to a special output canvas. As such, there is little point in
doing composited animation updates, as we will not be showing the result.

This also fixes a DCHECK in BlinkGenPropertyTrees/SPv2 mode, where paint
was skipped but DocumentAnimations::UpdateAnimations wasn't - this caused
UpdateAnimations to fail its DCHECK for the expected lifecycle state.

Bug: 842937
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If8a0e11bd25e931dd02434e18ec90a02c4e8f9e1
Reviewed-on: https://chromium-review.googlesource.com/1066405Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560815}

If any of the currently enabled services can perform gestures, consider
accessibility to be enabled. This changes
AccessibilityUtil#isAccessibilityEnabled to return true if Switch Access
is enabled.

Since the necessary capabilities APIs are only available on N+, on L & M
we look specifically for Switch Access to be enabled by checking the
ResolveInfo of enabled accessibility services.

BUG=839598

Change-Id: I30eceb33d6092c7000371e2733a63f35a9b7d4bb
Reviewed-on: https://chromium-review.googlesource.com/1054131Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560814}

Async destruction of Canvas2DLayerBridge was removed from the code a
long time ago.  There still some traces of it in the code.  This CL
is just a cleanup.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I86fd0424503be99e2a0310751e3867217d3b315e
Reviewed-on: https://chromium-review.googlesource.com/1066741
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560813}

Currently, the image data source must be set before the mediator starts updating
its consumer. The mediator will start updating its consumer as soon as it
starts observing sync state, which starts before the view controller has been
presented. Therefore, the imageDataSource will DCHECK since it is being
accessed before it is set.

The order of setting the imageDataSource should not matter. So a bug
was filed for this: crbug.com/845636.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9893493c1f0e2927b9bc6b69bfdea0142f03adab
Reviewed-on: https://chromium-review.googlesource.com/1069590Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560812}

https://skia.googlesource.com/skia.git/+log/5b58b7c14c44..91dfa3b571f1

$ git log 5b58b7c14..91dfa3b57 --date=short --no-merges --format='%ad %ae %s'
2018-05-22 egdaniel Reland "Move gn setup for vulkan library/headers into their own third_party directory."
2018-05-22 bungeman Remove include/gpu/gl from include paths.
2018-05-22 bsalomon Use layered templates for optional vertex attributes in GrTextureOp.
2018-05-22 mtklein start cleaning up non-skcms SkColorSpaceXforms
2018-05-22 egdaniel Add more blacklists for intel 405 vulkan perf bot.
2018-05-22 herb Remove SkTextBox
2018-05-22 bungeman Revert "Revert "IWYU for tests starting with 'D'.""
2018-05-22 senorblanco GrTessellator: fix crash on merging a dead edge.
2018-05-22 benjaminwagner Rename SwiftShader bots from CPU to GPU.
2018-05-22 bungeman Update SampleLua and lua files.
2018-05-22 jcgregorio Revert "Update docs preview URL in presubmit"
2018-05-22 bsalomon GrTextureOp: Rename template params "V" instead of "Vertex".
2018-05-22 angle-skia-autoroll Roll third_party/externals/angle2/ 787338f9b..534b00dbd (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG=chromium:844873


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I3f8ecf7422051adac07c78fe2bac5a8e3a118d2f
Reviewed-on: https://chromium-review.googlesource.com/1069416
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560811}

Container adds inline_end padding to inline children

Bug: 728378
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I43008ae9ec0b201eff0197fe457bc3a7483e4566
Reviewed-on: https://chromium-review.googlesource.com/1068139
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560810}

Change-Id: I4513ce566269daddeb2da39ef9d658038616612d
Reviewed-on: https://chromium-review.googlesource.com/1069554
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560809}

This reverts commit 49d49cc1.

Reason for revert: Broke all libFuzzer and coverage builds.
See
https://ci.chromium.org/buildbot/chromium.fyi/Libfuzzer%20Upload%20Linux%20ASan/13325

Original change's description:
> Roll src/third_party/perfetto/ a6f6a3133..d1fe1ee42 (39 commits)
> 
> https://android.googlesource.com/platform/external/perfetto.git/+log/a6f6a3133cf7..d1fe1ee42456
> 
> $ git log a6f6a3133..d1fe1ee42 --date=short --no-merges --format='%ad %ae %s'
> 2018-05-21 oysteine Re-enabled TraceWriter flushing on destruction
> 2018-05-21 hjd Fix mac build
> 2018-05-21 fmayer Tune values for ftrace_largebuffer.
> 2018-05-21 fmayer Change LOCKDOWN_UNSET to LOCKDOWN_UNCHANGED.
> 2018-05-18 brucedawson Disable features that fail in Chromium builds
> 2018-05-18 fmayer Add test config with larger buffer size.
> 2018-05-18 brucedawson Changes to get Perfetto tracing in Chrome for Windows
> 2018-05-18 fmayer Change wording in trace_to_text output.
> 2018-05-18 fmayer Correctly handle EINTR.
> 2018-05-17 fmayer Output duration of ftrace as well as total trace duration.
> 2018-05-17 primiano Add tdresser@ to ui/OWNERS
> 2018-05-17 dproy Rerun ninja when UI source files change
> 2018-05-17 brucedawson Fix Perfetto export definitions for Windows
> 2018-05-17 primiano Fix fuzzers and reduce noise from ftrace_parser unittest
> 2018-05-16 primiano Add skeleton for UI (Node + TypeScript + WASM  + build integration)
> 2018-05-08 primiano Clean up some TODOs and use PageAllocator in CpuReader
> 2018-05-15 lalitm perfetto: update docs to keep in sync with other copies
> 2018-05-15 fmayer Add -b flag to tools/tmux to run in background.
> 2018-05-15 primiano Roll GN, clang and libc++ to match chromium revisions
> 2018-05-14 primiano Fix mac build, make pipe_stats linux-only
> 2018-05-14 brucedawson Enable protozero tests on Windows
> 2018-05-14 brucedawson Use relative path to import perfetto.gni
> 2018-05-10 brucedawson Get page allocator working on Windows
> 2018-05-10 fmayer Add sanity check for page size.
> 2018-05-10 primiano Introduce WASM toolchain
> 2018-05-10 lalitm protos: fix typos for lint to be happy
> 2018-05-09 fmayer Use dynamically read header_page information.
> 2018-05-09 fmayer Add metatracing to trace perfetto itself.
> 2018-05-09 fmayer Add PRESUBMIT to protect whitelist.
> 2018-05-09 fmayer Add compile_commands.json to gitignore.
> 2018-04-30 hjd trace_to_text: Print FtraceStats
> 2018-05-09 fmayer Allow to parse events/header_page.
> 2018-05-08 brucedawson Enable more unit tests on Windows
> 2018-05-08 fmayer Add script to visualize pipestats.
> 2018-05-08 fmayer Add tool to analyze rate of events.
> 2018-05-08 primiano Limit concurrent traces to 5 to prevent stalls in traced_probes
> 2018-05-08 fmayer Temporary workaround for 32-bit crashes.
> 2018-05-04 fmayer Fix off by one.
> 2018-05-03 fmayer Increase ftrace buffer. Decrease i/o scan batches.
> 
> Created with:
>   roll-dep src/third_party/perfetto
> 
> Change-Id: I0e085bac9d14b1c55b1be527cd80e4f206240308
> Reviewed-on: https://chromium-review.googlesource.com/1068622
> Commit-Queue: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560522}

TBR=primiano@chromium.org,oysteine@chromium.org

Change-Id: I485d0383fa20161af541139f022f42776ba4bb08
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1069670Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560808}

This counts all crashes (ie crash report is non-empty). This metric
isn't generally useful since we don't traditionally cared a whole
lot about crashes while in background. However it is useful for
correlating with number of crash reports in the crash database.

Change-Id: Idea2e865e66ced5d7ccc4fc1b359d3793433d2ab
Reviewed-on: https://chromium-review.googlesource.com/1069419Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560807}

1) This CL adds two notifications (5 min and 1 min each) when the
   screen is going to be locked because the screen time limit set by
   the kid's parent is about to be used up. Remaining work: we need to
   support bed time notification as well as policy overriding
   notification but those are blocked by the WIP time limit processor.

2) The icon used on the notification should be the same with the one in
   |supervised_notification_controller.cc|, but other than this,
   the code there can't really be reused.

Bug: 843671, 823536
Change-Id: Ic7ec142451d6666a40b455c5bcc3091ad93bc4d8
Reviewed-on: https://chromium-review.googlesource.com/1063266
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560806}

This CL sets default text colors

Bug: 845598
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Icede912c9fd697341d96a3f99425dc8cf5eb7497
Reviewed-on: https://chromium-review.googlesource.com/1069593Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560805}

Bug: 803551
Change-Id: If492cb1d88f1f0947f369a66b7a2aedea19c16e2
Reviewed-on: https://chromium-review.googlesource.com/1067948Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560804}

This CL updates the tab sizing in the new Android non-overlapping tab switcher.
We scale the width by 80% when there's one tab open and 60% when there's more
than one open. When there's only one tab open, we crop the bottom to maintain
constant height.

Bug: 828224
Change-Id: I0c8e47bbec01f25a9d54a810b1846f5f7ab0f18b
Reviewed-on: https://chromium-review.googlesource.com/1066993
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560803}

Send Finch experiment ids from Chrome Autofill to Payment servers in existing Payment RPCs.

We already send experiment ids as one off, but this uses send_to_gws approach as that does this generically rather than waiting on to change for each change every time.


Change-Id: Ia125baab804bcb9873edfb38b01dbe05e9f77992
Reviewed-on: https://chromium-review.googlesource.com/1033631
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#560802}

This can lead to issues when the copy callback has been cleared,
but the old value has already been picked up by the render thread.

BUG=844833
TEST=none

Change-Id: I96cb0f5db1e9b28139e7a148fad135b434b2984b
Reviewed-on: https://chromium-review.googlesource.com/1069489Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560801}

This allows clients to restore the original host desktop size when the relevant
option is unchecked, rather than only on disconnect.

Change-Id: Ia344223bb1475c3b60fbbdd0510f20be8694203d
Reviewed-on: https://chromium-review.googlesource.com/1058675
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560800}

This will increase the likelihood that intermittent failures caused by
changes in this directory will be caught on the commit queue.

Bug: 843290
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie4d230c0290706c956d88f483b82b98f3a62f4bf
Reviewed-on: https://chromium-review.googlesource.com/1069598Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560799}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4198a7bdd11b350d04436c0048977d13f4f50c88
Reviewed-on: https://chromium-review.googlesource.com/1066323Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560798}

This CL refactors Stack into an abstract class with two subclasses:
OverlappingStack (which maintains the current behavior and apperance), and
NonOverlappingStack (to be used for the horizontal tab switcher experiment). The
initial version of NonOverlappingStack implements the basic functionality to
have the tabs not overlap. Later CLs will make the tabs smaller so you can see
the sides of the neighboring tabs, update the scrolling logic, and clean up the
animations.

Bug: 828224
Change-Id: Ib82d4ef59f5fc70f15afba3cabae89daf261ca29
Reviewed-on: https://chromium-review.googlesource.com/1066936
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560797}

This CL shows answer images that are delivered through the alternate json property

Bug: 843370
Change-Id: Ic0a2088b16b5f2d00944719c46c5ff1724d7cc90
Reviewed-on: https://chromium-review.googlesource.com/1066973
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560796}

Bug: 828887
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I121abc634c72e9429a9acdb39377b140143686bd
Reviewed-on: https://chromium-review.googlesource.com/1066295Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560795}

This uses skcms' ICC parser, and directly uses skcms for color
space transformation (rather than going through Skia).

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5add97b131f720545c2953a2d8175e607d138d98
Reviewed-on: https://chromium-review.googlesource.com/1052858
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560794}

This was a suggestion by dcheng@ on
https://chromium-review.googlesource.com/c/chromium/src/+/1063254.

This pattern occurred on other classes in this directory, so I also
migrated them.

Bug: 824568, 752273
Change-Id: I1d8150f0071e931f14211865ff2029f27e16a579
Reviewed-on: https://chromium-review.googlesource.com/1069258Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560793}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/994a66b3..44d7d7d6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Icbb0a0be8ef2d51c060fa2c1bd2860383dbb399a
Reviewed-on: https://chromium-review.googlesource.com/1069171Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560792}

This CL adds support for command line flags that are lists of url::Origins. E.g. The value in --flag=value will now be modifyable from the chrome://flags page using a free form textbox, and will be treated as a comma separated list of origins (e.g. http://example1.test,http://example2.test)

The string from the textbox is transformed as follows:
- Continuous whitespace characters are collapsed into single a space
- String is tokenized using space and comma as delimiters
- Each token is parsed as a GURL. Invalid URLs or URLs with a scheme other than http and https are discarded.
- Remaining URLs are converted to url::Origins, then joined into a single, comma separated string.

The CL also adds --unsafely-treat-insecure-origin-as-secure as the first such flag to chrome://flags. Developers will now be able to modify the list of insecure origins treated as secure from the chrome://flags page on all platforms.

Bug: 834381
Change-Id: Iad44b5b2724687c7bea1ae45c23ccc910eb5cc9f
Reviewed-on: https://chromium-review.googlesource.com/1038152Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560791}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4813121f9840..2315c9a28bd5

$ git log 4813121f9..2315c9a28 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:b/78191547


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2b35512c3d9cd8780e856a4f67039e15e3a9bf84
Reviewed-on: https://chromium-review.googlesource.com/1069551Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560790}