GitLab

Any extension that supports the Text-to-Speech callbacks will be able to
be linked from the Text-to-Speech settings page.

Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f2ae0d9008e48faccd8c3929b902cb925afb877
Reviewed-on: https://chromium-review.googlesource.com/1030755Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554947}

This is a reland of b29fc269

Original change's description:
> [Fuchsia] Use Netstack FIDL interface to get network interfaces.
>
> 1. Updated FILD GN template to generate and compile tables file, FIDL
>    generated code was failing to link without them.
> 2. Updated GetNetworkList() for Fuchsia to FIDL API instead of ioctl().
>
> Bug: 831384
> Change-Id: Ib90303a5110a465ea5f2bad787a7b63a2bf13f61
> Reviewed-on: https://chromium-review.googlesource.com/1023124
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: James Robinson <jamesr@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554868}

TBR=mmenke@chromium.org

Bug: 831384
Change-Id: Iabb29661680b835b947b2780d169e204fd5e2559
Reviewed-on: https://chromium-review.googlesource.com/1036484
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554946}

WebXR UKMs were designed to cover both WebVR usage and WebXR usage,
but were only hooked up for WebVR. Additionally, this change adds
additional UKM metrics for differentiating WebXR from WebVR, and
learning about gamepad vs. WebXR input usage.

BUG=824825

Change-Id: I4be3de178ba2dddad428dae7444313ea3624f4cd
Reviewed-on: https://chromium-review.googlesource.com/1008171
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554945}

The message loop processes chrome.test messages: PASS, FAIL, and named
command _messages_ sent from the test extension.

Rename |entry| to |message|. Use auto where useful and add commentary.
No change in behavior, no new tests.

Tbr: slangley, yamaguchi
No-Presubmit: true
Bug: 833834
Change-Id: Ieacf994cd1cc9fb7004ef24dd869b3ce9d288c18
Reviewed-on: https://chromium-review.googlesource.com/1034617
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554944}

It turns out that CSS mixins inheritance and precedence is more fragile than normal
CSS classes. The order of style includes affects the precedence, which caused the
styling to look correct on Settings, but incorrect on Extensions
(happens only with optimize_webui=true).

Bug: 837140
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I22b592315964c3101d25c68dd5f5f1c29d75b347
Reviewed-on: https://chromium-review.googlesource.com/1035785Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554943}

Change-Id: I9ab217675f0e163d5d43b4cdc78f7ba7e1121bd3
Reviewed-on: https://chromium-review.googlesource.com/1036233Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554942}

Wayland support won't come from mus, so ozone-linux shouldn't turn on
mus.

BUG=none
TEST=none

Change-Id: I682f7998f702d9826f9266ab74266a2593e4d9fb
Reviewed-on: https://chromium-review.googlesource.com/1036192Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554941}

Bug: None
Test: Shows enabled by default
Change-Id: I66f99bec91bed541c961835be6cece00da263946
Reviewed-on: https://chromium-review.googlesource.com/1036475Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#554940}

Bug: b/33693796
Test: manually tested with spinly app.
Change-Id: Id9214a318892bce97fa7290e69dd467d8fa7ce6c
Reviewed-on: https://chromium-review.googlesource.com/1033341
Commit-Queue: Mitsuru Oshima (OOO 4/30 - 5/9) <oshima@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554939}

This is a reland of 209edd56

Original change's description:
> overview: Initial patch for overview swipe to close.
>
> Adds ability to drag the overview item up or fling the item up to close
> the window. A later cl will add the fling animation. The feature is
> hidden behind a newly added flag.
>
> Test: added test coverage
> Bug: 828646
> Change-Id: I8e66fb3ed2a642deb6a833f30e9b7674d56b0fee
> Reviewed-on: https://chromium-review.googlesource.com/1014490
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554651}

Bug: 828646, 838061
Change-Id: Ifa3c4f33c6831c5f5e06c62682893680a5e4c27b
Reviewed-on: https://chromium-review.googlesource.com/1035368
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554938}

TBR=dtrainor@chromium.org

Bug: 838403
Change-Id: Ie77fa3e33a85eb6cc52c7a83f742b76d9d4839ae
Reviewed-on: https://chromium-review.googlesource.com/1036540Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554937}

Cookie handling of non-ASCII codepoints is not consistent across
browsers, so we definitely want tests that exercise these. To make
potential failures here more obvious, make sure that there are
dedicated test cases for non-ASCII interop with other ways of
getting/setting cookies (HTTP headers, document.cookie).

Also, make the document.cookie interop tests symmetric:
set/overwrite/delete by CookieStore observed by document.cookie and
vice versa.

Bug: 729800
Change-Id: I637401e5f8021a2915ba186fbb1cf7a50e940905
Reviewed-on: https://chromium-review.googlesource.com/1036306
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554936}

The constants are used outside the scope they're defined in, which means
unless they're marked 'static', their lifetime has ended and the compiler
is free to reuse their stack slot. Marking them static means they're always
alive, and also removes the need to copy them to the stack.

Re-using the stack slot for some part of these was causing the red channel
to disappear during chromoting when compiling with Clang without
-fmerge-all-constants.

Bug: 835506
Change-Id: I6bddbf531979fecf78c80c0f96afda8ea0d05e33
Reviewed-on: https://chromium-review.googlesource.com/1035323Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554935}

This reverts commit 4a57957a.

Reason for revert: mpearson@ would like to discuss it with the team before proceeding.

Original change's description:
> [omnibox] Don't add WYT search in keyword mode
> 
> When in keyword mode, results will be from that search provider,
> except for a single WYT search at the bottom. It looks odd to
> have a different search there, when the user asked for a keyword
> search. This CL doesn't add the match in that case.
> 
> Bug: 837395
> Change-Id: I1441a6fe07f5d1e7ac5cd3dc16de408df6ad18c9
> Reviewed-on: https://chromium-review.googlesource.com/1030613
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Kevin Bailey <krb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554762}

TBR=pkasting@chromium.org,krb@chromium.org,rdevlin.cronin@chromium.org

Change-Id: I95294218cde250794093ce05b85f955f4cb538b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 837395
Reviewed-on: https://chromium-review.googlesource.com/1036506Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554934}

[LegacyArrayClass] was removed from the WebIDL spec in
https://github.com/heycam/webidl/pull/551, so we no longer need to
include a note that it is unsupported in Chromium.

Change-Id: I32523e78b59aa74522f217b4b79cafb60d4d5eb8
Reviewed-on: https://chromium-review.googlesource.com/1036082Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554933}

R=dpranke
BUG=None

Change-Id: I7910a9de199f3d883b125bcbe3b79698adc24a7d
Reviewed-on: https://chromium-review.googlesource.com/1036588Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554932}

This reverts commit 53744640.

Reason for revert: broken dbg builder since NetworkContextTest.CreateNetLogExporterErrors crashed

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5453

Original change's description:
> S13n: Add APIs for implementing net-export in Network Service
> 
> (But don't use them yet).
> This takes care of managing the FileNetLogObserver with a passed-in
> destination file, and also of all aspects of pulling state from
> URLRequestContexts, which browser-end NetExportFileExporter presently
> does but won't be able to with network service.
> 
> There is one behavior difference in that respect: the in-progress
> entries for things that are in flight when the export is started
> now included all URLRequestContexts known, rather than just the
> main + media + system for whever the export UI is running. Given
> that events collected when export is active included everything
> already, this seemed rational as consistent, and avoiding complexity
> of finding the particular contexts, including the going-away media one.
> 
> Bug: 767450
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I55334b8282165203f13ecf7a7a7de253fe36b1f1
> Reviewed-on: https://chromium-review.googlesource.com/1030033
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554847}

TBR=tsepez@chromium.org,xunjieli@chromium.org,morlovich@chromium.org

Change-Id: I9a94f130ebb254a61a7afebcb2d7027a23903514
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767450
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1036486Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554931}

There's no longer a dependency on any system fonts when running Linux tests, so
font packages may be removed.  The CrOs fonts are kept because, presumably,
folks might still want them when testing Linux CrOs builds, though the CrOs
tests also no longer depend on any system fonts.

BUG=787020
R=dpranke

Change-Id: I6074842eb67eba6194fa90e549e0485b529aa814
Reviewed-on: https://chromium-review.googlesource.com/1036585Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554930}

This deprecates "xcode version" tag and replaces it with the new "xcode build
version" tag, effectively migrating off of a system-installed Xcode to Xcode
installed per build as requested by the config.

Additionally, use the appropriate Xcode version that supplies legacy iOS
simulators, so we do not depend on system-installed simulators.

R=justincohen@chromium.org

Bug: 835036
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia73c843ed907cef943b2ab9ec550366a338212e0
Reviewed-on: https://chromium-review.googlesource.com/1028650
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554929}

The ParentLocalSurfaceIdAllocator unit tests have a function to get a
fake child-allocated LocalSurfaceId. It hard-codes values.

The hard-coded parent sequence number is bad but not terrible. It forces
knowledge of the calling functions. This isn't good. It can be improved.

However, the embed token part is pretty bad. It forces the unit tests to
assert the wrong behavior. A child allocation should use the parent's
embed token. Since the hard-coded value is different, the calling tests
assert that the embed tokens don't match when in reality they should.

To fix these bad behaviors, the fake child allocation should take a
parent allocator (or parent-allocated LocalSurfaceId) so the values can
be based on what the test provides.

BUG=837030

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Iaa8e7b6226c0a6c6d67fa420183f24a36e7499ce
Reviewed-on: https://chromium-review.googlesource.com/1036530Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554928}

https://pdfium.googlesource.com/pdfium.git/+log/94161d59fd3c..3d3c2dea9fcb

$ git log 94161d59f..3d3c2dea9 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 hnakashima Change out parameter of CFGAS_GEFont::GetCharWidth to pointer.
2018-04-30 hnakashima Fix more possible integer overflows in CFX_TxtBreak.
2018-04-30 thestig Simplify Unicode_GetNormalization() and caller.
2018-04-30 thestig Fix some nits in CPDF_TextPage.
2018-04-30 tsepez Saner memory managment in cttfontdesc, part 1.
2018-04-30 hnakashima Fix Integer-overflow in CFX_TxtBreak::AppendChar_Others

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:838095,chromium:838095


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I933854bcd53e2eaef72c4dd112c012de1090b99c
Reviewed-on: https://chromium-review.googlesource.com/1036454Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554927}

BUG=762641
TBR=warx@google.com

Change-Id: I8eeaddc9c61b1a65650fcb97203ac18b3c00d9ab
Reviewed-on: https://chromium-review.googlesource.com/1036210Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554926}

There are states in the lifecycle of a page that only the browser has
the ability to transition to. But, web-developers need to be able to
test their application against those transitions. The added call
triggers those transitions.

Bug: chromium:837709
Change-Id: I1ead73ef7106773dc77e4534ec038177dae7b021
Reviewed-on: https://chromium-review.googlesource.com/1033357Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554925}

Precursor to land https://chromium-review.googlesource.com/c/chromium/src/+/1035788

Scripted used @ https://crbug.com/825327#c152

R=fdoray@chromium.org
TBR=jam@chromium.org

Bug: 825327
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I5a356e8004b633283a0615a73bb52ed703d97965
Reviewed-on: https://chromium-review.googlesource.com/1035807Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554924}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/65dbd539443e..c6e57bb74838

$ git log 65dbd5394..c6e57bb74 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 tandrii bot_update: really check whether repo is pinned at an actual sha1 revision.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:838292


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I025cdaef7b03da8b3c20b0432e0a43a9619d9745
Reviewed-on: https://chromium-review.googlesource.com/1035800Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554923}

When using HW secure codecs, we cannot and should not use the CDM
instance to do decrypt and/or decode. Instead, we should use the
CdmProxy to do decrypt and/or decode, with the help of HW
decoders/decryptors.

Bug: 795366
Change-Id: Ib43034fb17b5241d42a7d42fbebcbe660c3bc7c7
Reviewed-on: https://chromium-review.googlesource.com/1027206
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554922}

On a successful install/update, component_updater sends a dbus signal to
platform. This allows compnoent consumers to be notified instead of
retrying calling the Load API.

Include dbus in chrome/browser/DEPS

BUG=chromium:822902
TEST=sudo -u root dbus-monitor --system  "type='signal',sender='org.chromium.ComponentUpdaterService',interface='org.chromium.ComponentUpdaterService'"

Change-Id: Ie913658329e6eb0cf0deb030fc772ec03fdbd8ea
Reviewed-on: https://chromium-review.googlesource.com/984600
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554921}

Using wpt-import in Chromium 2b04fae0.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
7dea9b2c "[css-grid] Subtract scrollbar in ComputeReplacedLogicalHeightUsing()"
bf802aa6 "[css-tables] Scrollbar should be removed from OverrideLogicalHeight()"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16553

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=lukebjerring

No-Export: true
Change-Id: I6936c08787ff153fc17f450f06425d4609ae091b
Reviewed-on: https://chromium-review.googlesource.com/1035806
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554920}

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia67c37adbdfb1799567b27ae348dc3f4204f35bc
Reviewed-on: https://chromium-review.googlesource.com/1035615Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554919}

This adds conversion code to convert between the frameworks and Support
Library versions of SafeBrowsingResponse.

No change to behavior otherwise.

Bug: 837815
Test: ./gradlew :webkit:connectedAndroidTest
Change-Id: Id152ff18ad4d3b6cbd682ba90add1e02eb64a559
Reviewed-on: https://chromium-review.googlesource.com/1035908Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554918}

This will let the chrome-sdk explicitly set them as args (ie CL:1035427)

Once that lands, then we can remove the default env-var logic.

Bug: 732531
Change-Id: Id8283e6018f8f7e652a29cb367b0a3c10adc6fa8
Reviewed-on: https://chromium-review.googlesource.com/1035602Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554917}

Existing testing code needs a way to error out the transport layer so that
we can test caching behavior. This CL adds a new API to the network service
for testing that will force the transport layer to return the given error
code.

Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I67acfc0027bbb32ba751b61afd238e951dd39e67
Reviewed-on: https://chromium-review.googlesource.com/1034122Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554916}

LayoutText's CreatePositionWithAffinityForBoxAfterAdjustingOffsetForBiDi()
does no adjustment when the direction of |box| is the same as the
containing block.

The current code returns the "unadjusted" offset after checking whether
|offset| is at left or right edge of |box|, which is unnecessary. This
patch moves it out before the check.

Bug: 811502
Change-Id: Icf26191a3fc5aaa829b8dfb5e0319d9bb8fcdc1d
Reviewed-on: https://chromium-review.googlesource.com/1035918
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554915}

This change avoids allocating an additional std::string by using the
host_piece() method on GURL instead of using host() when comparing
against another GURL.

Bug: 663729
Change-Id: I3afd3aeccc0ecca4c04a77543adbdb856a78940e
Reviewed-on: https://chromium-review.googlesource.com/1036444
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554914}

This is to fix the trace_analysis_ct benchmark failure mentioned in
https://bugs.chromium.org/p/skia/issues/detail?id=7796#c8
and
https://chromium-review.googlesource.com/c/catapult/+/1035454#message-2b3d62be6599a5733e1af25499c95ec9808138c1

Bug: skia:7796
Change-Id: Ibed7336c9fde57b681e18ad6c0024731693d4430
Reviewed-on: https://chromium-review.googlesource.com/1036202Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554913}

Change-Id: Idb7667c42bbe16ab9eb7bb4421980401641b8c94

Bug: 730693
Change-Id: Idb7667c42bbe16ab9eb7bb4421980401641b8c94
Reviewed-on: https://chromium-review.googlesource.com/1032635
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554912}

https://chromium.googlesource.com/angle/angle.git/+log/0ade8e88d811..ddd772455ce7

$ git log 0ade8e88d..ddd772455 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 courtneygo Add GLESv1_CM to angle library apk

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ifb85912935f311038c8f3f6bd480ba540b350252
Reviewed-on: https://chromium-review.googlesource.com/1036107
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554911}

CL adds a WaylandDataDeviceManager class and moves that handle
wl_data_device_manager logic out of WaylandConnection into it.

It brings no functionality change, but makes it easier to be extended
to support primary selection (middle-click to paste).

BUG=578890

Change-Id: I8c04035bf4d3e9de5a0c2cac5c83d4552912cc0d
Reviewed-on: https://chromium-review.googlesource.com/1035943Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#554910}

Previously Zucchini-gen uses built-in heuristics to perform element
matching for ensemble patch generation. This CL adds an option
(accessible via the -impose parameter) to specify elements in "old"
and "new", and how they match. This allows the default heuristics to be
overridden, and enables external applications (who perhaps have better
ideas of element matching, e.g., have access to archiving programs) to
better use Zucchini to patch archives.

Zucchini-match is updated to prints the -impose command line to repeat
its results. Also, ElementMatch::ToString() is added.

Change-Id: I541b64722904c2fcd19ed75246d87e0268fbf86c
Reviewed-on: https://chromium-review.googlesource.com/1027191Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554909}

Bug: 759710
Change-Id: I595c8a031dbf3b890056024c5f8ac09b355ee7f0
Reviewed-on: https://chromium-review.googlesource.com/1033921Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554908}