- 11 Dec, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40dbba6dda38..0bf3f26cf343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: I4c77bcc6813db587e897fdf402db5e213e264519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586965Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836308}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7542517e29ce..0991ca17bab3 2020-12-11 ericlaw@microsoft.com [NetLog Viewer] Enable import of .ZIP files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057782 Tbr: wenbinzhang@google.com Change-Id: I3eb60c8ef9b33f230c855b0685d2e6232aa8e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74ccf7b62fc6..778b2c216924 2020-12-11 fmayer@google.com Merge "Default symbolizer to nullptr." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If8d244c11b4d38feec1c760a3ca98a204184db19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836306}
-
Andre Le authored
PhoneHub will only be available for primary user of the device. Bug: 1106937 Change-Id: Ic903a0f9d97bcd0a65afab8f5fd8a3ae8ed18d73 Fixed: 1155361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581691 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836305}
-
David Dorwin authored
The tests fail in component builds because of the way the Safe Search code is built. Disable the tests in component builds until this can be resolved. Bug: 1147231, 1157909 Change-Id: Idac5bb566377d387bd0332d8d32e00bff8c742ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587492Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836304}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_UpdateHitTestData IPC message to LocalMainFrameHost interface because the IPC message has been used by 2 functions. So, this CL adds the message to LocalMainFrameHost interface instead of handling it as a reply callback. To support the parameter, this CL moves AwHitTestData struct and HitTestDataType enum to Mojo. - AwHitTestData -> android_webview::mojom::HitTestData - Type -> android_webview::mojom::HitTestDataType Then, all uses of the native struct and enum are replaced by the Mojo struct and type. Bug: 1146495 Change-Id: I906e00f1f5f3e18556613b39eedb90bf845b164c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574560Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#836303}
-
Guillaume Jenkins authored
When browser sign-in is disabled by policy, replaces the sign-in promo in the "Other devices" section of the Recent Tabs views with a message indicating that the feature has been disabled by the managing organization / administrator. Bug: 1155745 Change-Id: I496e7f7ec53d721748e8a49c9a01228aa9b43548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575260 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836302}
-
David Black authored
Finishes the holding space view hierarchy refactor by renaming: - HoldingSpaceItemViewsContainer --> HoldingSpaceItemViewsSection - PinnedFilesContainer --> PinnedFilesBubble - RecentFilesContainer --> RecentFilesBubble Bug: 1154998 Change-Id: I621a8c76daf142ced35503fe78801dbfd09d4570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587611 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836301}
-
Anqing Zhao authored
KioskAppExternalLoader is used to load apps and extensions for a Chrome App Kiosk session. It registers a callback and wait until app info is updated. This class should be only used in Chrome App Kiosk, but not in other two Kiosk types. But according to the current implementation, the loader is enabled unexpectedly and blocks the uninstallation of force-installed extensions when they are removed by admins. Therefore, the check logic should be limited to a proper scope. Bug: 1153440 Change-Id: I8bf79fa553dfbea5e271b7f06fc6ff0dffb33495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575118Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#836300}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1152698 Change-Id: I55879a551671b5b9a87ad83c59cc10a055b4cf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585814 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836299}
-
Etienne Pierre-doray authored
Sampling profiler uses TimeTicks::Now in signal handler to get a timestamp associated with the sample. When called from signal handler, TimeTicks::Now occasionally crashes the following check: CHECK(clock_gettime(clk_id, &ts) == 0) In order to get good time precision in profiler, we'd like to get a timestamp while the sampled thread is paused. Since failures are rare, a solution is to allow clock_gettime to fail, and fallback to getting an 'async' timestamp after resume. To reuse some of the ConvertTimespecToMicros boilerplate common with TimeTicks::Now, this CL exposes subtle::MaybeTimeTicksNowIgnoringOverride() on posix, used in stack_coper_signal. Bug: 1155269 Change-Id: I4d8f5a3e050f5285b87297f13dfd29e888e40257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584603 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836298}
-
Evan Stade authored
Bug: 1152276 Change-Id: I44471424b6f6a106a029a87b54b30eca1e17229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582818 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836297}
-
Martin Barbella authored
Change-Id: If076a5431ed62f498f3098a29d65f5d616acd892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587357Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836296}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607666365-8ac3b41b3fd6b7cdefcffd3f36f49fc644306c58.profdata to chrome-win32-master-1607698715-1a3a3061a3079200d5a916fef636afe5df338f1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic50324a2663a8f89b91ff7af0abe51a14a0cac0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836295}
-
Min Qin authored
BUG=1157734 Change-Id: I419951b1c9880054f98d59eddaa681f02bb0359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586223Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836294}
-
Patrick Noland authored
This changes moves dispatchKeyEvent, onConfigurationChanged, showUrlBarCursorWithoutFocusAnimations, and updateStatusIcon to LocationBarMediator. To enable this, it adds a getter and setter for mUrlFocusedWithoutAnimations. Some unused methods are removed. Since onKey logic has changed structure, unit tests are added for this. Bug: 1147581, 746660 Change-Id: I4715a156d02b8e9c3a4c63109c0cc521251f5cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585444 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#836293}
-
Stephen Roe authored
Bug: 1126177 Change-Id: I7a092787449f01318f31f408adc80173e6f4f07d Ignore-Goma-Freeze: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580442Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#836292}
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/ui/views/extensions from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: Ie6c0e8002710c9fe895f65dc60b9a4ec1e8f71d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586120Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836291}
-
Finnur Thorarinsson authored
The bottom-sheet UI is a hybrid between the PWA install infobar and the install dialog and serves as a direct replacement when the feature is enabled. Bug: 1146450 Change-Id: I3c31659017e7872a1ab5f5df5c445d40b249ffc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550820 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836290}
-
Josh Imbriani authored
Bug: 169173203 Change-Id: I6afeb402e91399a529916f041b16f0964e8f4e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572776Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Josh Imbriani <joshimbriani@google.com> Cr-Commit-Position: refs/heads/master@{#836289}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c94b21d60ca4..99399caeacf6 2020-12-11 gavinmak@google.com [owners] Add BatchListOwners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Icc53e8c2aa44590e835f80b66b5f9079f023fe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836288}
-
Noel Gordon authored
After CL:2515787, the SWA main.html auto-generator generates an error Did you mean print(line + ' ' + _SWA) ? and stops a gn clean simple chrome flow ChromeOS build. Apply the fix suggested to fix build error (works before and after CL:2515787). Tbr: lucmult Bug: 1113981 Change-Id: I454674756ab2bcf24c65d4ca1b815fc2e5b30201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585261Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#836287}
-
Majid Valipour authored
Previously we would access the IDP web contents which was leading to crash. Bug: 1141125 Change-Id: I5943d38e51f8e14fbf0488d0a104cd56b39ea5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586112 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836286}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5912ded0c19b3a7db52efda609363d11a5ed7144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836285}
-
Dirk Pranke authored
This reverts commit bb97ab9b. Reason for revert: Various breakages. Original change's description: > Force Python 3 to be used in build. > > This CL makes Python 3 be the default script executable used by Ninja > to run action() and action_foreach()'s during the build. > > This does *not* mean that everything works with Python3; many targets > may still use Python 2 via the python2_action() and > python2_action_foreach() targets or via custom logic. > > However, it does mean that it should prevent regressions from > creeping in. > > This CL should not be taken to imply that we can start to write > Python3-specific code that can run during the build; we should > still be trying to ensure that everything is compatible with Python2. > > Also, this CL does not enable the use of vpython in actions; we should > still avoid that because vpython is slower than direct Python > invocations. > > Bug: 1112471 > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#836234} TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836284}
-
Carlos IL authored
Features were enabled by default in crrev.com/c/2583141 and are no longer required to be in fieldtrial_testing_config.json Bug: 1105210 Change-Id: Ie984ea0e17d151cf9105ab85ba11e6a4c4762457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586771 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#836283}
-
Carlos IL authored
As discussed with a11y team in comments 29 and 31 crbug.com/1061611, it is desirable that the net error code in SSL interstitials (which can be clicked to show the certificate information) has a button role for screen readers and other accessibility devices. This adds the role when the error code is clickable. Bug: 1061611 Change-Id: I02ac3ba3253fae3fcecff09da5fb7b683ba09258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582469 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#836282}
-
Joon Ahn authored
String spec "Nearby Share - Receiving - Confirmation" Bug: n/a Change-Id: I487c5c991c66eaa75cce9f59ce94e481d3cb57e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586253 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#836281}
-
Alex Moshchuk authored
Bug: 1157861 Change-Id: If1867229c04d823bea330375546f7dfe910d9262 Tbr: tvanderlippe@chromium.org No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587395Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836280}
-
behdad authored
Submitting a bulk of skipped compositor frames as dropped frames can affect the normalized worst case percent dropped frames. This change stops submitting skipped frames more than the limit (100 frames). Bug: 1157101 Change-Id: I63c6f57c9d6c7fa2021842f13f1ca86ff7c9fd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583008Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836279}
-
behdad authored
Frames which are started prior to first contentful paint will not be added to frame_sorter and as a result would not be reported as part of normalized smoothness metrics. Bug: 1157479 Change-Id: I665172b297c38ada0e2d468417342e5c2df06374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584647Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836278}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8b9cff42b376..7542517e29ce 2020-12-11 heiserya@google.com Escape user_agent when launching Lacros If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1148485 Tbr: wenbinzhang@google.com Change-Id: I739a914a8742d5cb2cdd1307c4f19c7accc43a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836277}
-
Alex Moshchuk authored
This reverts commit a28187dc. Reason for revert: After this change, PermissionPromptBubbleViewBrowserTest.AlertAccessibleEvent is failing consistently on some Mac try bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/58202 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/40075 Sample failure: ../../chrome/browser/ui/views/permission_bubble/permission_prompt_bubble_view_browsertest.cc:199: Failure Expected equality of these values: 2 counter.GetCount(ax::mojom::Event::kAlert) Which is: 1 Original change's description: > Implement a11y support for permission chip UI > > Announce to screenreaders that a permission has requested if chip UI is > used. For prompt UI, the bubble is shown and it takes over the focus. > Chip UI is less intrusive so it must be explicitly annouced for screen > reader users. To avoid users not hearing the announcement, it would be > reannouced after 2 minutes. > > Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users. > > Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement. > > Bug: 1150836 > > Change-Id: I7118abcf0bed9702cf17d15a9bb59f9a1d8783b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578843 > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836198} TBR=bsep@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,olesiamarukhno@google.com Change-Id: I3f11f1b4de624199c5ba2a4c4f4c7c327a7cde8a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586966Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836276}
-
chrome://accessibilityKurt Catti-Schmidt (SCHMIDT) authored
This change creates a ViewsAXTreeManager for each top-level Widget behind the runtime flag "--enable-features=AccessibilityTreeForViews". This change also displays the contents of the entire tree built by ViewsAXTreeManager under chrome://accessibility under a new "Top Level Windows" section that is only visible when the runtime flag is enabled. Much of the code changes here are converting methods that serialize BrowserAccessibility nodes to instead take AXNode's. This was fairly straightforward for most of these, however AccessibilityTreeFormatterBlink::AddProperties had to be forked due to all of the properties that depend on the delegate. WidgetAXTreeIDMap is added to map between Widget objects and their root AXTreeID. In order to suppress build errors on ChromeOS and macOS, this change is limited to non-ChromeOS Aura builds (Windows and Linux). AX-Relnotes: Displays internal UI tree in chrome://accessibility. Bug: 1049261 Change-Id: Id3918e177df360b284d186638a04d8be494508c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402398 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#836275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29339074e443..82e0d524143f 2020-12-11 nifong@google.com Don't crash debugger on missing images 2020-12-11 bsalomon@google.com Improve clamp mode in GPU blur with downsampling. 2020-12-11 tdenniston@google.com [svg] Prep work for filter primitive subregion 2020-12-11 egdaniel@google.com Add gr_cb class to help tracking command buffer uses of GrGpuResources. 2020-12-11 bsalomon@google.com Add new SkCanvas methods for Android Framework WebView queries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1156804 Tbr: jmbetancourt@google.com Change-Id: I32ec8fb58d79617e115a18c825eda38c107e6531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836274}
-
Toni Barzic authored
Leaves HoldingSpaceTrayIcon to only handle the content forward icon. Adds another image view for the default icon, and lets HoldingSpaceTray manage which icon is visible. Removes holding space observation logic from HoldingSpaceTrayIcon to avoid duplicate event handling to avoid HoldingSpaceTrayIcon getting duplicate holding space model events - e.g. if the icon is created or initialized during OnHoldingSpaceModelAttached, and starts observing model changes itself, it may handle model attachment twice. Relying on HoldingSpaceTray to notify HoldingSpaceTrayIcon about model changes makes avoid such scenario easier. The end goal is to make HoldingSpaceTrayIcon not depend on individual holding space model changes, and just have an API that would specify the list of items whose previews should be shown in the tray icon - will be done in a follow-up. BUG=1142572 Change-Id: Iad3bc7089d2aec770e03ef88bf168d3e43f706da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586554 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#836273}
-
Ryan Sturm authored
This adds three histograms: -- Why the prefetch was started/not started -- Why the navigation was served/not served from prefetch -- What the final status of the prefetch was when it was served or deleted by expiry policy Bug: 1138652 Change-Id: I6d8dc6ca34c4fda81be926d65ee66f96a3cadf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586067Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836272}
-
Anthony Polito authored
this was generated by an automated workflow Bug: 1113033 Change-Id: I67ec1b9e9684533a83adfed681abe68ff21f564c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586382Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#836271}
-
James Cook authored
I forgot to update the test expectations when I added LacrosMetricsProvider back in June. We weren't running lacros unit_tests in CQ/CI back then, so it got filtered out when the bots were brought up. Fix the test expectations and remove the filter. Bug: 1150115 Change-Id: I7e87e109ce94532a6a0bc9cf609126b4e80efd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587259 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836270}
-
Ajit Narayanan authored
Adds new user actions for when the user manually pauses or resumes Select-to-speak. Additionally, since the new STS bubble provides an alternative way to cancel, adds a new point of logging for CancelSpeech when performed through the close icon. Bug: 1143817 Change-Id: Ifc53543d4e6278b725ff418e4461562d37e56501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580479Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#836269}
-