GitLab

TraceProcessor replaces the existing (unmaintainable) proto2json
converter and adds features like combining of BEGIN/END events
and support for heap profiles.

Also updates a devtools test that was expecting separate begin/end
events where TraceProcessor now combines them into a complete event.

We have reduced the trace procesor's binary size overhead
by selectively excluding features Chrome doesn't need from >400kB to
~50kB. We could probably save a couple more kB if we invest even more
eng time and accept the maintenance burden for this in trace processor,
however, we feel that we've reached an acceptable state that balances
binary size & code health.

Binary-Size: see paragraph above.
Bug: 1006770
Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713593}

r705290 moved when exactly a renderer/NTP-initiated navigation starts to
be treated as if it was a browser/bookmark-initiated navigation.  This
regressed omnibox behavior which stopped showing the URL of a navigation
initiated by an NTP click.  The main cause of the regression is that
after r705290 the NavigationEntryImpl::is_renderer_initiated() would
return true (inconsistent with NavigationRequest).

This CL makes sure that NavigationEntry associated with a
renderer/NTP-initiated navigation also indicates that this navigation
should be treated as browser-initiated.  This is achieved by adding an
extra call to ContentBrowserClient::OverrideNavigationParams *before*
creating the NavigationEntry and *before* the new Omnibox display text
is calculated by the following callstack:
    LocationBarModelImpl::GetFormattedURL()
    LocationBarModelImpl::GetURLForDisplay()
    OmniboxEditModel::ResetDisplayTexts()
    OmniboxViewViews::Update()
    LocationBarView::Update()
    ToolbarView::Update()
    Browser::UpdateToolbar()
    Browser::ScheduleUIUpdate()
    Browser::NavigationStateChanged()
    content::WebContentsImpl::NotifyNavigationStateChanged()
    content::NavigatorImpl::GetNavigationEntryForRendererInitiatedNavigation()
    content::NavigatorImpl::OnBeginNavigation()
    content::RenderFrameHostImpl::BeginNavigation()

The decision whether a navigation is NTP-initiated needs to be based on
the |source_site_instance|.  The decision cannot be based on the
|initiator_origin|, because we want https://example.com to be treated
differently from https://example.com/chrome/ntp (the latter might have a
different effective Site URL when it is designated as a "remote NTP").
This requirement necessitates adding a |source_site_instance| parameter
to NavigationController::CreateNavigationEntry().  In the NTP scenario,
the NavigationEntry is created by the following callstack:
    NavigationEntryImpl::NavigationEntryImpl()
    NavigationController::CreateNavigationEntry()
    NavigatorImpl::GetNavigationEntryForRendererInitiatedNavigation()
    NavigatorImpl::OnBeginNavigation()
    RenderFrameHostImpl::BeginNavigation()

To account for DCHECKs that ensure that NavigationRequest and
NavigationEntryImpl are compatible, the CL also had to move the older
OverrideNavigationParams call from NavigationRequest::StartNavigation to
the NavigationRequest's constructor.

This CL adds a regression test: LocalNTPTest.PendingNavigations
Additionally, I've manually tested that repro steps from
https://crbug.com/1020610#c1 have expected behavior after this CL.

Bug: 1020610
Change-Id: I7a16b28eb9426c348f37f432e7b4813bee55ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896295Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713592}

no longer necessary with network service.

Bug: none
Change-Id: Ia96f8cb19c8c738d4cb310fbf161a655d6bdb307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888383Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713591}

Building WebRTC's frame_analyzer when is_component_build=true will
fail after [1] lands. It is possible to build it only for release
builds but this CL tries to remove it since probably this is not
needed.

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722

Bug: webrtc:9419
Change-Id: I6da6973b8a50ea08b60f0eea0da57014cce830e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904072
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713590}

Change-Id: I936c84d79cca2072e324946708762d7990f19ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898774
Auto-Submit: Eric Roman <eroman@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713589}

Bug: 1021236
Change-Id: I965d036f6021ea308bca56eebde229fd4de9aaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900548
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713588}

These are leftovers after https://codereview.chromium.org/1804813002
deleted the function bodies and calling sites.

Bug: 583477
Change-Id: I9982d7d35ee38e0995a3103ae224b3544494ec07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903131
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713587}

This path adds a metric recording whether each URLRequest's
referrer is "more informative" than its origin, in the sense
that its path contains at least one character other than its
opening slash.

This will be used for evaluating the impact
of changes to referrer handling that truncate referrers to the
initiating origin (if the truncation is a no-op, then the metric
should be equal between clients performing the truncation and clients
not).

Test: adds unittests covering same-origin and cross-origin requests
(which the histogram buckets by) and redirects.

R=csharrison, mmenke

Bug: 1019887
Change-Id: I131c786d3938aece1f15732a990d6e10fecce4be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900430
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713586}

Move contextualsearch/ constants into it.

Not moving all of the constants in ChromePreferenceManager at once
so that the review is more focused.

Bug: 1022107

Change-Id: I1da396bb180e5a7c05be42390d06e507a3771ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900575
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713585}

This reverts commit 331504cf.

Define guest view custom elements synchronously

Previously, we've had to wait for readystatechange before defining
the guest view custom elements because
1) there were circular dependencies that would cause errors if we
tried to perform the definition immediately, and
2) the Custom Elements V0 registration context was scoped to the
document rather than the window, so if we defined the elements
while the document was still on about:blank, the definition would
be available on about:blank, but not for the extension.

Now that the circular dependencies are fixed and guest view is
migrated to Custom Elements V1 (whose registration context is
scoped to the window), it is no longer necessary to wait for
readystatechange.

We now perform the definition immediately.

Bug: 810012
Change-Id: I009dbc7710316dd9f4b7fbe5a12ad091e6b597bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869115Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713584}

As one of the success metrics for the upcoming default referrer
policy change, we want to take a look at the distribution
of "effective" policies across requests (where "effective" means
the policy the request goes out on the wire with, rather than
the policy that was provided to the navigation stack).

Test: expand unittests

R=csharrison, mmenke

Bug: 1019887
Change-Id: I3643e7c213c5ab1cf0df0cb24656bd3eb63b58c9
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899730
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713583}

We have a few bad v106/v109 shell in the wild for clankium, chromium,
canary and dev channel. The bad shells can cause Chrome to crash
when Chrome tries to update that WebAPK but either times out or
couldn't reach the website.

The cause of the crash is that the shell has a resource id when
it shouldn't. This CL fixes that.

Bug: 1019318, 977173
Change-Id: I27b214f374d77942122365455cfac561244a161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902076
Commit-Queue: Henry Jian <hzjian@google.com>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713582}

The last caller was removed in crrev.com/669295.


Bug: 934009
Change-Id: I3cabd207d231c95787ad4511abbf296fa39feebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902271
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713581}

This adds the new field "Mainframe Ad Bytes" to the
AdPageLoad UKM, it records the number of detected
ad bytes in the main frame. This allows monitoring of
changes to main frame ad byte detection.

Similar to the existing Ad*Bytes metrics in AdPageLoad
it is binned by KB.

Amended ukm.xml to note that AdPageLoad byte counts
refer to network bytes.

BUG=1021038

Change-Id: I4898a9469d491fcfcd21b7f8fccff0c394c008b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895510Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#713580}

6dadd492b890 linux: fix proc stat reader flakiness
bd1aa246ca18 Starts compiling the crashpad_test_test target on iOS

Change-Id: Iad63f52106c16084d0408b425da0a9ef89cb94a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904307Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713579}

Bug: 1021236
Change-Id: Ib6d9239de1291281fd01fd683b9df88fc6427085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898623Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713578}

It's not used any more, and the calling script was changed
to no longer provide it.

Bug: 913074
Change-Id: I01250b226eddb40fd4d523c75f9132c97629a8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904232
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713577}

This saves about 90 kB of Android APK size, and should be nearly as fast. This
adds up mainly because we have a sufficient number of Mojo methods that this
code is very heavily repeated.

For example, network::mojom::NetworkContextRequestValidator::Accept (1,592 bytes)
is replaced with a 24-byte function and a 720-byte table, and the strings
"NetworkContext RequestValidator" and "NetworkContext ResponseValidator" are
replaced with a single "NetworkContext" that may even be further deduped.

Change-Id: I772145a839b9607098311b3309fd49e94e43991e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896773
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713576}

Fix:
Modified the decrease in level logic to only be applied when the
node would be part of a set.

Bug: 1021279
Change-Id: I26fa167cb062d36599d38f20a41eededd74f8bc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893118
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#713575}

https://android.googlesource.com/platform/external/perfetto.git/+log/50d2ff30828b..5d41eaf0f6ae

git log 50d2ff30828b..5d41eaf0f6ae --date=short --no-merges --format='%ad %ae %s'
2019-11-07 skyostil@google.com Merge "Lift function debug signature into a compiler specific macro"
2019-11-07 lalitm@google.com trace_processor: rework xBestIndex handling by making it more flexible
2019-11-07 lalitm@google.com trace_processor: fix broken iteration logic in thread and proces tables
2019-11-07 lalitm@google.com trace_processor: add missing new/legacy views

Created with:
  gclient setdep -r src/third_party/perfetto@5d41eaf0f6ae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: I30a65b202867a91e1ec513faaadbd2b8e9578c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903888Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713574}

Define shared skia component for the mojom traits so it can link correctly.
Remove unused image_filter_mojom_traits.cc and the
skbitmap_for_blink.typemap that is unneeded in this refined setup.

BUG=1008432

Change-Id: I8045cdeff554ea471875d1bf0f276287db208db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899316Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713573}

The fuzzer found a pathological case when the section size is 0 but the
offset is outside of image. This resulted in header parsing skipping
the section since the size was 0; however, later processing creates a
region of size 0 that is outside the image causing checks to fail. The
solution here is to check if the offset is outside the image and the
size is 0. This suggests that the data is ill formed and we should
reject the image entirely.

Bug: 1019271
Change-Id: If47d099aa4f919b097d4e15804048eaf64a59201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903886Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713572}

This CL plumbs the viewport size to the fling controller. There will be
follow up CL which will utilize this value for configuring fling
animation curve. Fling curve uses the viewport size to determine the
upper bound on how much distance a fling can travel/scroll.

Bug: 647137
Change-Id: I25896d9c514661ecc16e4f98b28e3d7c1f3b9f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884758
Commit-Queue: Sarthak Shah <sarsha@microsoft.com>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713571}

This CL adds user actions for pressing the home button and the back
button.

Bug: 1018916
Change-Id: I0d97812cbe53a0334dff7c32bbe016bd82d41c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900389Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713570}

We're still seeing good progress in the clean-up tracked by this
histogram but it will probably be safer to remove the code in M81
rather than in M80.

BUG=980946

Change-Id: I42039e2a747f84c13d8fb684bf6aa07c40d33bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901426Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713569}

https://webrtc.googlesource.com/src.git/+log/e9f663c8cb8c..7c1fb4156d24

git log e9f663c8cb8c..7c1fb4156d24 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 peah@webrtc.org Removing old scheme for dumping internal AGC diagnostic data
2019-11-07 mbonadei@webrtc.org Remove double declaration of cricket::kH264CodecName.
2019-11-07 sprang@webrtc.org Fixes incorrect probe timing check.
2019-11-07 ilnik@webrtc.org Enable FEC protection of packets with VideoTimingExtension

Created with:
  gclient setdep -r src/third_party/webrtc@7c1fb4156d24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I474f9f903bb988b011d94e5260ec2df6ab90e078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713568}

This patch migrates the Blink CSS minifier to GRIT and applies it
whenever GRIT creates a CSS resource. This allows us to minify all
CSS resources in a unified and effortless manner.

As a result, this patch achieves 12k Android binary size reduction:

https://ci.chromium.org/p/chromium/builders/try/android-binary-size/368229

Bug: 1015410
Change-Id: Ief8efe57d26f2e26c3b53523d8c973d1d193d20b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900259Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713567}

DataDecoderService is currently set up to allow only a single client
pipe. This is reasonable for the out-of-process case in most production
environments. For the in-process case (in tests and on iOS) however, it
is possible and reasonable for a single instance to have multiple
DataDecoderService pipes connected to it.

This upgrades the lone Receiver to a ReceiverSet, allowing for multiple
clients.

Fixed: 1022313
Change-Id: Iaeea6e1b1316351da0b6f57ae4a432eed62b5575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903748Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#713566}

Change-Id: I060578b0ca87d4eecd5fed2ab35fbffee6cb5aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902275
Auto-Submit: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713565}

Images with an explicitly empty alt attribute should be ignored.
Images that do not have the alt attribute explicitly empty will have
automatic image annotation done when possible, so we shouldn't ignore
them.

Bug: 1018853
Change-Id: If8f95d8ed7376797e24707047b5b291bde1555bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881124
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713564}

These got lost in the rename.

BUG=none
TEST=none
TBR=jam@chromium.org

Change-Id: I0273dd26860950d0eb87215f84914d5c511205f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903758Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713563}

Enable web developers to be able to update ImageRendering quality on
OffscreenCanvas. When ImageRendering quality changed between auto and
pixelated, the OffscreenCanvasPlaceHolder sends the update to
CanvasResourceDispatcher to update the CanvasResource of OffscreenCanvas.

Demonstration of classes interaction:
https://docs.google.com/document/d/1M-E7euqa7fLLcUlgPkPAtVMck7s7u0hmsA-uLL1H7J0/edit

tests added:
OffscreenCanvasImageRenderingAuto.html
OffscreenCanvasImageRenderingPixelated.html

Bug: 1001335

Change-Id: I9846d8ba851d55270a2a3e0380bd76a6b924a742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779188
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713562}

Previously, we would fail to call NotifyBeforeLayout for all such ancestors
that are scrollers, causing subtree layouts to completely fail to maintain
a scroll anchor for such ancestors.

Bug: 920289

Change-Id: I899634949739f5d4f3af1f282b598cbc4ef0e3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902767
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713561}

When the "Protected content" permission decision is different from the
default value, "Protected content" will show up in the PageInfo.

See screenshots at:
https://photos.app.goo.gl/Rmd5S75gTUNU7vZVA

Similar change on Android will be done in a separate CL.

Bug: 593210
Test: Manually tested. See screenshots linked above.
Change-Id: I4200ec867f143edc67a1215dc9dc755575c89a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900113Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713560}

Move content::AccessibilityTreeFormatter::FormatAccessibilityTree(),
which exposes BrowserAccessibility, to AccessibilityTreeFormatterBase,
and rename it to FormatAccessibilityTreeForTesting(), since the only
caller is in test support code.

Then introduce content::TestBrowserAccessibility, which is an opaque
class that represents content::BrowserAccessibility. Use it inside
content/public/test to avoid exposing BrowserAccessibility publicly.
With TestBrowserAccessibility, add a static FormatAccessibilityTree()
method to give tests access to FormatAccessibilityTreeForTesting(),
which this CL took away from AccessibilityTreeFormatter.

Change-Id: Ie89bfb6284f639fe3b8c34155b706b3808bdb4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900360
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#713559}

Change-Id: If996bf87eb9903ffd92257967c8f63ab2a24a298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903757
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713558}

Found via SuperSize query:
  size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d')

TBR=agrieve  # Trivial refactor

Bug: 747064
Change-Id: Ib9615718e0f6cacb081f9ea2f5295348d32cdcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901641
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713557}

Bug: 1022086
Change-Id: I925c5d170a32988db678dafb3daf73c0d231681f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902241
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713556}

Add Windows specific code to test registry provider blocked by the policy.

Bug: 1019160
Change-Id: I5ae7c383028b2a6a51075d76b60ae01dc507034c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893572Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713555}

This CL adds
CustomTabActivityTabProvider#registerTabObserver()
CustomTabActivityTabProvider#unregisterTabObserver()
These methods register (and unregister) a TabObserver for the
CustomTabActivity's active tab. The tab being observed is changed when the
CustomTabActivity's active tab changes. This differs from
TabObserverRegistrar#registerTabObserver() which registers the passed-in
TabObserver for all newly created tabs.

BUG=1020911
TEST=TabObserverRegistrarTest.testObserveActiveTab

Change-Id: Ie5c4b8f287209b672e89184a3e9f0710c69102ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896140
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713554}