- 12 Aug, 2020 40 commits
-
-
Gauthier Ambard authored
This CL removes the content of the error pages to avoid flag when loading it. Bug: 991608 Change-Id: I7600d091705f930e6115246496f47e21a09e197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352870 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#797307}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d56f379356d9..9f3ce85bab94 2020-08-12 omerkatz@chromium.org heap: Add ServiceWorker threads to gc metrics. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986235 Tbr: sadrul@google.com Change-Id: I31db620c74d602b653f96e808a32f2c45ab0211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797306}
-
Mark Yacoub authored
Use std::make_unique instead unique_ptr(new). Use '= default' to define a trivial default constructor. BUG=1082882 TEST=drm_overlay_validator_unittest,drm_window_unittest,screen_manager_unittest. Change-Id: I6ee0b6ff923d7134348d2a6d103c1acae48da9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352850 Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mark Yacoub <markyacoub@google.com> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#797305}
-
Becca Hughes authored
Also fixes a bug in RelList::ValidateTokenValue where || was used instead of &&, causing <something that happened, presumably incorrectly>. BUG=1053599 Intent-to-Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/OXZLwImwdbc/m/ltULzqsAAgAJ Change-Id: I32efa63c43fdb5ca641e8afae3c49f42d9013f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341934 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797304}
-
Ali Juma authored
This extends the expiry of safe-browsing-available from M85 to M87. The feature has not yet been enabled at 100%, so having an about:flags entry is still useful for testing. Bug: 1028755 Change-Id: I9385c83af0f2b759f6bf89f96b062c11ab6fbe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351958 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797303}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5245bcfaf6a9..bca9dcdf05aa 2020-08-12 yupingso@chromium.org flash-ap: Create private key file with mode 0600 2020-08-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-12 allenwebb@google.com lib/portage_util: Improve GetPackageDependencies 2020-08-12 gbiv@google.com toolchain_util: make `_CollectFiles` respect subdirectories 2020-08-11 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I58b85338cb1e213c57837dd2c10701733ddb33d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352359Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebc115d9852c..f7f46a7432a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: smcgruer@google.com Change-Id: Icacc3464a79fd3aa2325507ca08a6c62c139c5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797301}
-
Alice Wang authored
This CL adds an empty WebSigninBridge.Listener implementation to AccountPickerDelegate and a WebSigninBridge field to the delegate class. Bug: 1102784 Change-Id: I66f135e2b61f949122ee30582548ce2dbf5fb29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346572Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797300}
-
Sammie Quon authored
We will be adding more to it soon, so move it out of DesksController. No functional change. Test: none Bug: 1111445 Change-Id: I1c557c687d8508c844c0fc50c038ebc9d3258ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347199Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797299}
-
dizg authored
Bug: 1105865 Change-Id: Id95b06b84c36ba6824d83637a3c7b615bbed9f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341131 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797298}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/13f04d59c727..b65408064b1f 2020-08-12 sugoi@google.com Fix decorations bleeding to following block members If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaf21f1e9aa4659f670254d2b2c6462a0fb45b036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352349Reviewed-by:
-
Ella Ge authored
Change-Id: Ia933e396909d879ddd4ee81425770bdb036da819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351283Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#797296}
-
Mugdha Lakhani authored
The appearance of the URL bar in Weblayer shell was broken in: https://chromium-review.googlesource.com/c/chromium/src/+/2330614 when we renamed menu_button to app_menu_button but didn't update the reference to it in the layout. This fixes that and restores the initial size of the URL bar as well as the horizontal centering. Before this change: https://drive.google.com/file/d/1_m1hbatI6D-Nd988RoBnjv28_Y77rJRp/view?usp=sharing After this change: https://drive.google.com/file/d/1UBThgpxFDbgg_j93MGkwhQQlIYDz8WnU/view?usp=sharing Bug: 1114238 Change-Id: I2abbf85a188610d0b334558112b0397243ada4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352729 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#797295}
-
Rouslan Solomakhin authored
Before this patch, navigation to an insecure page would update the header view and remove the header view at the same time, which could result in a use-after-free. This patch updates the header view only when not aborting payment. After this patch, navigation to an insecure page will remove the header view and not try updating it, thus avoiding the use-after-free. Bug: 1114556 Change-Id: I946bed36433e3241c6c19c33d7be759ea23a1478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351959Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797294}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4451adcce85..5697d3550bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I61ab8d59af82e510f696c81bc6f48775dc334588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351457Reviewed-by:
-
Xiaohan Wang authored
This enables EME `persistent-usage-record` session type by default on all platforms. The actual support of this session type on each platform depends on the key system and CDM implementations. See Blink intent-to-ship thread for this feature at https://groups.google.com/a/chromium.org/g/blink-dev/c/7aTue7FPEuU Bug: 1081977 Change-Id: I1c05d4b41e15bec3571dfa9c66aa4e269c862004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341909Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797292}
-
Saagar Sanghavi authored
Re-design of the CL (crrev.com/c/2341362) to enable presubmit_support to time/ResultDB wrap each individual lower-level check in PRESUBMIT.py. The approach taken here is to have the PRESUBMIT_VERSION = 2.0.0 in here so that presubmit_support is aware of the new version of PRESUBMIT.py, then check input_api.version in CheckChangeOnCommit/Upload to ensure that presubmit_support itself is the new version. The associated changes to depot_tools (crrev.com/c/2349979) must be landed in order for this to work. Change-Id: I91d09337dd77a74540ac4a01017275bcaaa67cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350234 Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#797291}
-
Guillaume Jenkins authored
Creates and implements the missing delegates for enterprise reporting on iOS. Note that this won't be functional yet because of an issue with the way ApplicationContext instantiates its shared URLLoaderFactory. That issue will be fixed in a separate CL. #Squeegee Bug: 1066495 Change-Id: Idb493efeca63bb19eaf250ede02608f6bd842a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341995 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797290}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9642d3ae12e4..67615460bea4 2020-08-12 nisse@webrtc.org Move H264::Profile to h264_profile_level_id.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie530035682c0fe2ed15aa289d6bace47af7d6b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352361Reviewed-by:
-
Aaron Leventhal authored
Adjust menu controller to ensure correct number of kSelection events. These are turned into focus events under MSAA. - Regular menu items: we were firing extra events even when selection didn't change. - Hot button menu items, such as zoom-related, cut/copy/paste in edit menu, were not firing any events on hover, because the button already considered itself hot tracked via the button controller's mouse handling. AX-Relnotes: avoid missing or duplicate menu item announcements when using mouse Bug: 1077755, 1106916 Change-Id: Ie933146b647d56f7665cfc72bb708e9f7bdd71de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350483 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797288}
-
Andrew Xu authored
Bug: 1114880 Change-Id: I84ab8b5491aa9039696249851f44d0aef59b7925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351119Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797287}
-
Naomi Musgrave authored
Fetch the certificate from the CertificateManager, to pass to CreateShareTarget. This is a follow-on from a comment on I1b1ed2252baa59e68f4daa1e772a51e9cf32eff4. Bug: 1084644 Change-Id: Ie42ae628517716cc64e7d57011079497e803f260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346390 Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Cr-Commit-Position: refs/heads/master@{#797286}
-
Nick Diego Yamane authored
Also export WmMoveResizeHandler and do a few more minor cleanups. R=sky@chromium.org Bug: None Change-Id: Ic627348b14d624641bf0adf6b30732e17f13b8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348692 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797285}
-
Sebastien Lalancette authored
CreateFullPagePdf will check if the current page is an about scheme/app specific page (or an invalid URL), and if so will invoke the completion callback with nil NSData. Added a new unit test for the new logic. Bug: 1103777 Change-Id: I2eebd0d65ffe3c4c368893dff7fb8e1c53276ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340413 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#797284}
-
Michael Crouse authored
No logic change, only enums.xml. Change-Id: Id50d548062ded1894397feb73ff7068e5f08c89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352609 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797283}
-
Alice Wang authored
This CL separates account picker bottom sheet render tests into a different file to make it easier to test more screens in both light and dark modes. Bug: 1090356 Change-Id: I98b8a01d1c54b95c4653d055af3f0666804afd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346428Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797282}
-
Pâris MEULEMAN authored
also add Arthur as an owner as this has indrect implications to his work on access-reporting. Bug: 1059303 Change-Id: I5c579f89894dddb637ffeb3d1879249434cfd42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351998 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797281}
-
Robert Phillips authored
SkDeferredDisplayListRecorder::makePromiseTexture can fail for a variety reasons (in the repro case the requested width/height is 320/10048 while the max texture size is 8192) so try to fail gracefully. Bug: 1068253 Change-Id: I5fcb25343fe397240330e23db902c97cee71c239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351955Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#797280}
-
Chris Hamilton authored
This migrates all current usage at the same time. BUG=1113677 Change-Id: Ibdb4b69591d62c5e1673919811b33cfec0ea0f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341145Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797279}
-
Dan Harrington authored
Don't report this journey at all if the GetMore request was not allowed. This can happen if there's no next page token for example, which is expected at the end of stream. Bug: 1044139 Change-Id: I3330918653b012e4d85d595beef0db61d6c96f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346794 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797278}
-
Wez authored
Under Windows and Fuchsia the TestLauncher runs test batch processes in their own jobs, allowing any leaked sub-processes leaked by tests to be cleaned up. Under POSIX platforms each batch is run in its own process group, but the group was only being kill()ed if the test batch failed or crashed. TestLauncher now proactively kill()s each test batch's process group. The result of the call is also checked, and the test batch marked as failed unless kill() reports that the process-group was already gone. Note that this will still miss processes launched into new process groups by tests. Bug: 1094369 Change-Id: If379d200953a823b2020766cda73f8cf27bfdb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346388 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#797277}
-
Jonah Ryan-Davis authored
Add option --use-angle=metal to gl_switches, and forward this through EGL surface creation. Add proper piping of TEXTURE_2D for Metal. Add necessary options for Metal testing and expectations. Bug: angleproject:4847 Change-Id: I8f117f3a68ef33ea30e87fd3208ef5aedc3b0e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302915 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797276}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I5eb68cfb99aa5a849b1bde708e2c91b8a2fba43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350880 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797275}
-
Guillaume Jenkins authored
Implements the missing delegate methods for enrollment and policy fetch. Note that there is still an issue with the specific URLLoaderFactory implementation handling the requests that prevents the end-to-end flow from working properly. This is being investigated separately. Also adds CloudManagementEnrollmentToken to the list of supported policies (even though it's read directly from NSUserDefaults). #Squeegee Bug: 1066495, 1111145 Change-Id: I21c1ee3b26bc413ff26ad4031b44ebda5086e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337267 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
-
Andy Lu authored
Changed the parameter name from "Open {URLs} in Incognito" to "Open {URL} in Incognito" for the Open URLs in Chrome Incognito Siri shortcut. This makes more sense since the UI shows one URL to enter at a time, and only one URL can be entered in that field. Added in the new screenshot associated with this parameter change. Bug: 1115243 Change-Id: I0a821b36c838b1b033f745875f11c99c046ef0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350236Reviewed-by:Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#797273}
-
Ben Kelly authored
This CL updates the testing config to match the new trial launch target of 8 maximum parallel cache operations. Bug: 960012 Change-Id: I7d7b973ffaf257683a2c8fb5913b375b4bd205d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343223Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#797272}
-
Karel Král authored
Implement tracing of mojo async response parameters. Add a |parameter_group| argument to |trace_event| macro to provide more flexibility when naming the traced parameters. Thus provide debugging information for asynchronous response parameters as well. Bug: 1103623 Change-Id: I7e38d8cc53ba8eff30c207defc0467674be50f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339632 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797271}
-
Josh Nohle authored
The Nearby Share protocol uses HKDF with an authentication token, using a certificate's secret key as the salt and a trivial info, to generate a hash. Both parties--the receiver and sender--confirm this hash. This, along with a standard signing/verification flow, is used to establish an authenticated connection between devices. See go/nearby-chrome-cert. This CL implements a hashing method for both the private and decrypted-public certificate classes. We add tests using test vectors that are also used in GmsCore unit tests (cl/326170193) to ensure consistency across platforms. Fixed: 1115320 Change-Id: I5aa9f7de5340a537a57c323a5afb97f6a83a4b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351709Reviewed-by:
-
Ioana Pandele authored
This changed tests the creation logic for CompromisedCredentialForUI, which is part of GetCompromisedCredentials. Bug: 1102025 Change-Id: I5b4af3f9b13abc1eb16948abddf587b9b925fab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346438 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797269}
-
Victor Hugo Vianna Silva authored
The CL calls the incrementer from crrev.com/c/2340966 (later renamed). Now, a per-Gaia-account counter is incremented whenever the move bubble is shown and the user is not opted-in to the account-scoped passwords storage. The bubble won't be shown for users whose count is above a certain threshold (see crrev.com/c/2345309). Bug: 1082152 Change-Id: Id0ef7fd6b85598a1cb0651435a5c6f9bf6214049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351995Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#797268}
-
