- 28 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c7b056c0c8b..9950df105a7c git log 3c7b056c0c8b..9950df105a7c --date=short --no-merges --format='%ad %ae %s' 2019-02-28 renjietang@chromium.org netlog_viewer: Update Quic dashboard to show new experiment race_stale_dns_on_connection. Created with: gclient setdep -r src/third_party/catapult@9950df105a7c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: TBR=sullivan@chromium.org Change-Id: I67cf76a6898bcd127abb643091f33ae7f16ae09a Reviewed-on: https://chromium-review.googlesource.com/c/1495297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636532}
-
Marijn Kruisselbrink authored
After a PublicURLManager is "stopped" (i.e. the ExecutionContext it belongs to has been destroyed) it is no longer possible to resolve any URLs through it. So in that case, just early return from Resolve(), just like Register and Revoke already do as well. Bug: 931139 Change-Id: Ibd76833f10a1ffa40b712e93a5b5ef41071ebe99 Reviewed-on: https://chromium-review.googlesource.com/c/1495373Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636531}
-
Robert Liao authored
InProcessContextFactory isn't set up to properly support Direct Composition. BUG=936249 Change-Id: I34877fad76a40d8f141fb16c7a1d6d826d6c231a Reviewed-on: https://chromium-review.googlesource.com/c/1492482 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636530}
-
Sam Goto authored
We use ints for capturing and passing around deltas of time. This CL moves all of those uses to base::TimeDelta, which benefits us by being clearer about units (e.g. seconds, mins, etc) and semantics in tests. Bug: 878979 Change-Id: I5ad1cfc105882b63af7a974a72576212c773cb4a Reviewed-on: https://chromium-review.googlesource.com/c/1492991 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#636529}
-
Xida Chen authored
Bug: None Change-Id: I0cf1b3155c0fc2e9bfac6396dd45edd8a2d1ca3e Reviewed-on: https://chromium-review.googlesource.com/c/1494726Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636528}
-
Etienne Bergeron authored
This CL is removing the thread and using a task runner instead. I propose to continue this migration by renaming the thread service since it's no longer a thread. R=fdoray@chromium.org, gab@chromium.org BUG=936569 Change-Id: If65dfd41406d13c9f69036d71e75242ef29f9b1d Reviewed-on: https://chromium-review.googlesource.com/c/1492369Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636527}
-
chrome://flags/#enable-gamepad-vibrationMatt Reynolds authored
Removes the GamepadVibration content feature and the corresponding entry in chrome://flags. BUG=933443 Change-Id: Ic20cb81faf172381ef5ffdb1f8022772408b3441 Reviewed-on: https://chromium-review.googlesource.com/c/1487525Reviewed-by:
-
Tom Anderson authored
See the comments added in this CL for details. BUG=429404 R=sky Change-Id: Icc5bad8e70853a62f76640b111a89f9e6b487d4b Reviewed-on: https://chromium-review.googlesource.com/c/1481125 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Jenny Zhang authored
Bug: 932058 Change-Id: I139538ff5bf93d61229e682bb04b2d38b758e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/1492975Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636524}
-
Akihiro Ota authored
Bug: 934101 Change-Id: I4dc128287e7d408d6608b1170683b5f581dcc8ef Reviewed-on: https://chromium-review.googlesource.com/c/1495434Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#636523}
-
Jonathan Metzman authored
Speculative fix for Mac libFuzzer build breakage. Bug: 936849,831914 Change-Id: I7705682b79a9835ec014504f436af9cab83c01a3 Reviewed-on: https://chromium-review.googlesource.com/c/1494724 Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636522}
-
Jordan Taylor authored
web_tests/animations/animationworklet/scroll-timeline-display-none.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-display-none.https.html web_tests/animations/animationworklet/scroll-timeline.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline.https.html web_tests/animations/animationworklet/scroll-timeline-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-ref.html Bug: 915352 Change-Id: I26a859be4f5cd96c4f1229ebae66ac2c6ef508a3 Reviewed-on: https://chromium-review.googlesource.com/c/1488119Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#636521}
-
Steven Bennetts authored
sync_ui_util assumes a normal profile, not a guest/incognito profile, so do not call into it for guest users. Bug: 911013 Change-Id: I91e3617fdda12e5f228139af6ac93f81f7b79270 Reviewed-on: https://chromium-review.googlesource.com/c/1487887 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#636520}
-
Xianzhu Wang authored
This partly reverts crrev.com/c/1477912 about PaintArtifactCompositor::UpdateTouchActionRects() which was changed to be work in BlinkGenPropertyTree mode only. We still need it to work in non-BlinkGenPropertyTree mode. Also add virtual/disable-blink-gen-property-trees to avoid non-BlinkGenPropertyTrees regression before we fully launch BlinGenPropertyTrees. Bug: 936495 Change-Id: Iffd4751e61916e917697f88d77d587e6b7c2ea82 Reviewed-on: https://chromium-review.googlesource.com/c/1493210Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636519}
-
John Abd-El-Malek authored
Bug: 929909 Change-Id: Ic951d24c55a433b569031cf51d0907be840e9f86 Reviewed-on: https://chromium-review.googlesource.com/c/1492353 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636518}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21541ca9..67e3f02c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66edf6ee165d5720fde61b5e452c9ab84086007a Reviewed-on: https://chromium-review.googlesource.com/c/1495370Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636517}
-
Dan Beam authored
Note: I was not able to easily construct this list on Canary nor Chromium for some reason, so I don't have screenshot. I'm generally matching #time-gap-separator (which look similar: https://goo.gl/ho5uS9) R=dpapad@chromium.org BUG=923597 Change-Id: I382ed1a8ff20af13bb7fd83d412342c1a5aacf51 Reviewed-on: https://chromium-review.googlesource.com/c/1493444 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636516}
-
Emily Stark authored
This file is not used. Change-Id: I3af311f62ebb44e9821bf4e98df72a712138eb25 Reviewed-on: https://chromium-review.googlesource.com/c/1491036Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73263e44dae6..72565d358a64 Created with: gclient setdep -r src-internal@72565d358a64 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ieb1a4a749bd0136d63e90ec78639d86ef6ac0266 Reviewed-on: https://chromium-review.googlesource.com/c/1494826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636514}
-
Tommy C. Li authored
A feature flag's string has a typo, ("Omnibox" => "Ominbox"). We are not going to correct this typo, as we will use the misspelled string as-is in field trials. This CL adds a warning to not correct this typo. Bug: NONE Change-Id: I0e435df378c336cb556d1fd5c2dd2da3696d9caf Reviewed-on: https://chromium-review.googlesource.com/c/1492936Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#636513}
-
Mason Freed authored
Previous to this CL, the default safe_opaque_background_color_ was transparent. And in BGPT mode, we were not setting this setting at all. This lead to checkerboarded tiles being rendered fully-transparent, which means prior content was left visible. With this CL, the safe background color is being set. And additionally, a DCHECK makes sure that the color is actually opaque, to catch other cases where it isn't being set. Also, the OOMTileBorderColor was being used as the checkerboard color, when there was already a checkerboard color defined. It is now being used. Bug: 923202 Change-Id: Ie4f24edb8ccd7c625a4128decb0a5256bbae077c Reviewed-on: https://chromium-review.googlesource.com/c/1474973Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636512}
-
Joe DeBlasio authored
This CL adds translation console screenshots for the new lookalike interstitial. Bug: 927924 Change-Id: Ib570fa6da059368637829b074346da04e94c5efc Reviewed-on: https://chromium-review.googlesource.com/c/1495449 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#636511}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7b2da871e95..b2565b18d03e git log b7b2da871e95..b2565b18d03e --date=short --no-merges --format='%ad %ae %s' 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4b314eefc839..5de69e91bd93 (1 commits) 2019-02-28 fmalita@chromium.org solink with --start-group/--end-group 2019-02-28 scroggo@google.com Enable Skia for Windows 2019-02-28 halcanary@google.com SkQP Documentation 2019-02-28 kjlubick@google.com [canvaskit] Support image assets for Skottie Created with: gclient setdep -r src/third_party/skia@b2565b18d03e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/117921091,chromium:b/123085931 TBR=scroggo@chromium.org Change-Id: Id9e7ddb21dfbcd21024a59a5ab85dd8082444f32 Reviewed-on: https://chromium-review.googlesource.com/c/1494827Reviewed-by:
-
Majid Valipour authored
Reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1418076 Some of the test are flaky with threaded compositing. Enabling the virtual suite but marking these as flaky for now because it is better to have coverage on threaded compositing code path for other tests and any new ones that we migrate to wpt. external/wpt/animation-worklet/animation-worklet-inside-iframe.https.html [ Pass Failure ] external/wpt/animation-worklet/animator-animate.https.html [ Pass Failure ] external/wpt/animation-worklet/animator-with-options.https.html [ Pass Failure ] external/wpt/animation-worklet/playback-rate.https.html [ Pass Failure ] external/wpt/animation-worklet/scroll-timeline-writing-modes.https.html [ Pass Failure ] external/wpt/animation-worklet/worklet-animation-pause-resume.https.html [ Pass Failure ] external/wpt/animation-worklet/worklet-animation-with-fill-mode.https.html [ Pass Failure ] Bug: 915352 Change-Id: I31423fd0d1d55bbeb995be52db546c624a4b3744 Reviewed-on: https://chromium-review.googlesource.com/c/1492436Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636509}
-
Avery Musbach authored
When identifying snapped windows to carry over to split view on entering tablet mode, ignore the app list, non user positionable windows (such as extension popups), windows being dragged, and windows hidden from overview. Test: ash_unittests TabletModeControllerTest.* Bug: 931859 Change-Id: Ib498fb6c5ebad5ac907d05f1e4448e9ba4c254b7 Reviewed-on: https://chromium-review.googlesource.com/c/1471456 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This removes SystemClockClient from DBusThreadManager and uses explicit client initialization in Chrome and Ash. The intention is to remove all clients accessed in src/ash from DBusThreadManager and remove that confusing dependency from ash entirely. This CL also: * Moves system clock clients to a subdir in chromeos/dbus. * Adds a TestInterface to SystemClockClient so that tests do not require specific knowledge of the fake implementation. * Modifies ash::ClockModel to handle uninitialized SystemClockClient so that it is not required for every ash unit test using Shell. For minor change to c/b/chromeos/login browser test: TBR=xiyuan@chromium.org Bug: 647367 Change-Id: If6575cf2df9dc9677dcd31032be0c49ae0c286a5 Reviewed-on: https://chromium-review.googlesource.com/c/1492480Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636507}
-
Jacob Dufault authored
This means that all JS calls are deferrable by default. Bug: 930888 Change-Id: Id651e281746a0a99b6285bb82039bb8e5f0cf047 Reviewed-on: https://chromium-review.googlesource.com/c/1487809Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#636506}
-
Xida Chen authored
At this point, we do not purge any entry in the PaintWorkletImageCache, and this CL implements one caching strategy. The idea is: for each new impl frame, if a cache entry is getting accessed/updated, then reset the |num_of_frames_not_accessed| to 1, otherwise increase that by 1. At each new impl frame, we go through the cache, and purge any entry whose |num_of_frames_not_accessed| is larger than a certain threshold, which means that the entry is never used/updated in the last N frames. Unit tests are added. BUG: 907897 Change-Id: I7013325c71e498472e129addd7d171549a852c35 Reviewed-on: https://chromium-review.googlesource.com/c/1479658 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636505}
-
Mike Wittman authored
Changes Module to a class and encapsulates the its state. This is a prerequisite to changing Module to an interface that can be implemented independently for Windows and Mac. Bug: 931418 Change-Id: I5b52234d8f325a08f3b1b8147e60743baed31965 Reviewed-on: https://chromium-review.googlesource.com/c/1478084 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/160b5823ac4f..65cf8a9b9775 git log 160b5823ac4f..65cf8a9b9775 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 fmayer@google.com Merge "Add test that Read / Write work if the other end closes." Created with: gclient setdep -r src/third_party/perfetto@65cf8a9b9775 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3b093cd0c2b67758b95642367277e167f74135a6 Reviewed-on: https://chromium-review.googlesource.com/c/1495369Reviewed-by:
-
Sam Goto authored
Bug: 878979 Change-Id: Ie96867d4f6bc1415d8ffb5f1f43e93d0364043e2 Reviewed-on: https://chromium-review.googlesource.com/c/1492430 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
-
Kush Sinha authored
Summary of changes: - Consolidate the logic of checking Chrome OS Account Manager's availability into 1 utility function. - Make this utility function return |false| for the availability of Chrome OS Account Manager in Public Sessions. Bug: 926157 Change-Id: Ife2e5fffe95ca8c08c42376e80a5950785d4669f Reviewed-on: https://chromium-review.googlesource.com/c/1486333 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: -
Austin Eng authored
This adds HandleReturnData to DecoderClient to allow the WebGPUDecoder to send binary blobs of return commands back to the WebGPUImplementation. Its implementation in the InProcessCommandBuffer and the ProxyCommandBufferImpl forward the data to the GpuControlClient interface. The WebGPUImplementation will receive the return command stream via GpuControlClient::GpuControlOnReturnData. Bug: 877147 Change-Id: Ic7983b9d7b6dd15680427162762bc3bc39bd52fd Reviewed-on: https://chromium-review.googlesource.com/c/1481615 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636500}
-
Navid Zolghadr authored
Bug: 907601 Change-Id: I88d5682df5488f2030a1f5ef18118d3b3ba18008 Reviewed-on: https://chromium-review.googlesource.com/c/1486154Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636499}
-
Lan Wei authored
user-activation-delegation API allows to transfer user activation state to any target window in the frame tree through postMessages with "transferUserActivation" set to be true. Bug: 931885 Change-Id: I224f5fb04b2e08f751c33f5cba867562664fbe0b Reviewed-on: https://chromium-review.googlesource.com/c/1477911 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#636498}
-
David Bokan authored
In focusless spatial navigation, when the interested element is removed from the document, but remains alive, the search algorithm begins from it. This results in the algorithm not moving to a new element because it doesn't find a parent container (the document) for the Element. This CL fixes the issue by checking if the interested_node is disconnected when we decide on a starting node for the search. If it is, we use the default document node like we would when there is no interested element. Bug: 929526 Change-Id: Ic5ebe85e563e6c240d301f4fd0c92be8087dd43b Reviewed-on: https://chromium-review.googlesource.com/c/1493397Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636497}
-
Lei Zhang authored
- Add / simplify constructors/destructors. - Add a buffer size DCHECK() to avoid going out of bounds. - Replace new keyword usage with the appropriate "make" function. - Fix bad indentation from r636359. Change-Id: Iab5cb939b36abb4ccebcced2b44aa432c55b4f39 Reviewed-on: https://chromium-review.googlesource.com/c/1495366Reviewed-by:
-
Andrew Grieve authored
This reverts commit 53410c06. Reason for revert: merger script was updated. > Original change's description: > > android: Launch Crashpad with /system/bin/linker on Q > > > > This adds a small executable, libcrashpad_handler_trampoline.so, to > > Monochrome, Trichrome, and SystemWebView. The trampoline loads the > > remaining Crashpad handler code from the main native library, which > > must export `CrashpadHandlerMain()`. > > > > All three packages will continue to use /system/bin/app_process to > > launch Crashpad on P-. > > > > Note on static_initializers.gni: > > > > There aren't any real, new static initializers. The increased count is > > due to the addition of the new object. Static initializers are counted > > by measuring the size of each object's .init_array and dividing by the > > object's pointer size. libcrashpad_handler_trampoline.so has two > > invalid slots which are ignored by the loader: > > > > readelf -x .init_array libcrashpad_handler_trampoline.so > > > > Hex dump of section '.init_array': > > 0x00001008 ffffffff 00000000 TBR=pasko@chromium.org,torne@chromium.org,agrieve@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: Ifdeb10d70977208eb01761b4588d8bfbaecfa20d Bug: 928422, 935973 Reviewed-on: https://chromium-review.googlesource.com/c/1488574Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#636495}
-
Danyao Wang authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6rZ7kBLwmhg/lqEpsHLiDgAJ Bug: 915907 Change-Id: I08825b981d93016b1d8d3647ee76cb4ccea4173a Reviewed-on: https://chromium-review.googlesource.com/c/1492488 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636494}
-
Alec Douglas authored
This commit modifies the MediaControls to show the controls and update the current time indicators (current time text + timeline thumb) immediately during seek requests so the element behavior during rapid seek requests (e.g. user is holding down the FF button on their BT keyboard) look similar to when a user is scrubbing the timeline with their mouse. Bug: 748749 TEST=MediaControlsImplTest, manual testing out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest* Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d Reviewed-on: https://chromium-review.googlesource.com/c/1274945 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636493}
-
