- 18 Jul, 2017 7 commits
-
-
Jared Saul authored
Bug: Change-Id: Ib144cc6e0e13329aa346bf9bef4e272c06d2a06e Reviewed-on: https://chromium-review.googlesource.com/569076 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487300}
-
James Cook authored
We are inconsistent in our usage of this namespace. We mostly use it for test support code, but not always. We sometimes wrap tests in it, but not always. After discussion with top-level ash OWNERS we're going to eliminate the namespace entirely. This is more consistent with unittest.cc files in the rest of Chrome. TBR=reveman@chromium.org Bug: none Test: compiles, ash_unittests, chrome unit_tests Change-Id: I5afb42abcd06acab673ac1b459cfe071018f4400 Reviewed-on: https://chromium-review.googlesource.com/573324Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#487299}
-
Daniel Erat authored
Let the user remap the Caps Lock key when --has-chromeos-keyboard isn't provided (i.e. the internal keyboard has a Caps Lock key in place of Search). Formerly, the setting was only shown when an external keyboard was connected. Also add unit tests for KeyboardHandler and delete some unused variables. Unrelatedly, drop an accidentally-repeated call in PowerHandlerTest. BUG=742613 Change-Id: I56d7ccb0bd5e054b9e815fb4d8d457c0729ada0c Reviewed-on: https://chromium-review.googlesource.com/572209Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#487298}
-
Scott Violet authored
At the time I wrote SetMousePointerDisplayLocation() it was assumed SetMousePointerDisplayLocation() was called right after Reset(), which meant pointer_targets_ was empty. Now that SetMousePointerDisplayLocation() may be called by client code, that assumption is no longer valid and the DCHECK is out date. BUG=744923 TEST=none Change-Id: I19af55eab935bc05aa025839bd0a297ad585ea32 Reviewed-on: https://chromium-review.googlesource.com/574677Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487297}
-
Darren Shen authored
Currently, when we wish to combine several strings together to form the name for a class or data member for example, we have to use join_name, which would combine the strings correctly in a space separated format, followed by something like class_member_name that formats the result into the correct style. This patch allows things like class_member_name to take a list of names, and join_name internally. This does not change behaviour. Bug: 628043 Change-Id: Iae966e45b9dc80a14bb57cf477af580fb64c85fc Reviewed-on: https://chromium-review.googlesource.com/532676Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#487296}
-
Fady Samuel authored
FrameSinkManager is responsible for creating and updating the FrameSink hierarchy to allow propagation of BeginFrames across CompositorFrameSink. This CL removes some publicly exposed methods on FrameSinkManager that simply forward operations along to SurfaceManager. This takes us one step closer toward merging mojom::FrameSinkManager and viz::FrameSinkManager together. Bug: 722935 Change-Id: Ibb4b5b174a56e138add1ba44b32919ff9ad4ec52 Reviewed-on: https://chromium-review.googlesource.com/574878 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487295}
-
Kent Tamura authored
Bug: 742692 Change-Id: I3a64ed5870d6a1769bfccab353ad261ce24de17d Reviewed-on: https://chromium-review.googlesource.com/571521Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#487294}
-
- 17 Jul, 2017 33 commits
-
-
Lei Zhang authored
Many cases are else after returns. A few are converted to early returns. Change-Id: If6c8df0f182113c0d1d5710bd8369209ed477a1f Reviewed-on: https://chromium-review.googlesource.com/571162Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#487293}
-
Justin Carlson authored
Also rename factory class. This is in preparation for subsuming some of this functionality into a higher level printers manager. BUG=742487 Change-Id: I4929a4faa6bbdade248c9bdb710a3b53d8ebb262 Reviewed-on: https://chromium-review.googlesource.com/569849Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487292}
-
Devlin Cronin authored
Move ownership of the ICPMessageSender to the bindings system. This internalizes a bit more of the logic into the ExtensionBindingsSystem, and moves a bit more out of the overly-busy Dispatcher classes. Bug: 653596 Change-Id: I321afadb64c8351ca95cb0953a0148c71ad7f005 Reviewed-on: https://chromium-review.googlesource.com/570932 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487291}
-
Marijn Kruisselbrink authored
Also turn on the BlobStorageBrowserTest for the new mojo implementation now that transportation mostly works. This required a couple of minor other changes: - Adding BlobRegistry to the browser process' manifest - Turning off some BlobDispatcherHost IsInUseInProcess checks. These checks don't really make sense anyway when it will become possible to transfer blobs between renderers directly, and this never was a security boundary anyway, so removing the check shouldn't hurt. Bug: 611935 Change-Id: If8bfc2d8351aecc72a3818d0cbb013a55efc6175 Reviewed-on: https://chromium-review.googlesource.com/558192Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#487290}
-
Scott Chen authored
This allows WebUI sections outside of settings/ to reuse the same styles. Bug: 740758 Change-Id: Iefbdff0b219a3ced28b02098a0f05bbe25f83357 Reviewed-on: https://chromium-review.googlesource.com/571189 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487289}
-
Joshua Bell authored
The 'replacement' encoding originated as a spec concept to prevent security attacks via problematic encodings by recognizing the label but not decoding the stream. It was initially specified as the only encoding where the name wasn't one of the labels, requiring special cases in all implementations. Based on more implementer feedback we'd like to remove the special case. Delete the special case code in Blink too. See also: https://github.com/whatwg/encoding/issues/70 Bug: 744405 Change-Id: Ia15ccef1a9d7f35c23af4509a5a9758cbefc2087 Reviewed-on: https://chromium-review.googlesource.com/559973Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#487288}
-
scroggo authored
This method actually returns whether the encoded data for the frame at |index| has been fully received. (Prior to crrev.com/2879123003, the behavior was different for single-frame images versus multi-frame images. Now both return whether the frame is received.) Rename the method to better reflect its use, and avoid confusion in the future. No change in behavior, no new tests. Bug: 722168 Review-Url: https://codereview.chromium.org/2982083002 Cr-Commit-Position: refs/heads/master@{#487287}
-
Findit authored
This reverts commit 7ae6f9f5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 487250 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdhZTZmOWY1MGYyM2VlOGY1MDA3YTg1MGNkY2NiNmYwODNlYzY0MTgM Sample Build: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/89626 Original change's description: > Adjust the bounds in opened search box > > Changes: > 1. Adjust the height of SearchResultTileItemView based on spec: > https://screenshot.googleplex.com/AFQ5HnrMYch > 2. Adjust the height of SearchBoxView based on spec: > https://screenshot.googleplex.com/bGiXTCBUhdX > 3. Adjust the width and height of SearchResultPageView based on spec: > https://screenshot.googleplex.com/ykfwoEeMPTr > > Screenshot: https://screenshot.googleplex.com/8AQ0XofWAhZ > > BUG=742699 > > Change-Id: Iad10d029241f82ccf98b3bac7e8a50c597da1aa1 > Reviewed-on: https://chromium-review.googlesource.com/572365 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487250} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=742699 Change-Id: Id9ba9992566802461da8d3c055b6f052d0f69056 Reviewed-on: https://chromium-review.googlesource.com/575358Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487286}
-
Alexei Filippov authored
Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-006a.html as flaky NOTRY=true Bug: 736319 Change-Id: Ic6cd1b422ceb23774bbd65083919560795ce4799 TBR: rogerta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/575384Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Anna Maria authored
Bug: 721802 Change-Id: I592898445b73c36ed4744f7025e4613843b0c586 Reviewed-on: https://chromium-review.googlesource.com/570490 Commit-Queue: Anna Maria <paezagon@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487284}
-
Luke Zielinski authored
Change-Id: I42739f8f13a24efc48268b503bae8f167167d603 Reviewed-on: https://chromium-review.googlesource.com/571419 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#487283}
-
Kyle Horimoto authored
Previously, if a Tether connection was active and the browser crashed, the UI would start back up and show the device connected to the raw Wi-Fi network instead of the special Tether network; furthermore, all host scan results were gone and the device would not continue to send KeepAliveTickle messages to the active host, resulting in the phone's hotspot shutting down automatically. This CL creates a class which is run at the end of initialization of the Tether module, before a host scan begins. If it detects that there was saved active host data in persistent storage, it knows that the last session ended due to a crash since persistent active host data is cleared under the normal shutdown flow. If this is the case, CrashRecoveryManager restores the connection. Bug: 672263, 737273 Change-Id: Id51967e20855edb086285f5bfdb92c4677bee77c Reviewed-on: https://chromium-review.googlesource.com/572840 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487282}
-
smcgruer authored
This is effectively a partial revert of 9b503962 done manually to avoid reverting de4c1142 which is necessary for sticky elements. Bug=742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2977273002 Cr-Commit-Position: refs/heads/master@{#487281}
-
Ken Rockot authored
Reworks the system messaging APIs to give consumers direct control over serialized message attachments and replaces MojoMessageOperationThunks with a simpler pair of functions (serialize and destroy). Introduces new C API calls: MojoAttachSerializedMessageBuffer, MojoExtendSerializedMessagePayload, and MojoAttachMessageContext. Existing usage of the messaging APIs has been adapted to the new API surface as a precursor to using dynamically-grown messages during bindings serialization. BUG=742369 Change-Id: Ib3938b2d46a856e0c58b1fb89be78229bc469404 Reviewed-on: https://chromium-review.googlesource.com/571272 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487280}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/64ca2b5ad4d4..a9f03426f2e4 $ git log 64ca2b5ad..a9f03426f --date=short --no-merges --format='%ad %ae %s' 2017-07-17 simonhatch Dashboard - Change /get_histogram to always use same error message. 2017-07-17 trojal Add lowmemorykiller events to Memory Events track. 2017-07-17 simonhatch Dashboard - Convert bisect report from unicode. 2017-07-17 perezju [devil] Include stderr on RunShellCommand with large_output Created with: roll-dep src/third_party/catapult BUG=743171 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ida3150a9fd640b0f0dbaa0f30a0c03e2e65802ae Reviewed-on: https://chromium-review.googlesource.com/575352 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487279}
-
Xu Xing authored
Related file: context_cache_controller.h context_provider.h in_process_context_provider.h BUG=722935 TBR: sky@chromium.org Change-Id: I2a7c3875a0dae2d50ce409c12df05bf46982b324 Reviewed-on: https://chromium-review.googlesource.com/562930 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
-add an IO thread in child thread for the IPC case: this was missing and distorting results -remove MojoChannelPerfTest.ChannelPingPong: this isn't representative of how IPC is used in chrome -use idiomatic IPC macros: this doesn't change performance but is easier to read Change-Id: I18fef0d766b2261ed8f6085fbc01d0215da6e1b4 Reviewed-on: https://chromium-review.googlesource.com/571327 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#487277}
-
Xing Liu authored
When we cache the tab as thumbnail. It copies the bitmap from renderer asynchronously and the bitmap will be put to thumbnail cache later. But navigation can still happen, if the tab navigates to another URL, the thumbnail metadata in thumbnail_cache.cc will be removed, if bitmap arrives after this, we can dump the bitmap instead of assuming the metadata is still there. In VR related tests, we cache the thumbnail when ChromeActivity is paused, and then the WebContent navigates to another URL, which erase the thumbnail metadata, then the bitmap arrives. Bug: 738490 Change-Id: I980d90020170f609c7aa4a17a1e42a18ab553a4a Reviewed-on: https://chromium-review.googlesource.com/570782 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#487276}
-
Victor Costan authored
This lands https://www.sqlite.org/src/timeline?c=d6a44b35 in third_party/sqlite/src/ and third_party/sqlite/patches/0013-Add-new-interfaces-sqlite3_bind_pointer-sqlite3_resu.patch and re-generates third_party/sqlite/amalgamation/* using the script at third_party/sqlite/google_generate_amalgamation.sh. The CL also adds a layout test that verifies the patch works as intended. BUG=742407 Change-Id: I2e1a457459cd2e975e6241b630e7b79c82545981 Reviewed-on: https://chromium-review.googlesource.com/572976Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#487275}
-
Steven Valdez authored
Bug: Change-Id: I471ccb0aa6ce7145a3498f49ec8c12bc93314215 Reviewed-on: https://chromium-review.googlesource.com/571325Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487274}
-
Peter Collingbourne authored
The builders were removed in: https://chromium-review.googlesource.com/569606 https://chromium-review.googlesource.com/572430 Bug: 732652 Change-Id: Ibec4d9ad8e57f90222058bd4a51068ad97df04e9 Reviewed-on: https://chromium-review.googlesource.com/572731Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2937ab85..c2d2c94f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I5005827de78c164563f023e1c9300b8917f2c0a5 Reviewed-on: https://chromium-review.googlesource.com/574873Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487272}
-
Sean Kau authored
Bug: Change-Id: I9649650f8e38d181d5bfe7045b7036bd094a236f Reviewed-on: https://chromium-review.googlesource.com/562657 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Currently re-visiting the change picture page will not request an image update. Bug: 730031 Change-Id: I69afb9ef5a51f5d69ae31df2090b2776a39f8ada Reviewed-on: https://chromium-review.googlesource.com/570817 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487270}
-
Robert Liao authored
This change will allow for the detection of tasks running in TaskScheduler that fail to post their task in a COM STA Task Runner instead. BUG=706512 Change-Id: If8ea9df63cface0dc48aa11b5254ab3e6d87dc4f Reviewed-on: https://chromium-review.googlesource.com/549223 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Shivani Sharma authored
Bug: 741116 Change-Id: I58cbe1714808fa9a36a322ff26e65b93259e288d Reviewed-on: https://chromium-review.googlesource.com/574874 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487268}
-
Justin Schuh authored
Fixes the following minor issues: * MSVC silently accepted runtime version of clamped negate in constexpr (a correctness issue that also generated marginally slower code). * Checked negation did not use optimized builtins when available. Change-Id: Ifd9a756d6620917a915ebdd583909824f2f86410 Reviewed-on: https://chromium-review.googlesource.com/573432 Commit-Queue: Justin Schuh <jschuh@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487267}
-
Karan Bhatia authored
Currently, ExternalInstallError::RemoveError() calls RemoveExternalInstallError() on ExternalInstallManager (its owner) which deletes the ExternalInstallError instance. This also causes the deletion of the extension id, which is passed as a reference. This is further accessed in ExternalInstallManager::RemoveExternalInstallError leading to a UAF. This CL fixes the issue by using a copy of the passed string reference in RemoveExternalInstallError. A regression test is also added which fails on the current master. BUG=739142 Change-Id: I26c57a19a7d88e2a11eb17d3c45c371e95de700c Reviewed-on: https://chromium-review.googlesource.com/572763Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487266}
-
michaelpg authored
BUG=710168 Review-Url: https://codereview.chromium.org/2968613002 Cr-Commit-Position: refs/heads/master@{#487265}
-
Jess Zeisloft authored
Modified MenuController::OnMouseDragged to turn off highlight of a MenuItemView when the mouse exits on a drag. This fixes a small visual bug where the highlight would turn off when the mouse was released and subsequently moved. Bug: 553438 Change-Id: Ib6448954870d8709af222d30f4c431036bdfb975 Reviewed-on: https://chromium-review.googlesource.com/550261 Commit-Queue: Jess Zeisloft <jzeisloft@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#487264}
-
Alex Moshchuk authored
This CL introduces a new base::Feature to control whether the sign-in origin (https://accounts.google.com) requires a dedicated process, to be used for a Finch experiment. As part of this, during initialization content/ will call out to a new ContentBrowserClient method to get a whitelist of origins requiring a dedicated process. These origins will be process-isolated in all profiles for the lifetime of the browser. Bug: 713444, 739418 Change-Id: I308cd1eb209394a9990c5eb5793a95a78d76485a Reviewed-on: https://chromium-review.googlesource.com/569519 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#487263}
-
felixe authored
Revert of Remove confusing keyboard test & focus on input device (patchset #9 id:160001 of https://codereview.chromium.org/2964823002/ ) Reason for revert: A follow up fix for a race condition on cold boot was reverted in https://chromium-review.googlesource.com/c/574731/. With only this patch the functionality is broken in the user facing scenario. The code state without either this cl or the follow up is better than with only this cl. Original issue's description: > Remove confusing keyboard test & inspect input device > > In order to make the decision for when to trigger the OOBE display > chooser less confusing for end users I'm removing the keyboard check. > Instead an explicit remora requisition check is used to limit the > effects. > > BUG=738885 > > Review-Url: https://codereview.chromium.org/2964823002 > Cr-Commit-Position: refs/heads/master@{#485019} > Committed: https://chromium.googlesource.com/chromium/src/+/c923b817665a649b4e18243116c31c68404af7dd TBR=jdufault@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=738885 Review-Url: https://codereview.chromium.org/2977293002 Cr-Commit-Position: refs/heads/master@{#487262}
-
Toni Barzic authored
lock_screen_apps::StateController initialization is updated to include LockScreenItemStorage initialization. Adds lockScreenAppDataCryptoKey string pref to profile prefs - this pref will store base64 encoded AES key that shoul dbe used by LockScreenItemStorage to encrypt user data written to disk. The key is set during StateController initialization is not already present in prefs. Also, add browser tests for lockScreen.data API Bug: 715781 Change-Id: Ia7385d7938fb917053219480cb70895590772104 Reviewed-on: https://chromium-review.googlesource.com/568532 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487261}
-
