- 27 Mar, 2018 40 commits
-
-
kylechar authored
1. Consolidate logic to create VideoResourceUpdater into helper functions. 2. Improve ResourceType enum readability. 3. Delete dead code. 4. Fix software compositing tests expectations to ensure no new shared bitmap allocations. Bug: 730660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1c4120b511a4e411f2699462eb03d9843a85c0a3 Reviewed-on: https://chromium-review.googlesource.com/977891Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#546089}
-
Joshua Pawlicki authored
These keys are pinned in the client and rotated annually. Bug: 820479 Change-Id: I5d38e7ac182d6794d86354334a7a92ab6da67c8a Reviewed-on: https://chromium-review.googlesource.com/956974 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546088}
-
Chandan Padhi authored
Bug: 823831 Change-Id: I60dc7eb1d6a24e6e2e898c23dcacf1a74f06ccfd Reviewed-on: https://chromium-review.googlesource.com/978223Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#546087}
-
Rune Lillesveen authored
We stored the previous match state for :empty, for elements affected by :empty selectors, on their computed style. For :empty in non-rightmost compound selectors, we would set the flag on on an already calculated computed style. That required the ComputedStyle to be mutable. Also, this flag didn't really work as we weren't trying to detect when an element changed between empty and non-empty state. Instead, modify CheckForEmptyStyleChange to check if there are any element or non-empty text nodes before/after the added/removed node. If there are, no :empty selector matching needs to be updated. Bug: 813068 Change-Id: Ic2e7c9a855067267d84c50c71215114a834e92ae Reviewed-on: https://chromium-review.googlesource.com/980946Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546086}
-
kylechar authored
This CL adds a check when initializing the ContextProvider for layout tests. We should retry the on transient failures but just crash for fatal failures. There is no compositing mode fallback in layout tests for simplicity, so we can't do much other than crash here. The reason for this change is that ClusterFuzz was picking up access to some uninitialized data in some vaguely related code. This happens because there is a fatal failure in CreateDisplayOutputSurface() that is ignored. The crash stack should now pinpoint exactly where the failure was and make problems easier to diagnose. Bug: 817758 Change-Id: I766c0526e0e2c01d16be922f78de1b89365ae401 Reviewed-on: https://chromium-review.googlesource.com/980653Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#546085}
-
Elly Fong-Jones authored
In NativeWidgetMacNSWindow, sendEvent: will *not* call [super sendEvent:] for events that might be the start of a drag, which prevents the window from receiving the event if we think it might start a drag. Any LMouseDown could start a drag, so that causes mouse clicks that aren't on some other NSView to not raise the window. Fix that by not returning early when maybe starting a drag. Bug: 775984 Change-Id: Ibe93e45dc4dde39630a3d97f5a148de018c99ab2 Reviewed-on: https://chromium-review.googlesource.com/980701Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546084}
-
Bence Béky authored
In websocket_stream_test.cc, test methods take URL, host (with optional port), and path arguments, which are redundant. This CL removes the host and path arguments and generates them from URL. Also, every test uses the same origin and host_for_cookies, therefore there is no need to pass those as arguments either. Bug: 825231 Change-Id: I31c0c7a44e3e0d28d10c5b1b0c61b2fc744c7e48 Reviewed-on: https://chromium-review.googlesource.com/980958Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546083}
-
Rune Lillesveen authored
Bug: 820299 Change-Id: I9e380416b18f30294fe7cb969a0ce7d0ab1fd7bd Reviewed-on: https://chromium-review.googlesource.com/977910Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#546082}
-
Mythri Alle authored
When investigating failures due to handling of large traces, we disabled some of the pages on v8.browsing_mobile benchmarks. Some of these are enabled later on v8.browsing_mobile but not on v8.browsing_mobile-future. Enabling them now. BUG=chromium:799080 Change-Id: I8b25464be3f01d71d1b3cce07e0c66db8b0b5427 Reviewed-on: https://chromium-review.googlesource.com/962244Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#546081}
-
Reid Kleckner authored
Bug: 823655 Change-Id: If6dfa9d775d3be37b72b4cf5f2fd9db89763819a Reviewed-on: https://chromium-review.googlesource.com/981314Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#546080}
-
Koji Ishii authored
This patch implements Range.getClientRects and getBoundingClientRect by implemeting LayoutText::AbsoluteQuadsForRange, the underlying function to compute quads for a range of text. VisibleUnits and TouchAdjustment are other users of this function. crbug.com/698038 added some logic to clear the quad vector under specific condition for legacy, but the logic is a bit complicated. This patch tries to match to the spec without using the same logic. There may be a need to tweak the logic a little more, but the new logic seems to be more interoperable with Edge/Gecko. Bug: 636993, 755750 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5c6323680285a4e03d64109cd5681c788f6a6bbf Reviewed-on: https://chromium-review.googlesource.com/979732Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#546079}
-
yoshiki iguchi authored
This should fix the size of trays when the docked content is above the desktop (eg. docked magnifier, spoken feedback, etc...) Bug: 824077 Test: manual Change-Id: Iecccb721b14a2ffde045a87993d4951cd677efa4 Reviewed-on: https://chromium-review.googlesource.com/981846 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#546078}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c31982370181504cb80f2084ddf7cd15fb043a8 Reviewed-on: https://chromium-review.googlesource.com/975503Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#546077}
-
Mohamed Amir Yosef authored
This CL does the following refactoring to ModelTypeWorker 1- Changes DecryptSpecifics to a static one that accepts a cryptographer as an input. 2- Changes the WorkerEntityTracker::UpdateContainsNewVersion to take the exact update version instead of the whole UpdateResponseData object Those changes are in preparation for a later patch that will add more preparation for Bookmarks migration to USS Bug: 516866 Change-Id: I0444db35e6b5e31352d5f8aaff546bac7fbd8ec1 Reviewed-on: https://chromium-review.googlesource.com/980313 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#546076}
-
Alex Clarke authored
We would like it to be possible for headless C++ embedders to be able to customise resource metadata caching and this patch adds an API which allows them to capture resource metadata. NB the custom HttpCache introduced by this patch if selected completly disables the regular HttpCache. Design Doc: http://goo.gl/eZp9wz Change-Id: Ie3e916c6f21114c4f4929bbba156d6dac96c88f6 Reviewed-on: https://chromium-review.googlesource.com/953003Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#546075}
-
Adam Rice authored
Inheriting from SupportsWeakPtr<T> is error-prone because weak pointers are not invalidated until the parent object has been partially destroyed. Use WeakPtrFactory instead in WebSocketFactory::Delegate. WebSocketFactory doesn't need weak pointers at all, so remove it completely from there. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I94f8dc6fa20b4ede14295760db44bdeaae207610 Reviewed-on: https://chromium-review.googlesource.com/981964Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#546074}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e9cb694..2943c641 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic6a08781c28e6a7ee9b1ce39a0f4ee8babb9bef0 Reviewed-on: https://chromium-review.googlesource.com/981932Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546073}
-
Adam Langley authored
Currently, no response length (L_e) is encoded in U2F commands. The U2F spec[1] says “if the instruction is not expected to yield any response bytes, L_e may be omitted” – i.e. we are specifying that no response is allowed to our commands. The VASCO SecureClick respects the maximum response length and thus doesn't send a reply. Therefore Chromium's webauthn stack doesn't currently work with these tokens. This change causes us to always specify the maximum possible response length for U2F register and sign commands, and fixes interop with the VASCO token. [1] https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/fido-u2f-raw-message-formats-v1.2-ps-20170411.html#extended-length-encoding Change-Id: I5cc906eb6f167fb95c9a42a13ff46237d0e58b79 Reviewed-on: https://chromium-review.googlesource.com/979702 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#546072}
-
Christian Dullweber authored
SessionRestore on Chrome OS in a non-OWNER profile and with any flag enabled doesn't work correctly after logout/login. This was caused by the change to allow saving a session file without commands. (https://crrev.com/c/899249) This CL reverts the problematic parts and fixes session restore. Bug: 816586 Change-Id: I4a5050c532143c4fa9990e153952a82b72e3385f Reviewed-on: https://chromium-review.googlesource.com/978214Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#546071}
-
Gauthier Ambard authored
This CL adds a section separator for the tools menu, displayed as an item with a grey line in the middle. Bug: 804773 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I70d783ee0db85b8889dda5bbbe0d8ab2714a04a6 Reviewed-on: https://chromium-review.googlesource.com/977911Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#546070}
-
Dominic Battre authored
TBR=fukino@chromium.org notry=true Bug: 804413 Change-Id: I6fd7c66036d38bf23c6b77e16f214eff06c7d903 Reviewed-on: https://chromium-review.googlesource.com/980939Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#546069}
-
Alexandr Ilin authored
This CL starts using activity creation time instead of applicaton creation time for the Startup.Android.Experimental.Cold.TimeToFirst{ContentfulPaint,NavigationCommit} histograms. It's done in order to reduce histograms noise. These histograms are still experimental, so renaming isn't required. Bug: 778302 Change-Id: Ic615c14d62566bb31fec651e706ded158abf9d99 Reviewed-on: https://chromium-review.googlesource.com/977968Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546068}
-
Darren Shen authored
Currently we're just adding a TODO when we want to test a list-valued property. It's probably easier if we stub that test function and then implement it later. Bug: 774887 Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1 Reviewed-on: https://chromium-review.googlesource.com/981956Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#546067}
-
Christopher Cameron authored
Make RWHVMac call through RWHVNSViewBridge, and make RWHVCocoa call through RWHVNSViewClient. Some of these methods depended on knowing if RHWVMac::host() still existed, so refactor tear-down to add a RWHNSViewBridge::Destroy method which informs the RHWVCocoa whether or not its |client_| is still callable. Once RWHVCocoa no longer calls into the RWHVMac directly, all of these lifetimes will be clean-up-able. Bug: 821651 Change-Id: I30f6060ce661504f1eadf933384a6f1cbe4a3c96 Reviewed-on: https://chromium-review.googlesource.com/979595 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#546066}
-
Marc Treib authored
As a first (baby) step of removing the old signin APIs from Sync. Bug: 825190 Change-Id: I1554c96c54555083f06963a72d2c38248afeb960 Reviewed-on: https://chromium-review.googlesource.com/978186Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#546065}
-
Tetsui Ohkubo authored
In https://crrev.com/c/962556, MessageView started to use OnMouseReleased for detecting notification click. OnMouseReleased requires OnMousePressed and OnMouseDragged to return true in order to receive events. However, they are only overridden in NotificationViewMD, thus NotificationView's click event is broken. TEST=manual BUG=824789 Change-Id: Ie4e0c803ddf8425eebaad30c927c356bab699b69 Reviewed-on: https://chromium-review.googlesource.com/981873Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#546064}
-
Vaclav Brozek authored
For (Objective-)C++, there is _CheckNoProductionCodeUsingTestOnlyFunctions in //PRESUBMIT.py which can detect when a method with a ForTesting suffix is referenced in production code. This bug tracks adding such similar presubmit check for production .java files, which are approximated as .java files with no "test" or "junit" in the path and filename. The check is a modified copy of the one for C++. It does not attempt to share code with the C++ check, because some details are simpler for Java (e.g., no need to consider *_for_testing as well). The check is just a presubmit prompt, not error, because there are false positives to be expected. Bug: 821981 Change-Id: I3bb137197070ac696fbe0fd35d50abbfb823a8d8 Reviewed-on: https://chromium-review.googlesource.com/977581Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546063}
-
Takashi Toyoshima authored
Now DocumentThreadableLoader uses Blink API types to construct a CORS-preflight request, but this isn't necessary. Also, this change prefer using std::unique_ptr for ResourceRequest so to respect the direction of crbug.com/787704. Bug: 803766, 787704 Change-Id: I897b17b7ea20e47316c05436c7d36438e03f2d7d Reviewed-on: https://chromium-review.googlesource.com/964074 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#546062}
-
Hiroki Nakagawa authored
This is a preparation CL for enabling to establish WebSocket connections off the main thread. This CL reduces dependencies on Document in DocumentWebSocketChannel as a first step for making it thread-safe. Specifically, this CL replaces GetDocument() calls with GetExecutionContext() calls, and makes the channel get SubresourceFilter not from DocumentLoader buf from BaseFetchContext. Bug: 825740 Change-Id: Ibe49fa09a613818ec972b40a8141f7eecc5a3861 Reviewed-on: https://chromium-review.googlesource.com/981732 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#546061}
-
CJ Dimeglio authored
This CL adds tracing events for the cc::Surfaces for Video feature. This allows the events to be readily viewed in chrome://tracing. Bug: 746182 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibd2637027e4d781ca547991eaea0f3862dce4d81 Reviewed-on: https://chromium-review.googlesource.com/978512Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#546060}
-
Ilya Nikolaevskiy authored
Bug: webrtc:9058 Change-Id: I6bc96a93517dc926e9d847860977ac2d10380a7e Reviewed-on: https://chromium-review.googlesource.com/977922Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#546059}
-
Zhuoyu Qian authored
This CL introduce "InsertCommands.cpp" with moving |InsertCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic1fbdccc3c451fc1ad113b3db22cd704fbc21e04 Reviewed-on: https://chromium-review.googlesource.com/981714Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546058}
-
Adam Langley authored
Following up on https://chromium-review.googlesource.com/c/chromium/src/+/967066/9/content/browser/webauth/authenticator_impl_unittest.cc#306 Change-Id: I5078bd18d1be27f666918e1435df910534664cc0 Reviewed-on: https://chromium-review.googlesource.com/980828 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546057}
-
Kunihiko Sakamoto authored
This is a follow-up to crrev.com/c/981813. - Update spec links to the implementation checkpoint - Use #section-name instead of #rfc.section.numbers as numbers may change - Remove unused constants from signed_exchange_consts.h Bug: 803774 Change-Id: I460d580f30275c6a586cee4b1c7540ff80a98791 Reviewed-on: https://chromium-review.googlesource.com/981874Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#546056}
-
Jinsuk Kim authored
Handles the TODO's in the class spotted while working on other refactoring. The public APIs are not necessary. Change-Id: Ia4d07e5f3eab828125bb8146d7f46e2a9bbe9d31 Reviewed-on: https://chromium-review.googlesource.com/979734Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#546055}
-
Gauthier Ambard authored
This CL adds a popup menu to create new (incognito) tab when long pressing the tab grid button. Bug: 821560 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1a8c7ff3e82cb4422ba50f01993be5e28be275d Reviewed-on: https://chromium-review.googlesource.com/980255Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#546054}
-
Alexandr Ilin authored
This is a reland of cdd8661f Reason for reland: The failing test PlatformSharedMemoryRegionTest.MapAtWithOverflowTest was fixed. Original change's description: > base: Introduce the new Shared Memory API > > Design doc (public): https://goo.gl/HmBYy6 > > This patch proposes the new API for the Shared Memory based on two > concepts, a shared memory region and a shared memory mapping. The > region controls the platform-specific handle and mediates sharing and > access control. The mapping is just a reference to the memory bytes > which knows how to unmap itself. Ownership is per-instance: neither a > region nor a mapping may be copied, and resources are freed when then > instance dies. This is accomplished through move-only semantics. > > The goal of the new API is to provide a correct cross-platform > implementation that makes the sharing mode explicit via the C++ type > system. > > Thus, this CL introduces two classes for shared memory mappings: > - WritableSharedMemoryMapping owns and provides an access to writable > shared memory > - ReadOnlySharedMemoryMapping for read-only shared memory > > and three classes representing shared memory regions: > - UnsafeSharedMemoryRegion allows to create > WritableSharedMemoryMapping instances and cannot be used for making > read-only mappings > - ReadOnlySharedMemoryRegion, on the contrary, can produce only > ReadOnlySharedMemoryMapping instances and it also creates one writable > mapping in the caller process address space > - WritableSharedMemoryRegion allows to create writable > mappings and can be eventually converted to ReadOnlySharedMemoryRegion. > The important limitation in comparison with UnsafeSharedMemoryRegion > is that the WritableSharedMemoryRegion cannot be duplicated so in > order to pass the writable region to another process, the ownership of > the region must be moved/transferred to this process. > > Bug: 795291 > Change-Id: I7d1d0a24932145cc0f449b01ceb8cafef9b7e407 > Reviewed-on: https://chromium-review.googlesource.com/893458 > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545521} TBR=dcheng@chromium.org,erikchen@chromium.org,rsesek@chromium.org,rockot@chromium.org Bug: 795291 Change-Id: Ibba9aac8e7ca5bb6c55a2e0ddf62178fdc8fae20 Reviewed-on: https://chromium-review.googlesource.com/979653 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#546053}
-
Gauthier Ambard authored
This CL adds a blur effect for the popup of the popup menu. Bug: 821765 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie562e101ef8d43f8721d92aa070260ccdb957a72 Reviewed-on: https://chromium-review.googlesource.com/980312Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#546052}
-
Gauthier Ambard authored
This CL adds accessibility identifiers to all the items in the tools menu. Bug: 804773 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifaa40d7174dadf16e71a49949d5f674f873ff8b3 Reviewed-on: https://chromium-review.googlesource.com/980552Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#546051}
-
Daniel Bratell authored
In //extensions/browser a second helper function named WriteFile just appeared and in jumbo builds where all of extensions/browser is compiled in one translation unit (an extreme jumbo configuration), the two clash. This patch renames the function that is the least like base::WriteFile to "CreateDirAndWriteFile". Change-Id: I0d3dc1bb3e13279a2bf333bc0c12985f2133a35d Reviewed-on: https://chromium-review.googlesource.com/980056 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546050}
-