GitLab

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8539047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110357 0039d316-1c4b-4281-b951-d872f2087c98

This failure path has not received a lot of testing until now. Here are
the issues addressed by this patch:

- We usually check the return value of step() calls. However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step(). This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().

- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure. This will allow us to test these
error paths.

- Be careful in ShutdownOnSyncThread(). The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database. The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was. However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore. If this code
were to get executed it would put us into an inconsistent state. See
issue 103824. However, it's unlikely this code would get executed. If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().

- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails. Such a failure could
be due to bad local state. We don't know the actual cause because the
information is not available from the ProfileSyncService callback. The
safe course of action is to clear our local sync state and try again
later. It's the easiest way to get back to the most well travelled sync
initialization path.

- Fix error handling logic in OpenAndConfigureHandleHelper.  It used
to rely on a specially-crafted scoped_ptr to close the database if we
had to leave the function unsuccessfully.  This was wrong in two ways.
First, it did not reset the handle to NULL, which meant that the
DirectoryBackingStore would attempt to free the handle again when it
was destructed.  Second, it failed to clean up the handle when the
return value was not SQLITE_OK.  (Though I suppose it would have been
cleaned up by the DirectoryBackingStore destructor, thanks to the
previous issue).

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase


Review URL: http://codereview.chromium.org/8568028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110356 0039d316-1c4b-4281-b951-d872f2087c98

Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110355 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=103822
TEST=+1 action in SyncPromo.UserFlowAction and +2 new histograms.


Review URL: http://codereview.chromium.org/8528054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=make compositor_model_bench


Review URL: http://codereview.chromium.org/8576003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110353 0039d316-1c4b-4281-b951-d872f2087c98

loading. This effectively reverts the change to LocationBar. The change to LocationBarView was problematic because the boolean passed to OmniboxView::SelectAll means something different than the boolean passed to LocationBarView::FocusLocation.

BUG=104201
TEST=see bug
R=alicet@chromium.org,ben@chromium.org


Review URL: http://codereview.chromium.org/8486022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90644
TEST=none

R=brettw@chromium.org

Review URL: http://codereview.chromium.org/8486018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110351 0039d316-1c4b-4281-b951-d872f2087c98

This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided.

This should fix the notifications auto tests.

BUG=103821
TEST=Make sure all tests and autotests run

Review URL: http://codereview.chromium.org/8539038

TBR=stevenjb@google.com
Review URL: http://codereview.chromium.org/8488015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110350 0039d316-1c4b-4281-b951-d872f2087c98

The previous change covered only a small revision range, so that the bot
went red on noise. Now that more revisions are available, make the range
a bit longer.

TBR=cmp
Review URL: http://codereview.chromium.org/8513025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110349 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mal@chromium.org
Review URL: http://codereview.chromium.org/8576012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110348 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8513024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110347 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit b383640d.

Broke the Linux shared build.

BUG=53473
TBR=willchan

Review URL: http://codereview.chromium.org/8578013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110346 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8537017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53473
TEST=see attachment on bug 7469

Review URL: http://codereview.chromium.org/8249008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110344 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles and passes tests


Review URL: http://codereview.chromium.org/8570022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8486016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8576011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110340 0039d316-1c4b-4281-b951-d872f2087c98

Previously, this was an inline function with a static member, and
since we're building with -fvisibility-inlines-hidden, this resulted
in one copy of the singleton in each translation unit that includes
this header.

Turn on -Wexit-time-destructors for ppapi_proxy.

BUG=104323
TEST=none
TBR=noelallen@google.com (noelallen@chromium.org did LGTM already)

Review URL: http://codereview.chromium.org/8574027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110339 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7159: (pdox) Get rid of ld_script_arm_untrusted.
r7160: (pdox) Merge with LLVM up to r144148.
r7161: (mseaborn) Scons: Split up run_stubout_mode_test
r7162: (pdox) * Rebase build.sh and merge-tool.sh to run inside pnacl/ instead of native_client/.
r7163: (pdox) Fix the thread_test on PNaCl-GlibC by enabling target-specific defines for X86-64 for this test.
r7164: (robertm) Fix the package order for installing the trusted arm TC
r7165: (mcgrathr) Don't link with libcrt_platform.a, which is now empty
r7166: (pdox) Update toolchain DEPS to 7161.
r7167: (chrome-admin) Update .DEPS.git
r7168: (mseaborn) x86-64 Windows: Make the stack unwindable inside NaCl syscall handlers
r7169: (jasonwkim) Fix build breakage

BUG=none
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8468019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110338 0039d316-1c4b-4281-b951-d872f2087c98

* Switching to fullscreen on aura is synchronous. Use the same path as windows.
* Use dispatcher to run all pending in in_process_browser_tests.
* Check if the window is already destroyed in NatveWidgetAura::Hide

BUG=103485
TEST=following tests should pass with this patch on aura: BrowserTest.TestFullscreenBubbleMouseLockState
BrowserTest.TestNewTabExitsFullscreen
BrowserTest.TestTabExitsItselfFromFullscreen


Review URL: http://codereview.chromium.org/8571026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110337 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110336 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8539049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110335 0039d316-1c4b-4281-b951-d872f2087c98

Intentionally leaks NativeTheme* singletons to avoid destructor firing after main.  Memory bots will need suppressions for this.

Avoids clang error:

  time make -k -j16 compositor_unittests
    CXX(target) out/Debug/obj.target/ui/ui/gfx/native_theme_aura.o
  ui/gfx/native_theme_aura.cc:27:32: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
    static const NativeThemeAura s_native_theme;

BUG=none
TEST=compiles under clang -Wexit-time-destructors
R=jamescook@chromium.org, ben@chromium.org

Review URL: http://codereview.chromium.org/8520026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=willchan@chromium.org

Review URL: http://codereview.chromium.org/8549004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110333 0039d316-1c4b-4281-b951-d872f2087c98

This implements the policy inside the browser process, shutting down the cloud
print connector if the policy is set to disabled. This isn't a complete
solution, as the browser needs to be running or be launched for the policy to
take effect. (It will take a lot more refactoring for the service process to
use the policy code). The hole without the refactoring is that if you enable
the connector, quit Chromium, and set the policy, the connector will stay alive
until the next launch of Chromium.

The browser process checks the policy on startup, and listens for it changing
as long as it is up. You can sit on the Under the Hood page and watch the
button change state on Windows as you fiddle with the policy.

BUG=59769
TEST=Set Cloud Print Proxy policy to disabled, bring up browser, Options/Under
the Hood - Sign in to Google Cloud print will be disabled.  Unset policy, wait,
button becomes active.  Log in to cloud print.  Quit Chromium, note service
process hangs around for more than a minute.  Set policy, launch and quit
Chromium. Note that the service process quits within a minute.


Review URL: http://codereview.chromium.org/8438020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110332 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org
BUG=104484
TEST=policy.PolicyTest.testJavascriptPolicies passes

Review URL: http://codereview.chromium.org/8486021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101600, 94925
TEST=none
TBR=mnissler

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110235

Review URL: http://codereview.chromium.org/8573021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110330 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110329 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8486011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110328 0039d316-1c4b-4281-b951-d872f2087c98

This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided.

This should fix the notifications auto tests.

BUG=103821
TEST=Make sure all tests and autotests run

Review URL: http://codereview.chromium.org/8539038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110327 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/93936
TEST=none yet
Review URL: http://codereview.chromium.org/8574033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22447
TEST=GViewRequestInterceptorTest.*


Review URL: http://codereview.chromium.org/8574020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8511080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110324 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org
BUG=104484
TEST=policy.PolicyTest.testJavascriptPolicies

Review URL: http://codereview.chromium.org/8575007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110323 0039d316-1c4b-4281-b951-d872f2087c98

This makes panels usable on Linux with auto-hide taskbar. Currently
panels in title only mode are obscured by the taskbar when in auto-hide mode.

BUG=102719
TEST=Manual. Minimize panel. Hover and move mouse away. Panel should be in titlebar mode for a few seconds.

Review URL: http://codereview.chromium.org/8573030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110322 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, I haven't been able to reproduce bug 103058 very well
in WebKit's LayoutTest engine, because DumpRenderTree's libraries interfere with
resource lifetime; a browser_test doesn't have this issue, so it's able to
act as a good regression test for this issue.

BUG=103058


Review URL: http://codereview.chromium.org/8531002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110321 0039d316-1c4b-4281-b951-d872f2087c98

wouldn't do a final layout resulting in the content not laying out
correctly.

BUG=104082
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8573029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110320 0039d316-1c4b-4281-b951-d872f2087c98

This fixes DesktopNotificationsTest tests for aura.

BUG=104408
TEST=DesktopNotificationsTest.* on aura bots

Review URL: http://codereview.chromium.org/8573033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8539046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110318 0039d316-1c4b-4281-b951-d872f2087c98