- 18 Jul, 2016 40 commits
-
-
jmadill authored
https://chromium.googlesource.com/angle/angle.git/+log/4c32feb..5bc93c4 BUG=621031,628052,612066 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2158003002 Cr-Commit-Position: refs/heads/master@{#406049}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b4db493..9b382ab2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2158943002 Cr-Commit-Position: refs/heads/master@{#406048}
-
dpapad authored
BUG=628987 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2158043002 Cr-Commit-Position: refs/heads/master@{#406047}
-
fdoray authored
With this CL, the following histograms are recorded with a suffix indicating the number of startups with the same version: - Startup.BrowserMainToRendererMain - Startup.BrowserMessageLoopStartTime - Startup.BrowserMessageLoopStartTimeFromMainEntry - Startup.BrowserOpenTabs - Startup.BrowserWindowDisplay - Startup.FirstWebContents.MainFrameLoad2 - Startup.FirstWebContents.MainNavigationFinished - Startup.FirstWebContents.MainNavigationStart - Startup.FirstWebContents.NonEmptyPaint2 - Startup.LoadTime.ExeMainToDllMain - Startup.LoadTime.ProcessCreateToDllMain - Startup.LoadTime.ProcessCreateToExeMain - Startup.SystemUptime - Startup.TimeSinceLastStartup BUG=580211 Review-Url: https://codereview.chromium.org/2117373003 Cr-Commit-Position: refs/heads/master@{#406046}
-
kmarshall authored
* Change BlobChannel PutBlob() Mojo IDL to use shared memory handles instead of a byte array. * Create "SharedMemoryBlob" class for encapsulating Mojo shared memory initialization and lifetime management semantics. * Add BlobChannelSenderProxy class, which manages interactions with the renderer side of the BlobChannel IPC interface. * Add Blimp-specific run_all_unittests.cc, which bootstraps the Mojo environment before executing unittests. R=wez@chromium.org CC=maniscalco@chromium.org BUG=600719,614564 Review-Url: https://codereview.chromium.org/2033013003 Cr-Commit-Position: refs/heads/master@{#406045}
-
reveman authored
Allows widget close animations to use the scale assigned to shell surface at the time it is destroyed. BUG=628932, b/29082277 Review-Url: https://codereview.chromium.org/2157863002 Cr-Commit-Position: refs/heads/master@{#406044}
-
thomasanderson authored
This fixes a race condition where: 1. We get a ConfigureNotify event that tells us the window was resized and as a result post a delayed resize task 2. The window is resized 3. The delayed resize task runs and resizes the window to the old size The symptom experienced by this bug could be seen with tooltips which reuse the same window for each tooltip. If a window was resized to be larger, we would only render in the smaller area and garbage data would fill the rest. BUG=442111 Review-Url: https://codereview.chromium.org/2154483002 Cr-Commit-Position: refs/heads/master@{#406043}
-
gogerald authored
BUG=628046 Review-Url: https://codereview.chromium.org/2149163002 Cr-Commit-Position: refs/heads/master@{#406042}
-
rajendrant authored
ExternalDataUseReporter class is created with the data use reporting logic. ExternalDataUseReporter is created in IO thread and moved to UI thread. It is owned by ExternalDataUseObserver. BUG=570884 Review-Url: https://codereview.chromium.org/2145863002 Cr-Commit-Position: refs/heads/master@{#406041}
-
varkha authored
Changes the parent of search widget labels and close buttons in overview mode to be kShellWindowId_StatusContainer which is still above all windows but below menus and screen overlays. BUG=629039 Review-Url: https://codereview.chromium.org/2154323002 Cr-Commit-Position: refs/heads/master@{#406040}
-
clamy authored
We've seen a sharp augmentation of renderer hangs on Android. This histogram is meant to help identify the root cause of this renderer hangs, since it's currently hard to distinguish whether this is happening during normal browsing or during beforeunload/unload/when the page is closing. BUG=621303 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2136173003 Cr-Commit-Position: refs/heads/master@{#406039}
-
pkotwicz authored
BUG=None Review-Url: https://codereview.chromium.org/2149873002 Cr-Commit-Position: refs/heads/master@{#406038}
-
sdefresne authored
BUG=None Review-Url: https://codereview.chromium.org/2159763002 Cr-Commit-Position: refs/heads/master@{#406037}
-
rouslan authored
When user taps on an incomplete autofill credit card or [+ ADD CARD] button, the card editor launches. For server cards, the editor shows uneditable card information and lets the user set the billing address. For local cards, the editor shows the following fields. 1) A list of icons for supported card types. 2) The card number input with Luhn validation and formatting. Required field. 3) The name on card input. Required field. 4) The month and year dropdowns. January of this year by default for new cards. 5) The billing address dropdown with only complete addresses on disk and an option to add a new address. Required field. 6) A checkbox for saving the new card on disk. Checked by default, so it behaves similar to autofill settings. BUG=624924 Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea Review-Url: https://codereview.chromium.org/2116583002 Cr-Original-Commit-Position: refs/heads/master@{#405876} Cr-Commit-Position: refs/heads/master@{#406036}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d2b666834a28..3c2ec02098fa $ git log d2b666834..3c2ec0209 --date=short --no-merges --format='%ad %ae %s' BUG=628239 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2162583002 Cr-Commit-Position: refs/heads/master@{#406035}
-
jshin authored
This should go in after https://chromium-review.googlesource.com/#/c/349730/ is landed. Update install-chromeos-fonts.py to install the latest notofonts and roboto font packages for CrOS. R=dzhioev BUG=617281 TEST=OOBE screen still use Roboto CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2043883004 Cr-Commit-Position: refs/heads/master@{#406034}
-
rockot authored
Fixes a missing lock acquisition from the listener thread when accessing |channel_|. Also removes the TSAN suppression for this bug. BUG=628481 TBR=glider@chromium.org for suppression removal Review-Url: https://codereview.chromium.org/2158893002 Cr-Commit-Position: refs/heads/master@{#406033}
-
cco3 authored
Double.compare and Long.compare were introduced in api 19, but the minimum is api 16. This change uses compareTo instead. BUG=628711 Review-Url: https://codereview.chromium.org/2157663002 Cr-Commit-Position: refs/heads/master@{#406032}
-
jasonroberts authored
BUG= internal b/30144624 Review-Url: https://codereview.chromium.org/2154513002 Cr-Commit-Position: refs/heads/master@{#406031}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/490c07d77670..6451a0cea600 $ git log 490c07d77..6451a0cea --date=short --no-merges --format='%ad %ae %s' 2016-07-18 robertphillips Add makeSpecial calls to SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161533003 2016-07-18 fmenozzi Add filename to gradient scrape 2016-07-18 jcgregorio Revert of remove unused TableMaskFilter (patchset #1 id:1 of https://codereview.chromium.org/2156463002/ ) 2016-07-18 bsalomon In GrShape detect that stroked axis-aligned lines are rrects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=jcgregorio@google.com Review-Url: https://codereview.chromium.org/2154313002 Cr-Commit-Position: refs/heads/master@{#406030}
-
stip authored
BUG= Review-Url: https://codereview.chromium.org/2152413003 Cr-Commit-Position: refs/heads/master@{#406029}
-
pke authored
Implement a ContentSuggestionsProvider that reads from the OfflinePageModel, converts to ContentSuggestions and provides those to the ContentSuggestionsService. Add a chrome-flag to enable the provider and implement a factory that registers the provider with the service. The implementation is not usable by users, yet, because extraction of title, snippet text and image is not implemented. Those fields are filled with dummy data or left empty. Deduplication, sorting and discarding are also not implemented. But the OfflinePageSuggestionsProvider serves as an example for other ContentSuggestionsProvider implementations and it can be used to test multiple-section UI implementations. BUG=628198 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2149453004 Cr-Commit-Position: refs/heads/master@{#406028}
-
vmpstr authored
This patch fixes the order of parameters to be correct (progress comes first). BUG=588506 R=danakj CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2155893002 Cr-Commit-Position: refs/heads/master@{#406027}
-
rogerm authored
This CL updates the PersonalDataManager to run autofill profile de-duplication (if enabled) at the appropriate time, depending on whether autofill profile sync is enabled. If sync is not enabled, profile de-duplication is run after the data is initially loaded. If sync is enabled, profild de-duplication is run after the sync first becomes active. In all cases, de-duplication is only run once for a given version of chromium. BUG=627519 R=sebsg@chromium.org, mathp@chromium.org Review-Url: https://codereview.chromium.org/2142123002 Cr-Commit-Position: refs/heads/master@{#406026}
-
msramek authored
BUG=589586 Review-Url: https://codereview.chromium.org/2132563003 Cr-Commit-Position: refs/heads/master@{#406025}
-
robert.bradford authored
When building ash_unittests under "simple chrome": cros chrome-sdk gcc is used. The comment in WindowModalityControllerTest looks like a multline comment, triggering -Werror=comment. This CL adjusts the ascii art to avoid triggering that error. BUG=628667 TEST=ash_unittests builds under "cros chrome-sdk" Review-Url: https://codereview.chromium.org/2160603002 Cr-Commit-Position: refs/heads/master@{#406024}
-
halliwell authored
The old "egltest" platform set window title to "EGL test" by default. Would like to have the equivalent for X11. BUG=internal b/29226425 Review-Url: https://codereview.chromium.org/2156743002 Cr-Commit-Position: refs/heads/master@{#406023}
-
bokan authored
Most scroll layers in CC update the main thread with changed scroll offsets by using the did_scroll_callback, which calls into GraphicsLayer to update its copy of the scroll offset. The exception to this has been viewport layers, which don't set a did_scroll_callback. Instead, the viewport gets its values applied in WebViewImpl::applyViewportDeltas. This was done since viewport scroll bounds were dependent on page scale and top controls offset so these values had to be committed atomically. It turns out, only the inner (visual) viewport's scroll bounds depend on the page scale. While the outer (layout) viewport's scroll bounds do depend on top controls, the compositor already clamps the scroll offset to the acceptable bounds so as long as we apply the top controls delta after the scroll offset (to prevent the main thread from clamping it again) the outer viewport doesn't need to be in applyViewportDeltas. This CL removes the layout viewport as part of applyViewportDeltas and makes it use the regular did_scroll_callback mechanism. This simplifies the root scroller implementation which can change which layer is the outer viewport. Having the outer viewport use the callback avoids some race conditions as to which layer scroll gets applied to during a change of outer viewport. I've left the parameter in applyViewportDeltas' signature since that's a large mechanical change that'll touch many files. This Cl just passes 0 for the layout viewport scroll delta and a future CL will remove the parameter itself. BUG=505516 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2144303002 Cr-Commit-Position: refs/heads/master@{#406022}
-
vakh authored
Also, replace counters with iterators to avoid multiplications --- Original CL: https://codereview.chromium.org/2145163003/ Original description: PVer4: Keep track of the smallest hashes not their sizes. Also, replace counters with iterators to avoid multiplications BUG=543161 Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3 Cr-Commit-Position: refs/heads/master@{#405662} --- BUG=543161 Review-Url: https://codereview.chromium.org/2154973002 Cr-Commit-Position: refs/heads/master@{#406021}
-
jinho.bang authored
Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage. Related spec issue: https://github.com/slightlyoff/ServiceWorker/issues/897 BUG=627777 Review-Url: https://codereview.chromium.org/2102093002 Cr-Commit-Position: refs/heads/master@{#406020}
-
xiyuan authored
BUG=628379 Review-Url: https://codereview.chromium.org/2151113002 Cr-Commit-Position: refs/heads/master@{#406019}
-
tommycli authored
Currently, there can be a situation where if the plugin removes itself during initialization, the container is destroyed but the placeholder plugin is not. This patch fixes this issue. BUG=620515 Review-Url: https://codereview.chromium.org/2151483007 Cr-Commit-Position: refs/heads/master@{#406018}
-
alexclarke authored
There was a bad interaction between throttled task queues and logic in TimerBase::setNextFireTime that could cause setInterval to stop firing. If a timer was posted to a throttled task queue after running on a normal task queue, it was possible for NOW to be in the past. Logic existed in TimeDomain::ComputeDelayedRunTime to compensate for this. Usually that worked fine, however the anti-drift logic in TimerBase for repeating tasks could cause the scheduled run time (as visible to TimerBase) to fall on the exact same time as the previous run. This would cause TimerBase::setNextFireTime to nop out, which would cause the setInterval to stop firing. This patch prevents that by changing ThrottledTimeDomain to be based on RealTimeDomain. This means Now() is the real time rather than a periodically updated virtual time. I.e. it's monotonically increasing. At the same time I've remove the now useless TimeDomain::ComputeDelayedRunTime BUG=625041 Review-Url: https://codereview.chromium.org/2155143002 Cr-Commit-Position: refs/heads/master@{#406017}
-
wangxianzhu authored
Reland of New PaintController under-invalidation checking (patchset #1 id:1 of https://codereview.chromium.org/2156053002/ ) Reason for revert: The original CL is to discover such bugs. Will mark the test failure in the reland. Original issue's description: > Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ ) > > Reason for revert: > NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481. > > Original issue's description: > > New PaintController under-invalidation checking > > > > This is a follow-up of https://codereview.chromium.org/2107103002/ > > which broke the original under-invalidation checking in > > PaintController. > > > > BUG=596983,510908 > > > > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1 > > Cr-Commit-Position: refs/heads/master@{#405805} > > TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=596983,510908 > > Committed: https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64 > Cr-Commit-Position: refs/heads/master@{#405988} TBR=chrishtr@chromium.org,pdr@chromium.org,grt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596983,510908 Review-Url: https://codereview.chromium.org/2162603002 Cr-Commit-Position: refs/heads/master@{#406016}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db420127..3b4db493 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2162553002 Cr-Commit-Position: refs/heads/master@{#406015}
-
jennyz authored
Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the OutputNodeVolumeChanged signals responding from cras, do not pop up the volume bar for such signals. BUG=625222 Review-Url: https://codereview.chromium.org/2146313005 Cr-Commit-Position: refs/heads/master@{#406014}
-
jmadill authored
Several failures have tracking bugs or were mis-classified. BUG=483282,627531,624506,626068 BUG=angleproject:1246,angleproject:1268 R=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2146593002 Cr-Commit-Position: refs/heads/master@{#406013}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/b5683a83c BUG=624285 TBR=jgruber@chromium.org Review URL: https://codereview.chromium.org/2156233002 . Cr-Commit-Position: refs/heads/master@{#406012}
-
eugenebut authored
presentSSLError:forSSLStatus:recoverable:callback: is not implemented by Tab anymore. BUG=602298 Review-Url: https://codereview.chromium.org/2146763003 Cr-Commit-Position: refs/heads/master@{#406011}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/eaf6d4102258..490c07d77670 $ git log eaf6d4102..490c07d77 --date=short --no-merges --format='%ad %ae %s' 2016-07-18 msarett Test auto merger CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel TBR=jcgregorio@google.com Review-Url: https://codereview.chromium.org/2159783002 Cr-Commit-Position: refs/heads/master@{#406010}
-