- 31 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73329c8df9d5..c9eace8194dd git log 73329c8df9d5..c9eace8194dd --date=short --no-merges --format='%ad %ae %s' 2018-10-31 mtklein@google.com add unpremul gm 2018-10-31 caryclark@skia.org give include comments the once over 2018-10-31 jvanverth@google.com Only copy subrect in DistanceFieldGen setup 2018-10-31 benjaminwagner@google.com Upgrade Win10 Skylake graphics driver. 2018-10-31 herb@google.com Use bulk calls between SkGlyphRunPainter and SkDraw 2018-10-31 csmartdalton@google.com ccpr: Don't use cache entries as path listeners Created with: gclient setdep -r src/third_party/skia@c9eace8194dd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:896987 TBR=herb@chromium.org Change-Id: I1a44a333372733913970c1a3f2924e0cb31f7e3f Reviewed-on: https://chromium-review.googlesource.com/c/1310074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604328}
-
Morten Stenshorne authored
It used to fail on Windows. The rebaseline tool shuffled expectations around quite a bit (I expected only Windows to change), but I guess that's right. Bug: 591500, 900469 Change-Id: Id894f5637a52b9623990b7a618447490c80d137a Reviewed-on: https://chromium-review.googlesource.com/c/1309653 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#604327}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1e185db4498d..79263ca083e0 git log 1e185db4498d..79263ca083e0 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 thestig@chromium.org Move Skia features bits to the end of the "skia" target. Created with: gclient setdep -r src/third_party/pdfium@79263ca083e0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6d856dab5c479026068b2180ae3aa01831a42497 Reviewed-on: https://chromium-review.googlesource.com/c/1310076Reviewed-by:
-
Jun Cai authored
The "Initial upload" patch is the same as the reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1184306 Bug: 874651, 896603 Change-Id: I406f587cf4b9e69a80fb82e4558a78209eca801c Reviewed-on: https://chromium-review.googlesource.com/c/1294719 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604325}
-
Mustaq Ahmed authored
Bug: 897829 Change-Id: I652665d6a0531ac820329cb64ce073c3b517c8b6 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1299537 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604324}
-
Andrey Kosyakov authored
This adds Fetch domain on the browser target, that carries interception functionality previously available through Network domain, with a slightly brushed up interface. Bug: 899303 Change-Id: I74ef83ddfe711c566500ab9e815a24dfbf813106 Reviewed-on: https://chromium-review.googlesource.com/c/1292008Reviewed-by:
-
Lukasz Anforowicz authored
Why remove DoesSiteRequireDedicatedProcess ========================================== This CL removes LayoutTestContentBrowserClient::DoesSiteRequireDedicatedProcess. We plan to remove other overrides of this ContentBrowserClient method in follow-up CLs. We want to remove this ContentBrowserClient method altogether, because 1) it is currently the only reason SiteInstanceImpl::DetermineProcessLockURL needs to take BrowserContext* as an argument (and therefore is problematic on threads other than UI thread) 2) the method was initially introduced to support --isolate-extensions which has been obsolete since shipping --site-per-process in M67. Removal mechanics ================= This CL replaces LayoutTestContentBrowserClient::DoesSiteRequireDedicatedProcess with LayoutTestContentBrowserClient::GetOriginsRequiringDedicatedProcess (i.e. mechanism based on --isolate-origin functionality). Bug: 898281 Change-Id: I3d7cfa7cce6077d2d7b5af24089d6e3d212b8e73 Reviewed-on: https://chromium-review.googlesource.com/c/1307848 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604322}
-
Emil A Eklund authored
Introduce a new ShapeResultView class representing a read-only view into one or more ShapeResults. Will be used instead of ShapeResult::CopyRange in line breaking to avoid the extra memory and computational overhead of creating a copy. Switches the ShapeResult::runs_ vector to ref count the RunInfo instances to allow a ShapeResultView to outline the ShapeResult. Bug: 900015 Test: renderer/platform/fonts/shaping/shape_result_view_test.cc Change-Id: Id676b08a3f03c392ed4271af2f66c51a9e0b2ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1306637 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604321}
-
iOS Autoroller authored
TBR=smut Change-Id: I83595c80791ad4c4f54597b6b09c88d5eebd45f7 Reviewed-on: https://chromium-review.googlesource.com/c/1310354Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#604320}
-
Owen Min authored
This reverts commit 28c21fa4. Reason for revert: The tests are flaky again. Original change's description: > Re-enable disabled VR tests > > Re-enables all the VR tests that were marked as flaky now that the > root cause has been reverted. > > TBR=mthiesse@chromium.org > > Bug: 894796 > Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473 > Reviewed-on: https://chromium-review.googlesource.com/c/1305211 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603594} TBR=bsheedy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894796 Change-Id: I502b065118723a03d26f2a5b010dc44a724572cc Reviewed-on: https://chromium-review.googlesource.com/c/1310357Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604319}
-
Peter Boström authored
This is consistent with the new close-x on bubbles. It also fixes ink drops being out of sync with focus rings on Mac, since they were not derived from the same path. Bug: chromium:898806 Change-Id: I51ebd333b60435fee4b252a4db60e7ca459cea0d Reviewed-on: https://chromium-review.googlesource.com/c/1309136Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604318}
-
Wei Li authored
Clicking ElementInspect button would toggle entering/exiting inspector mode. However, previously clicking that button in inspector mode would be handled by pinned element logic. In this CL, we capture returned window element's active state. If the window is not active, pinned element logic should not mark the event as handled to give frontend a chance to handle the event. BUG=899000 Change-Id: I4356f85f0ec6d90298473bb894f197aa4ab733e3 Reviewed-on: https://chromium-review.googlesource.com/c/1306403Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#604317}
-
Aiden Benner authored
Throwable and Class have special JNI types jclass and jthrowable. Converting these types to object breaks the function bindings, This CL adds Class and Throwable to the list of types not to cast to objects when creating the JNI bindings Bug: 898261 Change-Id: I84f008a8aa6d3505a975f5989482ffb5f6bba237 Reviewed-on: https://chromium-review.googlesource.com/c/1307774Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#604316}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: Ia30d9ff86560bfb39217877f40c7b0e36cf475b6 Reviewed-on: https://chromium-review.googlesource.com/c/1307508 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#604315}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab0e8a3d06fc..673cf8fc2ca9 Created with: gclient setdep -r src-internal@673cf8fc2ca9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUGS=900463 TBR=mmoss@chromium.org Change-Id: I8965bbc01f00b033f51731de3083b6c911998823 Reviewed-on: https://chromium-review.googlesource.com/c/1310077Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604314}
-
Evan Stade authored
All tests run with 30 iterations with no failures. Bug: none Change-Id: I727c08ef70d6c0a34b31435009e419eeab4a5aac Reviewed-on: https://chromium-review.googlesource.com/c/1309137 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604313}
-
Francois Doray authored
Also mark as obsolete histograms that stopped being recorded in https://chromium-review.googlesource.com/c/chromium/src/+/961384. Bug: 885293 Change-Id: Id14bbc92a6aa175f5e5c9b5ebfa9173b8b157046 Reviewed-on: https://chromium-review.googlesource.com/c/1305195 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604312}
-
Xiyuan Xia authored
Bug: 900631 Change-Id: I849b63b4ec647a650e6d94986853468600f05da2 Reviewed-on: https://chromium-review.googlesource.com/c/1310215Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604311}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I1abba285ea8d44e64d7eaee15387fd2cd5d43323 Reviewed-on: https://chromium-review.googlesource.com/c/1309786Reviewed-by:
-
Tarun Bansal authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900641 Change-Id: Icba82d2aee1df55cd112bc275618881bf57ad0e8 TBR: zmin@chromium,.org Reviewed-on: https://chromium-review.googlesource.com/c/1310496 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604309}
-
bsheedy authored
Adds a workaround for an issue where loadUrl was returning before loaded scripts finished executing during XR tests, causing test flakiness. The workaround changes the condition being checked to include a check that the function being polled actually exists. Bug: 894796 Change-Id: I080345688a6a268b2dda656f39a7e91523b2cb95 Reviewed-on: https://chromium-review.googlesource.com/c/1306173Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604308}
-
Sandra Sun authored
Since range.h includes windows.h, which pollutes the namespace, we have to create SnapVisibleRange class in scroll_snap_data.h. Now that windows.h has been removed, we should use gfx::RangeF for scroll_snap_data. Bug: 898975 Change-Id: If86417f2d32f40f4560fe54ac1c1388e883518de Reviewed-on: https://chromium-review.googlesource.com/c/1308094Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#604307}
-
Yi Su authored
Current search_engine.js has a function __gCrWeb.searchEngine.getOpenSearchDescriptionDocumentUrl, which will be called by native side to get the OpenSearch URL. This CL strips the function shell, and let the code send messages to native side when OSDD is found in page. This helps avoid unnecessary Js execution on native side, and makes the SearchEngineTabHelper cleaner. Bug: 433824 Change-Id: I209ebc40129e753c9715123404a9228659e33158 Reviewed-on: https://chromium-review.googlesource.com/c/1309751Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604306}
-
Arthur Sonzogni authored
History: ======= * Initial : https://chromium-review.googlesource.com/1230067 * Revert : https://chromium-review.googlesource.com/1265060 * Reland : This CL. Cause of revert: ================ The tests depended on timing. On slow bots, it was failing. Instead of checking the number of IPCs sent was below 100_IPC/10_s, the new tests only check for the console error message to be displayed. Since this is not possible to send a console message to a remote frame, the last test has been removed. Original description: ===================== Some javascript function called in an infinite loop can cause the browser process to be flooded by IPC and become unresponsive. Limit the number of IPC sent to 10 per second per frame. This was already done for: - history.pushState() - history.replaceState() This is extended to: - history.back() - history.forward() - history.go() - navigations... 3 tests added. R=clamy@chromium.org TBR=palmer@chromium.org,dcheng@chromium.org Bug: 882238 Change-Id: Iacab2f76dffa889bfd508fedf47f6e840627dbc7 Reviewed-on: https://chromium-review.googlesource.com/c/1268016Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#604305}
-
Carlos IL authored
Followup to crrev.com/c/1299929, the TestNavigationObserver was having race conditions, and was unblocking after the initial navigation to on). Changed the observer to wait for a specific URL. about: blank, causing tests to be flaky (with committed interstitials Change-Id: I899daf5ef5e86bf45795d09f0acc0a3852ac8556 Reviewed-on: https://chromium-review.googlesource.com/c/1308938Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#604304}
-
Orin Jaworski authored
The code eliminated was a switch constant that wasn't being used. The .cc, .h, and related inclusions were eliminated with no effect. Bug: 900255 Change-Id: I76521fb8acce5b7eb5aa9e38fa748953468105ea Reviewed-on: https://chromium-review.googlesource.com/c/1308040Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#604303}
-
Dmitry Gozman authored
This reverts commit a58614dd. Reason for revert: the issue should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1309213 Original change's description: > Disable WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization on Linux > > Change-Id: Ibac0faa988dfa05b727967251d0f51cfe0b474d1 > Bug: 900432 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > TBR: dgozman@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1309322 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604089} TBR=dgozman@chromium.org,tbansal@chromium.org Change-Id: Ib776370c42fffc4c44ddec9eca10c8093c6db01b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900432 Reviewed-on: https://chromium-review.googlesource.com/c/1310355Reviewed-by:
-
Stephen Martinis authored
It appears that this isn't being set anywhere in recipes, so this should maybe be safe to remove? Bug: 718157 Change-Id: Iec1934638ec6f1acaf5b1b96c1e8fdb129457c39 Reviewed-on: https://chromium-review.googlesource.com/c/1308912 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604301}
-
Min Qin authored
Currently when history db fails to load, we creates a temporary download and won't persist it back to the history db. When in-progress DB is enabled, we should do the same. if history service won't return a valid id for a new download, this download should only live with the current browser sessions. BUG=898859 Change-Id: I1b09b59358b043541c4642d2080040c947ce8560 Reviewed-on: https://chromium-review.googlesource.com/c/1305877Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604300}
-
Dmitry Gozman authored
When pausing on initialization, we issue Debugger.enable immediately followed by Debugger.pause and expect the pause to happen. Because Debugger.pause can interrupt JS, it may actually run before Debugger.enable on the backend. That makes pause noop, and we never pause. The solution is to await for Debugger.enable before asking to pause. Bug: 775132, 900432 Change-Id: Ic2f504875b98312839235c6e32a10403757444f2 Reviewed-on: https://chromium-review.googlesource.com/c/1309213 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604299}
-
Rayan Kanso authored
The spec states that SyncManager::register should be rejected with an InvalidStateError if there is no active ServiceWorker, and NotAllowedError if the Background Sync has been disabled. https: //wicg.github.io/BackgroundSync/spec/#sync-manager-interface Change-Id: I7ef1ef99a388a61949bd0a7bfa2555ba9b7d6ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1309790Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#604298}
-
Bo Liu authored
The default for an "is empty" value should be true to better match reality. This is breaking the case where an offscreen webview is directly translated on-screen without another onDraw recording on the UI thread. The comparison in BVR::OnParentDrawConstraintsUpdated is supposed to catch this case and cause another invalidate. This CL refers to internal bug b/117560442 Change-Id: Ic03f91631780a2057931cb39cdecd04d32f52b1d Reviewed-on: https://chromium-review.googlesource.com/c/1295315 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fd20d12. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26811 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I0c25127f99cfc65d10251011351b6c8b27b5f945 Reviewed-on: https://chromium-review.googlesource.com/c/1309681 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#604296}
-
Tarun Bansal authored
This reverts commit a3bc216e. Reason for revert: Reverting the CL did not fix the flaky test. See crbug.com/900606. Original change's description: > Speculatively Revert "[url_pattern_index] Print matching rule for tracing" > > This reverts commit 1c7e7665. > > Reason for revert: > Fails test org.chromium.chrome.browser.SubresourceFilterTest#resourceFilteredClose > See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3471 > > Original change's description: > > [url_pattern_index] Print matching rule for tracing > > > > This is useful for debugging. > > > > Bug: None > > Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011 > > Reviewed-on: https://chromium-review.googlesource.com/c/1308013 > > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603990} > > TBR=jkarlin@chromium.org,csharrison@chromium.org > > Change-Id: I44e487142ab5c3477ff77945a3f2854bb9762056 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/1308904 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604073} TBR=jkarlin@chromium.org,tbansal@chromium.org,csharrison@chromium.org Bug: 900606 Change-Id: Ibf69e14dfdc650776d542ce6334102b67317fa89 Reviewed-on: https://chromium-review.googlesource.com/c/1310115Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604295}
-
Collin Baker authored
ReopenTabInProductHelp watches for certain user interactions and possibly triggers in-product help in response to them. These hooks call into this when such user events happen. Bug: 887991 Change-Id: I8f07626f07375a902f87f62dd662d51e8dbfc2ca Reviewed-on: https://chromium-review.googlesource.com/c/1306791 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#604294}
-
Takumi Fujimoto authored
The WebAuth dialog has implemented its own MD-style pulldown button with a down arrow on it. This CL moves the button class into its own file and reuses it as the source picker pulldown button in the Cast dialog. Bug: 893307 Change-Id: I565ce0e991c9f41f3b2ae6747e017dbbfec84523 Reviewed-on: https://chromium-review.googlesource.com/c/1278127 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604293}
-
Xida Chen authored
Currently at ApplyStandardPropertyValue, we give a double to FontVariationAxis which is supposed to take a float, and this could cause float-cast-overflow in corner cases. This CL does static_cast on the double value before given that to the FontVariationAxis. Bug: 900493 Change-Id: Ia4cc4b97bd81296ea1721affead42a2f482b58c0 Reviewed-on: https://chromium-review.googlesource.com/c/1309879Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604292}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed45c57d9818..e6caa9fbf6ef git log ed45c57d9818..e6caa9fbf6ef --date=short --no-merges --format='%ad %ae %s' 2018-10-31 xz4215@gmail.com export RTCRtpTransceiverInit Created with: gclient setdep -r src/third_party/webrtc@e6caa9fbf6ef The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8f960355840670a6c8ff081021fba9e288ff88e Reviewed-on: https://chromium-review.googlesource.com/c/1309550Reviewed-by:
-
Lei Zhang authored
It is only used in unit tests. Similarly remove the frame GUID. Change-Id: Idb9bf8f53ce825ea27cfc638ccd437c17e2b0e6f Reviewed-on: https://chromium-review.googlesource.com/c/1308075 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
-
Ehsan Chiniforooshan authored
We are merging TBMv1 and TBMv2 metrics and no longer have two versions of every metric. Bug: 890757 Change-Id: Ia304e7fa10d3abcf480d511751b16addab130713 Reviewed-on: https://chromium-review.googlesource.com/c/1309995 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#604289}
-
