GitLab

Bug: 778317
Change-Id: I3fae34b8d7cc9d1d3431604f9537bdb6774c76a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050138Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740537}

Bug: 634140
Change-Id: Ic09bdb2d88b59af4778bd6c1eed2afb39375bedb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041716Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740536}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5934f107c17a..88210f038eea


Created with:
  gclient setdep -r src-internal@88210f038eea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588,chromium:1041701
Tbr: jbudorick@google.com
Change-Id: I1147a8c4d526185d16496c04d28a10b0c0dd7a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051371Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740535}

https://chromium.googlesource.com/angle/angle.git/+log/72e9f4d73f65..e1ccac7ff9f0

git log 72e9f4d73f65..e1ccac7ff9f0 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 ynovikov@chromium.org Don't print INFO level log messages in Release by default.
2020-02-11 jmadill@chromium.org Vulkan: Command graph linearization (Step 5).

Created with:
  gclient setdep -r src/third_party/angle@e1ccac7ff9f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: If1693f2f63411440580844f9a3d4d3f58e872d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051137Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740534}

Since in some cases the request body was not accessed after copying,
this CL introduces ResourceRequestHead class which represents request
without request body.
The existing ResourceRequest occurrence not using request body will
be migrated to ResourceRequestHead.

Previous discussion:
"Restruct blink::ResourceRequest for streaming body upload"
http://bit.ly/2OdzJ1e

Brief summary:
class ResourceRequestHead {
 KURL kurl;
 ...
};

class ResourceRequest : public ResourceRequestHead {
 scoped_refptr<EncodedFormData> http_body_;
};

Bug: 787704
Change-Id: Ifedfeac31843cbcd5c9966fda9ac062fde26921d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032451
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740533}

Fixes warnings produced when this CL is patched in
https://crrev.com/c/2006413 which does stricter type checking on mojom
structs from colsure.

Fixed: 1047844
Change-Id: Ia1dd0159329ec697bce6d5b832abc8a70d083706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050846
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740532}

Now both render-subtree: skip-viewport-activation and skip-activation
subtrees are not in the AX subtree at all, as discussed in
https://github.com/WICG/display-locking/issues/102#issuecomment-564205445

Now only render-subtree:invisible subtrees are in the AX tree, and they
are automatically marked as offscreen because the nodes are activated
when they are on screen.

Bug: 1001930
Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740531}

(Unnecessary and also confusing ;-) )

Change-Id: I65461dc660c91d279e351ab405d1ee42cc569b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049828
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740530}

This puts all fields directly on the WifiConfigurationSpecifics
proto instead of using the legacy format of keeping them nested
in WifiConfigurationSpecificsData.

Bug: 966270
Change-Id: If26e390eba1b65411d4884316568db7db27c6bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045154
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740529}

This CL removes one difference between promotable web apps and
"Create Shortcut" web apps where Blink's understanding of the app's
scope was disabled for shortcut apps.

This makes promotable web apps and shortcut apps behave the same for
autoplay policy, keyboard events in app windows and picture in picture
mode (see uses of Document::IsInWebAppScope()). This is desirable
because promotable/non-promotable web apps are effectively identical to
the user so the fewer hidden behavioural differences the better.

Bug: 910016
Change-Id: I4d1e29566520369436b58ecdd1ba2eaefa17de31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041379
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740528}

Allowlist ping experiment is launched so this
flag is not needed anymore.

Bug: 953106
Change-Id: I9145dd18b83e90ad0661e364d730090f0318db0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051039Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740527}

This is a follow-up CL of crrev.com/c/2041678. Having a verb for
these methods is better as these will become mojo methods.

Bug: 1046335
Change-Id: I945b2da96754d6f29b8451ddd9194f9fd781757b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048623
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740526}

This refactors flex base size calculation to more explicitly match the
parts of https://drafts.csswg.org/css-flexbox/#algo-main-item . As a
result it is pretty verbose.

Bug: 845235
Change-Id: I1a49c7f153b8e0779b1d1eaa1206bd5056e9da2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986054
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740525}

Since we've moved manifest merger to using cmdline-tools, we no longer need
android_sdk/public/tools.

Bug: 1049700
Change-Id: I2946fe85a861b8e9ddc85af357953007259e7977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044885
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740524}

https://chromium.googlesource.com/catapult.git/+log/5b39823026a7..601fc962a276

git log 5b39823026a7..601fc962a276 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 dproy@chromium.org Add origin trial token for 127.0.0.1:8003

Created with:
  gclient setdep -r src/third_party/catapult@601fc962a276

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1036492
Tbr: oysteine@google.com
Change-Id: If8c94e5f938797b683b08fbd0aaa913f707fe091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740523}

Bug: 992823
Change-Id: Id4c2453cce71d969b92d19ec78f1f28d6424e5eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045280
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740522}

Just set state back to kRequestSent when auth credentials are
supplied by the client.

Change-Id: I8f344fe8deba0cc5fcbf04c6d4d412f2a83878d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051295Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740521}

Replace them with base::OnceCallback/base::RepeatingCallback and
base::BindOnce()/base::BindRepeating(), respectively.

Bug: 1007800
Change-Id: Id5d7312a5882b9acd3168b255ba67048bfc37908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050622Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740520}

Blink allows use of the //base histogram helpers, so switch away from
the Blink-specific histogram helpers and standardize on //base. The
long-term goal is to remove the Blink helpers, which differ from the
//base ones in some interesting and surprising ways.

Miscellaneous cleanup:
- use the histogram functions where appropriate (i.e. for metrics that
  aren't recorded on performance-critical paths)
- simplify enum histogram recording by changing the enum metric to be
  an enum class and defining kMaxValue where needed.

Bug: 742517, 1047547
Change-Id: Ie82d26a8866d005e481a67614b2756a03115d58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046541
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740519}

These are all the tests I can find that were likely creating desktop
icons every time the test was run.

Bug: 1046866
Fixed: 1046866
Change-Id: I10e90c313ff8ff2ab4fda288990be4bd500f895b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049563Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740518}

https://pdfium.googlesource.com/pdfium.git/+log/4a0f1a01ac8a..d9bd62fafb66

git log 4a0f1a01ac8a..d9bd62fafb66 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 tsepez@chromium.org Deduplicate a switch statement in cpdfsdk_appstream.cpp.
2020-02-12 tsepez@chromium.org Remove some unused methods and members from CFX_CSSSyntaxParser.
2020-02-11 tsepez@chromium.org Provide test for CJX_Packet methods from JavaScript.
2020-02-11 thestig@chromium.org Add a test case for a FPDFText_GetLooseCharBox() bug.

Created with:
  gclient setdep -r src/third_party/pdfium@d9bd62fafb66

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Id4da242671888f96d565c8c0d4c5f11203a2630c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050452Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740517}

Some clients deliberately send null/invalid handles, so do not require
the handle to be valid to pass deserialization. Callers will check that
the handle is a valid type before using it.

Bug: 778317
Change-Id: If7eb5ba939245abe694430fb158d4a8e499b248f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051184Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740516}

Two questions for metrics team:

 1. One of the metrics uses an existing enum,
    PersistentPrefStore::PrefReadError, which doesn't have a kMaxValue.
    Instead, I've used the old three-argument version of the histogram
    macro. Is this okay, or should I make my own enum and use the
    two-argument version?

 2. I've added the histograms as StructuredMetrics.*, but I'm hesitant
    to create a new top-level namespace. Would UMA.StructuredMetrics.*
    be better?

Bug: 1016655
Change-Id: I6f51e32100b3e379a01f4e8d2136ba9d4a8d0903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035475
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740515}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b956ec9468e8..5934f107c17a


Created with:
  gclient setdep -r src-internal@5934f107c17a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1041701,chromium:1050994
Tbr: jbudorick@google.com
Change-Id: I76d1040852468980a78c41670ca37b98646a513a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050450Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740514}

All uses of this function have already been converted to use
ChildProcessSecurityPolicyImpl::Handle instead.

Bug: 943887
Change-Id: I8daa6b35f978c9b31fe751c7d1f6b7f82fa10e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047512Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740513}

This is still relevant, as we want to ensure nothing degrades when upreving LibAssistant.

Bug: 1041516
Change-Id: I33d7ad0525d60ba5bda9ece1a491635ee5aa8faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050580Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740512}

A bounds in pixel and a bounds in DIP are compared.
It causes InputMethodSurface call OnTouchableBoundsChanged() always.

Bug: 1042549
Change-Id: I1cd0fafd8e754aced022acd2f3f7aa61c6ce7fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043337
Auto-Submit: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740511}

Use static_assert to make it more obvious when Enum::kMaxValue isn't
defined. Otherwise, it just fails with tons of compile errors in the
middle of logging macro soup.

Bug: 1047547
Change-Id: I0153f8af1770159967d170fe3a8025a5dfed3a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045792Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740510}

password_protection_service and cache_manager were moved to
services_delegate base class, but they are not shutdown explicitly in
services_delegate_android.

In this CL, move them to be shutdown in the base class, and let the
derived classes call the base class method.

Bug: 1050084
Change-Id: I30a70bb05432aa820073520b3fedfba694064be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050746Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740509}

Change-Id: Id48f7597a4bd1bbc441e74b02abf1eda9415c1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051007Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740508}

Bug: 1051237
Change-Id: I546c51e9a6dd2de0ddb2683811de252cb157b0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051296Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740507}

Adds the --no-sandbox flag to the following tests on Win10 x64 Debug
(NVIDIA):
1. info_collection_tests
2. depth_capture_tests
3. gpu_process_launch_tests
4. context_lost_tests

This will hopefully give us more information about why the renderer
process is flakily crashing/hanging without producing any minidumps.

Also drive-by removes a --no-sandbox addition to another GPU test on the
same bot which is no longer necessary.

TBR=kbr@chromium.org

Bug: 1007013
Change-Id: I9bbcc7a48e6eee61eccd8fb9f4bb40fa5e7954f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050146Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740506}

For the bug bash, if time limit is set for chrome android
app id, then use it for chromeos chrome app.

Bug: 1015661
Change-Id: I578114daa291a8e85ea27fd56712f0760a3f9f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050037Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740505}

Fixed: 1050648
Change-Id: Iac07909fdccd3cd9536dbfd58b25a8317f037867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050933Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740504}

Adds a bunch of style rule changes for the dialog header, managed by
the CSS class 'files-ng'.

Moved input styles from main.html since files-ng uses different colors.

Note: text-transform is set to 'none' for the cancel selection
button to retain the same behavior for the not files-ng styling.

Bug: 992823
Change-Id: I153d6e2e9e4268a77bbe3d06941e85a50f5e3650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984785
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740503}

This test was marked flaky in crbug.com/660185 and it seems from
the bug that many others were also flaky at the same time. Perhaps
it was the victim of something else and never got re-enabled. The
test itself looks fine, likely suffers from antialiasing around
diagonals, but should be ok. Let's find out. From patches in this
CL, it does appear that it has some flakiness on Windows only,
which is covered by crbug.com/953591. Seems ok on Mac/Linux.

Bug: 660185
Change-Id: I726c486f3db080141ae7c755890841c2d990d6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047490
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740502}

The [1] CL enabled the FormControlsRefresh feature by default for
Windows, Linux, and ChromeOS, which changed many layout tests. This
is the final patch cleaning up after the rebaseline effort.

One test just needed a modification (button-with-float), while the
other four are test issues. I've created bugs for each and marked
them in TestExpectations.

[1] http://crrev.com/c/1967608

Bug: 1035582
Change-Id: I727aec7fe00fd1ced8e1ca6e84739710a0fbf55c
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028302
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740501}

Some volumes can be displayed in the file list in addition to
directory tree. This CL enable their special icons in the file list new
design.

Bug: 992821
Change-Id: Ieee8bc47b2a29ce1956bee6ce6a78a2ddd04c6ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043519
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740500}

This makes the close-x keyboard focusable in most cases. This serves
a11y users who can detect its presence and use it, like other buttons,
without the Esc shortcut.

Adds the Close accessibility name back under Windows where the tooltip
is removed in favor of ones generated by the platform from HTCLOSE.

Bug: chromium:1019873, chromium:1049667, chromium:1049722
Change-Id: Ib33b992c1085d9368cc7573785b21e1ff05a9a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047454
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740499}

Use '' (single quote) for string literals for consistency.
Change map-based branching to switch statement to make it explicit for undefined calls.

Change-Id: Ie8d6f6d27eb017bd1588f9c4a1bf528c855bc2f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041373Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Dong-Hwi Lee <leedh@google.com>
Cr-Commit-Position: refs/heads/master@{#740498}