- 19 Nov, 2018 40 commits
-
-
Steven Bennetts authored
This simplifies the public KeybardController interface and helps prepare for supporting different InputMethodKeyboardController options in Mash. Bug: 845780 Change-Id: I8d857ca67c8ea57de76036ae1487abd9dbbbd91a Reviewed-on: https://chromium-review.googlesource.com/c/1337287Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609412}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cd22b3155708..d652ed3029eb git log cd22b3155708..d652ed3029eb --date=short --no-merges --format='%ad %ae %s' 2018-11-19 alanbaker@google.com Vulkan memory model: semantics validation Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d652ed3029eb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I60bf91aa2ddcbd3583ad6b79a20ec2421c158dcd Reviewed-on: https://chromium-review.googlesource.com/c/1342478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609411}
-
Oliver Renault authored
Allow mouse cursor to be a green plus when dropping items to desktop Bug: 905238 Change-Id: I90a6f7156e681271f577f1f604f1d75ada4beba2 Reviewed-on: https://chromium-review.googlesource.com/c/1334994Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609410}
-
Adrienne Walker authored
This is not something that has been used for some time. Change-Id: I25ad3a53653fc7734a40ae92851e8ed61cd6908b Reviewed-on: https://chromium-review.googlesource.com/c/1342938Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#609409}
-
Sammie Quon authored
This failed previously because when SnapWindow is called after ToggleOverview, it ends the overview start animations, which then activates the hidden overview textfield. This causes OnWindowActivated to be called before SnapWindow has finished, so IsSplitViewModeActive() still returns false. Test: tested with DCHECKS enabled Bug: 906707 Change-Id: Ic7b99eb8642f8bf1cd1badaa6fa6c981127987a7 Reviewed-on: https://chromium-review.googlesource.com/c/1342807 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609408}
-
Rob Buis authored
Setting document.title should have no effect for non SVG/HTML documents, see https://html.spec.whatwg.org/multipage/dom.html#document.title. Behavior matches Firefox. Bug: 906038 Change-Id: I724abf9ecd711536d71ad95ab45c72230c2e87b6 Reviewed-on: https://chromium-review.googlesource.com/c/1339959 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609407}
-
Yuri Wiitala authored
As documented in bug 847487, the DCHECK was a false alarm, being caused by acceptable amounts of integer truncation rounding error. This change removes the DCHECK, and also clarifies the logic a bit further: In the case where even the rounding error causes the |next_generate_time_| to be before |now|, that is close enough to warrant that a "skip-ahead" correction be made. Testing: Confirmed the logic works by manually freezing the audio process during an audio loopback session, observing recovery, and also examining the "GenerateMoreAudio Is Behind" TRACE_EVENTs (see crbug for file attachment). Bug: 847487 Change-Id: If19b3abd9745e28d9684965bde2364447722b5bc Reviewed-on: https://chromium-review.googlesource.com/c/1341155Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609406}
-
Collin Baker authored
This adds a class, ReopenTabPromoController, that manages display of the reopen tab in-product help promo, and expands the interfaces of AppMenu and AppMenuButton to allow this. Change-Id: I78431981a21d432778aceb65d3aa17642164bc14 Bug: 887991 Reviewed-on: https://chromium-review.googlesource.com/c/1334937 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609405}
-
Etienne Bergeron authored
The CPU sampling profiler trace events were added on windows to investigate some strange patterns happening in the field. We have enough data to make some analysis over it. There are plan to add sampling profiler to renderers, io-thread and so on. This will increase the amount of trace events in a trace and it's better to avoid producing events that are not needed. We are moving these trace events to a debug category. This will allow us to make a specific slow-reports scenario if we still want to analyze the sampling profiler and it's behavior. R=wittman@chromium.org Change-Id: If348399336e60c4aa511ea783aec4c92d0575462 Reviewed-on: https://chromium-review.googlesource.com/c/1340908Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609404}
-
Hector Carmona authored
Only users in a group will be able to ping finch to make retention analysis easier. Groups are: - Specified by finch - Incremented with each new version - Not reused - Cleared out when experiment ends Bug: 904051 Change-Id: I726b43cd122969447cd6d2e3e207b12a5e9c97b4 Reviewed-on: https://chromium-review.googlesource.com/c/1330899Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#609403}
-
Donn Denman authored
This test is now flaking a lot on all configurations of Android. BUG=620014 TBR=tdrainer@ Change-Id: Ib32eda48f964ddca7a05cc0ae6de7cf4ec9078b3 Reviewed-on: https://chromium-review.googlesource.com/c/1341151Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609402}
-
Alex Newcomer authored
For ash/app_list. Bug: 906684 Change-Id: I8b3b79ba1e4220d0c2a3e3df8e822300ac6f63a7 Reviewed-on: https://chromium-review.googlesource.com/c/1342621Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#609401}
-
Katie D authored
This completes work from go/a11y-arc++-window-mapping, but does not yet remove the restriction that we only look at the interesting subtree. That restriction is still valid because we only want one root node ID. If we assume that there is only one, we can remove this restriction. Bug: 891483 Change-Id: Ib9581be294de88c6ed4c4e9934536859edc9b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/1319858 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609400}
-
Donn Denman authored
TBR=tedchoc@chromium.org Change-Id: I7f70d7ec1adc281a8e0750690c2d9ec75d7ad307 Reviewed-on: https://chromium-review.googlesource.com/c/1342804 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#609399}
-
Eugene But authored
This is a step in multistep refactoring. The next steps will be: 1.) web::NavigationContext::URL is never set to placeholder URL and always represents navigation URL 2.) Same web::NavigationContext will be reused for placeholder navigation to extend it's lifetime. 3.) WebStateObserver::DidFinishNavigation will be caller after placeholder navigation is finished and will use original web::NavigationContext passed to WebStateObserver::DidStartNavigation This will partially fix crbug.com/903497 and will call WebStateObserver::DidFinishNavigation after committed URL actually changed. Bug: 903497 Change-Id: Ib6ba96d664ac352d038787aa74ac844d07282789 Reviewed-on: https://chromium-review.googlesource.com/c/1331044Reviewed-by:Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#609398}
-
Chris Harrelson authored
This reverts commit ab6eb7c4, with fix to Mac. Mac baselines have been updated. Tbr: pdr@chromium.org Change-Id: Iabb7b3a53965d2457f7a38088c90d4efb4461332 Reviewed-on: https://chromium-review.googlesource.com/c/1340875Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609397}
-
Charlie Harrison authored
Bug: None Change-Id: I83a7dad87ee1b937ad79e92a13ce382c22b76075 Reviewed-on: https://chromium-review.googlesource.com/c/1338462 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609396}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Ic0d2f8a09f1a1e80b0d51fbc896bc994d29433f6 Reviewed-on: https://chromium-review.googlesource.com/c/1336253 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#609395}
-
Rayan Kanso authored
Also add an upload endpoint to test Background Fetch uploads. Bug: 774054 Change-Id: I305e9f43b5d2e77a8e78e9e460e8398d771b03e0 Reviewed-on: https://chromium-review.googlesource.com/c/1341923 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be3e8ee6b10b..baafd0234bc7 Created with: gclient setdep -r src-internal@baafd0234bc7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibbaf3328e19c430cc12ce4856b81737627d5c327 Reviewed-on: https://chromium-review.googlesource.com/c/1342797Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609393}
-
Shawn Gallea authored
Move pointer_gestures interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I5f33889794bc1ff3645f6bb0006fd9b8c87de5df Reviewed-on: https://chromium-review.googlesource.com/c/1324146 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#609392}
-
Elad Alon authored
Bug: None Change-Id: I4c4f9eeea68bed082d9f44035b56a2a8a4a6111c Reviewed-on: https://chromium-review.googlesource.com/c/1341845 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL introduces a way to intercept all PendingIntents from notification with broadcast receivers. In the following CL we will add metrics recording into those broadcast receivers. This class will eventually be used in ChromeNotificationBuilder. Also we introduce a test that uses UIAutomator to actually click on a notification in test instead of mocking Android notification API. And verify the BroadcastReceiver interception. Bug: 898269 Change-Id: I16e52f7036db4d30093517e16373547d5e1e862c Reviewed-on: https://chromium-review.googlesource.com/c/1327803 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#609390}
-
danakj authored
A frozen RenderWidget must still be made visible when the RenderView is made visible (background tab becoming foreground) because RenderView reads the RenderWidget to determine the Page visibility (even though we have IPCs to the RenderView telling it what to use~~!). This is bad but we can't leave us crashing in Canary so avoid chaning compositor visibility even though the RenderWidget is changing, and the compositor's will catch up when unfreezing. R=ajwong@chromium.org, piman@chromium.org Change-Id: Idbc81efacd331c227d01ad61e182ccdf98bf2c42 Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1340864 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609389}
-
Liquan(Max) Gu authored
invocation In the current implementation, we assumed that whenever callback is invoked, there must be at least one records needing to assign swap time to itself. However, this ignored the possibily that nodes may be deleted between a callback is registered and invoked. Because the assumption is violated, we should remove the dcheck. Bug: 869924 Change-Id: Ifdfda96fd2260f85add1c2a78ad48cff22cd0dbf Reviewed-on: https://chromium-review.googlesource.com/c/1340966 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#609388}
-
Alex Clarke authored
A previous patch inadvertantly changed the code to return the set of PhishingClassifierDelegates by value. This lead to a crash because all modifications to the set where only applied to the local copy, and when PhishingClassifierDelegate::SetPhishingScorer got called, pending classifications (which stashed a raw pointer to the deleted data) where not cancelled. Bug: 905598 Change-Id: Id629c460b1fba66605565b8f17b6bd1d1fc6cf33 Reviewed-on: https://chromium-review.googlesource.com/c/1341520 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609387}
-
Wenzhao Zang authored
Bug: 846033 Change-Id: I2b1892437d44edd47245addd1c14901dad6f0d4b Reviewed-on: https://chromium-review.googlesource.com/c/1342803 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609386}
-
David 'Digit' Turner authored
This change ensures that all English locale pak files (i.e. en-US.pak and en-GB.pak) are stored inside an app bundle into a directory named: assets/fallback-locales/ This ensures that said .pak files are always stored in the base module split APK, and thus available on all Chrome installs, after any system locale change. This prevents Chrome from crashing on startup under rare circumstances (see related bug for details). Testing was performed manually because we don't have a good regression test suite that can change the device's system locale programmatically (see http://crbug.com/904360 for this). Following these steps: 1) Set device's language to Spanish 2) Ensure Chrome is not installed, then install the bundle. 3) Start Chrome. It displays its UI in Spanish. 4) Change system language to Slovenčina, and *remove* Spanish from the list of system languages. 5) Start Chrome. It displays its UI in English (the fallback) instead of crashing. English is chosen because it is the fallback language that the Android framework actually choses when the application doesn't have any resources compatible with the current system language. BUG=905725 R=agrieve@chromium.org,estevenson@chromium.org,yfriedman@chromium.org,tiborg@chromium.org,tedchoc@chromium.org Change-Id: I2c1f53a805122b6e48fb5105c1d9aa8c6262fa1d Reviewed-on: https://chromium-review.googlesource.com/c/1340303Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#609385}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/774fe563c663..8a0fb48a56d6 git log 774fe563c663..8a0fb48a56d6 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 jmadill@chromium.org Vulkan: Suppress functional.shaders.invariance.* on NV. Created with: gclient setdep -r src/third_party/angle@8a0fb48a56d6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I82113145611980e17062a58edf73a970db75077c Reviewed-on: https://chromium-review.googlesource.com/c/1342777Reviewed-by:
-
jonross authored
Currently when a frame is evicted, we immediately generate a new viz::LocalSurfaceId. This has been inflating our statistics for embedding times. This is a side-effect of how Window::UpdateLocalSurfaceIdFromEmbeddedClient uses null LocalSurfaceIds to represent generate a new one. This change adds a new InvalidateLocalSurfaceId for use during Frame Eviction. RenderWidgetHostViewAura has also been updated to verify if the current LocalSurfaceId is valid when beginning to show a currently evicted frame. So that it can allocate a new one. Bug: 655231 Change-Id: Iafb81333dfeb230311ef5ce19b81aa0d96d05061 Reviewed-on: https://chromium-review.googlesource.com/c/1336438Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#609383}
-
Jun Cai authored
This is a follow-up CL from the comments at: https://chromium-review.googlesource.com/c/chromium/src/+/1274585/11 This CL uses ifdef "using" decl to use web::TestWebThreadBundle on iOS as the equivalent to content::TestBrowserThreadBundle. Bug: 898307 Change-Id: I35620aade68dc2b6e9855be49afabd5fcd6dfd5d Reviewed-on: https://chromium-review.googlesource.com/c/1313450Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609382}
-
Sergey Ulanov authored
Also updated frame_imple_browsertest.cc not to use deprecated version of set_error_handler(). CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=fdegans@chromium.org Change-Id: Iccba408e0080b9fb70edcd6b64c51737bf8f4851 Reviewed-on: https://chromium-review.googlesource.com/c/1342599 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609381}
-
Joshua Pawlicki authored
Change-Id: I7db9d09d2ccf6cfa8ba11302464a6fb316aff79b Reviewed-on: https://chromium-review.googlesource.com/c/1342767Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL is 1) a reland of r604955 + 2) fixes. Original CL description follows below. Summary ======= This CL makes layout tests use the default site isolation from the platform they are run on (instead of opting out of strict site isolation via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation). Additionally, on platforms where strict site isolation is enabled, layout tests opt into slightly stricter isolation by enabling isolation of same-site origins used by Web Platform Tests - this ensures that features covered by WPT also get sufficient coverage of out-of-process iframes (OOPIFs). After this CL, expectations for tests that differ in behavior with and without OOPIFs are being moved from LayoutTests/FlagExpectations/site-per-process to: - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite) - LayoutTests/virtual/not-site-per-process/README.md - LayoutTests/TestExpectations and LayoutTests/NeverFixTests ("Site Isolation failures" section) Desirability ============ The CL helps with the following: - Focusing on testing the mode that is actually shipped to end users - Helping ensure that newly developed features get site-per-process coverage without having to set up a separate step (i.e. it is sufficient to set-up a bot that runs layout tests with --enable-features=NewFeature without also having to have a separate test step for runing layout tests with *both* --enable-features=NewFeature *and* --site-per-process This CL does *not* help with reducing requirements for CQ capacity, because we need to maintain a separate not_site_per_process_webkit_layout_tests step to make sure that tests pass without isolation (which is the mode Chrome ships on Android). Also note that layout test coverage on Android is very sparse - see https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion Preserving test coverage ======================== Most tests ---------- The CL preserves covering most layout tests with and without OOPIFs, by relying on the fact that CQ/waterfall run layout tests on both kinds of platforms - ones that default to strict site isolation (desktop platforms) and ones that default to no site isolation (Android). Tests that used to be excluded FlagExpectations/site-per-process ---------------------------------------------------------------- Around 40 tests fail when run in presence of OOPIFs. Such tests are disabled by this CL by moving test expectations from FlagExpectations/site-per-process into the main TestExpectations file. The CL preserves non-OOPIF test coverage provided by the disabled tests by introducing virtual/not-site-per-process directory which runs all such tests with site isolation disabled. Using a virtual test suites for preserving the test coverage relies on the ability to have separate test expectations for these tests (i.e. relying on the fact that disabling these tests in TestExpectations doesn't disable their virtual/not-site-per-process equivalents). Note that the CL keeps isolating "oopif.test" site even in virtual/not-site-per-process suite. This site should only be used by tests that require an OOPIF. Preserving site-per-process-specific test expectations ------------------------------------------------------ Some tests have site-per-process-specific expectations: - http/tests/inspector-protocol/network/security-info-on-response.js - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js The tests above highlight that cross-origin cookies are not displayed in site-per-process mode (a known regression tracked by https://crbug.com/849483). This CL preserves expectations and coverage by shuffling things around: - old, main expectation -> android expectation - old, site-per-process expectation -> main expectation There is one additional test with site-per-process-specific expectations: - external/wpt/dom/events/EventListener-addEventListener.sub.window.js Unlike the other 2 tests, it seems less important to preserve exact test expectations for the case when the test fails with Site Isolation. Therefore this test is covered by virtual/not-site-per-process test suite and an expectation for this test is added to the main TestExpectations. Lost test coverage ------------------ Even with extra caution described above, some test coverage may be lost: - Features covered by tests only on one kind of platform (e.g. disabled on Android) are at risk of losing OOPIF or non-OOPIF coverage. - Before this CL, site-per-process was also applied to all other `virtual/...` test suites. After this CL, `virtual/not-site-per-process` will not provide such coverage. Cleaned up test expectations ---------------------------- Some additional test expectations clean-up is done, while preserving test coverage: - The http/tests/perf/large-inlined-script.html test has been already present in `SlowTests` and therefore I didn't include this test in the new `virtual/not-site-per-process` suite. - The http/tests/devtools/network/network-datareceived.js test was already marked as expecting a `[Failure]` in TestExpectations and therefore I didn't include this test in the new `virtual/not-site-per-process` suite. - The http/tests/devtools/console-cross-origin-iframe-logging.js test was already marked as `[Timeout]` in the old TestExpectations but for Win only. Since I can repro a timeout on Linux (with and without site isolation), I just extended the old expectation to all platforms and I didn't include this test in the new `virtual/not-site-per-process` suite. I also removed the test from SlowTests (since timeouts in the test are not expected everywhere). Bug: 870761, 477150 Tbr: alexmos@chromium.org Change-Id: If3c6fbc58ccdac8bc64a81963238db13c0bff391 Reviewed-on: https://chromium-review.googlesource.com/c/1318750 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609379}
-
David Bokan authored
This crash was occurring because we added an element to the scroll chain that didn't have a ScrollableArea. This occurs on an iframe because we promote the iframe to be the effective root scroller (due to it filling the viewport). However, iframe elements don't have a ScrollableArea so this would crash when we bubble a logical scroll. The condition for always adding the root scroller is incorrect. We want to always add the _global_ root scroller, not the effective. The global is where the apply scroll callback is registered which is what correctly does pinch-zoom panning and overscroll glow. The global root scroller is guaranteed to always have a ScrollableArea. Bug: 904247 Change-Id: I14080a74ff3aa5a85347076e74edbc53b2fb9cfc Reviewed-on: https://chromium-review.googlesource.com/c/1340610Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609378}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a58355c49753..dac70cc74650 git log a58355c49753..dac70cc74650 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@dac70cc74650 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6431c9dea1f733127e0082d062d4f41a3a7718cf Reviewed-on: https://chromium-review.googlesource.com/c/1342479Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7376330d11e..a1211832046d git log f7376330d11e..a1211832046d --date=short --no-merges --format='%ad %ae %s' 2018-11-19 halcanary@google.com SkPDF: move image serialization over to new immediate mode. 2018-11-19 mtklein@google.com clean up SkBitmapProcState a bit 2018-11-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-19 bsalomon@google.com When outsetting for rect blur fast path use abs of scale factors. 2018-11-19 bsalomon@google.com Add single thread assertions to GrResourceCache functions called by GrGpuResource 2018-11-19 jvanverth@google.com Reland "Remove use of integers for atlas indexing" 2018-11-19 brianosman@google.com Use GrVertexWriter in GrDashOp 2018-11-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a1211832046d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:899512 TBR=csmartdalton@chromium.org Change-Id: I076eaa7f924b584032ac32413163876a28cfb9ac Reviewed-on: https://chromium-review.googlesource.com/c/1342009Reviewed-by:
-
Avi Drissman authored
We haven’t supported macOS 10.6 in years. BUG=none Change-Id: Ie19b16d0b2417f292b8c763ceeb412e73bdaa95f Reviewed-on: https://chromium-review.googlesource.com/c/1342799Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609375}
-
Patrick Monette authored
This allows us to use the hashes as value types with convenient assignment and comparison operators. Also add myself as owner of the third_party_dlls subdirectory as pennymac@chromium.org no longer works on Chrome. Change-Id: I66838fd4890637bf53faa22fbcbbfcae6456b583 Reviewed-on: https://chromium-review.googlesource.com/c/1340967Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#609374}
-
Eric Orth authored
Changed addresses_ to an Optional and added additional optional fields for text results (eg for TXT records) and hostname results (eg for SRV or PTR records). Deliberately avoided assumptions that only one result field could be non-nullopt at at time (but no constructor currently allows creating it) because there's nothing wrong with some query having results of multiple types. Eg, we may in the future choose to pull cannonname out of AddressList and set it as a hostname result. A subsequent CL will alter HostResolverImpl to allow querying, caching, and returning non-address types, and it will also use HostCache::Entry internally (and only internally) as a results container. For now, in this CL, most of the code dealing with HostCache results will just assume Entry::addresses() always has a value. Bug: 846423 Change-Id: I62e177452bf89e5931f75a74448f9de70b7f2357 Reviewed-on: https://chromium-review.googlesource.com/c/1331143 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609373}
-
