- 04 Sep, 2019 40 commits
-
-
Roger Tawa authored
This policy is checked if scanning for malware on uploads is enabled. Only URLs whose host is in this list will be scanned. Also adds enum values to SendFilesForMalwareCheck to handle case of malware check during uploads. Bug: 991553 Change-Id: I55dd5529a0438cf375272c808102c2b9a8fe4f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782513 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693142}
-
Nico Weber authored
Bug: 997673 Change-Id: Ibe3c484630173772f7dc457ee85856b68ab84a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784617 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#693141}
-
Lutz Justen authored
First batch of KerberosCredentialsManager unit tests. Also adds a test interface to FakeKerberosClient to - Set the task delay (tests set it to 0 to speed up the tests), - Record which functions are called for testing. BUG=chromium:952251 TEST=Unit tests succeed Change-Id: I14b3790d1dfb9809e0bc6b7b59a9b58d196e1929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760951 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#693140}
-
Michael Spang authored
GN doesn't understand conditional includes: ERROR at //chrome/utility/services.cc:74:11: Include not allowed. ^--------------------------------------------------------------------- It is not in any dependency of //chrome/utility:utility The include file is in the target(s): //components/services/pdf_compositor/public/mojom:mojom //components/services/pdf_compositor/public/mojom:mojom__generator at least one of which should somehow be reachable. Bug: 1000645, b/140414631 Change-Id: I94ab9df85f9c50f1999acec999e8c06a93eea6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784098 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693139}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b132e5cc..2e9e9171 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a23301c78f860c8263ade5f2250cf579b0f6068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784446Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693138}
-
Mark Cogan authored
This CL set up the iOS app configuration needed for multi-window. This includes (a) a bunch of specific Info.plist additions, and (b) a storyboard file to be used as a default by each scene. These files are added if the gn argument ios_enable_multi_window is set to 'true'. By default it is 'false'. Note that enabling this arg will, in Chromium's current state, cause the app to launch with an empty window and do nothing (because there's no class to load as the scene delegate). Follow-up CLs will fill that gap, but they need the plist and storyboard in place first. Change-Id: I61e153cd2d5d5df12bbd6347151f864e44a2d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782815 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693137}
-
Andrei Chulkov authored
This CL adds Java code that retrieves the "story" parameter from the PasswordManagerOnboardingAndroid feature and sets sets the correct image accordingly. Bug: 983445 Change-Id: I53e046562faac7b26fe9f81feaad87786444a563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781642 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693136}
-
Yasmin authored
Rename ClickToCallDialogtype to be used by other sharing features. Bug: 988461 Change-Id: I463868c7aae091a00cdd69cf139f9b84ca425ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778542 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#693135}
-
Julie Jeongeun Kim authored
This CL converts HyphenationRequest and HyphenationPtr to new Mojo types. Bug: 955171, 978694 Change-Id: I3be08953612cc01ea30d1f2ed65ea971df263b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778898 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693134}
-
Dave Tapuska authored
No shadowing was enabled for base code but not the unittests. Add the config to the unittest component as well and fix issues. BUG=794619 Change-Id: Ia23a007d8fc66d4ad6a2f1682d09b31894caae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776791Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/154adeb6c998..630b14f4812c Created with: gclient setdep -r src-internal@630b14f4812c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8ce43ac75d25af00466495089e8f7df8cda2057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693132}
-
Xiaocheng Hu authored
This patch fixes a regression introduced by crrev.com/c/1744799. Before the regression, the creator divides the pixel value of the length by the zooming after. The above patch incorrectly changed that into multiplication, which is the regression. This patch changes that back into a division. Bug: 999875 Change-Id: Ic5f07c2af52cdc94bde8b355e5c30a7f01c0a49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783638 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chrome://flagsdalyk authored
The flag will only be shown on Mac OS, Windows, Chrome OS, and Android. Bug: 985589 Change-Id: I816e70d3cd2941cb10a041c4c2403782ed5efc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779078Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#693130}
-
Findit authored
This reverts commit d66ef7a9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 693032 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2NmVmN2E5ZDVkYTJhOWZlODRkYTI0OTcyMTJmYjdiOWY1OTlhOGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/14206 Sample Failed Step: interactive_ui_tests Original change's description: > Cleanup the usage of force-use-chrome-camera-app flag > > This CL removes all the usage of force-use-chrome-camera-app since we > make CCA the default camera app started from R76. > > Bug: b/140463175, 953690 > Test: Chrome can be compiled successfully > > Change-Id: Ib5430fc06c7c7420a3c04f21e3d0b5dbeeb4ec47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784023 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693032} Change-Id: I7fd07f753473086ed02683fadb4e2d89e0ad2a56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/140463175, 953690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783523 Cr-Commit-Position: refs/heads/master@{#693129}
-
Roger Tawa authored
Bug: None Change-Id: I39b0e7e6817dbba8318b7447178485a23371a77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782727Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693128}
-
Rune Lillesveen authored
There's no need to schedule descendant invalidation sets on display:none elements. If that element is displayed on the next lifecycle update, RecalcStyle will make sure descendants will get their ComputedStyles if necessary. Bug: 972752 Change-Id: I60a980eecfccc43ff33bd4e050d223aced6383f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783142Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#693127}
-
Pavel Shmakov authored
Bug: 985331 Change-Id: Ib28b7fbdbcc9ad7f888f4f3527f89b8410294cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757930Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#693126}
-
Arthur Hemery authored
This CL creates a new fyi bot named "android-bfcache-rel", and has it run bfcache_gtests. These tests are already run on linux by linux-bfcache-rel. This will ease the monitoring of failing tests during the development of the back forward cache project. Bug: 976218 Change-Id: I7bc3b9598f9e32e6a861abb7d61be1f55965b2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782561Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693125}
-
Miyoung Shin authored
This CL converts PaymentManager{Ptr, Request} in content and blink to the new Mojo types. Bug: 955171, 978694 Change-Id: I09c3019d634a764e1ed7d02cb45a23e550087a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780100Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#693124}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4c187a619111..febf7e9ef536 git log 4c187a619111..febf7e9ef536 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 cwallez@chromium.org Use agreed upon include paths for spirv-cross (#795) Created with: gclient setdep -r src/third_party/shaderc/src@febf7e9ef536 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ia8877f0db4008c3694d61ec820b628ec1d27d0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693123}
-
Stephane Zermatten authored
It is now possible to execute "close_all_tabs" while showing a tab, that is, while in a layout different from the overview, on a phone, such as with a tab open. This works, but doesn't look good as there's no animation registered for this case: the tab just close. Background: go/chrome-direct-actions This change proposes switching to the overview layout just before closing all tab and then switching to the normal close all tab animation and behavior. Bug: b/140370009 Change-Id: I92e6c683f3f8212c2e4a77695e7101c5edad407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781425 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693122}
-
Mikel Astiz authored
The way ProfileSyncService determines whether the user is signed in depends on refresh tokens being loaded, for secondary accounts. This means, DISABLE_REASON_NOT_SIGNED_IN can report false positives during startup, and should not be honored to clear sync metadata, until refresh tokens are loaded and the signed-out state is determined reliably. This fixes cache GUIDs being reset upon every restart for secondary accounts. Bug: 955989 Change-Id: Ia149a940046da544f16c18d90cc5b5435c8968f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782805Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693121}
-
Aaron Tagliaboschi authored
If "RunUntilRedirect" or "RunUntilAuthRequired" is run and the request unexpectedly finishes, TestDelegate will crash for trying to run the "on_complete_" closure, which would be null, and crashes with a very unhelpful message. A DCHECK and comment have been added that should make The issue a little more clear. Bug: 1000299 Change-Id: I537e8f2abc7754323bdaedcd7ee5d802ea674c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782502Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#693120}
-
Jan Wilken Dörrie authored
TBR=blundell@chromium.org Bug: 990844 Change-Id: I437d36aa0908ae4600feef32e3e00bd9a81a6b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782849Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693119}
-
Rayan Kanso authored
- Create an abstract message handler and move the Android specific implementation to its own file. - Use the NotificationDisplayService for the Desktop implementation. In the Desktop Handler: - Show a notification that the text has been shared. - Any click on the notification will dismiss it (or it will dismiss itself after a few seconds) - It uses a newly introduced `devices` material UI icon. Bug: 996325 Change-Id: I7c5de5b532d1b6f91169403ae305c5a0a43d0441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778482Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/042f99bcb1d4..b1de0c8d6a36 git log 042f99bcb1d4..b1de0c8d6a36 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 hjd@google.com Merge "ui: Improve controls help" Created with: gclient setdep -r src/third_party/perfetto@b1de0c8d6a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iaaa56abec2dff3769b99cec73d30b9d5cfb79399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783843Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f26909d1..b132e5cc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6ab5c65936986a2f1d29cc9455d2a3049ca77fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784440Reviewed-by:
-
Rayan Kanso authored
As per 5.3.1.2 in the spec: https://rayankans.github.io/content-index/spec/#content-index-add Bug: 973844 Change-Id: Ib69b56b2f1def930ac62d40b4175a8bd65f964bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781679Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693115}
-
Arnaud Mandy authored
Adding test object as parameter to facilitate the use testharness.js API. Bug: 976596 Change-Id: I26e529bda547504d2a107f86b71d61156cc6f943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778619Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#693114}
-
Raphael Kubo da Costa authored
It documents how the current Blink code works, how it connects to the code in //content, //services/device and //chrome, as well as the current permission model for wake locks. Bug: 257511 Change-Id: Id01e1d0029708abbf113cff6e8a8c43af6e92d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778602 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#693113}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fbc146e97f30..cdb4549b571b git log fbc146e97f30..cdb4549b571b --date=short --no-merges --format='%ad %ae %s' 2019-09-04 swiftshader.regress@gmail.com Regres: Update test lists @ fbc146e9 Created with: gclient setdep -r src/third_party/swiftshader@cdb4549b571b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I670877c2115e561a49820025b2a3c3ac15c31d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783905Reviewed-by:
-
Guido Urdaneta authored
New system-level permissions for screen capture have been introduced in macOS 10.15. This CL adds checks for this new permission for getDisplayMedia() and the chooseDesktopMedia() extension API. Calls fail screen capture is requested but permission has not been given. There is no API to check this permission, but it can be done indirectly using other system APIs. This CL uses a heuristic proposed at https://crbug.com/993692#c3. Bug: 993692 Change-Id: I2b6b76f22f3aa800eb54b37c7c89c6b28536a632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776056Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#693111}
-
Mia Glaese authored
Bug: 982018 Change-Id: I1a9f44df3b737e9829f5766744e0c4e0a88e45f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763232 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#693110}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I0eac172f9867c9ce5a569731cf36ae7316d31325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761188 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693109}
-
Rune Lillesveen authored
If an element has a null ComputedStyle, its descendants can only have a ComputedStyle on the next lifecycle update if the element's ComputedStyle is updated. That would follow directly from inheritance in Element::RecalcStyle() and we won't need to mark those descendant with NeedsStyleRecalc(). Thus, we can skip style invalidation of descendants of display:none elements. This is a StyleInvalidator optimization, but also we are preparing for not marking style dirty for elements outside the flat tree for making it feasible to e.g. skip non-slotted subtrees of shadow hosts during style recalc. Bug: 972752 Change-Id: If586ac229c842189b6e3e664dfa756b262a9162c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783140 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 928941, 869818 Change-Id: I1d68ca7cd8b7cb6f080142c36f02c3e932e6837f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780838Reviewed-by:
-
Yasmin authored
Screenshots of the result: With Send Link: https://i.imgur.com/IaIgrmC.png Without Send Link: https://i.imgur.com/JlyILgV.png Bug: 1000025 Change-Id: I73d267a7f9d19b749b5f666532f39886f8a856f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778874 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Fergus Dall authored
This is a reland of 021c0b6d The original patch tried to upload metrics after CrostiniRestarter had been deleted. Original change's description: > Add UMA metrics for crostini VM startup > > We currently have metrics for the installer, but no way to tell how > many people are experiencing errors starting crostini after that. > > Bug: 977201 > Change-Id: If828e4cefc10197ddc9dbdc5b867f68184975f29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773999 > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692991} TBR=yhirano@chromium.org Bug: 977201 Change-Id: I414fa3b71b7f4e5e2ff37f91776bfb59529d6c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784266Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#693105}
-
Findit authored
This reverts commit 543a7657. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 693093 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU0M2E3NjU3MDA4ODVkMmRiMzU4NzgzOWRjZmZjNGVjOGFhZTI5ODYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/fuchsia-x64-cast/51291 Sample Failed Step: compile Original change's description: > X11 and Ozone: Move initialization to DWTHPlatform > > This CL moves the initialization of the X11Window aka PlatformWindow > to the DWTHPlatform and let the WTHPlatform to own the window instead. > > Also, instead of storing of XID in open_windows_, we store > AcceleratedWidget now, which is ok as XID and AcceleratedWidget > have the same type and it has already been used around the code. > > In the follow up CLs, I will start moving all the other codes from > DWTHX11 and add extend the existing PlatformWindow interface in > order to be able stop accessing the XWindow directly from the > DWTHX11. > > Also, AdjustSize and GetRootTransform have been moved to DWTHPlatform > and declared as protected so that DWTHX11 could access them. What is > more, the ToPixelRect and ToDIPRect have been removed from DWTHX11 as > the DWTHPlatform has already had those methods. > > Bug: 990756 > Change-Id: I077773fe3154d12696dcbfb606bb3eb3122c0936 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769442 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693093} Change-Id: I1312146ae26ae17fed7985bba81ee81ad055ae32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783522 Cr-Commit-Position: refs/heads/master@{#693104}
-
Maksim Sisov authored
This CL adds content_unittests for X11 with experimental percentage set to 100% and different names for the one running with headless and x11 backends. Once we have weston in place, wayland will also be added. Bug: 700309 Change-Id: I3ae0160028c4d94b8b81386240c824cf28483bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781438 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693103}
-
