GitLab

Before, the call to [self.omniboxPopupCoordinator openPopup] in the
location bar coordinator would always add the popup, under the
assumption that there would always be at least one suggestion (the
current page's URL). However, on incognito pages (both NTP and
regular pages), this doesn't appear and there are no suggestions, so
the popup appears, but is blank.

Instead of manually ordering the popup to appear or disappear, we can
use the popup's intrinsic content size, which is already how the
popup is being sized on iPad. Thus, when we were ordering the popup
to appear or collapse, we can instead just update the display status.

Bug: 933133
Change-Id: I11d3dff55f1a2f13daad259370e81df6ad7cc55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514573
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641681}

...from ProfileSyncServiceMock, which is an antipattern.

Bug: 910518
Change-Id: Ice6b8370077738d2c6f55904ecb036326761480a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525921Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641680}

This change is pretty simple because there are no uses of these APIs
and only two overrides of deprecated methods:

* BridgedContentView now supports accessibilityChildren directly
* NativeWidgetMacNSWindow now supports accessibilityTitle directly

In informal testing, browser windows and controls seem to still be
navigable using VoiceOver.

Bug: 386671
Change-Id: I46593b863603a4c2155cfd19859ea09401182c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528470
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641679}

With this CL, the state of the filling components are stored in a
PropertyModel to generalize some behaviors.

This is the base to structure new states for showing the accessory
without keyboard.

Bug: 932124
Change-Id: Ie75a15e99bdd3aae13615f20af1856cbf98fb48a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520493Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641678}

In https://crrev.com/b37e23cbd52ba447ab89c6d18f4ea0ecdc3fa5c0 I landed
a change to force synthetic gestures to cause a full redraw and wait for
the resulting CompositorFrame to be presented before invoking the
completion callback.

This patch broke VR telemetry. We never receive the presentation
notification so synthetic gestures never complete and cause the tests to
hang and timeout.

This CL causes synthetic gestures to complete without causing the redraw
and waiting for frame presentation if we're in VR mode. This was the
behavior prior to my change and gets the waterfall back to a green state.
I'll investigate a correct long term fix in a followup.

Bug: 940063
Change-Id: I6f6b9e9a5b9e369a1ec010cba93a1d952d3d0a18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525150Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641677}

Bug: 895825
Change-Id: Ic44559eff351a0efec8b807f973af6e356a2e293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528001Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641676}

Bug: 939092
Change-Id: I630a0497925d30d0419d0c58b10d921f6ab1dc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525178Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641675}

The volume-control-container element has CSS properties which were not override
for the immersive video player with slightly smaller controls.

Also, the modern media controls interfere with the custom immersive-mode styling,
so the hover-background elements for that have been hidden.

Bug: 918648
Change-Id: I755a3fcf8ec653d0d2693c0e4cc197587cd3126e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526675Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#641674}

As above. This should have no behaviour change.

Change-Id: I78cad0b91877f736bcb7432a8e0a38e2f017f724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525318
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641673}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c2bb50b73101..1cef4e693fc3


git log c2bb50b73101..1cef4e693fc3 --date=short --no-merges --format='%ad %ae %s'
2019-03-18 sugoi@google.com Allow null dispatchable objects
2019-03-18 capn@google.com Copy kokoro folder to tests/kokoro
2019-03-18 capn@google.com Fix Travis CI build
2019-03-18 bclayton@google.com Reintroduce "VkDebug: Update macros to address issues in b/127433389"


Created with:
  gclient setdep -r src/third_party/swiftshader@1cef4e693fc3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I4bed4d491d3a23bebb3b552d3580170193aa80a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528514Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641672}

Bug: 126849
Change-Id: I8de16c1d3f08c3d1be42068344a0f64a34ca7d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516776
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641671}

Because only the enrollment manager implementation, and not the base
class, uses prefs, the static registration function should reside in the
implementation files.

Bug: 899080
Change-Id: Ie3712286893cec94470148ddb3cb43d4b4d14b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528476
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641670}

Remove the old filename-based crash keys in favor of the address-based
async stack trace crash key as the latter is much more efficient to
record.

To symbolize these crash keys, use the crsym/ tool (Googlers only).

      strings. Sample reports: 2ed1e0ebbf79045a (Android),
      dffdce7a5580f7e4 (Windows)

Bug: 897751
Change-Id: I9e33e27459da079e8a78272c43dbe2a0b701acab
Test: Checked that symbolization yields the same information as the old
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528610
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641669}

Previously, we'd use the priority of the first request to use a tunnel
for the entire tunnel, as long as the tunnel existed. This could result
in a HIGHEST priority tunnel later being used solely for low priority
requests, for vice versa. This CL just uses a default priority for all
proxy tunnels.

We could reprioritize tunnels according to the highest priority request
using them at any time. This might give better real-world performance,
but it leaks more metadata to proxies.

Bug: 898526 (940848 gets honorable mention)
Change-Id: If140af0213f93673c7e0f9490f6d7e4d9f81978f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525174Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641668}

This CL also improves the ExternalVkImageSkiaRepresentation by avoiding
using vkQueueWaitIdle.

Bug: 932214,932260,932614
Change-Id: If40687586d39152b548eb5ee288a05e7c456337a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518752Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641667}

Change-Id: Ic1d89de8dd642e932b7917bea06dc1656aa8f539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516075
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641666}

Oilpan switched to non-eager tracing of objects recently. This removes
the now unused infra to track stack frame depth.

Bug: 933333
Change-Id: I8d75b6219cff838d20c8be5b71d62a85b005e339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524491Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641665}

TBR=twellington@chromium.org

Change-Id: I0ef49a607322d7da41356d0b500debb41461d5b8
Bug: 942902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527537Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641664}

libassistant only request audio focus with
output type STREAM_MEDIA at the end of ReleaseFocusForStream.

We would like to request audio focus when the internal media player is
playing.

In this CL:
- When the internal media player start audio playback with audio output
type STREAM_MEDIA, we explicitly acquire audio focus.
- When the internal media player stop audio playback with audio output
type STREAM_MEDIA, we explicitly abandon audio focus if necessary.

Bug: b:123718677
Test: Manual
Change-Id: Ia30e685d7ed2186145140c38ae8526db5284a7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506554
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641663}

Currently if a field is invalid, and we are using the client
validation feature, the field will not get autofilled.
According to the current validation logic, if country is empty,
all the address fields would be considered as invalid. This is not
good as we may have many valid profiles where the country is empty.
Therefore, we are going to have an exception here and have the
address fields autofilled, if the country is empty.

The suggestions would not change as the validation only changes
their order, and is not as aggressive.

Change-Id: I479dd9dd853032e309679c4bcaf2b117bb29d3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524677
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641662}

This is a reland of 8c66199b.

Fixes use of uninitialized |num_pending_|.

Original change's description:
> This CL adds SQLitePersistentReportingAndNELStore which persists
> NEL policies to disk in a SQLite database. It will eventually also store
> Reporting clients and reports.
>
> The code is based on that of the SQLitePersistentCookieStore.
>
> It is not hooked up to anything yet (just unittests).
>
> Bug: 895821
> Change-Id: I99ea14ace6f9b7fecd6075b1be98647db80d2bcb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504493
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#641361}

Bug: 942889, 895821
Change-Id: I679d6713a295715a3a08206f61c91cf58adcd0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528474
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641661}

Creates a new OmniboxPopupBaseViewController class. Renames existing
OmniboxPopupViewController class to OPLegacyVC.
Updates all current usage of OPVC to OPLegacyVC.

Bug: none
Test: none
Change-Id: I67338edce43431be0cd2b7dc9aabe91fcfc8c253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511356Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641660}

BUG=v8:8988

Change-Id: I0a0cc3b95814656de1a602cc31bca2fe726dae79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522193
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641659}

Added perfetto unittests to Linux, Mac, and Windows bots.
Removed tests from Android bots because they were failing.
Reland of https://crrev.com/c/1468261 with a few adjustments.

Bug: 931138
Change-Id: Ic4e844f0008e5a267ee28db627c3c4086e0fdfbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524528
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641658}

In focusless spat-nav mode, escape will blur a focused element so the
user can bo back to moving interest around. A common pattern is for the
page to move focus to an inner input element when clicked. Currently,
the implementation will blur the focused element on escape only if it's
also interested.

An alternative fix here would be to listen to focus changes and move
interest as well. That's a larger change and it's not clear it's
desirable. This CL simply removes the restriction that the focused
element must be interested; the escape key will blur any focused
element.

Bug: 942110
Change-Id: I0379bb3272b154f88a749453a41dbe9eadce4c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526484Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641657}

Bug: 929725
Change-Id: I91a2260c745a3d754f4b967cc354d3abc078434a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459522
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641656}

This makes CrasAudioHandler::AudioObserver::OnOutputMuteChanged
match CrasAudioClient::Observer::OnOutputMuteChanged

Bug: 940810
Change-Id: If170df2f5c3cb451b4895d4052c39f42c25d8580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522552
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641655}

Bug: 816629,861983
Change-Id: I2f6ce50bab8410679e8e5e7255349e087e62373d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1320207Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641654}

...instead of ProfileSyncServiceMock, which is an antipattern.

Bug: 910518
Change-Id: Iffd4da62dff2db9add9e930ef37e983c82525934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528184Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641653}

I will use this hook to do some processing before the damage is sent that
may impact the damage regions.

BUG=627663
TEST=will be coming

Change-Id: Ic4466c2290c6b30404c92744ecc0b708aa2a8b29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519312
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641652}

...instead of ProfileSyncServiceMock, which is an antipattern.

Bug: 910518
Change-Id: Iec983a22725d3d766c40dbbf52953909134b7b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528190
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641651}

R=proberge

Bug: 830892
Change-Id: I9def8b589ffbe1c037e81520fdb878b53df4b368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525177
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641650}

Some code use ui/events/blink/did_overscroll_params.h and
ui/events/blink/web_input_event_traits.h so there needs to
be a dependency to "//ui/events/blink" which declares those headers.

Missing dependency found with a gn check --check-generated (new
feature just added to gn, see gn:57).

Exact errors:

ERROR at //out/Default/gen/content/common/input/input_handler.mojom.h:78:11: Include not allowed.
          ^--------------------------------------
It is not in any dependency of
  //content/common:mojo_bindings
The include file is in the target(s):
  //ui/events/blink:blink
which should somehow be reachable.
___________________
ERROR at //out/Default/gen/content/common/input/input_handler.mojom.h:79:11: Include not allowed.
          ^---------------------------------------
It is not in any dependency of
  //content/common:mojo_bindings
The include file is in the target(s):
  //ui/events/blink:blink
which should somehow be reachable.
___________________


Bug: 938893
Change-Id: I3c2001e5cfe4d7a5cd6334cb1162b15ca97a6a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528185Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#641649}

There was an oversight in the old logic's "aggressive" correction path:
During device switch-over periods, when timestamps were unstable, the
resampler was being reconfigured for each and every call to Render().
This might have been part (or all?) of the cause of higher-than-expected
CPU usage seen on some machines.

The new logic in this change, instead, reconfigures the resampler in
coaser-grained steps. The code to accomplish this is also simpler. From
testing (on my three desktops, various scenarios), synchronization seems
to generally converge much more quickly and is generally more stable.

Bug: 936835, 931225
Change-Id: I01a029bdcc37e4c92ff84a22dfaac674712cac3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526798
Auto-Submit: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641648}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb85d2ba05ff..28645ae1d8fb


Created with:
  gclient setdep -r src-internal@28645ae1d8fb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org

Change-Id: I1cb61d485cb95a8330986f0266140a58dcc87653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528512Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641647}

If the user has sync disabled by enterprise policy, the Manage sync
settings and the sync toggle need be hidden. And an error needs to
explain why sync is not available.

https://drive.google.com/open?id=1EgUvUXD9zXAHC85mzB0wx75f67yUEuhe

Bug: 937118
Change-Id: I91a2c50b053a920289a8bdbcb967001961da5c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508262
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641646}

https://skia.googlesource.com/skia.git/+log/cfea834b8da6..252996c72d2c


git log cfea834b8da6..252996c72d2c --date=short --no-merges --format='%ad %ae %s'
2019-03-18 borenet@google.com [infra] Add some logging to go_deps asset creation
2019-03-18 brianosman@google.com Delay half-float vertex color determination until Op::finalize
2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c2bb50b73101..00424c1bc233 (1 commits)
2019-03-18 yikong@google.com [Android] Do not build for Windows


Created with:
  gclient setdep -r src/third_party/skia@252996c72d2c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:126457671
TBR=brianosman@chromium.org

Change-Id: I13a2caa2bb0ba3ddbf106c9bb0171afc3b287455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#641645}

Change-Id: If35f720b23aad710989b98c005629fcd5ba9702b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526611Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#641644}

Bug: 939801
Change-Id: I3203025ea4b0edcd536f12d3faf4e6f6280993a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528530Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641643}

Bug: 942654
Change-Id: If7eda05fc8e3e197488ac4140634c2606e2bef26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525171Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641642}