- 29 Dec, 2020 40 commits
-
-
David Maunder authored
Canary is showing we have some OutOfMemoryErrors. These will be handled in the same way as TabPersistentStore/TabState - we will not save the CriticalPersistedTabData/ShoppingPersistedTabData files. This will be achieved by serializeAndLog() returning null in the event of an OutOfMemoryError and a null response resulting in the file not being saved. Bug: 1161980 Change-Id: I403751dae99b3b3e532686f288a803cb91aecdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605614Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839637}
-
Miriam Zimmerman authored
We've made the relevant decision on a timeout and no longer need these metrics. Code sending this metric was removed in https://crrev.com/c/2605214. BUG=1156196 TEST=CQ Fixed: 1156196 Change-Id: I28fe2abb37980d22fd351e8ed55f68f074b9d3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606369Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#839636}
-
Jeffrey Kardatzke authored
BUG=1146646 TEST=Verified new string in UI Change-Id: Ia45dade605890c7cb024f660798490ca97f54d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605288 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839635}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/368db7cde02e..67a477b85b60 2020-12-29 johnstiles@google.com Remove stale FrExp test files. 2020-12-29 reed@google.com Use sampling in bitmapdevice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: I8eba035c8e00310d9b4942eeb7a500147678c212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839634}
-
Jeroen Dhollander authored
The |Service::Context| object is used by |AssistantManagerServiceImpl| but it was destructed first during teardown, causing a use-after-free error. Bug: 1162128 Test: compiled Change-Id: I44a6a52387879602d67057dafc482a50d482d265 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605578 Commit-Queue: Tao Wu <wutao@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#839633}
-
Clark DuVall authored
I saw some of the class loader mismatch crashes came back after adding preloading. This will hopefully fix those crashes. Bug: 1146745 Change-Id: I9e9364ba6d0a69bb38267905461961c018e73133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606193Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839632}
-
Kyle Horimoto authored
This CL creates url_constants.h/cc files in //chromeos/components, where they can be accessed from both //ash and //chrome, and removes constants which were previously in both those spots. Note that the content at that URL does not yet contain Phone Hub information; this will be added before launch. Fixed: 1144053 Bug: 1106937 Change-Id: I434d2b42b54b64ea299aaace97e12c5b53af7410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605613 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839631}
-
Toni Barzic authored
Refactors HoldingSpaceImage, and adds support for requesting image refresh (i.e. image reload using the async bitmap resolver). Refreshing the image creates a new ImageSkia representation for the holding space item, so HoldingSpaceTrayIconPreview has to be updated to better handle changes to the backing image skia. When the holding space item image is updated, HoldingSpaceTrayIconPreview just creates a new ImageSkia to be used to draw the icon, instead of tracking changes in an ImageSkia specialization (and having to invalidate existing image representations). On HoldingSpaceImage side, the ownership of AsyncBitmapLoader had to be moved to HoldingSpaceImage, so it can be passed to the new image skia. While here, I did some additional cleanup: * Moves logic to request image from image skia source to the HoldingSpaceImage implementation (this will be useful to support item file path changes). * Removes image caching from HoldingSpaceImage::ImageSkiaSource. ImageSkia already caches its representations, so there is no need for another caching layer on top of it. Also, adds some unit test for HoldingSpaceImage. TBR=xiyuan@chromium.org For a trivial change in ash/public/cpp/BUILD.gn BUG=1139115 Change-Id: Ic94bd5890a095010291546ae880b7bb50dbc6392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605836 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839630}
-
Devlin Cronin authored
We have a shiny new docserver, and no longer rely on the server in the Chromium repo. It served us well for many years. Wish it a grand farewell, and remove it from the codebase. This removes *everything* under chrome/common/extensions/docs/server2, as well as the docserver tests introduced in https://crrev.com/031fdd9a8941a3f6ce45140aad4156f9ddd13606. Bug: 1161364 Change-Id: Idb18fac9c00decf6c7c46a3f4c1dcb8547d73edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601680Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839629}
-
Hui Yingst authored
[iOS] Disable flaky test [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField]. TBR=javierrobles@chromium.org Bug: 1162301 Change-Id: Ia706d997b20bb1b33d00ef63d02b7050b1e5edb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606191Reviewed-by:
Hui Yingst <nigi@chromium.org> Reviewed-by:
Alan Screen <awscreen@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839628}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609241635-1a5deaa23ae88856f623544afdac379b41a9d7db.profdata to chrome-mac-master-1609264741-782c7fdabb35af8d5bad4658593c39d1b6051717.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I634c2b19ca45a92194babd8b44e9b84d3a34039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606373Reviewed-by:
-
Daniel Cheng authored
Frame::Swap() would previously call DetachDocument(), save some state, and then complete detaching old frame by calling Detach(). However, this left the old frame in a semi-inconsistent state between DetachDocument() and Detach() and could trigger some weird edge cases (such as in the printing code). Instead, since Detach() already takes a FrameDetachType, improve the coordination between Detach() and Swap() so that detaching a frame for swap preserves the state that Swap() will adopt. By doing this, Frame::Swap() no longer needs to call DetachDocument() at all. Bug: 1061686, 1063150 Change-Id: I937bbf9d0a6d0de911aa4bd4743a16b86df1b4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597169Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839626}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609241635-e4b96f72ae58e1971ec4cf3bb5311f454317b912.profdata to chrome-linux-master-1609264741-3c5a3a442fc29468a5cb13e2f3f40377429cca30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I788a9d40630255af96b41340309693eb5e65bf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606372Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c73806bc052..c14f809140e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: I990fa15dd37ad35053d41a81e37cf3fe89eac89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606585Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839624}
-
Kyle Horimoto authored
This CL removes an Observer interface and related functions which are no longer used. They previously were used to facilitate the "Locate phone" feature, whose implementation was changed to no longer need this functionality. Fixed: 1156382 Bug: 1106937 Change-Id: Ic3c7b4208388c6ac96e307a3a7364c4171edd378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605844 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Judy Wang authored
Test: Manual test Bug: 1157711 Change-Id: I3daca3c9ea1b59684ded122a6e5c908d03fb7ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601582 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#839622}
-
John Lee authored
Bug: 1162022 Change-Id: I7d6d3e5691a52505306a600738b813cc27bc73ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601269Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839621}
-
Allen Bauer authored
This will remove the need for the child_infos_ field in LayoutManagerBase. Somewhat related to the work of integrating fill layout behavior into views::View. Bug: 1159116 Change-Id: I968aa58fb3b29f78d96cd520e61ccb731c2e9ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605567 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic2173abfeb3242643e62d657c228a45997159a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606567Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/095fd1d3ad25..c2847bbcf303 2020-12-29 thomasanderson@chromium.org [GLX] Don't request exposure events for child windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1158170 Tbr: jonahr@google.com Change-Id: Idedc27d0add4714552349a8eaba629c48e16de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606320Reviewed-by:
-
Jeremy Roman authored
This is mostly mechanical, though two slightly non-trivial changes have also been made: The enrollment dialog view connect_ callback has been unused since: https://codereview.chromium.org/10230012 which was over eight years ago, so it has been removed. FilePathWatcher can be held directly in an std::map, which already provides std::unique_ptr-like no-moving semantics, allowing fewer indirections and fewer map lookups. This change is made while here. Bug: 1007635 Change-Id: I99fde79a09d8968cf37132aac6f85893cd2ee195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601217 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
David Black authored
Similar to as was done for the holding space tray icon, holding space item views sections will no longer directly observe the holding space controller and/or model. Instead, these events will be forwarded from its parent, a holding space child bubble. In the next CL to follow, holding space child bubbles may sometimes withhold events from item views sections, such as when the child bubble is being animated out. There should be no user visible change as a result of this CL. Bug: 1154998 Change-Id: Iccdeaee7dabfd3eeaa5eec0448e300d215377ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605419Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839616}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifa14ab39255d05ee797ebac1e08bf14367fae827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603971Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f 2020-12-29 aeubanks@google.com Merge "Fix std::abs undefined behavior in string_writer.h" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id3050d6af813d93d9db166c94206540e28fee4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606545Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 115 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-03-29. TBR=chromium-metrics-reviews@google.com Change-Id: Ib0f18065ee7fef60fb7d1b8f5f78c95c10417107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606425Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#839613}
-
Kurt Catti-Schmidt (SCHMIDT) authored
I haven't been able to get a consistent repro for this hang, so this is a speculative fix without a unit test. However, I have a strong reason to believe that this will fix the underlying issue. With https://chromium-review.googlesource.com/c/chromium/src/+/2521570 ...focused nodes are never ignored. This exposed a circular dependency in this sequence of events: 1) Node A becomes focused 2) A tree update occurs on a node to reparent Node A 3) The new parent is ignored (Node B) 4) Another child of Node B (Node C) has another tree update, which recomputes ignored state. This queries if a caret is present. 5) Determining whether a caret is present uses UnignoredSelection, which creates AXPositions that in turn ask the anchors if they are ignored. But we're already determining ignored state, so there's a circular dependency. 6) All of this occurs in the same AXTreeUpdate This speculative fix simply removes HasCaret's dependency on UnignoredSelection, so no traversal on ignored nodes will occur. This seems safe, as the subsequent IsDescendantOf will handle nested focus without depending on ignored state. For cases where HasCaret has tight dependencies on UnignoredSelection (like ATK selection offsets), the UnignoredSelection parameter is explicitly passed in. Bug: 1156965 Change-Id: I67bac8fc2a1aa5db948aab470de91d39283f3c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595198 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839612}
-
Yi Gu authored
Note: in |ToolbarActionsBarBubbleViews::OnWidgetVisibilityChanged|, the BindRepeating is changed to BindOnce. Bug: 1152282 Change-Id: I57b6f87f111a160a91e28d32bbd6e194652472a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595931 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
When the "Locate phone" feature is unavailable, we now show a tooltip explaining to the user why this is the case. Namely, the feature is not allowed when the phone has "Do Not Disturb" enabled and does not allow alarms with sounds to disrupt this state. Bug: 1156382, 1106937 Change-Id: I72f09e2cf8ae3dbd917cf87f49b954f944ef5332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604015 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/0324bd3ef1af..d9581878fcf8 $ git log 0324bd3ef..d9581878f --date=short --no-merges --format='%ad %ae %s' 2020-12-22 huangdarwin Fix SQLITE_OMIT_WINDOWFUNC builds by moving declaration of sqlite3ExpandSubquery out of "ifndef SQLITE_OMIT_WINDOWFUNC" block. 2020-12-22 huangdarwin Amalgamations for release 3.34.0 2020-12-01 drh Version 3.34.0 2020-11-30 Dan Kennedy Update the tea/win/makefile.vc file that ships as part of the autoconf package to use "sqlite3" instead of "tclsqlite3" for the installed dll filename. 2020-11-30 drh Do not reuse the obsolete SQLITE_TESTCTRL_PRNG_RESET value for SQLITE_TESTCTRL_SEEK_COUNT. Give SEEK_COUNT its own unique value. This avoids incompatibility with legacy test code. 2020-11-27 Dan Kennedy Fix a compiler warning in fts5_aux.c. 2020-11-27 Dan Kennedy Add missing cast to fts5 bm25() code. 2020-11-27 Dan Kennedy Remove a redundant "if( rc==SQLITE_OK )" from the fts5 bm25() code. 2020-11-27 Dan Kennedy Move an "if( rc==SQLITE_OK )" to outside a loop body in the fts5 bm25() code. 2020-11-27 Dan Kennedy Fix a case in the FTS5 integrity check where a corrupt database could cause a buffer overread. 2020-11-26 Dan Kennedy Update mkunicode.tcl to match the change erroneously made to machine generated file fts5_unicode2.c in [b7b7bde9]. 2020-11-25 drh Update a requirement mark in the e_expr.test script. 2020-11-25 drh Fix harmless compiler warnings about unused function parameters. 2020-11-25 drh Fix a potential NULL pointer dereference in the geopoly_overlap() routine of the GeoPoly extension. 2020-11-25 drh Fix the shell1.test test script so that it works on windows. 2020-11-25 drh Change the -init option to the command-line shell to honor the -bail option. Also change it to report an error if the filename mentioned cannot be opened. 2020-11-24 drh Fix a typo in the sqlite3_txn_state() documentation. 2020-11-24 drh Add the new sqlite3_txn_state() interface to the set of routines accessible by run-time loadables extensions. 2020-11-24 drh Fix a harmless typo in a comment. 2020-11-24 dan Fix a bug in OOM handling code introduced by [6a28713d]. 2020-11-24 dan Ensure that super-journal and other journal filenames passed by SQLite to an sqlite3_vfs.xOpen() implementation may be safely passed to sqlite3_uri_parameter() and similar functions. 2020-11-24 drh Remove the VERSION_NUMBER macro from configure.ac as it has been unused since 2009 check-in [7f4810747b086498]. See also [forum:/forumpost/bb2c634fcd|forum post bb2c634fcd]. 2020-11-23 drh Syntactic changes to work around a bug in gcov 9.3.0. No changes to the generated code for release builds. 2020-11-23 drh In os_unix.c, put ALWAYS() on unreachable branches associated with pathname normalization. 2020-11-23 dan Fix a test script problem causing crash8.test to fail when run with leak-sanitizer. 2020-11-23 drh Allow "substring()" as an alias for "substr()" for compatibility with other SQL engines. 2020-11-20 dan Add file doc/vdbesort-memory.md, containing notes on the way vdbesort.c uses heap memory. 2020-11-19 drh More test case changes so that shared-cache mode tests all work with normalized database names. 2020-11-19 drh Fix the tkt3793 test case so that work even when filenames are normalized. 2020-11-18 drh Improvements to the mechanism that attempts to report SQLITE_CORRUPT if pread() says that the underlying filesystem is corrupt. 2020-11-18 dan Update cksumvfs.c so that if SQLITE_AMALGAMATION is defined, SQLITE_CKSUMVFS_STATIC is implied. 2020-11-18 dan Add test infrastructure for cksumvfs. And update cksumvfs so that it works in concert with version 2 VFSs. No changes to core SQLite. 2020-11-18 dan Fix a problem causing sqlite3_carray_bind() to return an undefined value. 2020-11-18 dan Update test code to fix a problem with SQLITE_OMIT_VIRTUAL_TABLE builds. 2020-11-18 drh On unix, for certain error codes of read()/pread() return SQLITE_IOERR_CORRUPTFS instead of SQLITE_IOERR_READ. And then convert this error into SQLITE_CORRUPT prior to returning back to the application. 2020-11-17 drh Claw back most of the performance lost in the previous commit. 2020-11-17 dan Fix trivial memory leaks in the shell and sqldiff programs. 2020-11-17 dan Fix test file busy2.test so that it works with the "inmemory_journal" permutation. 2020-11-17 drh Add a single-argument form to the CARRAY table-valued function, with content bound using the sqlite3_carray_bind() interface that is included with the extension. 2020-11-16 drh Enhance the unix VFS so that it removes extra "/", "/./" and "/../" from the database filename. 2020-11-14 drh Modify UPDATE so that two-pass updates on a rowid table use an ephemeral table to store rowids rather than a RowSet. This uses less memory, though it is slower. 2020-11-12 drh Improved diagnostics output with ".wheretrace 0x800". No changes to non-debug builds. 2020-11-11 drh Fix a typo in a comment. No changes to code. 2020-11-08 drh Use NEVER and ALWAYS macros to confirm that the return value from sqlite3ExprSkipCollateAndLikely() is never NULL in some of its use cases. 2020-11-06 drh Add ALWAYS() to conditionals associated with SHM locking that are always true. 2020-11-05 drh Suppress errors associated with TEMP triggers that reference objects in non-TEMP databases. This is a continuation of the fix for ticket #3810 shown in check-in [ba1afc040171810d] from [/timeline?c=trunk:200908061743|2009-08-06], based on a bug report in [forum:/forumpost/157dc791df|forum post 157dc791df] 2020-11-05 drh Remove unused variable from speedtest1.c 2020-11-02 drh Fix an another OSS-Fuzz discovered assertion fault due to ALTER TABLE and strange triggers. 2020-10-31 drh Add the -tabs command-line option to the CLI. 2020-10-31 dan Update the ALTER TABLE command to correctly handle UPDATE ... FROM statements within trigger programs. (...) 2020-09-15 drh Do not invoke usleep() for more than 999999 microseconds. 2020-09-11 dan Catch fts5 index corruption caused by issuing 'delete' commands with incorrect data earlier in some cases. Also fix a couple of test script problems. 2020-09-10 drh Try again to fix the typo in the sqlite3_txn_state() documentation. 2020-09-10 drh Fix typo in the documentation for the new sqlite3_txn_state() interface. 2020-09-10 drh If an amalgamation is created using SQLITE_ENABLE_UPDATE_DELETE_LIMIT, ensure that it can still be compiled without that option by setting the SQLITE_UDL_CAPABLE_PARSER flag in the preamble. 2020-09-07 dan Fix another (harmless in practice) tsan error in shared-cache mode. 2020-09-06 drh Remove an artifical limitation on the length of columns in the "box" output mode of the command-line shell. 2020-09-05 drh Fix a bug in Fossil that might cause it to crash if there is a multi-terminal token with a space following the "|" separator. This does not affect SQLite. 2020-09-04 dan Fix a tsan error that could occur when using shared-cache mode. 2020-09-04 dan Ensure that the busy-handler count is reset at the end of each sqlite3_file_control() and sqlite3_prepare() (and _v2() and _v3()). 2020-09-01 mistachkin Fix harmless compiler warning. 2020-09-01 drh In the Lemon output, add a prefix comment that explains that the output file is automatically generated and shows the name of the source file. 2020-09-01 drh Lemon updates: (1) include the #defines for all tokens in the generated C file, so that the C-file can be stand-alone. (2) If the grammar begins with a %include {...} directive on line one, make that directive the header for the generated C file. (3) Enhance the lemon.html documentation. 2020-09-01 drh Improvements to the IN-early-out optimization so that it works more efficiently when there are two or more indexed IN clauses on a single table. 2020-09-01 drh Fix a harmless compiler warning. 2020-08-31 drh New test-control that returns the number of calls to sqlite3BtreeMovetoUnpacked() on the main database and then resets the counter. This only works for SQLITE_DEBUG builds. 2020-08-31 drh Fix the documentation for the OP_IdxGT family of opcodes to show that the P5 operand is not used. 2020-08-29 dan Fix a sanitizer warning in zipfile.c. 2020-08-28 dan Fix handling of an xShmLock(SHARED, UNLOCK) call when the caller does not hold any lock on the specified slot, but another connection in the same process holds an EXCLUSIVE. 2020-08-28 dan Modify the unixShmLock() function to avoid iterating through the (possibly large) set of connections to the same database file. 2020-08-28 mistachkin Add the miscellaneous 'series' extension to the shell. 2020-08-28 drh Update Lemon documentation. Patches from sgbeal. 2020-08-28 drh Fix a couple of unreachable branches. 2020-08-28 dan Add fts5 test to confirm that for a table with columns a, b, c and d, "{a b}" and "-{c d}" are handled similarly. 2020-08-27 drh Remove a (harmless) redundant variable from the CLI implementation. 2020-08-27 drh Include the original text of the CHECK constraint in the error message for anonymous CHECK constraints. 2020-08-27 drh Apple the same fix for ticket [9eda2697f5cc1aba] to text-to-integer conversions that was done for floating point conversions by check-in [1c76f1d8ec0937a2]. 2020-08-27 dan Do not attempt to run test script analyze3.test as part of the "prepare" permutation. 2020-08-26 drh Enhance the ".databases" command in the CLI so that it shows the result of sqlite3_db_readonly() and sqlite3_txn_state() for each database file. 2020-08-26 drh If the argument to the ".read" command in the CLI begins with "|" then run the remainder of the argument as a command and read input from the output of that command. 2020-08-25 drh Add support for the sqlite3_txn_state() interface. 2020-08-24 drh Reduce the N in the logN term for the sorting cost associated with computing DISTINCT by B-Tree by half, under the assumption that the DISTINCT will eliminate about half the rows of output. This is really a wild guess. But we do not have any better way of estimating what the row-count reduction due to DISTINCT will actually be. 2020-08-24 dan Correctly handle expressions like "x IS (not) true/false" within the rhs of IN() expressions. Fix for [f3ff1472]. 2020-08-20 dan Fix a crash that could occur in SQLITE_MAX_EXPR_DEPTH=0 builds when processing SQL containing syntax errors. 2020-08-20 dan Avoid a buffer overrun in test code that could occur if certain test functions were passed a hex-string containing an odd number of digits. 2020-08-19 drh Try to make SQLite easier to compiler for Mac Catalyst. See [https://sqlite.org/forum/forumpost/803387a1c5|forum post 803387a1c5]. 2020-08-19 drh Do not skip over TK_IF_NULL_ROW operators when bypassing TK_COLLATE operators. Fix to check-in [ac31edd3eeafcef4] which was itself a fix for ticket [45f4bf4eb4ffd788]. 2020-08-19 dan Update releasetest_data.tcl so that the "Fast-One" configuration runs bigmmap.test as part of release testing. 2020-08-19 dan Fix a problem in test file bigmmap.test. 2020-08-17 drh Fix the -quote option on the CLI to set the correct column separator. 2020-08-16 drh Optimization to sqlite3BeginWriteOperation(). 2020-08-15 drh Optimization of the sqlite3SrcListDelete() routine. 2020-08-15 drh Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s. 2020-08-15 drh Avoid unnecessary calls to the sqlite3GetVdbe() routine. Add assert() statements to prove each call is unnecessary. 2020-08-15 drh Omit the unnecessary not-NULL check on the upper bound of a forward index range scan. The subsequent OP_IdxGT will always catch the NULL. Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL. 2020-08-14 drh Update the version number to 3.34.0 for the next development cycle. 2020-08-14 drh Optimizations to the logic that converts main table accesses into equivalent index accesses. Code is now slightly smaller and faster than trunk. 2020-08-14 drh For UPDATE and DELETE, use OP_DeferredSeek always. If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed. This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing. 2020-08-14 drh Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks. 2020-08-14 dan Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests. Created with: roll-dep src/third_party/sqlite/src Bug: 1161048 Change-Id: Ieb8f0154930d6cc0597b5aee9444678cf021035b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600334Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839609}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c85bce8ea6c8..368db7cde02e 2020-12-29 johnstiles@google.com Improve Metal matrix *= support. 2020-12-29 brianosman@google.com Fix bugs/formatting in MSL inverse helpers 2020-12-29 bsalomon@google.com GrSurfaceContext::read/writePixels takes GrPixmap 2020-12-29 johnstiles@google.com Handle values above int32 safely during IR generation. 2020-12-29 reed@google.com add sampling param to drawAtlas 2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6fa6f0c8 to c7d00ca7 (125 revisions) 2020-12-29 reed@google.com Simplify GrInterpretSamplingOptions 2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c8d5277e86ee to 0eb61724c8f1 (1 revision) 2020-12-29 jcgregorio@google.com Add particles and svg support to fiddle. 2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5e606e5bfce2 to 220642a93da1 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Idce12b2c9eda0b90af242933f4c10914883cd4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606544Reviewed-by:
-
Kyle Horimoto authored
This CL updates phonehub_api.proto to include fields sent by the phone on W50+ indicating whether "Find My Device" functionality is available. Then, it updates FindMyDeviceControllerImpl to use these additional fields, breaking the dependence on DoNotDisturbController. Due to this change, we can now use the "locate device" feature while DND is on, as long as alarms are not also disabled on the phone. Bug: 1156382, 1106937 Change-Id: I74363b1ca225b6f6f839d5c28034c60d203eaef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605784Reviewed-by:
-
evliu authored
Add check to verify that the speech recognition service is still active before sending data down the pipe This CL contains a speculative fix that addresses a crash when calling AudioReceivedAfterBubbleClosed after the caption bubble is closed. I haven't been able to repro this crash and thus have not been able to verify this fix; however, the recognition client shouldn't send data to the speech recognition recognizer if the speech recognition service is destroyed anyways so this fix is of very low risk. Bug: 1161756 Change-Id: Ied868dfa17966650f79ceb954a6ac694f59e33d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605295Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#839606}
-
Peter Kotwicz authored
This CL rolls androidx.legacy:legacy-support-core-utils BUG=1064277 Change-Id: Iac6cb8a6f83a20c4f37bcc3a00fb2089212ad373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602392 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
Regan Hsu authored
Previously, there were strings without a space before the anchor <a> tag, because settings CSS would cause subsequent <a>s of <span>s to have additional margin starts. The lack of a space is confusing, esp to translators. This CL adds a space back to those strings, and modifies settings stylization so that having that space in translation won't cause additional indentation to the link embedded in the string. Fixed: 1063036 Change-Id: Id05c847f097d6dcbd2fa9553b6e9540d43dff583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605594 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839604}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 21 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-03-29. TBR=chromium-metrics-reviews@google.com Change-Id: Id094b38b267ab8a3f05fb636cfc2b8b16d5fb010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605349Reviewed-by:
-
Alexander Surkov authored
Inspect tools provide option to show internal ids of accessible objects, which is a handy feature for debugging and event recording. Platform tree formatters rely on internal accessible trees to retrieve object ids. It should be avoided, because the tree formatters should operate on external trees to produce same results not depending on how a tree formatter was initiated (whether by tests or by ax_dump_tree tool). WebKit exposes AXIdentifier attribute, which looks like a great match for this case. However, no comments from Apple so far about what exactly this attribute is for, so let's move with ChromeIdentifier attribute for now. Later it can be revisited. Bug: 1134623 Change-Id: I367158bc8802734d0e9311c9739eb8da13ff0cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602356 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
-
Matt Reynolds authored
The HID spec allows a device to group its functionality into separate top-level collections within the HID report descriptor. On Windows, each top-level collection is represented in the system registry as a separate logical device node. This CL identifies when a device exposes multiple top-level collections and merges them into a single HIDDevice instance. Bug: 1009715 Change-Id: I0524fee04b5e530dfa5ff724b57d2442187946be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592149 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839601}
-
Junbo Ke authored
Bug: internal b/156555613 Test: cast_base_unittests Change-Id: I5087a0a2df39559cf510ff5f9712ac9ece6a5b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605591Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#839600}
-
Jeffrey Kardatzke authored
Since we haven't enabled the new CDM with HW HEVC support yet overall, we need to condition adding the HEVC codecs in EME on the same flag as the CDM being enabled. BUG=b:176202075 TEST=GPM playback works with default Alcatraz CDM Change-Id: I626cb1e33973b812dce59edc514c086a578b45bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605292 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8db531ffa636..9c73806bc052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia3aec89d2ef653871b95315f69436e1f2db34eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605597Reviewed-by:
-
