GitLab

BUG=1106937,1126208

Change-Id: Ic8178b1c481db1b74a9abd775f8e98b30d81e6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444126
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813396}

This CL enables a feature to move cache_storage operations off
the IO thread and onto a sequence instead.  This feature has
previously launched on all other platforms.  It has been held
back until now on ChromeOS due to some measured performance
regressions.

After a couple months of experimentation we have not been able to
shift the regressions.  It appears there is just measurable delay
from the additional task that is run when mojo messages are targeted
off the IO thread.  There is not a lot we can do about this
unfortunately.

The regression show up in cache match time and body reading at P95.
Top level UMA such as FCP, however, are neutral.

Architecturally we are motivated to launch this in spite of the
regressions.  We do not want to support multiple threading models
into the future.  In addition, cache_storage can interfere with
other parts of the browser that also need to use the IO thread via
mojo message passing.

Therefore this CL proceeds with enabling the feature.

Bug: 960012
Change-Id: Ie9d5931ce9530dafe101d209a13f65ff22dffddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441125Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813395}

chromeos::TabletState is the singleton that actually holds the
information about the current TabletMode state. The state getter
method is public, but its setter is not. The idea is that only a
handful of classes can actually set the state, eg
ash::TabletModeController.

In the future, Lacros will also be able to create a
chromeos::TabletState instance and set the tablet mode state
via the (upcoming) use of `zcr_remote_shell` Exo protocol extension.

BUG=1113900
R=jamescook@chromium.org

Change-Id: I2ec77e7f038095b7e4f9c776683993f6b30c409e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443219
Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813394}

thread_watcher_report_hang.cc has various unique functions which are
designed to be on the call stack when hangs are reported. Guaranteeing
this requires making all of the functions unique and inhibiting tail
calls. The tail call inhibiting was only applied to two of the functions
so this change applies it to the other two (commented out in one of
them) and adds the NOT_TAIL_CALLED attribute to the function they all
call. This attribute makes the ordering in the functions irrelevant but
there is no cost to having belt and suspenders, so why not?

This completes the work of crrev.com/c/1373878.

Bug: 905288, 1032679
Change-Id: I383cc3453ab2f506017de1143bc8f3666ed38a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443891Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813393}

Crosapi mojoms have to be backwards compatible. Most interfaces and
structs use explicit ordinal values (@0, @1, ...) to emphasize this,
but I missed a couple of them. Add annotations to the missing ones,
so we're consistent throughout //chromeos/crosapi/mojom.

Bug: none
Change-Id: I9c7e7729cbdab903154d8d9c3d10b2e44fbb0b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442645Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813392}

Deprecate ProxyBypassList, ProxyMode, ProxyPacUrl & ProxyServer since
ProxySettings can do everything they can and is the first policy checked.

Bug: 1018157
Change-Id: If312cc1419a1c6761d1580609be0582ca95fbb91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441265Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813391}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Icc8256e084705d78b460641a873a05cdc0d7ef06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446766Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813390}

This was a mistake in the previous patch. When walking up the DOM tree,
we don't encounter the document object directly (this is different than
the layout tree).

Bug: 1129979

Change-Id: Ib6b7040e2a54658948d0830230d7a8ebeba44b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446517Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813389}

AudioBufferSourceHandler::RenderFromBuffer wasn't handling the case
where the source buffer had buffers that were transferred away.  Check
to see if the buffer was transferred and then just fill the
destination with zero.

Bug: 1132574
Change-Id: I92abd74f20918cb53810abf9ad00c9c4f4582baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439361Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813388}

This reverts commit 991f4851.

Reason for revert: This causes generate_buildfiles to fail, as seen
here: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome-easwa

This is the only CL within the revert range that includes barhopper

Original change's description:
> [ShapeDetection] Add barhopper impl for BarcodeDetection.
>
> This CL adds BarcodeDetection and BarcodeDetectionProvider
> implementations based on the barhopper barcode detection
> library.
>
> NOPRESUBMIT=true
>
> Bug: 1093185
> Change-Id: I29b233418108482ebc80bce7c34888fa2081068f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419911
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#813335}

TBR=jam@chromium.org,dpranke@google.com,reillyg@chromium.org,azeemarshad@chromium.org

Change-Id: Ia604a3ad2999116a453384261cd6f1873c73454d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446027Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813387}

This patch replaces the TopToolbarOverlay's dependency on the
ControlContainer with a callback for the progress bar's draw info.
This will make chainging the ownership of TopToolbarOverlay from
the LayoutManager to the TopToolbarCoordinator easier.

Bug: 1100332
Change-Id: Id6cd9ae9f2ffe8b4dd70436c360147fb9877dcc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357955Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813386}

Fixes some windows compile warnings that were preventing fuzzers
from being added; only minor functional changes since last update.

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2caaff2b0a1d

$ git log 995c0b844..2caaff2b0 --date=short --no-merges --format='%ad %ae %s'
2020-10-02 tuexen Minor cleanup.
2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533)
2020-10-01 tuexen I guess Bitrig support arc4random().
2020-10-01 tuexen Whitespace change.
2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0.
2020-09-30 deadbeef Add missing return type to init_random. (#531)
2020-09-30 tuexen Try to fix the Windows build.
2020-09-30 tuexen Add Android specific code for the random number generator.
2020-09-30 tuexen Add platform specifc includes to the corresponding code.
2020-09-30 tuexen Add a cleanup routine for the random number generator.
2020-09-29 tuexen Improve the input validation and processing of cookies.
2020-09-28 tuexen Whitespace cleanup
2020-09-28 tuexen Improve random number generation on __Fuchsia__.
2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path.
2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984
2020-09-24 tuexen Whitespace changes
2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529)
2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527)
2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528)
2020-09-19 tuexen Improve consistency.
2020-09-19 tuexen Cleanup.
2020-09-19 tuexen Improve Windows build.
2020-09-19 tuexen Fix syntax error on windows.
2020-09-19 tuexen Add include for getrandom() on Linux.
2020-09-19 tuexen Fix type of init_random() on Linux and Windows.
2020-09-19 tuexen Improve Windows build.
2020-09-19 tuexen Improve consistency.
2020-09-19 tuexen Improve random number generation on Linux and Windows.
2020-09-19 tuexen Cleanup read_random(). No functional change.
2020-09-19 tuexen Fix NetBSD related #ifdef.
2020-09-19 tuexen Whitespace changes
2020-09-18 tuexen Add license.
2020-09-18 tuexen Add license statement.
2020-09-18 tuexen Fox more typos.
2020-09-18 tuexen Fix typo.
2020-09-18 tuexen Remove trailing whitspaces.
2020-09-18 tuexen Improve consistency, no functional change intended.
2020-09-18 tuexen Check for too short packets when using the receive threads.
2020-09-18 tuexen Fix mask for ECN bits.

Created with:
  roll-dep src/third_party/usrsctp/usrsctplib

Bug: chromium:1025302
Change-Id: I3faeb75f9f12d71b7b6ef3d326ad2e8d8becf3cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430446
Commit-Queue: Taylor <deadbeef@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813385}

Test: manual
Change-Id: Ic3cfb8d62a72a07b9ced7d8de778b25134e16dca
Fixed: 1134451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446531
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813384}

- Unnecessary because the "title" slot can be placed directly
  on the div that contains the title text content for the
  card.

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I4f5620c6c07d5afc28288fd04dd902ca5f92dc0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443499
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813383}

Bug: 1134662
Change-Id: I4a4d5f576110045ea355dc6c7fa11cb69711b37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446830Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813382}

Bug: 1132948
Change-Id: I48988ab9e0aa9b8f17e93674ad443225b30ef837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446778Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813381}

When the computed value of a property contains a color keyword, that
keyword should be reported from the computedStyleMap API in its
unresolved form. By contrast, getComputedStyle should report used
values, i.e. rgb values, for certain properties per the CSSOM spec[1].
We don't currently distinguish between the two use cases for those
properties.

This CL introduces a distinction between computed and used values for
serializing properties containing color keywords and passes the correct
parameter at various call sites. The parameter does not yet influence
serialization - that will come in a follow-up change - so no Web-facing
behavior difference is expected.

[1] https://drafts.csswg.org/cssom/#resolved-values

Bug: 1112362,1099874
Change-Id: Ifcbd3d197b78195023f394b0e527907488990cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438010Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#813380}

Since Android SurfaceControl code is not depended on GL, move it from
ui/gl to ui/gfx.

R=Khushal
TBR=sadrul, kenrb

Bug: 1134453
Change-Id: If73f518da053579180b9bf05b2b18f7d7d90dae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444533
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813379}

For chromeosInfoPrivate and imageWriterPrivate, some apps remain active
beyond the original 2017 deprecation date. Update the TODO comments so
readers do not try to remove them.

BUG=329088,510270

Change-Id: I78547cca1d5b46f31217e49aa1cbbbc9866b5d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591968Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813378}

This is a reland of bfeec8b7.

This CL fixes a use-of-uninitialized-value error in the original
change.

Original change's description:
> Exclude no-update frames for jank detection
>
>
> This CL improves the jank metrics by excluding the delays caused by
> frames without intended updates and prevents certain outlier cases
> when a high jank percent is reported on a page with very low percent
> of dropped frames.
>
> Bug: 1133058
> Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812988}

Bug: 1133058
Change-Id: I270ca4ad044468e19136d3ed544c25de8ec3c916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446530Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813377}

This reverts commit 239e4113.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 813342 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIzOWU0MTEzYTBmYWVkYzdhMjY2NzcwYmQxNjQ1ZTQ3OGY0ZmU5ZTQM

Sample Failed Build: https://ci.chromium.org/b/8867519387170143872

Sample Failed Step: compile

Original change's description:
> [Autofill] Move legacy server request/response protos to be test only
> 
> 
> Bug: 1114655
> Change-Id: If1f6a68aa8f42b4e5df16b862022f5547ac08b1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442733
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#813342}


Change-Id: Ic183da760ca10d8d03f03ebf5c43fade7ff6b4f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1114655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446557
Cr-Commit-Position: refs/heads/master@{#813376}

TBR=dmazzoni@chromium.org

AX-Relnotes: n/a.
Bug: None.
Change-Id: I242cdd57d3f762684c613a826e6787a26f18e35c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446657Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#813375}

https://swiftshader.googlesource.com/SwiftShader.git/+log/375fee944c76..16636f480f81

2020-10-02 vantablack@google.com Added support for AndroidHardwareBuffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I41519c4559cfefe0d5f1cb87433c241d10047c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446751Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813374}

This is one more step towards enabling the flag
AccessibilityExposeHTMLElementEnabled to include the HTML element in the
accessibility tree.

Bug: 1063155
Change-Id: I3160bf5f9d39b46e2f7ff08ea81215ee7765e4eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441282
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813373}

https://skia.googlesource.com/skia.git/+log/36366209d412..6d696086211d

2020-10-02 johnstiles@google.com Store a unique_ptr* for a candidate's parent statement.
2020-10-02 egdaniel@google.com Always bind input attachment to all pipelines in subpasses that uses one.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1134454
Tbr: brianosman@google.com
Change-Id: Idfac697a3bd46168f0ec2aea96edf73b4c67219e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813372}

Bug: 1112095
Change-Id: I3137ed5e2bda1a3408b1c08d5f163e159780a7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444456Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813371}

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Ib7591b14f25a67815a9a19eb09745b62d0560631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431411
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813370}

(use_v4l2_codec || use_vaapi) was being used as a poor proxy for
chromeos builds.

Also reformat the file.

Change-Id: I9eb3615935c7cbc07f7f0918dad40ce80468c760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441733Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813369}

https://chromium.googlesource.com/openscreen.git/+log/be7345166a4f..77107392837f

2020-10-02 rwkeane@google.com [Discovery] Fix MdnsRecord Comparison Bugs
2020-10-02 jophba@chromium.org Add more trace logging to standalone_ impls
2020-10-02 jophba@chromium.org [Minor] fix periods in headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I174576872ef782a03d747e35cdfb7d585915d397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446752Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813368}

This reverts commit 01d5d6cf.

Reason for revert: Breaks lacros builder.
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-builder-rel/4366?

Original change's description:
> Switch angle_unittests to isolated script API.
>
> Uses the new 'use_isolated_scripts_api' feature added here:
> https://crrev.com/c/2425210 to switch the tests to the ANGLE
> standalone testing harness.
>
> Bug: angleproject:5124
> Change-Id: I363997060874df09653bcb78bb9c57f3cce3f6e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441149
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#813269}

TBR=ynovikov@chromium.org,dpranke@google.com,jmadill@chromium.org

Change-Id: I7d8a8b4f312038c40d8090d30b95da23ccc17df2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446655Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813367}

NGTableTypes::Columns is not dependent on ConstraintSpace, and can be shared
between MinMax/Layouts.
It gets cached in LayoutNGTable.
Cache is invalidated by LayoutObject bitfield: TableColumnConstraintDirty()
TableColumnConstraintDirty gets set when table needs layout (SetNeedsLayout/SetChildNeedsLayout)

Cached Columns need to be immutable. Had to modify few parts of code that assumed
Columns were mutable, mostly in NGTableAlgorithmHelpers.

Some related fixes in ng_length_utils included, will need review.

Few minor fixes that were in the same files included too.

Bug: 958381
Change-Id: I497c03b2e0b8c8d58b90cde8d0f21f240bac573a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436302
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813366}

We're seeing a surprising number of "TypeError: Failed to fetch" errors
in live testing when executing fetches with accompanying Trust Tokens
operations (see the linked bug---internal due to describing metrics,
sorry---for more information).

Analyzing logs added in
crrev.com/c/2416882 shows that these failures are *not* due to an
increased incidence of connection-related errors (DNS,
ERR_CONNECTION_FAILED, etc), so it seems likely that they could be
due to some kind of Fetch API requirement being violated closer to the
fetch callsite.

This CL adds some temporary logging to fetch_manager.cc that, for failed
fetches with accompanying Trust Tokens operations, histograms a reason
why the fetch failed. This is the union of:
- a new enum that captures each code path into
FetchManager::Loader::Failed
- a ResourceRequestBlockedReason.

I've filed crbug.com/1133944 to track cleaning up these log lines after
the investigation has finished.

Test: expands trust_token_browsertest to cover some logging cases
Bug: 1128174
Change-Id: Idbe424a3b68939a687ea1243cf1b9a681e82e51b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442229Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813365}

Roll Chrome Mac PGO profile from chrome-mac-master-1601575120-30d2ff52ccba123fa446e04afa93e5dc42388f0f.profdata to chrome-mac-master-1601661327-f1cf60f844e0debf5bf4063a28b1716a25f6a438.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: If59e218148889559065bee5046033f835ee76884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446758Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813364}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39117d2b244e..e4b0c039a1f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC kelvinjiang@google.com,anthonyvd@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1134625
Tbr: kelvinjiang@google.com,anthonyvd@google.com
Change-Id: I0f95bb530630bddcad88e49aa5e4456609e7936f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446753Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813363}

https://android.googlesource.com/platform/external/perfetto.git/+log/c0482f7bd156..9b8970cc0198

2020-10-02 treehugger-gerrit@google.com Merge "Reserve space for frames in AllocRecord."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ia4c76bbceafcfca75f862c3e7970e8136dbe7fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813362}

The interactive tutorial uses hard-coded strings to specify text
content. Included in this patch:

1. Add tutorial_common.js, which can be used to share code between
the tutorial and lesson components
2. Add a function, getMsg(), to fetch localized strings
3. Change some hard coded strings to message IDs
4. Clean up BUILD.gn

fr and es) and verify that content gets translated.

Bug: 1075752
Test: Manually load the tutorial in several locales (I used
Change-Id: I5784f1466f3646e31a41145478db9dfcb766f70e
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254345
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813361}

Bug: 1121806
Change-Id: I8a24e775c3b3955a86d606d199f6ee966f681ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444431Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#813360}

We are no longer using ZeroSuggestVariant.

Instead, we are moving to using separate base::Feature flags for each
experiment.

See here for a discussion about removing this:
http://g/chrome-omnibox-team/lNT8EsY1gFI

Bug: 1124050
Change-Id: I20fb3d79ad2ab64fb7daf52729449cbad3193e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430227
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813359}

https://chromium.googlesource.com/catapult.git/+log/8c88c750bd45..b494582b95e5

2020-10-02 bsheedy@chromium.org Revert "Make Catapult build as a part of Chromium under Python 3."
2020-10-02 bsheedy@chromium.org Revert "[Devil] Add install sanity check"
2020-10-02 landrey@webrtc.org Reduce upload completion token usage back to 5%
2020-10-02 dpranke@google.com Make Catapult build as a part of Chromium under Python 3.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1112471,chromium:1114061,chromium:1132297,chromium:1134629
Tbr: oysteine@google.com
Change-Id: I7496a084db82d0b09b4e5410b9ed78eb16a38618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446750Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#813358}

The content side was deferring to the gfx:: structs so just use
them on the public blink API.

BUG=738465

Change-Id: I4f8f449d86310fa80b72054c8465756a17b90f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443534Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813357}