- 15 Nov, 2018 40 commits
-
-
Kentaro Hara authored
Revert "Remove remaining components/domain_reliability dependency on content/ and components/keyed_service." This reverts commit bd611e3e. Reason for revert: It looks like this CL broke CFI bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11301 Original change's description: > Remove remaining components/domain_reliability dependency on content/ and components/keyed_service. > > This way it can run in the network process, similar to Network Error Logging. > > Bug: 853251 > Change-Id: I403a5dcc3cae12b592a444c7e23f71c552b58e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1334848 > Reviewed-by: Misha Efimov <mef@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608175} TBR=jam@chromium.org,mef@chromium.org Change-Id: I57829e413ad57ec667882069f77bf2d97faec4a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853251 Reviewed-on: https://chromium-review.googlesource.com/c/1337215Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608268}
-
Nicolas Pena authored
Bug: 896024 Change-Id: Ie4a0ba6a07c96557f0bfd464e523c0ad8d804c8e Reviewed-on: https://chromium-review.googlesource.com/c/1336431Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608267}
-
Koji Ishii authored
When NGInlineItemsBuilder removed an item, it needs to adjust BoxInfo::item_index. This patch fixes it. This was revealed in crrev.com/c/1333588, tests will fail with the CL without this fix. Bug: 636993 Change-Id: I7a996e358c0daa8e6c7aa1b5227e4027fe0295bd Reviewed-on: https://chromium-review.googlesource.com/c/1337210Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608266}
-
Robbie McElrath authored
This is identical to crrev.com/c/1329897, but the underlying issue that caused that CL to break unit tests was fixed in crrev.com/c/1336066. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} Bug: 882610 Change-Id: I05ecbac510b479eb28520cc0b0ad5b613519fab7 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1336154Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#608265}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43a35d299bbc..91de11099dcd git log 43a35d299bbc..91de11099dcd --date=short --no-merges --format='%ad %ae %s' 2018-11-15 yyanagisawa@chromium.org autoninja: fix shellcheck warnings Created with: gclient setdep -r src/third_party/depot_tools@91de11099dcd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8f9333288bfebeeafe6100b3a59331110818b1d0 Reviewed-on: https://chromium-review.googlesource.com/c/1337272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608264}
-
Xiaocheng Hu authored
The layout test has a "multiline" test case which isn't really multiline, as the linebreak characters in HTML are turned into whitespaces. This patch changes the <p> element into <pre> so that the linebreak characters are really breaking text into lines, and the test case is a multiline test case. This patch is a preparation for changing StartOfSentence() to use TextOffsetMapping (crrev.com/c/1335959). Bug: 778507 Change-Id: I77cd48eb13a1ff442e7ecbe1c71819055bccf078 Reviewed-on: https://chromium-review.googlesource.com/c/1336785 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608263}
-
Kent Tamura authored
* kWebKitUserModifyEffective It counts if contenteditable content attribute value and -webkit-user-modify property value are mismatched. * kPlaintTextEditingEffective It counts if -webkit-user-modify:read-write-plaintext-only is effective or a user interact with an element with contenteditable=plaintext-only. The counters are triggered only in Element::IsFocusable(). - Checking all elements costs too much. - If a user interacts with an element, IsFocusable() must be called. It's ok to ignore elements without user interaction. The behavior of such elements isn't important for web-site compatibility. Bug: 687843 Change-Id: Idb7a9280e1f63c4ecdca0c4ce3298c3c9be715da Reviewed-on: https://chromium-review.googlesource.com/c/1335069 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
It's a speculative fix for https://listnr.corp.google.com/product/5015361/report/85785278442. In the report, the reporter observed (from offline email): 1. opened up my mewoth/brydge 2. noticed that brydge kb wasn't working, checked quick settings menu and noticed bluetooth was missing 3. tried to enter password but no virtual kb came up Since there is not a consistently repro way to repro this, my guess is the Bluetooth stack was broken somehow but Chrome didn't get notified. With this CL, the device should be able (hopefully) to enter the correct ui mode and have the virtual keyboard if Bluetooth stack is broken. Bug: None. See description Change-Id: Ic04a769c111f772211e99c25d187726b46429626 Reviewed-on: https://chromium-review.googlesource.com/c/1337011Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#608261}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c1d38395f19..bb18f19dce17 Created with: gclient setdep -r src-internal@bb18f19dce17 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd664f528939594fa4dd798e31f829572d6a2de7 Reviewed-on: https://chromium-review.googlesource.com/c/1336529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608260}
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to allow cross-platform evaluation of the test cases. Change-Id: Ifba919b388f8a6c6de062f8615d0547fac2d2ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1336661Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3da725065a5f..2eccd58916ee git log 3da725065a5f..2eccd58916ee --date=short --no-merges --format='%ad %ae %s' 2018-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fca8fd620190..f3acb8c133fa (4 commits) 2018-11-15 alx.khovansky@gmail.com [canvaskit] Exposed SkPath::arc. Exposed SkEncodedImageFormat enum. Exposed SkImage::encodeToData overload with arguments Created with: gclient setdep -r src/third_party/skia@2eccd58916ee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ica91792257de0f7c93701e63a1984ce6585fb1f2 Reviewed-on: https://chromium-review.googlesource.com/c/1336928Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 11759 11762 11764 11770 11777 11781 11789 11792 11796 11805 11810 11812 11818 11826 11831 11833 5 lines were removed and 4 lines were deflaked by consecutive results since 11777. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I228b1460be577f1cbeefac3ab6623917b9ce4284 Reviewed-on: https://chromium-review.googlesource.com/c/1333175 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#608257}
-
Nigel Tao authored
BUG=826982 Change-Id: Icc1398c6c6a87484e8348039c7e7b9b8918d483e Reviewed-on: https://chromium-review.googlesource.com/c/1328626 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#608256}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8117fe38..b0e3bc7d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2033d3cd16e6cb2f0f7ed709c339785c6d310b2 Reviewed-on: https://chromium-review.googlesource.com/c/1336778Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608255}
-
Xianzhu Wang authored
This prepares for implementation of SPv2 interest rect expansion for composited scrolling. Bug: 792577 Change-Id: I0332bff4ce4f5fa9a5f5adf4a28c06a1442cc9d8 Reviewed-on: https://chromium-review.googlesource.com/c/1335067 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I2f0422bbf5e40dc1a2070b6f7a9d4525ae0aac41 Reviewed-on: https://chromium-review.googlesource.com/c/1336563Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#608253}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1934b786149d..f3acb8c133fa git log 1934b786149d..f3acb8c133fa --date=short --no-merges --format='%ad %ae %s' 2018-11-15 jmadill@chromium.org Retool perf test running. Created with: gclient setdep -r src/third_party/angle@f3acb8c133fa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If1599057a6bf53f83373979442f1d38f6c18b1c3 Reviewed-on: https://chromium-review.googlesource.com/c/1336927Reviewed-by:
-
Luciano Pacheco authored
Add ability to run integration tests with MyFilesVolume feature enabled. Change Files app base BrowserTest class to: 1. create folder Downloads when the flag MyFilesVolume is enabled, so it emulates the same condition that happens in the device. 2. |DownloadsTestVolume.CreateEntry| method to prefix entries with "Downloads" so they are all created inside the sub-folder downloads. This is needed to make the test logic compatible with the flag MyFilesVolume enabled or disabled. Since MyFiles becomes the root volume when it's enabled, entries would be created in MyFiles. This should be cleaned up once MyFilesVolume is fully rolled out. MyFiles/FilesAppBrowserTest.Test/myFilesUpdatesChildren_MyFilesVolume Test: --gtest_filter=" Bug: 873539 Change-Id: I1464b7fa6f30f16cd7ddaa5900b11e95fafd9208 Reviewed-on: https://chromium-review.googlesource.com/c/1334989Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#608251}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f66e5510327b..43a35d299bbc git log f66e5510327b..43a35d299bbc --date=short --no-merges --format='%ad %ae %s' 2018-11-15 yyanagisawa@chromium.org autoninja: quote the arguments when needed. Created with: gclient setdep -r src/third_party/depot_tools@43a35d299bbc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:902930 TBR=agable@chromium.org Change-Id: Ie4967480952faab9f57be654ea1bb7f6042ec17d Reviewed-on: https://chromium-review.googlesource.com/c/1336926Reviewed-by:
-
Joe Mason authored
Also includes changes to parsers/ and test/ that chrome_utils depends on. R=csharp Bug: 830892 Change-Id: Idaba2972a0fbc2c5e896c9403442c24c8b8c6a60 Reviewed-on: https://chromium-review.googlesource.com/c/1336047 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608249}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/83aa5ace99a5..d575a2d43a2d git log 83aa5ace99a5..d575a2d43a2d --date=short --no-merges --format='%ad %ae %s' 2018-11-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3d76a59d..4ffd688e (608069:608180) 2018-11-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fbed28d4..3d76a59d (607938:608069) 2018-11-14 ouj@fb.com Exposing rtcp report interval setting in objc api Created with: gclient setdep -r src/third_party/webrtc@d575a2d43a2d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I199d9eea4a1c51d4ddbdd480d7fdb77e4e36c154 Reviewed-on: https://chromium-review.googlesource.com/c/1336925Reviewed-by:
-
Alan Cutter authored
Change-Id: Icfde8442ceca605f8fe055a407082bcd082257e6 Reviewed-on: https://chromium-review.googlesource.com/c/1335054Reviewed-by:
-
Ken Rockot authored
We underestimate the total size of a message carrying arrays with struct elements. This fixes that. Bug: 905529 Change-Id: Ib05fa52e42d850c3ebe38bd4f716f7c1327e4cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1336779Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccb751a21b7d..5c1d38395f19 Created with: gclient setdep -r src-internal@5c1d38395f19 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idbcd9367eb0e4ccffc150dfd72325e25a8a65dd7 Reviewed-on: https://chromium-review.googlesource.com/c/1336923Reviewed-by:
-
Hiroki Nakagawa authored
Nested dedicated workers has been enabled by default since Chrome 69: https://www.chromestatus.com/feature/6080438103703552 Bug: 31666 Change-Id: I12785dd8c1d5582ae0d069b5b6993ad50c6be9b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325596Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#608244}
-
Charles Zhao authored
Changes made in this CL: (1) new preprocessor_config.pb and new native_inference weights. (2) the native_inference.cc logic is also changed a bit because new quantized model does not have dequantization any more. (3) only kept 'score tests' to confirm this model returns same result as the model trained in google3. Other 'expectation tests' are all removed, because we have to fix them for every new model. Instead we do a full feature analysis before submit the model to verify that. Bug: 902196 Change-Id: I3dd4382f750b9216369c7de14edd9c692cf6db71 Reviewed-on: https://chromium-review.googlesource.com/c/1319209 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d2aae3165a2..3da725065a5f git log 7d2aae3165a2..3da725065a5f --date=short --no-merges --format='%ad %ae %s' 2018-11-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@3da725065a5f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I93ef7c7c0a21fc258635661a44dd490d464a45d8 Reviewed-on: https://chromium-review.googlesource.com/c/1336922Reviewed-by:
-
Akihiro Ota authored
Added functionality for AXNode::PosInSet(), which determines a node's position within an ordered container, and AXNode::SetSize, which determines the total number of elements within the node's container. Change-Id: Idd1849891db8cb96c30edda4d4b85b9a206220f2 Reviewed-on: https://chromium-review.googlesource.com/c/1336327 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608241}
-
David Tseng authored
This changes does the bulk of the work to stitch together all of the public surface a UI component needs to expose a list of braille displays: - connect/disconnect/forget operations - device change, pincode request notifications - finish pairing response - management of a single preferred display connection ChromeVox will keep an explicit list of braille display device names. This appears to be the same strategy used by all other clients of Brltty, including NVDA, and BrailleBack. This list is currently not complete, during the initial phase of this feature. Bug: 882261 Test: new test suite added. Manually tested. Change-Id: I033c6ce6425421db26ad04a1af8f04a04a9e8a47 Reviewed-on: https://chromium-review.googlesource.com/c/1335946Reviewed-by:
-
Stuart Langley authored
As requested by Drive SRE these changes reduce the frequency of requests on the drive back ends, and also lessens the likelihood of convoying. 1. When XMPP is connected, change the poll timeout for changes from 5 minutes to between 60 & 120 minutes. 2. When XMPP is disconnected, change the poll timeout for changes from 1 minute to between 1 and 2 minutes. This issues start page token requests which are cheap for the drive back ends. 3. When batching XMPP notifications, change the batch time from 5 seconds to between 15 and 30 seconds. This reduces the QPS on drive back ends when a team drive change notification is broadcast to a large corpus of users, and prevents convoying of requests by introducing jitter. Bug: 905201 Change-Id: I5310d956c9ccb5b59261cdf99bbefb515f75771f Reviewed-on: https://chromium-review.googlesource.com/c/1336949Reviewed-by:
-
Hitoshi Yoshida authored
IDL compiler did not work for cases that have multiple values separated with ', '. For example, we couldn't specify "Exposed=(Window, Worker)". This CL fixes for Exposed cases, thus we will be possible to use "Expose=(Window, Worker)". This change works only for Expose attributes, because it is handled separately, and it would be a huge change if we work for general cases. Bug: 904326 Change-Id: I33bc09d96c1dd1afdd29850300add30687fa9d3b Reviewed-on: https://chromium-review.googlesource.com/c/1331292Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Sergey Berezin authored
A previous luci-go roll was introduced in https://crrev.com/c/1333093 but that git_revision hash doesn't exist for all packages. Bug: 905218 Change-Id: Iad06836b7c1b6fa3c511eb7eaa70d52068d8d64b Reviewed-on: https://chromium-review.googlesource.com/c/1336909Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608237}
-
Bence Béky authored
Bug: 461981 Change-Id: I2e58d90f9f9e2a983286fbec9742234838fbbf50 Reviewed-on: https://chromium-review.googlesource.com/c/1335951 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608236}
-
Sadrul Habib Chowdhury authored
This reverts commit 68dbb3a4. Original commit message ======================= Instead of sending the presentation-feedback over a separate IPC, include it with the begin-frame messages. The presentation feedback can be requested for each frame. So this can reduce an extra IPC per frame for each client. TBR=flackr@chromium.org,boliu@chromium.org,tsepez@chromium.org,piman@chromium.org tbr'ing since this is a reland with a trivial build fix. Bug: 883592 Change-Id: Ia017b14f79eb06b247a9a75a395e4e1d4b51c1db Reviewed-on: https://chromium-review.googlesource.com/c/1336989Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608235}
-
Zhuoyu Qian authored
Move: build/scripts/{ => core/css}/make_css_property_names.py build/scripts/{ => core/css}/templates/css_property_names.h.tmpl build/scripts/{ => core/css}/templates/css_property_names.cc.tmpl This CL has no behavior changes. Bug: 732657 Change-Id: I267ff9cf0824109aebb7c1f791172b481ae4e0fc Reviewed-on: https://chromium-review.googlesource.com/c/1334995Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef71a5f047da..f66e5510327b git log ef71a5f047da..f66e5510327b --date=short --no-merges --format='%ad %ae %s' 2018-11-15 yyanagisawa@chromium.org autoninja: support -j100 and -tclean. Created with: gclient setdep -r src/third_party/depot_tools@f66e5510327b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I41516e4c6a5990999b112587a8b7c75bbdd1357a Reviewed-on: https://chromium-review.googlesource.com/c/1336652Reviewed-by:
-
David Black authored
Per change in spec, the Assistant caption bar should be 48dip tall. See bug for detailed spec. Bug: b:119498360 Change-Id: I40cd7cd44a37b9ca99710dad9311b929373b3797 Reviewed-on: https://chromium-review.googlesource.com/c/1336525Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#608232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74096ec8f277..cd83dda45843 git log 74096ec8f277..cd83dda45843 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 hjd@google.com Unify on for (;;) Created with: gclient setdep -r src/third_party/perfetto@cd83dda45843 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7444b3208fa39e54a631954fe8bcd5a38f0bb917 Reviewed-on: https://chromium-review.googlesource.com/c/1336651Reviewed-by:
-
Tony de Luna authored
This cl moves network icon cache purging to a new observer that is owned by the unified system tray. Currently there are five subclasses of TrayNetworkStateObserver::Delegate. Every time we get a network list update the global network icon cache is purged. This means that for every update the cache is purged at least five times. With this cl TrayNetworkStateObserver::Delegate can still be used as a simple way of subscribing to all network events without excessive icon purging. Bug: 902409 Change-Id: I078ac8dbdee473fc285ee8e91f735c99524c74a7 Reviewed-on: https://chromium-review.googlesource.com/c/1334835 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
-
Shu Chen authored
are changed but also when the selection is changed. Bug: 898442 Change-Id: I927171f7ded54cad1626e367a33a900e90adc8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1319211 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
-
