1. 04 Feb, 2010 40 commits
    • alice.liu@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error · 0e020ebd
      alice.liu@apple.com authored
      codes for most elements that arent listbox or menupopup related"
      <rdar://problem/7436861>
      
      Reviewed by Jon Honeycutt.
      
      * AccessibleBase.cpp:
      (AccessibleBase::accSelect):
      - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that 
        aren't beneath listboxes or menupopups.  This was too restrictive since 
        any element can be selectable.
      - Correct the misinterpretation of MSDN's stipulation of situations involving 
        adding, removing, and extending selection on single-select elements
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54376 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0e020ebd
    • christian@webkit.org's avatar
      2010-02-04 Christian Dywan <christian@twotasts.de> · 7a15a7e0
      christian@webkit.org authored
              Reviewed by Xan Lopez.
      
              Require either libsoup 2.28.2 or 2.29.90.
      
              * configure.ac:
      
      2010-02-04  Christian Dywan  <christian@twotoasts.de>
      
              Reviewed by Xan Lopez.
      
              Conditionalize third party cookie policy for libsoup 2.29.90.
      
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::setCookies):
              * platform/network/soup/DNSSoup.cpp:
              (WebCore::prefetchDNS):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::restartedCallback):
              (WebCore::startHttp):
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::toSoupMessage):
              (WebCore::ResourceRequest::updateFromSoupMessage):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54375 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a15a7e0
    • christian@webkit.org's avatar
      2010-02-04 Christian Dywan <christian@twotoasts.de> · 779ae56a
      christian@webkit.org authored
              Rubber-stamped by Gustavo Noronha Silva.
      
              Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.
      
              * platform/gtk/GOwnPtrGtk.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54374 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      779ae56a
    • ap@apple.com's avatar
      Correct a mistake in ChangeLog entry. · 8317ed7e
      ap@apple.com authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54373 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8317ed7e
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 385e0632
      ap@apple.com authored
              Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
              https://bugs.webkit.org/show_bug.cgi?id=34520
      
              Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html
      
              * dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute
              properties before attributes. Otherwise, copying "checked" property would make the cloned
              node checked, unchecking original (they share a name, and are thus in the same radio group).
              We do want the original to be unchecked, but we also want to know its original state in
              HTMLInputElement::copyNonAttributeProperties().
      
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties):
              Use setChecked instead of plain assignment to prevent m_checked getting out of sync with
              checkedRadioButtons. Also, copy field related to default checked state, so that m_checked
              won't be overridden when copying attributes.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54372 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      385e0632
    • kevino@webkit.org's avatar
      [wx] Build fix after addition of Clipboard::writePlainText method. · aecf5120
      kevino@webkit.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54371 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      aecf5120
    • bfulgham@webkit.org's avatar
      Properly handle margin settings when printing Plugins in WinCairo. · d5bedaba
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34613
      
      Reviewed by Adam Roben.
      
      * WebFrame.cpp:
      (WebFrame::spoolPage): Adjust the GraphicsContext passed to the
        paintContents method so that the World Transform is properly
        positioned to account for margin settings at the time that
        PluginViewWin.cpp processes the drawing operations.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d5bedaba
    • mrowe@apple.com's avatar
      Update auto-version.sh to better handle major version numbers with fewer than three digits, · 50b103fa
      mrowe@apple.com authored
      and the case when WEBKITLIBRARIESDIR is not set.
      
      Reviewed by Steve Falkenburg.
      
      * win/tools/scripts/auto-version.sh:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54369 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      50b103fa
    • enrica@apple.com's avatar
      REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info. · e106ecff
      enrica@apple.com authored
      <rdar://problem/7595685>
      https://bugs.webkit.org/show_bug.cgi?id=34609
      
      Reviewed by Oliver Hunt.
      
      WebCore: 
      
      Test: editing/pasteboard/drop-inputtext-acquires-style.html
      
      The dragging code did not distinguish the case of dragging the content of an input control
      as a special case. The markup placed in the pasteboard included the style information.
      I've modified the Clipboard class interface adding a new method writePlainText to match the
      behavior of the copy and cut commands and modified the drag code to detect the special case.
      I've modified all the platform specific implementations of the Clipboard class.
              
      * dom/Clipboard.h: Added writePlainText pure virtual function.
      * editing/Editor.cpp:
      (WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
      (WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
      * editing/htmlediting.cpp:
      (WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
      in Editor.cpp
      * editing/htmlediting.h:
      * page/DragController.cpp:
      (WebCore::DragController::startDrag):
      * platform/Pasteboard.h:
      * platform/android/ClipboardAndroid.cpp:
      (WebCore::ClipboardAndroid::writePlainText): Added.
      * platform/android/ClipboardAndroid.h:
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::writePlainText): Added.
      * platform/chromium/ClipboardChromium.h:
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::writePlainText): Added.
      * platform/gtk/ClipboardGtk.h:
      * platform/haiku/ClipboardHaiku.cpp:
      (WebCore::ClipboardHaiku::writePlainText): Added.
      * platform/haiku/ClipboardHaiku.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writePlainText): Added.
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::writePlainText): Added helper function.
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::writePlainText): Added.
      * platform/qt/ClipboardQt.h:
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::writePlainText): Added.
      * platform/win/ClipboardWin.h:
      
      LayoutTests: 
      
      * editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
      * editing/pasteboard/drop-inputtext-acquires-style.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54368 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e106ecff
    • sullivan@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=34611 · 4f278788
      sullivan@apple.com authored
      WebLocalizedString() could use an assertion that it is being called on the main thread
      
      Reviewed by Tim Hatcher.
      
      WebKit: 
      
      * WebKit.xcodeproj/project.pbxproj:
      Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)
      
      WebKit/mac: 
      
      * Misc/WebLocalizableStrings.m: Removed.
      * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
      Renamed to use .mm extension so it can include a C++ header.
      (WebLocalizedString):
      Added an assertion that this is being called on the main thread.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54367 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4f278788
    • eric@webkit.org's avatar
      2010-02-04 Steve Block <steveblock@google.com> · 6702b91b
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              Fix bug in V8 convertNPVariantToJValue when converting float and double types
              https://bugs.webkit.org/show_bug.cgi?id=34593
      
              No new tests, build fix only.
      
              * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
              (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54366 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6702b91b
    • darin@chromium.org's avatar
      2010-02-04 Chris Guillory <chris.guillory@google.com> · 840d44ac
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Notify ChromeClientChromium of AccessibilityObject state
              change notifications.
              
              https://bugs.webkit.org/show_bug.cgi?id=34464
      
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              (WebCore::toChromeClientChromium):
              (WebCore::AXObjectCache::postPlatformNotification):
              * page/chromium/ChromeClientChromium.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54364 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      840d44ac
    • eric@webkit.org's avatar
      2010-02-04 Jeremy Moskovich <jeremy@chromium.org> · 1dc00ac3
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Update comments to better document the possible values of the
              writing direction menu state variables.
      
              * public/WebContextMenuData.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54363 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1dc00ac3
    • loki@webkit.org's avatar
      Use an easily appendable structure for trampolines instead of pointer parameters. · e897512d
      loki@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34424
      
      Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
      Reviewed by Gavin Barraclough.
      
      * assembler/ARMAssembler.cpp:
      (JSC::ARMAssembler::executableCopy):
      * jit/JIT.h:
      (JSC::JIT::compileCTIMachineTrampolines):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      * jit/JITStubs.cpp:
      (JSC::JITThunks::JITThunks):
      * jit/JITStubs.h:
      (JSC::JITThunks::ctiStringLengthTrampoline):
      (JSC::JITThunks::ctiVirtualCallLink):
      (JSC::JITThunks::ctiVirtualCall):
      (JSC::JITThunks::ctiNativeCallThunk):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54362 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e897512d
    • senorblanco@chromium.org's avatar
      2010-02-04 Stephen White <senorblanco@chromium.org> · 50575ce1
      senorblanco@chromium.org authored
              Unreviewed, build fix for Chromium.
      
              Revert r54341 ("[v8] Remove clear method from DOM object maps"),
              since it causes the worker tests to fail on Chromium.
      
              * bindings/v8/DOMData.h:
              (WebCore::DOMData::removeObjectsFromWrapperMap):
              * bindings/v8/DOMDataStore.h:
              (WebCore::ChunkedTable::clear):
              (WebCore::ChunkedTable::clearEntries):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear):
              (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
              (WebCore::removeAllDOMObjectsInCurrentThread):
              * bindings/v8/V8DOMMap.h:
              (WebCore::WeakReferenceMap::clear):
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::~WorkerScriptController):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54361 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      50575ce1
    • kevino@webkit.org's avatar
      Build fix after changes in r54345. · 39e712d4
      kevino@webkit.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54360 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      39e712d4
    • eric@webkit.org's avatar
      2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 2eefc700
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Crashes when an invalid hostname is pre-fetched
              https://bugs.webkit.org/show_bug.cgi?id=34602
      
              * http/tests/misc/dns-prefetch-control-expected.txt:
              * http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.
      2010-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Xan Lopez.
      
              [GTK] Crashes when an invalid hostname is pre-fetched
              https://bugs.webkit.org/show_bug.cgi?id=34602
      
              * platform/network/soup/DNSSoup.cpp:
              (WebCore::prefetchDNS): NULL-check the SoupURI that is created
              from the hostname; that will happen for invalid hostnames.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54359 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2eefc700
    • bweinstein@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · 3d3fe80b
      bweinstein@apple.com authored
      Add Windows expected results to the new scrollbar test because Windows was trying
      to compare to platform/mac first instead of cross-platform.
      
      * platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54358 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3d3fe80b
    • kenneth@webkit.org's avatar
      Rubberstamped by Oliver Hunt. · 0cd18dd8
      kenneth@webkit.org authored
      [Qt] QtLauncher cleanup.
      
      Refactor option handling out in utility functions and make the
      arguments more Qt compatible.
      
      * QtLauncher/main.cpp:
      (requiresGraphicsView):
      (LauncherApplication::handleUserOptions):
      * QtLauncher/utils.cpp:
      (takeOptionValue):
      (formatKeys):
      (enumToKeys):
      (appQuit):
      * QtLauncher/utils.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0cd18dd8
    • bfulgham@webkit.org's avatar
      Properly handle margin settings in WinCairo. · 3a7f5754
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34545
      
      Reviewed by Adam Roben.
      
      * WebFrame.cpp:
      (scaleFactor): Require the margin information as an input
        parameter, and use them when computing the scaling factor.
      (WebFrame::drawHeader): Pass margin size to scaleFactor.
      (WebFrame::drawFooter): Pass margin size to scaleFactor.
      (WebFrame::spoolPage):
        1. Pass margin size to scaleFactor.
        2. Recognize that the return value of printerMarginRect is
           already in device units, and therefore scale it so that
           the Cairo drawing is correct.
        3. Remove scaling call for margins in GDI code, as it is
           already in scaled units.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54356 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3a7f5754
    • eric@webkit.org's avatar
      2010-02-04 José Millán Soto <jmillan@igalia.com> · 2bcb88af
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] webkitgtk crashed when Orca open
              https://bugs.webkit.org/show_bug.cgi?id=34463
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (textForObject):
              Checking if render objects are texts before calling toRenderText
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54355 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2bcb88af
    • xan@webkit.org's avatar
      2010-02-04 Xan Lopez <xlopez@igalia.com> · 6e215ff3
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Bump minimum libsoup requirement to 2.29.90
      
              * configure.ac:
      
      WebCore:
      
      2010-02-04  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Set first party URI in all SoupMessages. This allows libsoup to
              implement a "no third party cookies" policy in case it wants
              to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
              use it for SoupURI.
      
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::setCookies):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::restartedCallback):
              (WebCore::startHttp):
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::toSoupMessage):
              (WebCore::ResourceRequest::updateFromSoupMessage):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54352 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6e215ff3
    • pfeldman@chromium.org's avatar
      2010-02-04 Pavel Feldman <pfeldman@chromium.org> · 72eecb98
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: group cookies by domains, not frame's domains.
      
              https://bugs.webkit.org/show_bug.cgi?id=34599
      
              * inspector/front-end/CookieItemsView.js:
              (WebInspector.CookieItemsView.prototype._cookiesForDomain):
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
              (WebInspector._addCookieDomain):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54351 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      72eecb98
    • japhet@chromium.org's avatar
      2010-02-04 Nate Chapin <japhet@chromium.org> · eae7c263
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Delete V8CustomBinding.h and all references to V8Custom
      
              https://bugs.webkit.org/show_bug.cgi?id=32638
      
              * bindings/v8/NPV8Object.cpp:
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/V8NPObject.cpp:
              * bindings/v8/V8Utilities.cpp:
              * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
              * bindings/v8/custom/V8AttrCustom.cpp:
              * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
              * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
              * bindings/v8/custom/V8ClipboardCustom.cpp:
              * bindings/v8/custom/V8CoordinatesCustom.cpp:
              * bindings/v8/custom/V8CustomBinding.h: Removed.
              * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * bindings/v8/custom/V8DataGridColumnListCustom.cpp:
              * bindings/v8/custom/V8DatabaseCustom.cpp:
              * bindings/v8/custom/V8ElementCustom.cpp:
              * bindings/v8/custom/V8EventSourceConstructor.cpp:
              * bindings/v8/custom/V8EventSourceCustom.cpp:
              * bindings/v8/custom/V8GeolocationCustom.cpp:
              * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
              * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
              (WebCore::v8HTMLAudioElementConstructorCallback):
              (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
              * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
              * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
              * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
              (WebCore::v8HTMLImageElementConstructorCallback):
              (WebCore::V8HTMLImageElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
              * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
              (WebCore::v8HTMLOptionElementConstructorCallback):
              (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
              * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
              * bindings/v8/custom/V8HistoryCustom.cpp:
              * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
              * bindings/v8/custom/V8LocationCustom.cpp:
              * bindings/v8/custom/V8MessagePortCustom.cpp:
              * bindings/v8/custom/V8NodeCustom.cpp:
              * bindings/v8/custom/V8NodeFilterCustom.cpp:
              * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
              * bindings/v8/custom/V8SQLTransactionCustom.cpp:
              * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
              * bindings/v8/custom/V8SVGLengthCustom.cpp:
              * bindings/v8/custom/V8SharedWorkerCustom.cpp:
              * bindings/v8/custom/V8StorageCustom.cpp:
              * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
              * bindings/v8/custom/V8WebGLArrayCustom.h:
              * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
              * bindings/v8/custom/V8WebKitPointConstructor.cpp:
              * bindings/v8/custom/V8WorkerContextCustom.cpp:
              * bindings/v8/custom/V8WorkerCustom.cpp:
              * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54349 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eae7c263
    • sfalken@apple.com's avatar
      Windows build fix for projects not defining WebKitLibrariesDir. · a3365995
      sfalken@apple.com authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54348 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a3365995
    • ariya@webkit.org's avatar
      2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com> · e25a1640
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Unnecessary QBrush construction for doing a solid fill
              https://bugs.webkit.org/show_bug.cgi?id=34559
      
              Use the similar trick like r37421, i.e. use the special brush for
              solid color to avoid creating QBrush again and again.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setPlatformFillColor):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54347 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e25a1640
    • mitz@apple.com's avatar
      REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big · 3ccba3e1
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34371
      
      Reviewed by Simon Fraser.
      
      * platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54346 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ccba3e1
    • mitz@apple.com's avatar
      REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big · 5e7e3bc1
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34371
      
      Reviewed by Simon Fraser.
      
      WebCore: 
      
      Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
      40 in ScrollbarThemeMac.
      
      * WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
      * editing/EditorCommand.cpp:
      (WebCore::verticalScrollDistance): Use Scrollbar methods instead of
      constants, and cap the scroll distance if needed.
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars): Ditto.
      (WebCore::ScrollView::wheelEvent): Ditto.
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
      value from the native scrollbar theme.
      * platform/Scrollbar.h: Replaced scroll amount constants with static methods.
      (WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
      (WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.
      * platform/ScrollbarTheme.h:
      (WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
      that returns the largest int.
      * platform/gtk/WheelEventGtk.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/haiku/PlatformWheelEventHaiku.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/mac/ScrollbarThemeMac.h:
      (WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
      that returns 40.
      * platform/mac/WheelEventMac.mm:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
      Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.
      * platform/wx/MouseWheelEventWx.cpp:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
      constants.
      * platform/wx/ScrollViewWx.cpp:
      (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
      methods instead of constants, and cap the scroll distance if needed.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.
      
      WebKit/mac: 
      
      * WebView/WebFrameView.mm:
      (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
      constants, and cap the scroll distance.
      (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
      cScrollbarPixelsPerLineStep.
      (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
      constants, and cap the scroll distance.
      
      WebKit/wx: 
      
      * WebView.cpp:
      (wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54345 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5e7e3bc1
    • eric@webkit.org's avatar
      2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com> · 1fb233f7
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
              recaching, remove QTimer::singleShot and QPixmap::scaled, more
              accurate strategy of handling transform operation blends. Rotating a
              bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.
      
              https://bugs.webkit.org/show_bug.cgi?id=34062
      
              This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching
              (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs
              (WebCore::OpacityAnimationQt::updateState): style change
      2010-02-04  No'am Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Ariya Hidayat.
      
              [Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
              of QTimer::singleShot, and moved syncLayers() from paint() to update()
              https://bugs.webkit.org/show_bug.cgi?id=34062
      
              * Api/qgraphicswebview.cpp:
              (QGraphicsWebViewPrivate::update): Moved the sync operation to update
              (QGraphicsWebView::paint): Moved the sync operation to update
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54344 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1fb233f7
    • pfeldman@chromium.org's avatar
      2010-02-04 Pavel Feldman <pfeldman@chromium.org> · d17b787d
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Cookies for resources are not shown in storage panel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34594
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::getCookies):
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              (WebCore::InspectorResource::cachedResource):
              * inspector/InspectorResource.h:
              (WebCore::InspectorResource::requestURL):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54343 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d17b787d
    • abecsi@webkit.org's avatar
      2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu> · 7523d09c
      abecsi@webkit.org authored
              
              Reviewed by Tor Arne Vestbø.
      
              Implement a locking and scheduling mechanism for http testing sessions to be able
              to run multiple instances of run-webkit-tests parallel on the same machine.
              If a test session wants to run http tests and this feature is enabled, the pending
              sessions create lockfiles with sequential lock numbers. These locks are used to schedule
              the running test sessions in first come first served order. An exclusive lock ensures
              that the lock numbers are sequential to avoid deadlocks and starvation.
              Because the buildbot master specifies the flags used by slaves we need an environment
              variable too to be able to use the feature per-slave.
              Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
              flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
      
              https://bugs.webkit.org/show_bug.cgi?id=33153
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54342 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7523d09c
    • eric@webkit.org's avatar
      2010-02-04 Anton Muhin <antonm@chromium.org> · ac208885
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              [v8] Remove clear method from DOM object maps
              https://bugs.webkit.org/show_bug.cgi?id=34530
      
              No new tests. Should be covered by existent testing infrastructure.
      
              * bindings/v8/DOMData.h:
              * bindings/v8/DOMDataStore.h:
              * bindings/v8/V8DOMMap.cpp:
              * bindings/v8/V8DOMMap.h:
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::~WorkerScriptController):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54341 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac208885
    • eric@webkit.org's avatar
      2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 2a55cbb2
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Increase test coverage for the QScriptValue.
      
              https://bugs.webkit.org/show_bug.cgi?id=34533
      
              * qt/tests/qscriptvalue/qscriptvalue.pro:
              * qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
              (tst_QScriptValue::tst_QScriptValue):
              (tst_QScriptValue::~tst_QScriptValue):
              (tst_QScriptValue::dataHelper):
              (tst_QScriptValue::newRow):
              (tst_QScriptValue::testHelper):
              (tst_QScriptValue::ctor):
              * qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
              * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added.
              (tst_QScriptValue::initScriptValues):
              (tst_QScriptValue::isValid_initData):
              (tst_QScriptValue::isValid_makeData):
              (tst_QScriptValue::isValid_test):
              (tst_QScriptValue::isBool_initData):
              (tst_QScriptValue::isBool_makeData):
              (tst_QScriptValue::isBool_test):
              (tst_QScriptValue::isBoolean_initData):
              (tst_QScriptValue::isBoolean_makeData):
              (tst_QScriptValue::isBoolean_test):
              (tst_QScriptValue::isFunction_initData):
              (tst_QScriptValue::isFunction_makeData):
              (tst_QScriptValue::isFunction_test):
              (tst_QScriptValue::isNull_initData):
              (tst_QScriptValue::isNull_makeData):
              (tst_QScriptValue::isNull_test):
              (tst_QScriptValue::isString_initData):
              (tst_QScriptValue::isString_makeData):
              (tst_QScriptValue::isString_test):
              (tst_QScriptValue::isUndefined_initData):
              (tst_QScriptValue::isUndefined_makeData):
              (tst_QScriptValue::isUndefined_test):
              (tst_QScriptValue::isObject_initData):
              (tst_QScriptValue::isObject_makeData):
              (tst_QScriptValue::isObject_test):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54340 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a55cbb2
    • vestbo@webkit.org's avatar
      Make run-webkit-tests work under Cygwin for the Qt port · d51d95a4
      vestbo@webkit.org authored
      Reviewed by Simon Hausmann.
      
      setPathForRunningWebKitApp() is implemented for the Qt port
      by using qmake to query for the location of the Qt libraries.
      
      This requires the original environment (%ENV) to be untouched,
      so launchWithCurrentEnv() was refactored to launchWithEnv(),
      and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
      instead. This has the added benefit of getting rid of the temp
      variables used for storing the current env.
      
      openDumpTool() is also refactored a bit into platform-spesific,
      port-spesific, and generic environment variables.
      
      Checks for undef was added a few places to fix Perl concat
      warnings when run-webkit-tests is aborted.
      
      https://bugs.webkit.org/show_bug.cgi?id=33895
      
      * Scripts/run-webkit-tests:
      * Scripts/webkitdirs.pm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54339 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d51d95a4
    • ossy@webkit.org's avatar
      [Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot · 6a78c72d
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34281
      
      * platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54338 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6a78c72d
    • zecke@webkit.org's avatar
      [Gtk] Check if the renderer() exists in textForObject. · 1a58308d
      zecke@webkit.org authored
      This is fixing a crash in the textForObject method. It can
      happen when inspecting AtkObjects in the accerciser, then
      navigating to a new page and still inspecting the old tree.
      
      In this case the AccessibilityObjectWrapperAtk was still
      valid but the included renderer() was returning 0. Add a
      check for the accObject->renderer() before trying to use
      the result.
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (textForObject):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54337 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1a58308d
    • yuzo@google.com's avatar
      2010-02-04 Yuzo Fujishima <yuzo@google.com> · 0a997086
      yuzo@google.com authored
              Unreviewed.
      
              Add Yuzo to the committers list.
      
              * Scripts/webkitpy/committers.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54336 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0a997086
    • yurys@chromium.org's avatar
      2010-02-04 Yury Semikhatsky <yurys@chromium.org> · 3ee79f57
      yurys@chromium.org authored
              Unreviewed. Revert 54333 which broke Chromium build.
      
              * WebKit.gyp:
              * tests/TransparencyWinTest.cpp: Removed.
              * tests/UniscribeHelperTest.cpp: Removed.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54335 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ee79f57
    • yurys@chromium.org's avatar
      2010-02-04 Yury Semikhatsky <yurys@chromium.org> · a3c002b7
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Provide strongly typed C++ interface for inspector's injected script.
      
              https://bugs.webkit.org/show_bug.cgi?id=33616
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * inspector/InjectedScript.cpp: Added.
              (WebCore::InjectedScript::InjectedScript):
              (WebCore::InjectedScript::dispatch):
              (WebCore::InjectedScript::callFrames):
              (WebCore::InjectedScript::wrapAndStringifyForConsole):
              (WebCore::InjectedScript::releaseWrapperObjectGroup):
              * inspector/InjectedScript.h: Added.
              (WebCore::InjectedScript::InjectedScript):
              (WebCore::InjectedScript::~InjectedScript):
              (WebCore::InjectedScript::hasNoValue):
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::injectedScriptForId):
              (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::dispatchOnInjectedScript):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::inspectedPageDestroyed):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::scriptObjectReady):
              (WebCore::InspectorController::setFrontendProxyObject):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::getProfile):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::didPause):
              (WebCore::InspectorController::injectedScriptForNodeId):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::frontendScriptState):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::addConsoleMessage):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54334 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a3c002b7
    • eric@webkit.org's avatar
      2010-02-04 Yaar Schnitman <yaar@chromium.org> · bbafe7b7
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
              https://bugs.webkit.org/show_bug.cgi?id=34509
      
              * WebKit.gyp:
              * tests/TransparencyWinTest.cpp: Added.
              (WebCore::RECTToFloatRect):
              (WebCore::drawNativeRect):
              (WebCore::getPixelAt):
              (WebCore::clearTopLayerAlphaChannel):
              (WebCore::clearTopLayerAlphaPixel):
              (WebCore::operator<<):
              (WebCore::TEST):
              * tests/UniscribeHelperTest.cpp: Added.
              (WebCore::UniscribeTest::UniscribeTest):
              (WebCore::UniscribeTest::MakeFont):
              (WebCore::UniscribeTest::SetUp):
              (WebCore::UniscribeTest::TearDown):
              (WebCore::TEST_F):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54333 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bbafe7b7