- 10 Oct, 2019 40 commits
-
-
Austin Eng authored
These tests are failing on every run. Bug: chromium:1013295, dawn:208 Change-Id: I4e625753a4b39807e62905bf7aa8cef6297317a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853992Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#704861}
-
Toby Huang authored
Currently, screen readers narrate "Setup parental controls" for the title of the Add Supervision dialog. This phrase is unclear and should be changed to "Setup parental controls dialog" instead to describe the top-level dialog more clearly when in focus. Bug: 1011556 Change-Id: I82707b26c80354dfbe1395d8f3a33517be8231db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842633Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704860}
-
Yutaka Hirano authored
The bug broke extension scripts cancelling WebSocket connections in onBeforeRequest handlers with "extraHeaders" option. Bug: 1011108 Change-Id: I6aec9ff124384b80818955ee66cad05a016579bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844912Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#704859}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/51c8a7860a5a..383a4e801d41 git log 51c8a7860a5a..383a4e801d41 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 dproy@chromium.org Add .py extension to update_chrome_reference_binaries Created with: gclient setdep -r src/third_party/catapult@383a4e801d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I47916be7ebb527e672948d533671a5dd053ce9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704858}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5697a837..d372b6c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb355cdaded845b33408854fc568f265bb90ec5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704857}
-
John Emau authored
Problem: When a web audio context change event occurs the "changed to" context is first removed from the context selector list then added back. If the list only contains 1 items then the list contents goes 1 -> 0 -> 1 and the event listener AudioContextSelector._onListItemReplaced will intermediately disable the context menu during the change event when the empty state list is reached. This can cause side-effects and is extra cycles we don't need to spend. Solution: The UI.ListModel.replace method does the same operation without the intermediary empty list state. Change-Id: Ide76e2281c6c7224c22e77f3e7a5766fb2ef0a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823730 Commit-Queue: John Emau <John.Emau@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704856}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/364848cc9284..f1f2e8606a69 git log 364848cc9284..f1f2e8606a69 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 efoo@chromium.org Add "# COMPONENT" to chromite OWNERS file Created with: gclient setdep -r src/third_party/chromite@f1f2e8606a69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3e5452344b46279175bd06d3c46e2dab38f4d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853999Reviewed-by:
-
David Tseng authored
Bug: 865575 Change-Id: I8d8328a459d7621d6fc0a0d65e0f24f788b9767f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852414 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704854}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60e30b8a1a53..561ba7ee890b git log 60e30b8a1a53..561ba7ee890b --date=short --no-merges --format='%ad %ae %s' 2019-10-10 primiano@google.com Add gen_all --check-only to CI Created with: gclient setdep -r src/third_party/perfetto@561ba7ee890b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:123498112 Change-Id: I341cdf88d08771bde74853e7a02a02302b666a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853996Reviewed-by:
-
Dave Tapuska authored
Add a post dispatch hook so message filters can do work after a dispatch. This will be used for the content layer which sets the debug URL during each message dispatched. Since only one filter is ever used only allow one to be set. BUG=1008432 Change-Id: Ie531e875ea9cbf42347374030d3c5a030fa6290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853129Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#704852}
-
Dan Beam authored
Also annotate other teammates relationships to this code. R=mahmadi@chromium.org BUG=none Change-Id: I3eabc0422737c1ef0184fc554890308850ccb8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854399Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704851}
-
Evan Stade authored
All activity logging is done on the UI thread now, so there's no need for a thread-safe cache of extension whitelists or ActivityLog active state. Bug: 268984 Change-Id: I3c35017cb8413be59a270a96e587f3c401e80b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849419Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#704850}
-
Brandon Wylie authored
Events aren't getting through when they should when using UrlBar.UrlTextChangeListener. Using a combination of TextWatcher and UrlBarCoordinator triggers more frequently. Bug: 1008474 Change-Id: I60252e7f2bca878089667cc29f79f82e18884789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835101 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#704849}
-
Akihiro Ota authored
This change adds a validation check in ChromeVox's phonetic data api to avoid potential crashes. Change-Id: I47ef89e8a514c9227208e8821536ee53017c3c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850357Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Reviewed-by:
-
Yves Gerey authored
This CL introduces an ad-hoc builder for roll of opus into chromium. 1/ Used as pres-submit validation. 2/ Runs dedicated tests and benchmarks for a fixed Android model. The point 2/ shall be completed in follow-up CLs. Bug: chromium:1002973 Change-Id: Idb5c8b46ab68d8a9d63a864594396ac021a22746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816555 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#704847}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e70f3614347..d0704ce5c6a1 git log 9e70f3614347..d0704ce5c6a1 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 mellem@webrtc.org Remove RTCP tests from channel_unittest. 2019-10-10 perkj@webrtc.org Send rtcp::RemoteEstimate and rtcp::TransportFeedback in one packet Created with: gclient setdep -r src/third_party/webrtc@d0704ce5c6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I46ce58d7869a5e8a7cc6ff5c1baf405ee1cf7019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853674Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=ccameron@chromium.org Bug: 1007760 Change-Id: I6612255cd5e5c88849da9d219861a6adb72e251b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849538 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704845}
-
Rob Paveza authored
The Elements tool Properties pane is inaccessible via keyboard only. It can't be tabbed into, and even if a user clicks into it, the current selection top level tree branch can't be escaped. This change addresses this issue by replacing the use of individual ObjectPropertiesSection trees with an overarching ObjectPropertiesSectionsTreeOutline, and then creating roots for each of the objects being displayed. It also gives the OPSTO a read-only mode (matching existing behavior) and enables tabbing into the properties list. GIF of after change: https://imgur.com/a/5Fi7W3h Bug: 963183 Change-Id: I9c178c1d9758450196dd0596241047c9ea2dd813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757080 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
-
Chris Davis authored
This change removes the call made to determine the default browser state in call to shell_integration::GetChromeDefaultState. The call is expensive on all platforms and in this case the result is never even actually used. Removing CachedDefaultWebClientState from BrowserProcessImpl since it is not used. Bug: 1012357 Change-Id: Ic85f5dbdea9bd45afe2b372942069bad3136be90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845509Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704843}
-
Donn Denman authored
This CL just makes the Overlay Panel Bar height larger by updating a resource the contains the height dimension in DPs. BUG=1013333 Change-Id: I863d76ea2021ac48d52c3be212bdc34604d9f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854206Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#704842}
-
Chandani Shrestha authored
Earlier, when user pressed Enter when focus was in Add button it used to close color-picker because keydown event used to get bubbled up to inline_editor_module.js which was hiding the element. This inline_editor_module hides the suggested list of items when user presses enter in one of them. This change adds keydown handler in UI.Toolbar which consumes the keydown event similar to click handler in it which prevents hiding up color-picker when user presses enter. Also, this change gives focus to recently added item when add button is clicked which has a lightblue border color. Gif showing this change: https://imgur.com/2aaF4Y2 Bug: 963183 Change-Id: Ia4594adbb802fdf2fada7ebf62be9a8d1c148f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688337Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704841}
-
Fredrik Söderquist authored
Clamp the result to the [Min(), Latest()] range. Remove the IsFinite() checks from SVGSMILElement::ParseOffsetValue() and SVGSMILElement::ParseClockValue() since they will no longer trigger. Bug: 1012665 Change-Id: I7183888fe1a0a2dd598fb42c152dee94d216d66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852924Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#704840}
-
Mitsuru Oshima authored
CursorManager should use logical display. In addition, the this is now handled in new way which does the right thing. (https://crrev.com/c/1761772) Bug: 1013339 Change-Id: Icde517b3791ea5df468d65b4f0378a5327bc4280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853856Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#704839}
-
Mohsen Izadi authored
Everywhere we access OzonePlatform, it is already initialized (and should be in future). There is no need for EnsureInstance() anymore. BUG=958387 Change-Id: I1adf0f65ce8a446275417856caeb56c2310bea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763633Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704838}
-
Andrew Luo authored
Bug: 765833 Change-Id: Icf477e67b98c58bd45d1c7328081a9d6e25c5e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832289 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704837}
-
Giovanni Ortuño Urquidi authored
Two issues came up when trying to import bindings_lite as a module: 1. Closure compiler generated the following code in order to polyfill Number.MAX_SAFE_INTEGER: ``` Number in this ``` `this` is undefined inside modules, so the above code caused an error. We get around this by changing Closure to compile to ES2015. 2. Namespaces were being added to `this` which again is undefined in modules. To get around this, we change to `self`[1] which should work in regular scripts, modules, and workers. This CL also moves mojo tests to http/ so that the resources are served from a server which is needed in order to import modules. Not all tests need their resources to be served from a server, but we move them to http/ regardless to avoid having tests in two places. [1] https://developer.mozilla.org/en-US/docs/Web/API/Window/self Bug: 1004256 Change-Id: I5c32e37e1f57e8539b39f0bdcc85f796e114f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831660 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704836}
-
Sophie Chang authored
This also only creates the prediction manager if the feature is enabled and overrides any target decision if feature is enabled Bug: 1001194 Change-Id: Iea7db02a4e7b851967228df44c8ce7458118d1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853863Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d8a95ee71b5..66ae304f501e git log 2d8a95ee71b5..66ae304f501e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 robertphillips@google.com Plumb GrTextureProxies down into emitSampler/addSampler 2019-10-10 kjlubick@google.com [canvaskit] Enable tests for getGlyphPosition Created with: gclient setdep -r src/third_party/skia@66ae304f501e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I5c93ea91fd52d6b4088e11f19ee75be6565067db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854025Reviewed-by:
-
Antonio Gomes authored
This wraps up Onion souping of media_stream_video_webrtc_sink_unittest.cc|h that happened on [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1811179 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4302207403f614cdac329be3cb591a13f13db52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816793 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704833}
-
Simon authored
TBR=perezju@chromium.org Bug: 1013317 Change-Id: Ie5fd327f9973cce71da173a4d70539de2f859370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853947Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#704832}
-
Hesen Zhang authored
- Deleted the redundant style appled in dialog linear layout. Bug: 1012450 Change-Id: Ice1accff7bc3bc09dc625c622a679328be133d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846470Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704831}
-
Tao Bai authored
Bug: 10128236 Change-Id: Ibe238ddd409a00ae256d15e705d2c95dfad67f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849633 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
-
Kevin Marshall authored
The use of leading slashes causes path validation issues in VFS implementations like vfs::PseudoDir. This fixes the issue by discarding the leading slash from the path component of requested URLs. Adds a browser test which validates the use of PseudoDir and VfsFile with ContentDirectoryProvider. Bug: 1011180 Change-Id: I2b47ad35023be73cc32538f83b166ebaa9b85f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848411 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704829}
-
Lei Zhang authored
Instead of trying to handle a NOTREACHED() condition, just crash if the impossible happens. Change-Id: I01f79600aa0c58ec9f6276f30a4e0cc8c2f729f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853887Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704828}
-
Yuwei Huang authored
This CL renames jid_util.* to signaling_id_util.* and renames its functions from Jid to SignalingId. Bug: 983282 Change-Id: I94b50afc6b9c33031905e17c5c55ada3d846e9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853868Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#704827}
-
Josh Nohle authored
This flag will be used to enable the CryptAuth v2 DeviceSync protocol. The Chrome OS migration plan from CryptAuth v1 to v2 DeviceSync is outlined in the design document http://go/cros-devicesync-v2. Bug: 951969 Change-Id: I317f0027012fba111244ca7180e3002946074165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845431Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#704826}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1007760 Change-Id: Idc44c0d854b36239257f4bf25eeab74bd1cbd170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849489 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1007760 Change-Id: Ia37dc17f05b941994c11cbbefc99832fcc9f7179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849536 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL disables support for VP9.2 and VP9.3 in Vaapi so that decoding of these profiles falls back automatically to libvpx. This is because the majority of content in those formats is also HDR, and Vaapi does not support on ToT colorspace information nor high bit depth. Bug: 1011469, 1011454 Cq-depend-on-chromium:1845616 (CrOs tast repo). Change-Id: I1cb1d9c4f91181b7049caab961d2dec2427f360c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842564 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704823}
-
Brian Ho authored
To load the Vulkan instance function pointers, we currently use the Vulkan API version of the VkInstance (returned via vkEnumerateInstanceVersion) which refers to the maximum supported version of the Vulkan implementation on the system. The actual hardware, however, may only support up to an earlier API version. When the API versions differ between the VkInstance and the VkPhysicalDevices, the spec mandates that you must use the lowest API version [1]. More concretely, this bug manifests in Chrome when the VkInstance supports 1.1, but the GPU only supports 1.0. In this case, we load 1.1-specific functions like vkGetPhysicalDeviceFeatures2, but when we actually try to run them on our 1.0 VkPhysicalDevice, the GPU process crashes [2]. This CL fixes this bug by explicitly checking the VkPhysicalDevice's API version instead of just seeing if vkGetPhysicalDeviceFeatures2 is non-null. [1] https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkPhysicalDeviceProperties.html [2] https://cs.chromium.org/chromium/src/gpu/vulkan/vulkan_instance.cc?l=282&rcl=cf2dfbbe19a94a77242a325388eeaeb62f530483 Bug: 1012880 Change-Id: I5e60bae02cf47e3c94f0ac9ba1ed60c0712e8d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853871Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#704822}
-
