- 04 Feb, 2017 1 commit
-
-
bnc authored
Review-Url: https://codereview.chromium.org/2669953003 Cr-Commit-Position: refs/heads/master@{#448110}
-
- 03 Feb, 2017 39 commits
-
-
chenwilliam authored
BUG=687641 Review-Url: https://codereview.chromium.org/2668413003 Cr-Commit-Position: refs/heads/master@{#448109}
-
ymzhang authored
BUG=679905 Review-Url: https://codereview.chromium.org/2673673003 Cr-Commit-Position: refs/heads/master@{#448108}
-
alph authored
Review-Url: https://codereview.chromium.org/2671553005 Cr-Commit-Position: refs/heads/master@{#448107}
-
joedow authored
flexbox_flex-natural-mixed-basis-auto.html is flaky on Win7 as well as Win10 so I'm making the exception generic to Windows. BUG=626703 TBR=qyearsley@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2670383003 Cr-Commit-Position: refs/heads/master@{#448106}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0a400c91d743..6fd1f2f90e11 $ git log 0a400c91d..6fd1f2f90 --date=short --no-merges --format='%ad %ae %s' 2017-02-03 benjhayden Merge TelemetryInfo diagnostics. 2017-02-03 simonhatch Previously alert.py has some pre-hook logic to update associated groups. This involved several sync gets + query, with some potential puts and deletes. The newer implementation strips the pre-hook out in favour of heavily batching async calls when alerts are updated. 2017-02-03 rnephew [WPR] Add Platform Specific recording capabilities to record_wpr BUG=618698 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2671043003 Cr-Commit-Position: refs/heads/master@{#448105}
-
jzern authored
BUG=684340 Review-Url: https://codereview.chromium.org/2663073003 Cr-Commit-Position: refs/heads/master@{#448104}
-
mmenke authored
The default implementation of URLRequestJob::GetResponseCode() is being modified to (mostly) match what it currently does. BUG=688481 Review-Url: https://codereview.chromium.org/2670413002 Cr-Commit-Position: refs/heads/master@{#448103}
-
hcarmona authored
BUG=630157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676573003 Cr-Commit-Position: refs/heads/master@{#448102}
-
emircan authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/a4c36d8..5a5de79 $ git log a4c36d8..5a5de79 --date=short --no-merges --format=%ad %ae %s 2017-02-03 jianj@google.com Add VP9 full stack tests: - ConferenceMotionHd2000kbps100msLimitedQueueVP9 2017-02-03 stefan@webrtc.org Reland of Enable audio streams to send padding. (patchset #4 id:60001 of https://codereview.webrtc.org/2652893004/ ) 2017-02-03 agouaillard@gmail.com Protect APM in webkit builds. 2017-02-03 brandtr@webrtc.org Fix and improve FlexFEC configuration for RTP/RTCP. 2017-02-03 henrika@webrtc.org Extends timer from 10 to 30 seconds for output volume check on Android. 2017-02-03 henrika@webrtc.org Avoid calling PostTask in audio callbacks. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2675993003 Cr-Commit-Position: refs/heads/master@{#448101}
-
justincarlson authored
Along the way, clean it up a lot based on lessons learned from my first chromium code. Note this changes PpdReference to use just a single "effective_make_and_model" field to resolve ppds from the ppd server. This closely mirrors what's usually available from IPP and other sources, so seems to be the most sensible key for doing ppd lookups. This also updates all callsites and cascading changes to make the provider changes work. BUG=617253 R=skau CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2613683004 Cr-Commit-Position: refs/heads/master@{#448100} -
kojii authored
Empty LineBoxData produces empty BidiRunList, which confuses LayoutBlockFlow::constructLine() in CopyFragmentDataToLayoutBlockFlow(). There are cases where we need empty line boxes, such as when the caret is set while editing. Such cases need to be revisited in future. This is part of the effort to layout Wikipedia main page[1] with LayoutNGInline runtime flag enabled. [1] https://en.wikipedia.org/wiki/Main_Page BUG=636993 Review-Url: https://codereview.chromium.org/2676883002 Cr-Commit-Position: refs/heads/master@{#448099}
-
ymzhang authored
BUG=679905 Review-Url: https://codereview.chromium.org/2677713002 Cr-Commit-Position: refs/heads/master@{#448098}
-
lukasza authored
1. The special handling was incorrectly mangling URIs (https://crbug.com/688199#c1) 2. The special handling apparently is not needed anymore - clang tool runs fine without it (https://crbug.com/688199#c10) BUG=688199 Review-Url: https://codereview.chromium.org/2673683006 Cr-Commit-Position: refs/heads/master@{#448097}
-
eugenebut authored
BUG=683964 Review-Url: https://codereview.chromium.org/2670213003 Cr-Commit-Position: refs/heads/master@{#448096}
-
bcwhite authored
BUG=620813 Review-Url: https://codereview.chromium.org/2673083003 Cr-Commit-Position: refs/heads/master@{#448095}
-
alph authored
The patch makes the bottom-up tree to be built lazily as the user explores its branches. Review-Url: https://codereview.chromium.org/2673733003 Cr-Commit-Position: refs/heads/master@{#448094}
-
qiangchen authored
Revert of Mark Layer Damaged When The Client Is Gone (patchset #4 id:60001 of https://codereview.chromium.org/2664943002/ ) Reason for revert: Crash Original issue's description: > Mark Layer Damaged When The Client Is Gone > > We found a bug that black boxes are seen when hangouts switches focused > participants. It is related to an issue that we did not mark the layer > hosting WebMediaPlayerMS damaged properly. This CL fixed that issue. > > BUG=681006 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2664943002 > Cr-Commit-Position: refs/heads/master@{#447811} > Committed: https://chromium.googlesource.com/chromium/src/+/101569dac2a9cee88240aa87fc695b9b6fb93aa1 TBR=danakj@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=681006 Review-Url: https://codereview.chromium.org/2667383009 Cr-Commit-Position: refs/heads/master@{#448093}
-
mcasas authored
CIQRCodeFeature [1] is an interface in the CoreImage framework (which at a time was part of the QuartzCore framework) and is used to detect QR Codes in images. CIQRCodeFeature is only available in Mac OS X 10.10+, which is fine for the bots bug causes warnings elsewhere: .../CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has been explicitly marked partial here @interface CIQRCodeFeature : CIFeature ^ ../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose 'CIQRCodeFeature' in an @available check to silence this warning This CL adds it to sdk_forward_declarations so it's forward-defined when needed. [1] https://developer.apple.com/reference/coreimage/ciqrcodefeature?language=objc BUG=665150 TBR=rockot Review-Url: https://codereview.chromium.org/2667283006 Cr-Commit-Position: refs/heads/master@{#448092} -
mahmadi authored
BUG=688515 TBR=robhogan Review-Url: https://codereview.chromium.org/2677503005 Cr-Commit-Position: refs/heads/master@{#448091}
-
reed authored
BUG= Review-Url: https://codereview.chromium.org/2675793003 Cr-Commit-Position: refs/heads/master@{#448090}
-
reveman authored
This prevents us from capuring more than one cursor snapshot per frame. BUG=b/31798695 Review-Url: https://codereview.chromium.org/2676053002 Cr-Commit-Position: refs/heads/master@{#448089}
-
mcasas authored
Because is being used as the popularity of [1] bears witness to, and we'd like to measure it. [1] https://twitter.com/Paul_Kinlan/status/824932360231800832 BUG=676124 Review-Url: https://codereview.chromium.org/2670823004 Cr-Commit-Position: refs/heads/master@{#448088}
-
Matt Menke authored
Also remove a couple overrides of the method that are no longer needed, mostly from net test classes. Others can be removed in followup CLs. BUG=688481 R=juliatuttle@chromium.org Review-Url: https://codereview.chromium.org/2676033002 . Cr-Commit-Position: refs/heads/master@{#448087}
-
eroman authored
implementations other than CertVerifyProc::CreateDefault(). BUG=649017 Review-Url: https://codereview.chromium.org/2629093002 Cr-Commit-Position: refs/heads/master@{#448086}
-
skym authored
EnableDisableSingleClientTest's tests enable or disable a type, and then go verify that the root node was or was not present. This doesn't work for USS, as USS doesn't create root nodes. So ever time we migrate a USS type we have to update this file. However, this was a difficult task because of the way it was set up. Full or hard coded rules about relationships, and dependent on specific orderings of ModelType. The most egregious violation being it would call enable/disable on non-user selectable types, this would no-op, and then it'd verify it had the correct affect, because typically these grouped types are preceded by their corresponding user selectable type, and this test went through the types in order. To fix this, we start by making the test harness return false (failure) if you try to enable/disable a non-selectable type. This in turns means that EnableDisableSingleClientTest's cases need to understand some of this type group mapping. So SyncPrefs was updated to expose ResolvePrefGroups to allow intelligent tests. Not only does this allow us to remove most hard coded type rules, but we are also able to test on a more precise level, knowing typically exactly which types should change as a result of an enable/disable. The main caveat being types that are mapped to by multiple selectable types, which we're slightly less strictly testing when they change. Also updated test to guess that any new type of syncer::PRINTERS or later will be USS. This strives to reduce the pain of adding new types, although it is a risk in that the logic is fragile. BUG=686172 Review-Url: https://codereview.chromium.org/2670903002 Cr-Commit-Position: refs/heads/master@{#448085}
-
cco3 authored
Some exploration of this approach to generating upstream/downstream objects has revealed that it doesn't properly handle some use cases. BUG=685383, 687142 Review-Url: https://codereview.chromium.org/2673113002 Cr-Commit-Position: refs/heads/master@{#448084}
-
donnd authored
OverlayPanelContent#onContentLoadFinished is being called even when the content was not on the main frame, which is not correct. Looks like we don't really need this notification anyway. It was being called for metrics and to clear out history of error pages in the unlikely case that GWS returns errors for our searches when being preloaded. This CL removes OverlayPanelContent#onContentLoadFinished. BUG=685740 Review-Url: https://codereview.chromium.org/2674533007 Cr-Commit-Position: refs/heads/master@{#448083}
-
csashi authored
BUG=664367 Review-Url: https://codereview.chromium.org/2671993004 Cr-Commit-Position: refs/heads/master@{#448082}
-
hablich authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f9f5e5b..5dd3abff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. Speculative roll-back because of CL Suspected of causing webkit failures in Chromium trybots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2007 Test (fails due to leak): inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html TBR=machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2672633006 Cr-Commit-Position: refs/heads/master@{#448081}
-
mikecase authored
Add helper script to manage uploading data to logdog from the test runner. Also, add new 'links' entry to results.json file which will primarily contain logdog URLs. Review-Url: https://codereview.chromium.org/2664873002 Cr-Commit-Position: refs/heads/master@{#448080}
-
wangxianzhu authored
Shape of an outline can be affected by layout/style change of descendants. Previously we assumed that an outline will change when an object having outline is checked for paint invalidation for any reason, which covered all cases of outline changes, but also produced over invalidations, which is especially bad when we move caret paint invalidation into paint invalidation stage: a blinking caret will cause full paint invalidation of the edit box having focus ring. Now tighten the condition. If a box's outline is not affected by descendants, don't do full paint invalidation. TEST=paint/invalidation/outline-*.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2669003002 Cr-Commit-Position: refs/heads/master@{#448079}
-
chaopeng authored
This issue is caused by remove hit test element in |Document::updateHoverActiveState| when hit test contains scrollbar. Instead we should replace the hit test element to be scrollbar's parent when hitting a scrollbar. BUG=686678 Review-Url: https://codereview.chromium.org/2668133003 Cr-Commit-Position: refs/heads/master@{#448078}
-
aizatsky authored
Changes: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/4d737af21c2ce9e8b0655cd9397d83fa7956406c..64bdf915852b7a8c2b81013682d77e003280168b BUG= Review-Url: https://codereview.chromium.org/2669243011 Cr-Commit-Position: refs/heads/master@{#448077}
-
tkent authored
This CL has no behaivor changes. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2675703004 Cr-Commit-Position: refs/heads/master@{#448076}
-
poromov authored
Implemented similar to App Launch Splash Screen that is used for Chrome Kiosk. Splash screen is shown immediately after launching ARC++ Kiosk session and destructed when app window is launched. This leads to no UI exposed, except to sign in screen, splash screen and finally app window. User can escape launching of the app by pressing Ctrl+Alt+S during the splash screen. Also fixes bug of restarting app few seconds after launch. BUG=682778,682780, 681111,677310 TEST=Manual, Start ARC++ Kiosk sessions. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2649103006 Cr-Commit-Position: refs/heads/master@{#448075}
-
thakis authored
One change in behavior: clang-format wants <> includes to go first (like in Chromium -- but Chromium style recommends a newline between the <> include block and the "" include block), while they used to go to the end in Blink. BUG=688155 Review-Url: https://codereview.chromium.org/2667423006 Cr-Commit-Position: refs/heads/master@{#448074}
-
emircan authored
This test checks that canvas capture happens for N times when there are N repaints on <canvas>. Currently 2D and WebGL redraws are added. It will be followed by OffscreenCanvas and transferFromImageBitmap tests. BUG=685796 Review-Url: https://codereview.chromium.org/2658973002 Cr-Commit-Position: refs/heads/master@{#448073}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rkaplow@chromium.org Review-Url: https://codereview.chromium.org/2669923004 Cr-Commit-Position: refs/heads/master@{#448072}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/20c5e0b31c76..0a400c91d743 $ git log 20c5e0b31..0a400c91d --date=short --no-merges --format='%ad %ae %s' 2017-02-03 charliea Fix multiple --extra-args for RunEslint 2017-02-03 simonhatch Revert of Dashboard - Remove pre-hook logic from alert.py. (patchset #2 id:240001 of https://codereview.chromium.org/2650683007/ ) 2017-02-03 charliea Fix bug in run_eslint where only the exit code would be printed 2017-02-03 charliea Roll deps for eslint and eslint-plugin-html Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2677673003 Cr-Commit-Position: refs/heads/master@{#448071}
-