- 08 Jan, 2021 40 commits
-
-
Christian Dullweber authored
Bug: 1160731 Change-Id: Id615ad3a07bcd19a41eeecb1891691e37f09e866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617711 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#841519}
-
Dylan Cutler authored
This constructor does not check that that the resulting cookie is canonical, and CanonicalCookie instances should be created using one of the static factory methods. Bug: 1102874 Change-Id: I910729a0a399de78f5722fe488a38e12befd03bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586238Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#841518}
-
Friedrich Horschig authored
The CL crashes every second run. See linked bug for trace and more info. TBR=afakhry@chromium.org Bug: 116381 Change-Id: I7c9aa2dda6947970d56142aea70c35cbb821cc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616228 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841517}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff24c712..e665c5ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieb52c0509a6f27cb797e0b3f5ba5d80fbdc04896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618061Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841516}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070ef598892a..3ce4e8ee1301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I068410c3ff0c67e973d204009dd4ebb45080d687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841515}
-
Victor Hugo Vianna Silva authored
This is a reland of c547b0cd Original change's description: > Fork SyncController.isSyncingUrlsWithKeystorePassphrase() in PSS > > SyncController will soon disappear, so we start moving this method to > ProfileSyncService. The SyncController method is still exposed for the > moment because it's called in downstream code. > > There should be no behavior change in the only call site: > SyncController.get() is null iff ProfileSyncService.get() is null. > > Bug: 1156620 > Change-Id: Ida792cb92702f932aad3023d05e048be8aee94e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577227 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Victor Vianna <victorvianna@google.com> > Cr-Commit-Position: refs/heads/master@{#834745} Bug: 1156620 Change-Id: I3e15cbd0ca6d51edf340dc4339988332ecfbe190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580074Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#841514}
-
Austin Sullivan authored
Simplifies the lifetime of file writers. Previously, if the mojo pipe outlived the usefulness of the writer (i.e. after the writer had been either closed or aborted), the object would hang around until the pipe closed. Now, the writer is destroyed (and the mojo pipe closed) when the writer is closed or aborted. Bug: N/A Change-Id: I69efecba1fe8d6c94f778defa6f0eaf91d088fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595905 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841513}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51690fcadbed..3b1f7453a734 2021-01-08 tvanderlippe@chromium.org Make UIString and i18n return tagged localized strings 2021-01-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-08 jacktfranklin@chromium.org Migrate report, theme_colors and webvitals docs to TS 2021-01-08 jacktfranklin@chromium.org Migrate linkifier, perf_piechart, linear_memory_inspector examples to TS 2021-01-08 jacktfranklin@chromium.org [Docs] Migrate elements_breadcrumbs examples 2021-01-08 jacktfranklin@chromium.org Migrate icon_component, issue_survey_link, layout_pane docs 2021-01-08 jacktfranklin@chromium.org Migrate color_swatch & computed_style_* examples to TS 2021-01-08 leese@chromium.org Compare script ids when comparing console messages 2021-01-08 jacktfranklin@chromium.org Migrate data_grid_controller examples to TypeScript 2021-01-08 petermarshall@chromium.org [i18n] De-duplicate identical i18n strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132260,chromium:1144106,chromium:1163928 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8ecd4392ebd7e4df37c8eb3f0c1e13c8d150a2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618069Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ce4e8ee1301..afc78f5e6ae9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifa757d2e38530286a2707e13a5a487710c7bf3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618178Reviewed-by:
-
Maks Orlovich authored
The marshalling code writes out utf-8, but demarshalling used WTFString ctor which is latin1 Bug: 1161142 Change-Id: I55c4f5a38d76ff6f6c6e502e6a84471327de37d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602360 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#841510}
-
David Van Cleve authored
Right now, fetches from inline CSS use the inline CSS's base URL instead of the URL from the context that embeds the inline CSS: for instance, loading a source-site.com page with the following code <base href="https://other-site.com"> <style type=text/css> @import('best-sheet.com') </style> should lead to the best-sheet.com sheet getting fetched with a source-site.com referrer, but it will currently provide an other-site.com referrer. However, if the imported sheet from best-sheet.com makes more nested fetches, those nested requests should use best-sheet.com as the basis for their referrers (as they do currently). This CL updates CSSParserContext's referrer setting logic to roughly do the following: - inline CSS: use the embedding document's URL as the referrer, or, for srcdoc iframes, walk up the frame tree until hitting a non-srcdoc frame - requests from fetched stylesheets: just as currently, use the fetched sheet's URL as the basis for constructing the referrer This seemed like it required refactoring CSSParserContext slightly because there are constructors that take both a Document and a base URL, and it's not obvious from the constructor signature whether the Document or the base URL should be the one that provides the referrer. To resolve this ambiguity, the refactor updates these CSSParserContext constructors to take caller-provided Referrer objects. Change-Id: If5a99d8057dff5e771e821d0e1f605566e28ff1d Fixed: 1158645, 1158010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592447Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841509}
-
Fredrik Söderqvist authored
This reverts commit 6ef82730. We rely on the side-effect of ensuring computed style to make it possible to propagate style recalc requests to <use> instances. Bug: 1162628 Change-Id: I3a96b7a8d95f3c8c9c6b27ad10b48715f50d01e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617838Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#841508}
-
Fredrik Söderqvist authored
Make the edge-clipping a bit easier to read by computing how much to extend/shrink by first and then manipulating the "hole rect". Also move it to a helper function. Move computation of the outer rect ("area casting shadow") closer to where it is used. Ditto for |fill_color|. Also drop an unnecessary FloatSize cast. Bug: 1159514 Change-Id: I1a6daae3cfa9a5d83eafa62952f26bfe4500216a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617924Reviewed-by: -
Mike Dougherty authored
JSSuggestionManager was being created using CRWJSInjectionManager which is deprecated. This was and translate is one of the few remaining features using it. Migrating it off of this dependency will help to cleanup existing JavaScript feature code in preparation for new JavaScript features. Additionally, update usage of JSSuggestionManager within FormInputAccessoryViewHandler to check for nil JSSuggestionManager. This change is necessary because previously the suggestionManager would always exist, but now if there is no WebState, there will be no suggestion Manager. (For example, see the change in -[ManualFillInjectionHandler suggestionManger]) Bug: 949178 Change-Id: I8136efbcde14494fb37c2a1ecab5def15a289ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594207Reviewed-by:
Maria Kazinova <kazinova@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841506}
-
Kyle Horimoto authored
This previous screenshot mistakenly did not include the localized string in question. See b/176595633. Bug: 1106937, b/176595633 Change-Id: Ib32384610e3b95956147168614f9d99fe636a67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617127 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841505}
-
Fredrik Söderqvist authored
We still need to handle cases like when display transitions from 'none' to not-'none' since we might need to invalidate paint properties or similar in those cases. Unlike previously though we can just call MarkAllClientsForInvalidation(). Remove LayoutSVGResourceClipper::WillBeDestroyed() since it should no longer be needed. Bug: 1162093 Change-Id: Ic0073dd10f0043e11b6ed984b57ac122a8ec37fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614430Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/bf29902dbe3e..e395b66ed41c 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 0e5078dc0cfb to ce18d1b8a563 (1 revision) 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 134a52003407 to 0e5078dc0cfb (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I66aaa036aade761cd510e19d5f3cfa5aa9237658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618158Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101080600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/G2hKrv9siNlrFfUOPnGITX-1vPXVfef552IDKjdJcgoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/157694064,b/174286210 Tbr: media-app@grotations.appspotmail.com Change-Id: I7f7a732916391458c7efd41a3aee0272310e3877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841502}
-
Lily Chen authored
Bug: 986319 Change-Id: I2e9beaca7ed07d012fc38c248198bfe72057545b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615482Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841501}
-
Sami Kyostila authored
Use STL algorithms to split out and remove cancelled tasks from the task queue instead of reimplementing them manually. Also avoid exposing protected fields of std::priority_queue. No behavioral changes. Bug: 1155905 Change-Id: I4afb25038dea1dc2114163e19ec9c100a780701f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612900 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#841500}
-
Saurabh Nijhara authored
The unit tests for force installed extensions repeatedly use code to create an extension using ExtensionBuilder and mark the extension as loaded/ready. This code can be extracted in a common function and used from there to reduce some code duplication. Bug: 1163617 Change-Id: I8f7d88e798a44fad9f3079e22bc08c1caa93bbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611705Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#841499}
-
Colin Blundell authored
This CL removes the remaining deps on //components/signin from safe_browsing_token_fetcher.h in order to enable using this interface in //weblayer, which does not use //components/signin. Namely: - We remove the consent_level parameter altogether: in production it is always set to unconsented. - We replace the base::Optional<AccessTokenInfo> used for passing the access token to clients with just the std::string of the access token (empty if no access token was available, e.g., because of an error). This is all the state that clients used from the AccessTokenInfo. There is no behavioral change in this CL. One subtlety here is the metric computed in RealtimeUrlLookupService::OnGetAccessToken(). Currently it reports that a token was fetched if the base::Optional instance has a value. In this CL it reports that a token was fetched if the access_token string is non-empty. These cases actually coincide: - Currently, the base::Optional instance has a value iff the the underlying AccessTokenFetcher reports that there was no error in the fetch. - By the documentation of AccessTokenFetcher, the AccessTokenInfo returned from its fetch will also have a non-empty token exactly when there was no error reported by the fetch. Bug: 1080748 Change-Id: Ib0309417201c1906a0a4fb8bf71b9bac50d88bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611255 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841498}
-
Mihai Sardarescu authored
Due to a bug in https://crrev.com/c/2421739, observers were notified if RevokeSyncConsent was invoked when there was no sync consent. This CL fixes that and adds an appropriate test. Bug: 1155519 Change-Id: I9e46ea403eaa0813ce73940646ca59de63e4d916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582080 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0433378a468..36b254fb9b13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1023759 Tbr: fhorschig@google.com Change-Id: Ia75202c13e327fec7bcdd445df9fb57c6dde7e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618071Reviewed-by:
-
Justin Cohen authored
Remove the variations config, but leaving the feature itself as a kill switch. Bug: 1032928 Change-Id: I83a98fa11df058cf23a9c75ca47c7d2ef03410e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610065 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#841495}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cbc14b10e623..0901a6f74c70 2021-01-08 apodtele@gmail.com Tweak .gitignore. 2021-01-07 apodtele@gmail.com [builds/windows] Fix up DLG build with VC++. 2021-01-07 apodtele@gmail.com [builds] Relocate `FTMODULE_H'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I43d784af6c7391934f557c53628d0dfda7394b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616843Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841494}
-
dpapad authored
Previously PDF Viewer resources were registered as part of component_extension_resources.grd. This CL adds a dedicated and auto-generated grd file to hold the PDF Viewer's resources. This CL also opens up the possibility of using optimize_webui() to improve the startup performance of the PDF Viewer. Bug: 1132403 Change-Id: Ib1ed6ebc9f51dfe0ffd375b73186cfb3b07c6806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614504 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#841493}
-
Evan Stade authored
This allows Chrome to do logging for the IPH feature. Bug: 1164069 Change-Id: I57bd7dc364d1b9d913b1ea316a4df8b1951c3f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616489Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#841492}
-
Nicolas Ouellet-Payeur authored
As pointed out by rhalavati@, the kWaitingForBrowserWindow ref was removed when _any_ ScopedProfileKeepAlive was added. This does not match intended use. This CL only removes kWaitingForBrowserWindow when a kBrowserWindow ref is added. Also, record histograms in ~ProfileManager(), to detect leaked keepalives. Bug: 88586 Change-Id: Iaec7d54109b7268059c8475261fef56ca1594c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611050Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Liviu Tinta authored
There are a few wpt pointerlock tests that fail under the new wpt try bots. The wpt try bots are running wpt run in headless mode. Turns out that, when running wpt tests in headless mode with the wpt runner,the code is reaching this line in WebContentsImpl::RequestToLockMouse [1]. The problem here is that delegate_->RequestToLockMouse is actually the empty implementation from WebContentsDelegate::RequestToLockMouse. This is why the WebContents::GotResponseToLockMouseRequest is never called. The expectation for WebContentsDelegate::RequestToLockMouse is to call WebContents::GotResponseToLockMouseRequest like other code paths. The culprit is HeadlessWebContentsImpl:Delegate, which inherits the empty implementation of WebContentsDelegate::RequestToLockMouse. When running the wpt tests without --headless the delegate is an instance of Browser class. Implement HeadlessWebContentsImpl:Delegate::RequestToLockMouse similar to what we do for content shell. [1] https://www.google.com/url?q=https://source.chromium.org/chromium/chromium/src/%2B/master:content/browser/web_contents/web_contents_impl.cc;drc%3D3fab4813ccc76de821bb74b441ff491afc8a7a6f;l%3D3402&sa=D&source=calendar&ust=1608479687279000&usg=AOvVaw2Q3jZFrFsbSnQd8osPwpOU TEST=external/wpt/pointerevents/pointerlock/pointerevent_getCoalescedEvents_when_pointerlocked.html,external/wpt/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html,external/wpt/pointerevents/pointerlock/pointerevent_getCoalescedEvents_when_pointerlocked.html,external/wpt/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock.html,external/wpt/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture.html,external/wpt/pointerevents/pointerlock/pointerevent_pointermove_in_pointerlock.html,external/wpt/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked.html Bug: 1127055 Change-Id: Ic1da165fed1dc1902c5e8c0dbb5f7cfc7513ee30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594009Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#841490}
-
Fergal Daly authored
This is a reland of 2cda8338 Test is Flaky on Mac, so relanding with Mac disabled. Original change's description: > Reland "[Paint Preview] Post task captured callback" > > This is a reland of c669ac6b > > This is the test only, the fix was landed in https://crrev.com/c/2598087 > > - the previous test did not reproduce the crash, this one has crash a > crash that matches the trace in the wild > https://ci.chromium.org/p/chromium/builders/try/linux-dcheck-off-rel/16863? > It differs from the previous test by > - calling SetNeedsReload (emulating Clank's autorefresh) > - navigating to another frame afterwards, triggering Unload > > - the previous test timed out on some builders. It's possible that > the callback was already called before the test's own RunlLoop > started, which would mean that the loop never exits. This is avoided > by recording whether it has run or not. > > Original change's description: > > [Paint Preview] Post task captured callback > > > > This CL attempts to fix a bug where calling > > WebContents::DecrementCapturerCount in the callback passed to > > PaintPreviewClient can result in reloading a crashed render frame. > > This is problematic and crashes if it occurs inside RenderFrameDeleted > > and PaintPreviewClient::OnFinished is invoked. By posting the callback > > it should be invoked after RenderFrameDeleted cleanup is done resulting > > in DecrementCapturerCount no longer being called inside > > RenderFrameDeleted. > > > > Bug: 1146573 > > Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247 > > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#837649} > > Bug: 1146573, 1160608 > > > Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel > Change-Id: I3ef0a81bb4fa99e2f42c6278ba53931aa934793e > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596697 > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Auto-Submit: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840497} Bug: 1146573 Bug: 1160608 Change-Id: Ib26af42633d55e49752623930ce63245b6f4482e Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615724 Auto-Submit: Fergal Daly <fergal@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#841489}
-
Jordan Demeulenaere authored
This CL introduces a new SEND_FEEDBACK chip type that shows the feedback form when it is selected. This new chip type can only be used inside a Prompt atm, but follow-up CLs will expose the feedback chip for more use cases (e.g. client errors). Bug: b/173401004 Change-Id: Idea938ed9f3706ab88be7da2bcf1c34be5a3eb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617923Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#841488}
-
Antonio Sartori authored
Initially, this parameter was just an enum, so we were passing it by value. Now it became a struct, so we should pass it by const reference. Bug: 1130587 Change-Id: I6c02e4453259914c01a7d6c218be66cc5af30ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616560 Auto-Submit: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841487}
-
dpapad authored
With the addition of the |resource_path| grd attribute, there is no longer a need to manually handle generated paths in ChromeComponentExtensionResourceManager. This is in preparation of auto-generating the grd file for the PDF Viewer. Bug: 1132403 Change-Id: I7d788c5cfaa3da21471a76bf4dd7585a56339ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614130Reviewed-by:
-
Alexei Svitkine authored
Feature params cannot change at runtime. Retrieve them only once, instead of repeatedly. We're seeing lots of crashes with SIGABRT on shutdown retrieving UKM feature params by these code paths. SIGABRT may suggest that it's just shutdown taking too long and it just happens to land here (because retrieving params takes a bit of time). Eliminate this possibility by caching these values. This should slightly speed up UKM recording, including on shut down. If shut down still takes too long and is the cause of the SIGABRTs we're seeing, the stack traces should hopefully change and the field trial param code won't be blamed anymore (perhaps replaced by some other slow code, which can be fixed separately). Bug: 1131877 Change-Id: I365e7a6fac5d3ef941cd0a26e9b280d03df6b28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615820 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Austin Sullivan authored
This finishes renaming in blink, with the exception of web platform tests. Renames "NativeFileSystem" to FileSystemAccess or FileSystem. Generally, NativeFileSystem is renamed to FileSystemAccess. In cases where IDL exposes something as "FileSystem", NativeFileSystem is renamed to "FileSystem". Bug: 1110509 Change-Id: I483c50ae0ffa2de7946c0bd802c5082715113d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601576Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#841484}
-
Ryan Hansberry authored
Change-Id: I2643b6473c8b88fb901cef59b265af336878bfda Fixed: 1160901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612034 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Owen Min authored
The test is timeout on trybots which is likely caused by the RunUntilIdle() function which is put here just in case. Trying to solve the timeout issue by removing the function. Bug: 1137094 Change-Id: I4e48b937901ffa23f2daff6c41050eaa7b9f7f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615324Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841482}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb3bcf88e382..d2f51b18065a 2021-01-08 johnstiles@google.com Fix fuzzer-discovered optimizer crash. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I85a386f3f3a1998c3d9438949dae0f3939c41c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618068Reviewed-by:
-
Joe Mason authored
This conflicts with the use of 0 bytes as a sentinel for frames that hadn't been measured and should be dropped from the result. So this also makes the bytes optional in WebMemoryBreakdownEntry, so that frames with a byte count of 0 are reported and frames without a byte count are dropped from the result. R=ulan Bug: 1085129 Change-Id: Ie838c72049465e3a3bef9c0a9bb3a11aa648e62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616818Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#841480}
-
