GitLab

It will be less error-prone to pass references instead of pointers.
Customers don't need to add ASSERT().

This is a follow-up CL of https://codereview.chromium.org/547383004/,
and no changes in behavior.

BUG=321462

Review URL: https://codereview.chromium.org/558283004

git-svn-id: svn://svn.chromium.org/blink/trunk@181871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,adamk@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/570453003

git-svn-id: svn://svn.chromium.org/blink/trunk@181870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just some styling and import boogs, but they meant buttons
didn't render at all.

NOTRY=true
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/564023002

git-svn-id: svn://svn.chromium.org/blink/trunk@181869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of going through string(), use
the AtomicString API directly.

Review URL: https://codereview.chromium.org/560273004

git-svn-id: svn://svn.chromium.org/blink/trunk@181868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused use-after-free in :LocalDOMWindow::willDetachDocumentFromFrame.
https://code.google.com/p/chromium/issues/detail?id=413316

> Simplify DOMWindowProperty and its unregistration.
> 
> As LocalDOMWindow controls the registration lifetime of its
> DOMWindowProperties, there's no need to offer a separate unregistration
> mechanism. Remove it, simplify notification code + retire now unused
> LocalDOMWindow back reference on DOMWindowProperty.
> 
> R=haraken,ager
> BUG=
> 
> Review URL: https://codereview.chromium.org/558213002

TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/564013002

git-svn-id: svn://svn.chromium.org/blink/trunk@181867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have basic support for IDL dictionary so we can use it for
MIDIOptions. Renamed m_sysexEnabled and setSysexEnabled()
because their role have changed.

MIDIOptions is the first IDL dictionary in modules/ so this CL
also contains GYP/GN changes.

Existing tests (LayoutTests/webmidi) should cover this change.

BUG=403150

Review URL: https://codereview.chromium.org/547383004

git-svn-id: svn://svn.chromium.org/blink/trunk@181866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds trace events for setNeedsLayout calls so that we can
do end-to-end tracking of what causes repaints to occur. The devtools
side isn't yet hooked up so this patch simply adds the trace event.

As a cleanup, "core/inspector/InspectorTraceEvents.h" has been moved
up into RenderObject and unneeded includes have been removed.

R=kouhei
BUG=410701

Review URL: https://codereview.chromium.org/561413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Directly embed the failure cards into the failure stream, and abstract
the button UI out into ct-failure-card-buttons.

NOTRY=true
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/565523002

git-svn-id: svn://svn.chromium.org/blink/trunk@181864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of passing a String url and having ResourceRequest
create a KURL out of it, pass in the readily available
KURL object.

Review URL: https://codereview.chromium.org/561383002

git-svn-id: svn://svn.chromium.org/blink/trunk@181862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is the first in a three-sided set of changes, and introduces
WebSourceBufferClient for handling media engine notifications
of newly received initialization segments.
It adds logic to make the addition of a SourceBuffer into
MediaSource.activeSourceBuffers more compliant once all three sides
land: addition will be done per the MSE spec's first initialization
flag logic rather than other non-compliant approaches like at
addSourceBuffer() time or on transition to HAVE_METADATA. Insertion
logic is included to preserve correct ordering of
activeSourceBuffers.
Updated and new layout tests are included.

R=acolwell@chromium.org,philipj@opera.com,tkent@chromium.org
TEST=No mediasource layout test regression
BUG=249428,397243

Review URL: https://codereview.chromium.org/552943002

git-svn-id: svn://svn.chromium.org/blink/trunk@181861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is patchset 1 of 4 in making that happen.

This patch changes update-w3c-deps to do the import. Tests will now be imported into the "LayoutTests/imported" directory, to avoid any conflicts with the old git repos.

This patch significantly reworks update-w3c-deps, and patches webkitpy.test_importer to remove the import logs, make logging work better during the import, and handle skipping subdirs properly when not importing in place.

This patch also adds an exit() method to the SystemHost class to remove one more reason for importing sys.

TBR=eseidel@chromium.org
BUG=413454
BUG=

Review URL: https://codereview.chromium.org/565673006

git-svn-id: svn://svn.chromium.org/blink/trunk@181860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The existing implementation instead couldn't decide if it wanted to
calculate the nearest time or how close a given time was to a range.

The new implementation follows the HTML spec for TimeRanges where
nearest() returns a time within the range closest to the desired
time. Equidistant matches are resolved by distance from the current
time.

BUG=412562
TEST=new unittest.

Review URL: https://codereview.chromium.org/559993004

git-svn-id: svn://svn.chromium.org/blink/trunk@181859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/567673003

git-svn-id: svn://svn.chromium.org/blink/trunk@181858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Drop worker support from DatabaseClient.
- Remove WorkerGlobalScope support of DatabaseContext::allowDatabaseAccess.

BUG=397429
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/564713002

git-svn-id: svn://svn.chromium.org/blink/trunk@181857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add a similar test to make sure the API exists/rejects in service workers.

BUG=383125

Review URL: https://codereview.chromium.org/543203003

git-svn-id: svn://svn.chromium.org/blink/trunk@181855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/544823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=413341
NOTRY=true

Review URL: https://codereview.chromium.org/563923003

git-svn-id: svn://svn.chromium.org/blink/trunk@181852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It turns out that selection of all elements in console (aka Ctrl-A)
works properly only if the last element in viewport DOM is a block
element with some text.

BUG=410899
R=vsevik

Review URL: https://codereview.chromium.org/564893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Split out CSSParser public API (patchset #1 id:1 of https://codereview.chromium.org/566703002/)

Reason for revert:
Bring it back since the OilPan builder is not a tree closer.

Original issue's description:
> Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)
> 
> Reason for revert:
> Caused compiling errors.
> 
> Original issue's description:
> > Split out CSSParser public API
> > 
> > This patch separates the public API of BisonCSSParser from the hundreds
> > of public methods it exposes. The plan is to build a new parser based on
> > the css-syntax specification, which will eventually complete replace the
> > bison-based parser. The functions in this class will do the run-time
> > switching between the bison parser and the new (unwritten) parser.
> > 
> > For the functions here which are only ever used with a newly instantiated
> > BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> > the functions can be static.
> > 
> > This is an updated version of a patch by eseidel from 8 months ago:
> > https://codereview.chromium.org/112933010/
> > 
> > BUG=330389
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825
> 
> TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181837

TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/563893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes crbug.com/411933 where overlay scrollbars in ChromeOS would show
up on the new tab page even though they weren't needed. This was occurring
because the page scale factor limits, though set in RenderViewImpl::Initialize,
were ineffective until a layout occured since Blink's PageScaleConstraintsSet
wouldn't have computed the final constraints. Thus, the limits used were Blink's
default limits, set to hardcoded values in PageScaleConstraintsSet. This caused
the scrollbar in the compositor to think the page was zoomed in and displayed
the scrollbars.

This patch replaces the uncomputed final constraints with "all 1" values for
minimum, maximum and initial scale, rather than using the (Android-specific)
defaults.

BUG=411933

Review URL: https://codereview.chromium.org/567663002

git-svn-id: svn://svn.chromium.org/blink/trunk@181848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A Skia change caused this to start failing, and the bug in Skia has since been fixed.
Remove the suppression since these tests have been passing.

TBR=senorblanco,hclam
NOTRY=true
BUG=408858

Review URL: https://codereview.chromium.org/568543002

git-svn-id: svn://svn.chromium.org/blink/trunk@181847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The handling of the PromiseDataWrapper in r181662 wasn't complete, as it
failed to keep an Oilpan-reachable persistent to the GCed wrapper object,
risking premature finalization. For Oilpan also, this wrapper object should 
only keep its references weakly alive.

To make the tracing of these relationships work out, PromiseTracker is
no longer a part object, but heap allocated.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/561753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412251
R=pdr@chromium.org
TEST=./Tools/Scripts/run-webkit-tests fast/events/click-*

Review URL: https://codereview.chromium.org/562653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/559383002

git-svn-id: svn://svn.chromium.org/blink/trunk@181843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All scripts currently load at a medium priority and compete with each
other for resources. Async scripts do not block the parser and should be
loaded at a lower priority than those that do.

This patch lowers the priority of scripts with async or defer attributes
and scripts that were injected dynamically to load at a "low" priority
which is below blocking scripts but above (non-visible) images.

Visible images are loaded at the same priority but with a higher
intra-priority based on the screen area they cover so visible images
can preempt async scripts once layout is done (a good thing).

We want to keep scripts at a higher priority than (non-visible) images
for a couple of reasons:

1 - Scripts may cause other resource loads while images do not
(generally). There is potential to push out the onload time of the page
if a script with lots of follow-on content is loaded at the end after
images.

2 - By the time the code executes to inject the script the preload
parser may have already discovered the bulk of the images on the page.

Test results: https://docs.google.com/spreadsheet/ccc?key=0As3TLupYw2RedC1RUHlMRHhFY3RoVHEtc2FhbXQ1aWc&usp=sharing

Slight improvements (~1%) to onload, render and DOM Content Loaded.
1-2% improvement on Speed Index.

BUG=408229

Review URL: https://codereview.chromium.org/514893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some compile failures on Sheriff-O-Matic link to the wrong page today, causing
"No results to display" to be shown under the information for a host, instead
of stdio for that compile failure.

This change checks if the step is "compile" and always displays stdio in that
case.

I haven't added a test case for this; I'd like to clean up the routines in this
class to make it easier to test. I tested this manually while waiting for a
compile failure to happen that didn't display well.

NOTRY=true
BUG=404927

Review URL: https://codereview.chromium.org/549313005

git-svn-id: svn://svn.chromium.org/blink/trunk@181841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since we are supposed to end up with an AtomicString, don't rely on implicit conversion, but provide it as static local variable while using ConstructFromLiteral to avoid using strlen.

Review URL: https://codereview.chromium.org/567653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/565723002/)

Reason for revert:
Not a culprit.

Original issue's description:
> Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/)
> 
> Reason for revert:
> Your patch broke quite a number of webkit tests:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462
> 
> Original issue's description:
> > CSP: Convert CSPSource constructor bools into a enum.
> > 
> > Rather than passing the wildcard disposition of CSPSource's hosts and ports
> > as booleans, we should have an enum that allows us to figure out hat we
> > mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> > order to make this clear.
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821
> 
> TBR=jochen@chromium.org,mkwst@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181833

TBR=jochen@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/563863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)

Reason for revert:
Caused compiling errors.

Original issue's description:
> Split out CSSParser public API
> 
> This patch separates the public API of BisonCSSParser from the hundreds
> of public methods it exposes. The plan is to build a new parser based on
> the css-syntax specification, which will eventually complete replace the
> bison-based parser. The functions in this class will do the run-time
> switching between the bison parser and the new (unwritten) parser.
> 
> For the functions here which are only ever used with a newly instantiated
> BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> the functions can be static.
> 
> This is an updated version of a patch by eseidel from 8 months ago:
> https://codereview.chromium.org/112933010/
> 
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825

TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/566703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And switch LinkHighlight over to using DisplayList.

The GraphicsContext change is needed for cases when we wish to record a DisplayList without
an existing GraphicsContext. The LinkHighlight case demonstrates that.

R=pdr@chromium.org,chrishtr@chromium.org,esprehn@chromium.org
BUG=410019

Review URL: https://codereview.chromium.org/541913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This field is no longer needed or in use by embedders, and can be
safely removed.

This is part 4 of a 4-sided patch simplifying WebTouchEvent:
1) https://codereview.chromium.org/557863002/
2) https://codereview.chromium.org/558773002/
3) https://codereview.chromium.org/559693003/
4) This change

BUG=358132

Review URL: https://codereview.chromium.org/560493003

git-svn-id: svn://svn.chromium.org/blink/trunk@181834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/)

Reason for revert:
Your patch broke quite a number of webkit tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462

Original issue's description:
> CSP: Convert CSPSource constructor bools into a enum.
> 
> Rather than passing the wildcard disposition of CSPSource's hosts and ports
> as booleans, we should have an enum that allows us to figure out hat we
> mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> order to make this clear.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821

TBR=jochen@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/565723002

git-svn-id: svn://svn.chromium.org/blink/trunk@181833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also moves the basic V8 initialization to gin. The main advantage
is that we now initialize V8 first and then start creating isolates. It
also removes some code duplication.

BUG=none
R=haraken@chromium.org,andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/559363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I verified manually that the new files differ from the original expected
results by a few bits. I did not investigate the underlying cause for
the difference, but I suspect some changes in ffmpeg is causing these
differences.  Android was using the linux files for the expected
results so changes in ffmpeg can cause Android results to differ since
WebAudio uses Android's MediaCodec framework to decode audio files.

BUG=407368
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/501213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

blink scheduler still needs to know about them because we
want it to enter low latency mode when the user is
interacting with the device.  To facilitate that this patch
adds an didReceiveInputEvent API function.

BUG=391005

Review URL: https://codereview.chromium.org/554693004

git-svn-id: svn://svn.chromium.org/blink/trunk@181830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebTouchEvents passed to plugins no longer use the changedTouches or
targetTouches properties, rebaseline appropriately.

TBR=loislo@chromium.org,jianli@chromium.org
BUG=413098

Review URL: https://codereview.chromium.org/563643003

git-svn-id: svn://svn.chromium.org/blink/trunk@181828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yosin@chromium.org
BUG=388681

Review URL: https://codereview.chromium.org/560653003

git-svn-id: svn://svn.chromium.org/blink/trunk@181827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This follows the lates spec update: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23170

R=dglazkov@chromium.org
BUG=408272
TEST=import-defaultView.html, import-script-prototypes.html

Review URL: https://codereview.chromium.org/560183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch separates the public API of BisonCSSParser from the hundreds
of public methods it exposes. The plan is to build a new parser based on
the css-syntax specification, which will eventually complete replace the
bison-based parser. The functions in this class will do the run-time
switching between the bison parser and the new (unwritten) parser.

For the functions here which are only ever used with a newly instantiated
BisonCSSParser, I've moved instantiation to inside the CSSParser so that
the functions can be static.

This is an updated version of a patch by eseidel from 8 months ago:
https://codereview.chromium.org/112933010/

BUG=330389

Review URL: https://codereview.chromium.org/566483002

git-svn-id: svn://svn.chromium.org/blink/trunk@181825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 44cef15dcdbf3b78339c3678fe533f3a97e59870.

The patch were reverted due to problem with uninitialized memory.

BUG=413229
TBR= jianli@chromium.org,  dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/557823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181824 bbb929c8-8fbe-4397-9dbb-9b2b20218538