- 14 May, 2020 40 commits
-
-
Robbie McElrath authored
This CL hooks up a skeleton Site Settings UI, which for now just shows a single string. The focus of this CL is hooking up the RemoteFragment. Hooking up the UI Fragments themselves will be in a followup. Bug: 1049683 Change-Id: Ie9d79d928655067565a90ef96b5cc49dba591c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199986Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#769017}
-
Tim Song authored
BUG=1073536 Change-Id: If5988a47ff11f0bc15021c558039c3465e1a3b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198602 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769016}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/db592f10d318..ae9bd93fb5cc git log db592f10d318..ae9bd93fb5cc --date=short --first-parent --format='%ad %ae %s' 2020-05-14 bsheedy@chromium.org Ignore .dat files when pulling CrOS dumps Created with: gclient setdep -r src/third_party/catapult@ae9bd93fb5cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082255 Tbr: nuskos@google.com Change-Id: If37c8a0bdf66b6b1a37a7ddecb86e35c4c883986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769015}
-
Chris Lu authored
Bug: 1071914 Change-Id: Ifd26c511e4011d4d14b01839d294259552b2ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199692Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#769014}
-
Zentaro Kavanagh authored
- Fixed some #includes - Used default where appropriate - Used auto where appropriate Bug=None Test=None Change-Id: I870d9ba95f5e65bb4f6846b308aa0e25e842bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202962Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#769013}
-
Moe Ahmadi authored
Bug: 1079040 Change-Id: I913f809e0906858cd925f38c628d99d0f7d6758c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202504Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769012}
-
yilkal authored
This cl normalizes a url before checking if it has been whitelisted. This is required because a smart user can circumvent the blocking page by using a whitelisted url in the query part of a url that the user wants to visit. Bug: 1082817 Change-Id: Iba1a09c6870582bfc4af77a3f5975c41c546705f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199994Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#769011}
-
Jacques Newman authored
This change allows us to defer sending events to improve performance during the initial page load. EventScheduleMode determines if we schedule events with a delay or not. EventScheduleStatus replaces ack_pending_, and tracks what state we are in with regard to event scheduling. This is based on: CL 1691523: Large batch accessibility event processing during page load Bug: 976849 Change-Id: I74cd5f31102199f8c5752e0ef5d0eb623fdbd9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123310Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#769010}
-
Garrett Beaty authored
Bug: 1056428 Change-Id: If9dc68ce95b45a79faa2992294d46d53e252293b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197601 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#769009}
-
Ghazale Hosseinabadi authored
This is the last CL to remove NOTIFICATION_EXTENSIONS_READY_DEPRECATED. Bug: 411566 Change-Id: I69937ae19ed42e259509ac0587d5285a33cb56b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#769008}
-
Wei-Yin Chen (陳威尹) authored
Add "quick" and "pinned" modes to Finch parameter "omnibox_scroll_mode" to make the omnibox in Start surface omnibox-only variation more visible. The default mode requires scrolling all the way to the top for the omnibox to re-appear. "Quick" mode makes omnibox re-appear when scrolling up anywhere in the recycler view. "Pinned" mode makes omnibox pinned at the top and never hide. Bug: 1082664 Change-Id: I4b593019940a9c7d51ce9a5a1ee5df6dda180502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199934 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#769007}
-
Xiaohui Chen authored
Bug: b:154268518 Change-Id: I50639eb364d74c3c7cfc42842b85dd915850015f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199993Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769006}
-
Daniele Castagna authored
This reverts commit a79f5b3b. Reason for revert: Enabled the optimization on the wrong platforms and it causes flickering (crbug.com/1082947) Original change's description: > viz: Re-enable ignore_undamaged on platforms using GL buffer queue > > SurfaceAggregator has an option to output only the quads that > intersect the damage rect computed by SA itself. > > This optimization was disabled on devices with HW overlays or where > the renderer might expand the damage, since SA would not know the > final damage rect. > > This CL re-enables the optimization on devices where we can estimate > a bounding rect of the renderer expanded damage. > > This is achieved by asking to the renderer for a bounding rect that > represents the maximum area that can be expanded. > SurfaceAggregator will aggregate the boundingrect union the damage. > > The damage on the root render pass will be unchanged, so that HW > overlays damage computation won't be affected. > > > Bug: 1077210 > Test: viz_unittest (new test and Display tests) > Change-Id: Ie94d1f09923959e2e025845f89a9b3eae759a64a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179763 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768572} TBR=dcastagna@chromium.org,sunnyps@chromium.org,kylechar@chromium.org Change-Id: Id7453435c8b50981e5b7752855e3fd2190076676 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203219Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#769005}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/053213d049fa..176bf641480b git log 053213d049fa..176bf641480b --date=short --first-parent --format='%ad %ae %s' 2020-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@176bf641480b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ice51f7ccc42785e85fb2a9647515174c4b62f942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202488Reviewed-by:
-
Wenyu Fu authored
Add two more metrics to track the number of times HomepagePromo is seen until user take action or dismiss the promo. Bug: 1068831 Change-Id: Iddb9777ef58289d4a97708dd1c61b30f316a056a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199931Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769003}
-
Andrew Walbran authored
This is a licensed third-party controller for the Nintendo Switch. It doesn't support vibration, and doesn't report valid calibration data for the joysticks so default values are used instead. BUG=1077889 Change-Id: If5fdecf5a9a3d92ffd85ac67a6c2ccd438c8428c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188611 Commit-Queue: Andrew Walbran <qwandor@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#769002}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e272a6a2895..446c499de196 git log 8e272a6a2895..446c499de196 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tmathmeyer@chromium.org Match some color schemes to the other parts of devtools Created with: gclient setdep -r src/third_party/devtools-frontend/src@446c499de196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id98f594e3cbaf5af9265a6379e1af21c9e09903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202490Reviewed-by:
-
Moe Ahmadi authored
Adds the ability to render the *full* version of autcomplete matches (including entities) and handle interactions with them such as: 1. showing and hiding matches in a suggestion group. 2. removing a match using the RHS remove button. 3. navigating to a match via click. 4. updating the realbox icon/favicon as the match selection changes. Bug: 1041129 Change-Id: Iee5d8192cd0b2b122a4c9b22a7860278fa5d37be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199361 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
Adjusted the logic in ClientHints::IsJavaScriptAllowed to better reflect the default value of `null` (and align closer to most of the logic in most of Blink) and check in even more places! Bug: 1082674 Change-Id: I75cd95ef66c95e6633825e7657409b01fcf75db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201976Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#768999}
-
dpapad authored
Bug: 866236 Change-Id: Ifd37272f147fba8cf068db10dbdf37bbecf09944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202662Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#768998}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.gestureScroll* with gpuBenchmarking.smoothScrollByXY in third_party/blink/web_tests/fast/scroll-behavior/scroll-over-resizer.html. Bug: 1047176 Change-Id: I48ab79295e22e350f577200ead7fdbd15624a6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183480Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#768997}
-
Jérôme Lebel authored
Adding drainUntilIdle after "Manage Sync" is tapped and before to open again the settings. When "Manage Sync" is tapped, the sign-in UI can take a little bit of time to be dismissed. Fixed: 1077187 Change-Id: I7c2e0da6c1d0912e3374b1761f54f648673c590c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178889Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768996}
-
Travis Skare authored
Change-Id: Ib13ad2a8d2300cf8de7d6cd0f2bb991d7c4f91e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132594 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#768995}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None Change-Id: I4677d686f6a9508df6cd5fdde0908b40934b3960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199180 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#768994}
-
François Doray authored
This reverts commit ce5b93b3. Reason for revert: We have collected enough data. We do not want the DumpWithoutCrashing in release branch. Original change's description: > [threadpool] Report when a sequence holds more than 10000 tasks. > > That suggests that there is code that posts tasks faster than they can > be executed by the pool, leading to unbounded memory usage growth. > These cases should be identified and fixed. > > crbug.com/1071127 is a known instance of this problem. > > PendingTask is 72 bytes. 10000 tasks ~ 720 KB > > From the ThreadPool.NumTasksInSequenceOnPush histogram that was briefly > recorded in 84.0.4121.0, the max value recorded by a user in a day is > above 10000 tasks for less than 0.01% of users. Therefore, we don't > expect this change to flood the crash server. > > Bug: 1071127 > Change-Id: I08e4d44f36a816439931fc187a7753f3af4ddd1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151686 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763872} TBR=gab@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1071127 Change-Id: Iab689966dfe9552fb2ffabcb4ab4d17467e1760f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202506Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#768993}
-
John Delaney authored
This CL gates conversion registration on the redirect being same origin. This is done to prevent sites from triggering registration events for other reporting origins without their consent. This change introduces a new struct on ResourceRequest containing the previous url in the redirect chain. This url is then used to perform a same-origin check when looking for a conversion redirect. Bug: 1042919 Change-Id: I444dfacdb5209e5c63019c369a7900db25250b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171545 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#768992}
-
Rahul Singh (EDGE) authored
This is a follow up to https://crrev.com/c/2146212 which added support for App Icon Shortcuts Menu on Windows. This CL adds UMA metrics for shortcuts menu registration and unregistration on Windows. These will help us track the stability of this newly added feature. Bug: 1077083 Change-Id: Ie41aa70f1a7f07253d11d0b516877281b188b5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191322Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768991}
-
Mugdha Lakhani authored
Bug: 1077766 Change-Id: I8079081f01ac1c69b28b169d0b159dedf121a783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199288 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#768990}
-
Domenic Denicola authored
These are based on https://github.com/WICG/origin-isolation/blob/master/scenarios.md#session-history-scenarios. Bug: 1042415 Change-Id: If58a573764cb31ac34e17627555403134edac30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202657 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#768989}
-
Tao Bai authored
Added Datalist into FormFieldData. Remove SetDataList() mojo interface. This patch doesn't change any feature. Bug: 949555 Change-Id: I7b8c79a73ab37c6f66d59e32d40b72dcd8f6996d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197199Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#768988}
-
Dana Fried authored
This reverts commit ca2e472b. Reason for revert: breaks compile, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/4247? Original change's description: > [ios] Reduce pointer boilerplate in Credential Provider > > crrev.com/c/2199891 introduces a reusable class for pointer > interactions for non-button views. This class internally handles > all the delegate callbacks. So usage is simplified to a single line. > > This CL should have no impact/change on the UI. > > Bug: 1073961 > Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768924} TBR=edchin@chromium.org,javierrobles@chromium.org Change-Id: Ib4e9c99203d3dbb673d49f302b342d2055561b3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203138Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Dana Fried <dfried@google.com> Cr-Commit-Position: refs/heads/master@{#768987}
-
Dana Fried authored
This reverts commit 16307825. Reason for revert: crashes in tests on Mac Release (Intel) - see attached bug for information Bug: 1082966 Original change's description: > Metal: Run test shaders on a ThreadPriority::DISPLAY thread > > The Metal test shaders are compiled in a function that comes from > a PostTask. There is currently no path through which a PostTask > will end up running on a ThreadPriority::DISPLAY thread. > > Change the Metal test code to create a ThreadPriority::DISPLAY > thread and do its work there. A separate change is making that > correspond to a pthread priority of 50. > > Of note is that Metal's callback to Chrome comes from a Metal-created > thread which has priority 31. > > Also change the default test shader to be a Compile instead of a > Link (the Link tests have not been completed). > > Bug: 974219 > Change-Id: Ieb5ab0748b3aa255ee7dd3348870ddf812caa682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200357 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768962} TBR=avi@chromium.org,ccameron@chromium.org Change-Id: I852346697048fc916711ea60dd050b646a53705c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203257Reviewed-by:
-
edchin authored
The NTP omnibox pointer hover effect looks slightly oversized. This CL reduces it by 1 point. Bug: 1073961 Change-Id: Idd6daa3952cf4521083c2110a6d6b5645157f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203018Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768985}
-
Ali Juma authored
The WebKit build directory contains a copy of libclang_rt.asan_osx_dynamic.dylib inside WebKitTestRunnerApp.app. This file is also needed at the top level when fuzzing, since trying to dynamically load a version of this library from other locations leads to crashes. This CL makes copy_webkit_for_clusterfuzz.py copy this library to the top level, and makes run-clusterfuzz.sh set DYLD_LIBRARY_PATH to this top level directory. Bug: 1064181 Change-Id: I7de42891c39c12ae422beb6e8031745ff36640b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202682Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#768984}
-
Nate Fischer authored
This logs a histogram to check crash collection state. This does a small refactor to move the work of creating the error message into the callback. This is a small optimization (this work is only needed if crash collection is disabled), but also makes it easier to only log these cases when they're user facing. Fixed: 1082506 Test: Verify the error UI looks correct in each state Change-Id: Ib78bc5e788e7ec53a4ce591a3121ecdc8c17ec36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200277 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#768983}
-
Steve Kobes authored
Intent to ship: bit.ly/clssesi2s Bug: 1053510 Change-Id: Ibd24c3f11c08c71c3e83eb6f2ae1749f13170202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197557Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Jae Hoon Kim authored
DBus method calls to |Uninstall()| and |Purge()| to dlcservice will not be queue'ed and all dlcservice errors will be propaged to callers. This change is to reduce complexity in the client and transition the complexity into the platform dlcservice. BUG=chromium:1071656 TEST=./unit_tests Change-Id: Ic58432cd09dc8f41422ab6ff5667e5e36a4d6c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199687 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#768981}
-
Tobias Sargeant authored
This also adds an allow list of crash keys, derived from the WebView set. Bug: 1064594 Change-Id: I8e476444a8b2bb7a3e9301598fbed719809c6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202996 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This logs the length of the crash UI's user-facing list to UMA. Fixed: 1082468 Test: None Change-Id: Iff1436454c3e3f5aa7d5950414e6ab246f4d61f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199872 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768979}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2b7d96959916..37120ab59d1f git log 2b7d96959916..37120ab59d1f --date=short --first-parent --format='%ad %ae %s' 2020-05-14 danilchap@webrtc.org in RtpSenderVideo propagate chain_diffs into dependency descriptor Created with: gclient setdep -r src/third_party/webrtc@37120ab59d1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id00984b6f7247d1517015b6f16b66b0330a59ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202486Reviewed-by:
-
