- 28 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/68998788dee4..f6444c825797 2020-09-28 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/SourcesNavigator.js 2020-09-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieabffddef28151097347a6b524791bb2f9a78db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811147}
-
Johann Koenig authored
This reverts commit 71953034. Reason for revert: tools/run-swarmed.py out/Win content_browsertests --swarming-os Windows-10 --gtest_filter "All/DumpAccessibilityEventsTest.AccessibilityEventsVisibilityHiddenChanged/uia" Original change's description: > Reland: Improve name calc handling of hidden objects, relation traversal > > - Display: none objects should not get an accessible name. > - EnsureComputedStyle() should not be called during a potentially unsafe > time. This is fixed by calling it during Init(), in cases where it > will likely be needed (inside a display:none subtree). > - Remove unnecessary and often incorrect heuristic for determining when > inside an aria-labelledby or aria-describedy calculation. This flag is > already passed in via recursion when following that kind of relation. > - Do not recurse into children that are explicitly hidden > - Improve explicitly hidden computation for CSS visibility. Explicitly > hidden means that the element was specifically hidden, and that it > didn't just inherit the fact that it's hidden. > - Improve results in name-calc-visibility, where an element explicitly > referenced by aria-labelledby wasn't included in the name because it > was visibility:hidden element. Elements that are explicitly referenced > must be included in a name or description even if they are hidden. > > TBR: dmazzoni@chromium.org > Bug: 1130436 > Change-Id: I52d11208a9658a53bf0af7313a41f4bb8eafc24e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431448 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810683} TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1130436 Change-Id: I24a6949799f55a96318e29253670735359181014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434018Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0081a12803bf..26fef59eda82 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic3e2ab658d1d7877c26669595e35619943cec891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435004Reviewed-by:
-
Jason Lin authored
This reverts commit 4d4f20fc. Reason for revert: https://crbug.com/1132535 Original change's description: > Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps > > Screenshots: > http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1 > http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818 > http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71 > > When Chrome OS did not support external protocol handlers, it > replaced browser/ui/views/external_protocol_dialog with > browser/chromeos/external_protocol_dialog which states that no > handlers are available. ARC has added a dialog which is shown > when any android apps can handle a link. This CL uses the > standard ExternalProtocolDialog for Guest OS apps when ARC does > not handle a link, but Guest OS can. > > * Renamed CrOS version of ExternalProtocolDialog to > ExternalProtocolNoHandlersDialog. It is still used when no handlers > are found. > > * Changed ui/views/external_protocol_dialog to now be compiled into > CrOS, but leaving out > ExternalProtocolHandler::RunExternalProtocolDialog which is provided > in the CrOS version: chromeos/external_protocol_dialog.cc. > > * Replaced platform_util_chromeos OpenExternal to Launch the registered > Guest OS app. This function was previously not ever called in CrOS. > > Bug: b/168506505 > Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#810381} TBR=ellyjones@chromium.org,xiyuan@chromium.org,thestig@chromium.org,joelhockey@chromium.org,lxj@google.com Bug: b/168506505,1132535 Skip-Translation-Screenshots-Check: True Change-Id: I52bfc2a8169a018076790df8a63c253c29ded64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434014 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#811144}
-
Sergey Silkin authored
In RTC video decoder factory, wait until initialization of GPU is finished before querying supported formats and creating a decoder. Timeout is configurable via RtcDecoderSupportTimeout field trial. The feature is enabled by default. The default timeout is 10 seconds. Bug: 1047994 Change-Id: I9d827507664228f903e4ce46e2949785b13192ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411935Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811143}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I1cf3d692816707b5920d8859e4033f82c56c23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434797Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811142}
-
Noel Gordon authored
Chrome style and makes debugging assert failures easier. No change in behavior. Bug: 1064855 Change-Id: Ib3833eeead4499dfc7edd197eb335a1722b32d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434121Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811141}
-
Jan Krcal authored
This CL proceeds with the happy path of the signed-in profile creation flow: 1) After a successful sign-in, the current WebUI for sync confirmation gets displayed; 2) After choosing whether to sync, the flow is finished by opening a browser window for the new profile. Error handling and restyling the confirmation page is left for follow-up CLs. Bug: 1126913 Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#811140}
-
Hua, Chunbo authored
Bug: None Change-Id: Ie1a4b37e8f5a574d549fccb798c727b2e99d530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434145Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811139}
-
Yuki Shiino authored
The new bindings of IDL callbacks take the new IDL enumeration instead of WTFString. This patch adds adapter code so that the callers of IDL callbacks work with both of the old and new bindings. Bug: 839389 Change-Id: Ia8b60105347f9e64d7e99ddbca831c22eec8d223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434104 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#811138}
-
Nicholas Hollingum authored
On some platforms (including CrOS, as of crrev.com/c/2277694) ordinal motion will be available as part of mouse motion events. We use ordinal motion to provide unaccelerated motion in the zwp_relative_pointer interface. In the event that ordinal motion is not available, we default to the old behaviour (i.e. using accelerated motion). This behaviour is guarded by a flag, as the units it provides on CrOS are disproportionately small (compared with the standard cursor acceleration). Bug: b/161755250 Change-Id: I774db6ef7db7460f1c5674fffdaca65e7fb170fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371088 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#811137}
-
Thanh Nguyen authored
This CL ClearIndex function to Index and its subclasses. This function clears all the data stored in the index. Bug: 1132170 Change-Id: Idbec8ed4c721f09577b40c59b9cf24ebe5060252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428273Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811136}
-
My Nguyen authored
Error was "Pref not found for element SETTINGS-TOGGLE-BUTTON source: chrome://os-settings/controls/pref_control_behavior.m.js (41) Clear document.body.innerHTML in setup of the second suite as the document state in the first suite seems to intefere with the second suite. Clearing should be in setup because tests in other suites might intefere with these particular ones. Tested with 1000 repeat and stress cpu to 100%. Bug: 1132577, 1132259 Change-Id: I38cb14a5b892fffdf157a93fda2b7c805c454e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434584 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811135}
-
Findit authored
This reverts commit 26e5926b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 811131 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI2ZTU5MjZiNjY5NzEwODNkOWEwNTBiNDM0OGUxM2VjOTZjZWRiZTAM Sample Failed Build: https://ci.chromium.org/b/8867933801572145104 Sample Failed Step: compile Original change's description: > Video Tutorials : Moved language to a server side concept > > This CL > 1 - Adds language struct to the proto consisting of name, native text, > and locale. > 2 - VideoTutorialService will still store the preferred locale in a > pref which will be used as a key when iterating through the > supporting languages. > 3 - Removes the checked in strings for languages > > TODO : Change server side proto > > Bug: 1132161 > Change-Id: I1483903e0615714aa790b6af1fbfaa4c6637c802 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429979 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811131} Change-Id: I88a5a6858e0ca686b5a28327664dd80c6eeb61a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434695 Cr-Commit-Position: refs/heads/master@{#811134}
-
Jacobo Aragunde Pérez authored
Bug: 1082217 Change-Id: I97159b1cb3b6ccf8c57f17f54d011447fa6db681 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432027Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#811133}
-
Yuki Shiino authored
Refactors bind_gen/ to support IDL callback functions and IDL callback interfaces in https://crrev.com/c/2434004 Bug: 839389 Change-Id: Ie58f15269efe7c80f0157c4296f0cb37465deab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432708Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811132}
-
Shakti Sahu authored
This CL 1 - Adds language struct to the proto consisting of name, native text, and locale. 2 - VideoTutorialService will still store the preferred locale in a pref which will be used as a key when iterating through the supporting languages. 3 - Removes the checked in strings for languages TODO : Change server side proto Bug: 1132161 Change-Id: I1483903e0615714aa790b6af1fbfaa4c6637c802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429979 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811131}
-
Alex Rudenko authored
shadow DOM with unslotted elements. This CL adds additional tests that help to reproduce the issue that was fixed in [1]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2426450 Fixed: 1130920 Change-Id: I45a79f5a88d50ccebe543391e47533511b9ae384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421820 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#811130}
-
Yuki Shiino authored
Since https://crrev.com/c/2434004 will be going to introduce bindings::CallbackInvokeHelper, which is expected to reduce the APK size by 7KB, then some of IDL callback APIs need to be accessible from CallbackInvokeHelper. So this patch moves such APIs to public. Bug: 839389 Change-Id: I3eafa3992d21d7c011b7fcff07e4c7d57eb8a32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432149Reviewed-by:
-
Noel Gordon authored
JEITA EXIF color space defines and supports two color spaces only per the JEITA specification: sRGB and AdobeRGB1998. The PIEX C++ returns their values as strings 'sRgb' and 'adobeRgb' so return those values in the PiexLoaderResponse [1]. Note JEITA EXIF color space indicates the color space only. The image does not have an embedded ICC Color Profile. A future option for piex is to slice open the JPEG preview, insert an ICC Color Profile in the AdobeRGB1998 case, before returning the PiexLoaderResponse. [1] In files app, make image_request_task.js convert the value in the PiexLoaderResponse to ColorSpace type. No change in behavior. Bug: 1132695 Change-Id: Ifa076635dc5672a552094bf1b5fa9e69e164d9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432150Reviewed-by:
-
tby authored
The cooldown between successive calls is set to 15 minutes by default, but is controlled via an experiment parameter if we need to change it later. Bug: 1034842 Change-Id: Ief80a68db10bf67b67c55d679555e6d55b49fab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434072 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811127}
-
Tal Pressman authored
Use GetAgentSchedulingGroup().InitProcessAndMojos() instead. Bug: 1111231 Change-Id: Iee0addc20fa11a7bbeb8fd437455ed26aaf6e2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434107Reviewed-by:
-
Koji Ishii authored
This patch fixes the logic to recalculate ink overflow, especially for self-painting layers. |PaintLayer| calls |RecalcVisualOverflow| for its owner |LayoutObject|. |LayoutBlockFlow| already redirects this to |NGFragmentItems|, but inline boxes and atomic inlines did not handle this. They have ink overflow stored in corresponding |NGFragmentItem|s, and they need to be recalculated. This patch handles this situation by adding |LayoutBoxModelObject::RecalcVisualOverflow|. Currently, there are multiple workarounds added to pass all tests, but they are causing sometimes redundant, or sometimes missing recalculations. This fix allows to remove one of such workarounds in |NGFragmentItem::RecalcInkOverflowForCursor|, that calls |RecalcInkOverflow| even if the child is |HasSelfPaintingLayer|. Removing this workaround reduces redundant recalculations. Three sets of tests cover this change: 1. This patch adds a unit test that demonstrates when the current code fails to recalculate ink overflow, originally found while investigating <crbug.com/1128199>. 2. When |NGFragmentItem| is enabled, reading dirty self ink overflow hits DCHECK. Not hitting DCHECK can ensure that this change calculate ink overflow for all cases where we read self ink overflow. 3. This patch adds a DCHECK when reading dirty self-and- container ink overflow. 215 unit tests and 653 web tests fail this DCHECK <crrev.com/c/2432707> but pass with this patch (except when NG block fragmentation is enabled, see notes below.) Note: * Both legacy and |NGPaintFragment| have the same issue. This patch addresses only for |NGFragmentItem|. * |LayoutBlockFlow| does not handle |RecalcVisualOverflow| correctly for multicol. This was fixed in r810561 <crrev.com/c/2428516>. Many `virtual/layout_ng_block_frag` tests fail without that fix when this patch is applied. * 3 `virtual/layout_ng_block_frag` tests still fail the new test #3 above, even after the fix above. crbug.com/1132619 tracks this issue. Bug: 1128199, 1130856 Change-Id: I42a75e1dad7c2b35146cca4ddaaf9763df4e7440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428530 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811125}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0922403dcdc6..ad6aeace6eee 2020-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from eec9edfd5769 to ed2b465f8607 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I154ecc6629799cc17cf8f6b571df129a87c55351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434476Reviewed-by:
-
Takashi Sakamoto authored
This CL fixes the following 2 tests' failures: - OutOfMemoryDeathTest.AlignedAlloc - OutOfMemoryDeathTest.AlignedRealloc Bug: 998048 Change-Id: I83f5ac00aded8d750ab610db3c17c17fad8b7074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418631Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#811123}
-
tby authored
The steps involved are: 1. Get some results from the cache 2. Run them through LocateFilesByItemIds to convert item IDs into file paths 3. Assign relevance scores and create FileResult objects. Bug: 1034842 Change-Id: If217d5eb5645e9a5eefa8a57609d9ea91014db4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434108Reviewed-by:Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811122}
-
Matthew Denton authored
Add seccomp ioctl numbers and newer seccomp flags necessary for the USER_NOTIF broker. Also adds linux_prctl.h for prctl constants like PR_SET_PTRACER. Bug: 1117351 Change-Id: Idf56efcb189f1b20f13b23bacc71dd1b38786c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407064 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811121}
-
Christopher Lam authored
This CL removes the kSystemWebApps feature which is now always true. Bug: 1067073 Change-Id: Ib2e142fdbd0499e745934d28fac03e2a5695fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395298 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#811120}
-
Noel Gordon authored
JEITA EXIF image orientation is a number in [1..8]. PIEX C++ defaults to 1 if there is no image orientation or its value is invalid. Return the value in the PiexLoaderResponse and let the client code deal with converting it to other types [1]. [1] In files app, make image_request_task.js convert the value in the PiexLoaderResponse to ImageOrientation type. No change in behavior. Bug: 1132695 Change-Id: I728680d17c31426d72b6b09bd52ee821540cbcd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432231Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d6aeaf33afbe..68998788dee4 2020-09-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I18a2a33ded931701f7820ea03eef8bec5c65da85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434864Reviewed-by:
-
Sergei Datsenko authored
Bug: 1125669 Change-Id: Ia0de3d3be2fb1f91f49a1ec5cf07139625bdf924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426148 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#811117}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iddf2ffa2ea560eb98e9928761cf9ff367914e3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434826Reviewed-by:
-
Javier Fernández García-Boente authored
During the HandleOverflow we consider the possibility of breaking at previous opportunity. The logic for this case is implemented in the BreakTextAtPreviousBreakOpportunity function. In case that there is such suitable previous opportunity, we modify the ItemResult that includes this opportunity in its offset range. We also create a new ShapeResultView associated to this item_result, using the new offset range. However, it's possible that the trailing_collapsible_space_ structure already has this ItemResult instance, that we are now altering as part of the HandleOverflow logic. The problem described in the issue 1131470 is caused by this situation, where an ItemResult instance hold by the trailing_collapsible_space_ is modified. During the computation of the trailing spaces size, as part of the RemoveTrailingCollapsibleSpace function, we avoid calling to the TruncateLineEndResult, which will reshape again, in case the item_result considered is already present in the trailing_collapsible_space_ structure. This causes that we end up with an ItemREsult of a different size than the previously computed collapsed_shape_result. Bug: 1131470 Change-Id: I15b31303fb8ec52b6d7359880f2785d16e1a0c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429411 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811115}
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: If1297043ae0ac4278b04885d6f908f1178415ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419534Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#811114}
-
Shakti Sahu authored
This CL moves all the java code to internal/. VideoIPHCoordinator, and VideoPlayerCoordinator were extracted to interfaces. VideoTutorialServiceFactory is the factory responsible for providing implementation for all public interfaces. Bug: 1131959 Change-Id: I3f5b0383edfef902d12e3a18c50fec2787897fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429423 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This is a reland of 278cb45f Original change's description: > Video Tutorials: Added video player UI > > This CL adds the video player UI. > 1 - Added VideoPlayerActivity at chrome layer, which creates > VideoPlayerCoordinator and passes a WebContent supplier in order to > create ThinWebView. > 2 - Added video player MVC, the mediator handles display logic between > loading screen, controls, thinwebview, and language picker. > It also handles callbacks for control buttons, and observes media > session through a PlaybackStateObserver. > > TODO : > Add screenshot. Add UI polish. Define share/watchnext behavior. > Polish media session logic. > > Bug: 1117172 > Binary-Size: Unavoidable method count increase (includes methods from previous CL). > Change-Id: Ide7c0d7bf4fa20a9bfbe0c10717e6983d0da88dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415672 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811094} TBR=dtrainor@chromium.org Bug: 1117172 Change-Id: If6c7fd26ba1643ded722eb274f876dad085dd075 Binary-Size: Unavoidable method count increase (includes methods from previous CL). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434560Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811112}
-
Etienne Bergeron authored
The test TtsSsmlBrowserTest.TestStripSSML but it seems to work fine. I suspect the memory leak got fixed by: https://bugs.chromium.org/p/chromium/issues/detail?id=961029#c6 Re-enabling the test. If this issue come back, please revert. Bug: 961029 Change-Id: Ia896498bcab1298f8afaa6fceb090eabac42c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811111}
-
Johann authored
Tests fail under asan/lsan: ./out/chromeos_asan_lsan/chromeos_unittests \ --gtest_filter="*MultiDeviceSetupWifiSync*" deterministic failures [caused step to fail]: All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Failure/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Failure/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.FailureCallback_SyncedHostBecomesUnverified/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.FailureCallback_SyncedHostBecomesUnverified/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.MultiplePendingRequests_EnableDisable/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.MultiplePendingRequests_EnableDisable/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.MultipleRequests_FirstFail_ThenSucceed/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.MultipleRequests_FirstFail_ThenSucceed/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.PendingRequest_NoSyncedHostDevice/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.PendingRequest_NoSyncedHostDevice/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Retrying_SyncedHostBecomesUnverified/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Retrying_SyncedHostBecomesUnverified/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.SimultaneousRequests_StartOff_ToggleOnOff/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.SimultaneousRequests_StartOff_ToggleOnOff/1 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Success/0 All/MultiDeviceSetupWifiSyncFeatureManagerImplTest.Success/1 BUG=chromium:1117619 TBR=cvandermerwe@google.com, khorimoto@chromium.org, jonmann@chromium.org Change-Id: Iad6b03ac9448371e8757a4d823a47bd74421bd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434011Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 944f0d0b. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Idccab5c3db88a1c5cee086ee92dedcff52f3f510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434626Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811109}
-
Ahmed Mehfooz authored
Consolidate pin logic into HoldingSpaceItemView since it will now be common between screenshots and chip views. Bug: 1131262 Change-Id: I600f5e7bb78726fe4b07afd379dd77857cd6bef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429533 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#811108}
-
