GitLab

Leverage content-visibility property to optimize render time.
https://web.dev/content-visibility/

Screenshots from Dev Tools: Performance:
original: https://drive.google.com/file/d/1bb_KeUWn1C0TDmUuhZO2zE0qcqqDlq3O/view?usp=sharing
optimized: https://drive.google.com/file/d/1yHm19aq3ri7YnI9xUpPbfmVQCycuESXF/view?usp=sharing

6x-slow screenshots:
original: https://drive.google.com/file/d/13ymyxUmpPWHNh0z-I_s_wUN2osGFwJW_/view?usp=sharing
optimized: https://drive.google.com/file/d/1y7MPjiU9px2S0BlfRlCizKG9b9kj9tHi/view?usp=sharing

Bug: 1099917
Change-Id: I2206817422cbaeb4a59ed1707a2e39dd354cc7ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493092Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820498}

https://skia.googlesource.com/skia.git/+log/42a741a2145c..58a26a83628c

2020-10-23 csmartdalton@google.com Fix the formula for fNumRadialSegmentsPerRadian in GrStrokePatchBuilder
2020-10-23 johnstiles@google.com Add unit test for nested function calls in FP files.
2020-10-23 reed@google.com Show cubic made up of 2 quads
2020-10-23 johnstiles@google.com Revive SkSLFPTestbed for basic verification of CPP/H codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: Id7e6b89b0915cb939688a4b63c53bddd6c3a7bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495692Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820497}

Bug: 1141261
Change-Id: I9f877ac89f9435193f04c87a6a3f3d51593f202d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495516Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820496}

This CL adds a CloseTabSearch browser command. The primary use case
for this will be enabling better control of the feature for use with
the Devtools protocol.

See below for context:
https://crrev.com/c/2488764

Bug: 1099917
Change-Id: I7744187da08a51dfb9ff1fe31f4c17a4891e6122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495863Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820495}

Add a new Polymer element, page-size-select, to display the page sizes
in a dropdown.

Bug: 1059779
Change-Id: Ia546795ab44e350adbf8256867e7e5fccb42dc02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492944Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820494}

Android unit tests don't work on Android R+, but this isn't mentioned
in the docs, and the error message is pretty arcane and hard to
understand. This change updates the docs to mention this problem.

Bug: 1094062
Change-Id: I77b196febde1009eb13b195be937243e96ace1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495968
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820493}

This reverts commit 715577e4.

Reason for revert: This caused compile failure:
https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/97365?
[8734/14809] CXX obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o
FAILED: obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o
/b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long)
../../content/browser/indexed_db/indexed_db_backing_store_unittest.cc:924:20: error: no member named 'SetExecuteJournalCleaningOnNoTransactionsForTesting' in 'content::indexed_db_backing_store_unittest::TestableIndexedDBBackingStore'
backing_store()->SetExecuteJournalCleaningOnNoTransactionsForTesting();
~~~~~~~~~~~~~~~  ^
1 error generated.

Original change's description:
> indexeddb: defer journal cleanup in CommitPhaseTwo
>
> Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo
> calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs
> in the recovery journal (under some conditions).  Unfortunately, it
> doesn't remove the blobs that were just written in that transaction from
> the recovery journal prior to calling DidCommitTransaction.
>
> This patch rearranges the calls so that DidCommitTransaction is always
> called in CommitPhaseTwo, but only after the journal has been updated.
>
> Bug: 1131151
> Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872
> Commit-Queue: enne <enne@chromium.org>
> Auto-Submit: enne <enne@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820486}

TBR=mek@chromium.org,enne@chromium.org

Change-Id: Id3876068e31e91817ff7c396f024cf159b3c1dfe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1131151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496035Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820492}

This change splits the ZeroSuggestProvider into
- ZeroSuggestProvider serving the Search suggestions and
- ZeroSuggestMostVisitedSitesProvider, serving the MostVisited
  suggestions.

The Most Visited Sites are served specifically on mobile devices
and are therefore wired specifically for iOS and Android.
This change enables MostVisited suggestions to be served
alongside the zero-prefix REMOTE_SEND_URL suggestions.

Bug: 1106109
Change-Id: I1053f5dfcd539e056d8443e31294c00bb0145588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488982
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820491}

If you navigate to "Apps" page and then to an application,
and then hit the back button the focus does not highlight the
application that was chosen when in ChromeVox mode.

Steps (in ChromeVox mode):
1. Apps
2. Chrome
3. Back button

Bug: 1029954
Test: Manual
Change-Id: I8c54f7fb88379392ebfc373f209b9386a84a345e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493826
Commit-Queue: Michael Irani <michaelirani@chromium.org>
Auto-Submit: Michael Irani <michaelirani@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820490}

This reverts commit 27e795c1.

Reason for revert: Sorry for another revert, but this is still causing flake. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9353 . Specifically:
../../content/public/test/browser_test_base.cc:702: Failure
Failed
RunLoop::Run() timed out.
Stack trace:
#0 0x56324b6c5e50 base::internal::Invoker<>::Run()
#1 0x56324b623b4f base::(anonymous namespace)::OnRunLoopTimeout()
#2 0x56324b6249e3 base::internal::Invoker<>::RunOnce()
#3 0x5632492266ab base::internal::CancelableCallbackImpl<>::ForwardOnce<>()
#4 0x56324b63bc46 base::TaskAnnotator::RunTask()
#5 0x56324b64c845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#6 0x56324b64c588 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#7 0x56324b69fb29 base::MessagePumpLibevent::Run()
#8 0x56324b64cf9a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#9 0x56324b62363e base::RunLoop::Run()
#10 0x5632483f1f23 chromeos::EduCoexistenceLoginBrowserTest::WaitForScreenExit()
#11 0x563248402206 chromeos::ParentalHandoffScreenBrowserTest_RegularUserLogin_Test::RunTestOnMainThread()
#12 0x56324bae8dd1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#13 0x56324b6fff04 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#14 0x56324b6ff3b9 ChromeBrowserMainParts::PreMainMessageLoopRun()
#15 0x563248bf574e chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#16 0x563249bdf3b0 content::BrowserMainLoop::PreMainMessageLoopRun()
#17 0x563249f3668a content::StartupTaskRunner::RunAllTasksNow()
#18 0x563249bde45b content::BrowserMainLoop::CreateStartupTasks()
#19 0x563249be0bba content::BrowserMainRunnerImpl::Initialize()
#20 0x563249bdcbd2 content::BrowserMain()
#21 0x56324b198740 content::RunBrowserProcessMain()
#22 0x56324b1995d1 content::ContentMainRunnerImpl::RunServiceManager()
#23 0x56324b199234 content::ContentMainRunnerImpl::Run()
#24 0x56324a5c8687 content::RunContentProcess()
#25 0x56324a5c8c16 content::ContentMain()
#26 0x56324bae8a00 content::BrowserTestBase::SetUp()
#27 0x56324b5d8620 InProcessBrowserTest::SetUp()

Original change's description:
> Reland "Adds parental handoff login screen in oobe."
>
> This is a reland of dca1afe8
>
> This is an interesting failure point due to the difference between
> official builds and non official builds. In official builds, the
> Sync Consent screen is shown and it will not exit until we interact
> with it. The waiters timeout waiting for the Parental Handoff Screen
> to be shown.
>
> Original change's description:
>
> > Adds parental handoff login screen in oobe.
> >
> > The description and mock can be seen in the comments in the bug report.
> >
> > Bug: 1134567
> > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618
> > Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> > Reviewed-by: Aga Wronska <agawronska@chromium.org>
> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> > Reviewed-by: Jesse Doherty <jwd@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819158}
>
> Bug: 1134567
> Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756
> Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820388}

TBR=jwd@chromium.org,rsorokin@chromium.org,agawronska@chromium.org,yilkal@chromium.org

Change-Id: I6febf7f06a0d5d7a072be1e50aaa9cc2a4d3c217
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1134567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495423Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820489}

A WebContentsObserver may receive updates from multiple AXTrees.
Currently, that isn't supported, so add a fix that ignores updates that
aren't from the first tree that the WebContentsObserver receives.

Test: AccessibilityBridgeTest.MultipleAXTrees
Bug: 1136541
Change-Id: If1fb3de647c150c58bc07b55477452f91abfcef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469470
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820488}

- Does not run tests yet

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Idbe2de1c4f4f3100b36a49947a3e6ded79ba2eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469448
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820487}

Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo
calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs
in the recovery journal (under some conditions).  Unfortunately, it
doesn't remove the blobs that were just written in that transaction from
the recovery journal prior to calling DidCommitTransaction.

This patch rearranges the calls so that DidCommitTransaction is always
called in CommitPhaseTwo, but only after the journal has been updated.

Bug: 1131151
Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820486}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/751a6ed6316a..f28949d69964

2020-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ib97faabc4a435b01c0266c08842b60905b3c8581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495904Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820485}

Bug: 1133016
Change-Id: I4c33d871f13d888392c293a9d4197378d2b82698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473537
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820484}

This CL changes NativeDesktopMediaList to no longer assume that
CaptureFrame completes synchronously. This means changing the code
to wait for OnCaptureResult before calling CaptureFrame again.

DCHECKs are added to DesktopCapturerLacros to guard against such
misuse in the future.

Bug: 1141483
Change-Id: I579dd0f5ea8bef9a02c7be6d3dead23805601038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492940
Commit-Queue: Darin Fisher <darin@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820483}

The USE flag for CHROMEOS_PROTECTED_MEDIA will be turned on before we
have encrypted content handling done here, so reject that config in all
cases until that is done.

BUG=b:153111783
TEST=Builds

Change-Id: Ibcd83a91ab83ef30afd01bbe7db6b5c792f474a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495801
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820482}

Also updated callsites to use -[EarlGrey rotateDeviceToOrientation:error:].
Old method was needed to support EG1 tests, because EG1 did not have
rotateDeviceToOrientation:error: method.

R: zhaoyangli@chromium.org
Bug: 1017281
Change-Id: Ia7a016f3c78e3ee550dda4a5d4cf00e3a15ac312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495602
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820481}

script_test template.

It will be used to pass arguments to the test target for test run
via typ.

Bug: 1141577
Change-Id: I11582b6e97d0dd088ededf5bd61247ee6ecfa3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493368Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#820480}

Using wpt-import in Chromium 82982a2b.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I9bbd812f848d0b653e1f53aee6734674558642a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495643Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820479}

Also updated callsites to use -[EarlGrey isKeyboardShownWithError:].
Old method was needed to support EG1 tests, because EG1 did not have
isKeyboardShownWithError method.

Bug: 1017281
Change-Id: I78f69b868b45ed34e4fd35b031ca7a1897fffdd3
R: zhaoyangli@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495330
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820478}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I728bd3a60556d43f65fde9763dcf21b7947626ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495349Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820477}

New UKM metrics Request doc: go/client-rendering-api-ukm-review

Add collections for Canvas/OffscreenCanvas context type:
2d, bitmap, webgl, webgl2.
Tested locally with canvas.getContext and chrome://ukm

WebGPU context is not added yet in this patch as it's not associated with canvas.

Bug: 1135706
Change-Id: Ib6c15629e5f69f3be554e1614351b815e15a6c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473043
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820476}

https://quiche.googlesource.com/quiche.git/+log/867ef5f63787..d84ef00c9666

$ git log 867ef5f63..d84ef00c9 --date=short --no-merges --format='%ad %ae %s'
2020-10-23 haoyuewang Reduce QuicConfig size from 1432 bytes to 1160 bytes by better padding.
2020-10-22 mattm Add QuicConnection::HaveSentPacketsInCurrentKeyPhaseButNoneAcked method.
2020-10-22 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ibfad65022d1065dab86862d12aff144d3478c422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495263
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820475}

Bug: 904390
Change-Id: If057d964a0e4224233aa074b6172b98793cae98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494812Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Cr-Commit-Position: refs/heads/master@{#820474}

The WebUI tab strip is a tab strip built using JavaScript. It allows
users to drag tabs, and to do so, it relies on JS drag events. The JS
checks the dropEffect on a DragEvent's dataTransfer object to determine
if a tab was moved.

This CL overrides the dropEffect to `move` when dragging a tab using the
WebUI tab strip to allow the front-end to correctly catch cases in which
a tab is dragged into its own window.

Bug: 1081905
Change-Id: Ief542c8eeb15a8324efbcc26cbde366ad84ba029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488741
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820473}

Updated LabelButton to subscribe to the callback rather than overriding the virtual.

Bug: 938501
Change-Id: I8063618a2f8d3b3b2903281cd59ca5449e051dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495828
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820472}

This CL adds feature param to control default pin state for the
experiment.

Change-Id: I42f8244adfc5f8fb5a195f7a5243314864cd57a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488721Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820471}

It is not needed to include any //ui/aura headers.
This CL will make //ui/ozone/platform_wayland depend on
//chromeos/ui/base more easily.

BUG=1113900
R=jamescook@chromium.org

Change-Id: Icc30e4cf93955abc4be6add8d882ccfbf5c7e338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492565
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#820470}

These buttons are subclasses of ImageButton or LabelButton. Since they
didn't set their focus behavior, they inherit the beahvior. This CL uses
DCHECK to assert such behavior, and set the behavior explicitly. So when
we change ImageButton and LabelButton's focus behavior later, these
buttons won't be affected.

Bug: 1001103
Change-Id: I88675c772b83348f68234d588a3c3884387fea84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495820Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820469}

Also crash on sysctl-read failures.

Bug: 1126350
Change-Id: I9d69c69979ab076e257ca079f6e5f09aed5c28be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493440
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820468}

This CL moves the logic for calculating size and placmeent and for
drawing the "New" badge into any View.

It also provides (as a convenience) a drop-in version of Label that
displays a "New" badge that can be used in almost any situation a plain
label can be used.

Bug: 1055150

Change-Id: Ib9227c9dfc630eb0c03650adf5b8f177a086b431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486575Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820467}

As part of the refactor and improvements to Translate's metrics, added two UMA histograms related to TranslateRanker. This information will eventually be logged in UKM as well. Updated TranslateRanker's unit tests and added unit tests for TranslateMetricsLogger to confirm that the metrics are recorded as expected.

Full Design Doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing

Bug: 1114868
Change-Id: I56ea8fc167599688596da015cef00454790f991c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481472
Commit-Queue: Max Curran <curranmax@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820466}

It's been replaced with LOGGING_NUM_SEVERITIES.

Bug: 849450
Change-Id: Ib43718d39a8d171a53e88d6d51942d28f42b7585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494504Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820465}

Original PR
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841

Bug: 1137050
Change-Id: If9bc0044ad01654eb4a92f81acd28d346ab291d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495786Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#820464}

Static IP configuration for Cellular networks does not work and can
only break things.

Bug: 993587
Change-Id: I734c25ccabd5330134aa59be9eea04f3dc6ad0a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495704
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820463}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/42c17639..c572b425

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie07fa49ce28eecad493eff84d3a92452e7232393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495247Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820462}

BUG=1141927
TEST=test only change
TBR=xdai@chromium.org

Change-Id: I150f47081d1d88afc15c0c90f7f1fc6c333aee48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495831Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820461}

Context:
Currently, //components payment targets depends on //chrome resources
ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png. It's
because the payment view templates depend on them. This CL is written
to break the dependencies.

Changes:
* this CL changes to set fre_product_logo and product_logo_name
programmatically from //chrome, from having them referenced in
//components templates.
* ic_edit_24dp.png is moved from //chrome into //components

Before:
The two //components xml templates depends on the //chrome resources
ic_edit_24dp.png, product_logo_name.png, fre_product_logo.png.

After:
No //components payment targets depends on the //chrome resources.

Bug: 1141076

Change-Id: Idea99bdb55d1dd633a540eee4d2db27e2c471634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490162
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820460}

This CL re-arranges some early-abort behaviors to avoid calling
GetDomainInfo() when possible, since GetDomainInfo() is very expensive.

This is a pretty small change that'll hopefully help some performance
regressions. A better long-term way to make a difference is to put
off the expensive parts of GetDomainInfo, possibly by lazily
populating the IDN-related parts, until needed. I might give that a
shot in a follow-up CL.

Bug: 1135279
Change-Id: Iaddc566274501501a7d8a141bc58c21639ee0f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495611
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820459}