GitLab

BUG=687269

Review-Url: https://codereview.chromium.org/2740963002
Cr-Commit-Position: refs/heads/master@{#455722}

https://skia.googlesource.com/skia.git/+log/28b1252bab29..08541e8d7f28

$ git log 28b1252ba..08541e8d7 --date=short --no-merges --format='%ad %ae %s'
2017-03-08 msarett Optimize mipmap downsample_2_2 in sRGB mode

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Ib3e72df71504cce948b864ef0ad1b5cc27392da7
Reviewed-on: https://chromium-review.googlesource.com/451941Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455721}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fc069168..fbffc377

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2741673002
Cr-Commit-Position: refs/heads/master@{#455720}

Revert of [table] Stretching tables when needed due to self-alignment properties (patchset #6 id:120001 of https://codereview.chromium.org/2528253003/ )

Reason for revert:
This patch is causing several important regressions.

Original issue's description:
> [table] Stretching tables when needed due to self-alignment properties
>
> The Self-Alignment properties, align-self and justify-self, apply to
> tables when they are flex or grid items.
>
> This patch addresses only the issue of applying the stretch value, which
> effectively affects the size of the table in those cases.
>
> The justify-self applies also to tables when they are block-level
> boxes, but the alignment feature is still not implemented for that
> case, so for now the related test cases expect no stretching.
>
> Other values of alignment aren't implemented yet for tables, but those
> will be part of future CLs, once somebody files the appropriated bug.
>
> BUG=667785
>
> Review-Url: https://codereview.chromium.org/2528253003
> Cr-Commit-Position: refs/heads/master@{#454743}
> Committed: https://chromium.googlesource.com/chromium/src/+/a90dba1f2dd094e51229dd2e5e059c6b53cee93a

TBR=svillar@igalia.com,rego@igalia.com,cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667785

Review-Url: https://codereview.chromium.org/2740063003
Cr-Commit-Position: refs/heads/master@{#455719}

Currently error member of RequestCore class not initialized. This cause
MSan error in net_unittests. To fix it was initialized by OK value.

BUG=None
R=asanka@chromium.org

Review-Url: https://codereview.chromium.org/2738513006
Cr-Commit-Position: refs/heads/master@{#455718}

This was used to update the Toolbar state, but the Toolbar doesn't
depend on Instant anymore (and hasn't for a long time).

BUG=627747

Review-Url: https://codereview.chromium.org/2736243002
Cr-Commit-Position: refs/heads/master@{#455717}

This patch is trival and only adds the required code to allow closure to
compile without @unrestricted.

R=lushnikov
BUG=None

Review-Url: https://codereview.chromium.org/2723203003
Cr-Commit-Position: refs/heads/master@{#455716}

RemoteWindowProxy won't have a ScriptState in the future, so move the
DCHECKs so it's possible to continue asserting invariants that should
always hold true in WindowProxy.

BUG=527190

Review-Url: https://codereview.chromium.org/2744483002
Cr-Commit-Position: refs/heads/master@{#455715}

Minor differences on Windows bots.

TBR=xhwang@chromium.org
NOTRY=true
BUG=699573

Review-Url: https://codereview.chromium.org/2741693002
Cr-Commit-Position: refs/heads/master@{#455714}

platform/loader has a BUILD.gn, but it does not contain files for
platform:test_support that can be used in blink_platform_unittests
and webkit_unit_tests. This patch moves platform/loader/ files for
the test_support from platform/BUILD.gn to platform/loader/BUILD.gn.

BUG=699369

Review-Url: https://codereview.chromium.org/2732243005
Cr-Commit-Position: refs/heads/master@{#455713}

This patch moves |textDirectionForSelection()| to |EditingStyleUtilities| class
to "EditorCommand.cpp" since it is used only in "EditorCommand.cpp" for
improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2734043004
Cr-Commit-Position: refs/heads/master@{#455712}

This patch makes |rootEditableElementOrTreeScopeRootNodeOf() | to take
|Position| instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

This patch also replaces deprecated version of |computeVisibleSelection()|
in |InputMethodController::getSelectionOffsets()| since it is called in
after |computeVisibleSelectionDeprecated()|.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2742703002
Cr-Commit-Position: refs/heads/master@{#455711}

This code is perfectly valid on any linux platform.

And required as a pre-step to enable glCreateImageCHROMIUM
with linux dma buf on OS_LINUX.

BUG=584248
R=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2683593006
Cr-Commit-Position: refs/heads/master@{#455710}

* speedometer-ignition
* v8.browse_desktop_ignition
* v8.browse_mobile_ignition,
* v8.infiniter_scroll-ignition_tbmv2
* v8.todoMVC-ignition

The ignition-staging configuration of v8 used in these benchmarks is no longer the
shipping configuration. The corresponding turbo benchmarks are tracking the future
shipping configuration of v8.

BUG=chromium:670087

Change-Id: Ic7b8d8e69ec2f1aafff750fa07c516d90824e611
Reviewed-on: https://chromium-review.googlesource.com/451657
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#455709}

Add a method to CollectionViewController to reconfigure cells based in their
index path instead.

BUG=none

Review-Url: https://codereview.chromium.org/2738743005
Cr-Commit-Position: refs/heads/master@{#455708}

This patch makes |GranularityStrategy::updateExtent()| to return
|SelectionInDOM| instead of |VisibleSelection| to reduce usage of
|VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2735143002
Cr-Commit-Position: refs/heads/master@{#455707}

Revert of Improve performance of GeometryMapper cache. (patchset #39 id:690001 of https://codereview.chromium.org/2729243002/ )

Reason for revert:
Breaks msan:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/781

Original issue's description:
> Improve performance of GeometryMapper cache.
>
> 1. Store clips and transforms in vectors attached to the clip and transform nodes.
> This avoids all hash map lookups. Invalidation uses a global cache generation id
> (currently we don't support anything other than global invalidation of the
> GeometryMapper caches).
>
> 2. Return clips and transforms by reference, to avoid copying.
>
> #1 is expected to be a good optimization because we almost always compute clips
> and transforms relative to the same ancestor, so the vectors are short and hash
> lookups are reduced.
>
> BUG=692614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2729243002
> Cr-Commit-Position: refs/heads/master@{#455571}
> Committed: https://chromium.googlesource.com/chromium/src/+/ee72c4b5d2fd1e4882bddca66e0f89fe8784a7fc

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2738113003
Cr-Commit-Position: refs/heads/master@{#455706}

This patch makes |SpellChecker::removeMarkers()| to take |EphemeralRange|
instead of |VisibleSelection| as preparation of reduce usage of
|VisibleSelection| for improving code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740873003
Cr-Commit-Position: refs/heads/master@{#455705}

In particular: run the code to extract logcat output within the context
of the main Chrome process/service, rather than kicking off the work to
a pair of background services.  Moreover, dramatically simplify the
MetricsUploadService code: remove all but one of the intents that it
handles.

BUG=694884
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2727573004
Cr-Commit-Position: refs/heads/master@{#455704}

This patch is in preporation to draw items in network timeline panel in
layers. To make it easier to draw in layers I removed the gradients we
currently have with flattened versions.

See: http://imgur.com/a/Nbis6 (note these two are from different requests)

R=caseq,luoe
BUG=697669

Review-Url: https://codereview.chromium.org/2723053003
Cr-Commit-Position: refs/heads/master@{#455703}

This patch refactors standard CSS property transition calculation to
be isolated to calculateTransitionUpdateForStandardProperty().
This is in preparation for introducing another separate function
called calculateTransitionUpdateForCustomProperty() that enables
CSS Transitions on registered custom properties.

This patch is a refactor and does not change behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2725803006
Cr-Commit-Position: refs/heads/master@{#455702}

BUG=699347
TBR=csharrison

Review-Url: https://codereview.chromium.org/2740023002
Cr-Commit-Position: refs/heads/master@{#455701}

This is a clean-up CL and doesn't change behavior.

For improving extensibility, this CL separates WorldIdConstants to 2 parts:
WorldTypes and WorldId. This encapsulates identifier allocation logic in
DOMWrapperWorld[1] and makes it easier to expand the identifier space for
Worklets[2].

[1] WorldIds for IsolatedWorlds still need to be given from out of
    DOMWrapperWorld because of its unique convention to allocate the identifier.
[2] https://codereview.chromium.org/2735823006/

BUG=697622, 697629

Review-Url: https://codereview.chromium.org/2735973006
Cr-Commit-Position: refs/heads/master@{#455700}

Rather than using the (obviously "racy") technique of looking up the
event-base element again when disconnecting from it, store the reference
on connect (sharing storage with the sync-base element since they are
mutual exclusive) and use it to disconnect properly.

BUG=641437

Review-Url: https://codereview.chromium.org/2739893002
Cr-Commit-Position: refs/heads/master@{#455699}

BUG=webrtc:6424

Review-Url: https://codereview.chromium.org/2737133002
Cr-Commit-Position: refs/heads/master@{#455698}

This should be impossible, but we'd like to try it in canary
to try and figure out what's going on in the linked bug.

This should be reverted by 17 March.

BUG=694520

Review-Url: https://codereview.chromium.org/2740013002
Cr-Commit-Position: refs/heads/master@{#455697}

platform/loader has a BUILD.gn, but it defines only production files,
and files for testing are still defined in platform/BUilD.gn.

This patch moves test file definitions for blink_platform_unittests
from platform/BUILD.gn to platform/loader/BUILD.gn.

BUG=699369

Review-Url: https://codereview.chromium.org/2733253003
Cr-Commit-Position: refs/heads/master@{#455696}

This is being done by default in V8 itself.
The API used to do this is being deprecated.

R=marja@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2740913002
Cr-Commit-Position: refs/heads/master@{#455695}

Network traffic annotation is added to network request of
search_provider_logos/logo_tracker.

BUG=656607

Review-Url: https://codereview.chromium.org/2718443002
Cr-Commit-Position: refs/heads/master@{#455694}

Convert dumb single/double quotes to smart quotes just like gitiles.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2740863004
Cr-Commit-Position: refs/heads/master@{#455693}

Current behavior when trying to browse to the basic URL is to return
an error message, and then force the dev to figure out the full path
to the doc and put it in.  Let's present a simple directory listing
instead for them to navigate if they want.

This doesn't try to emulate gitiles, just produce something that isn't
awful on the eyes.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2742683002
Cr-Commit-Position: refs/heads/master@{#455692}

Add a new positionForOffset method to ShapeResult that returns the x-pos
for a given offset. Effectively being the companion to offsetForPosition
that returns the offset for a given x-pos. Also add unit tests for both.

Will be used by the LayoutNG shaper-driven line-breaking implementation.

R=kojii@chromium.org
TEST=Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Review-Url: https://codereview.chromium.org/2739993002
Cr-Commit-Position: refs/heads/master@{#455691}

This CL fixes the SHOWING_TERMS_OF_SERVICE part.
- Renamed to NEGOTIATING_ to reflect its actual responsibility.
- Move checks if ToS negotiation is skipped into the state.
  - For better encapsulation.
  - Removing state machine transition from STOPPED to
    CHECKING_ANDROID_MANAGEMENT as simplification.
- Get rid of CancelAuthCode() on Terms of Service rejecting.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2737453003
Cr-Commit-Position: refs/heads/master@{#455690}

enum.

BUG=626786
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2733823003
Cr-Commit-Position: refs/heads/master@{#455689}

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2732963002
Cr-Commit-Position: refs/heads/master@{#455688}

This is a follow-up CL to https://codereview.chromium.org/2371673002, to make testing of length-accepting properties more complete.

To do this, I added "Length" as a typedom_types for each property in CSSProperties.in
While I was at it, I also added the valid keywords for those properties.

BUG=545318

Review-Url: https://codereview.chromium.org/2583063002
Cr-Commit-Position: refs/heads/master@{#455687}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f529f7c9..fc069168

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2740793003
Cr-Commit-Position: refs/heads/master@{#455686}

The library is intended for mutation protocol buffers for fuzz testing.
It can't function without proto descriptors and proto reflection.
The library is and will be testonly, so there should be low risk
of linking with production binary.

BUG=

Review-Url: https://codereview.chromium.org/2736333002
Cr-Commit-Position: refs/heads/master@{#455685}

Revert of Finish OSMesa support for Ozone X11. (patchset #2 id:40001 of https://codereview.chromium.org/2730993002/ )

Reason for revert:
Sorry, speculatively reverting based on persistent ozone builder flake. Started with this CL as best as I can tell.

Appears to be a sync command buffer IPC hang on shutdown, affecting only tests which force single-process mode. Possibly a deadlock caused by ... something in the OSMesa/X11?

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_ozone_rel_ng%2F336922%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FSavableResourcesTest.GetSavableResourceLinksWithPageHasInvalidLinks%2F0

Original issue's description:
> Finish OSMesa support for Ozone X11.
>
> Modify the GLOzone implementation for Ozone X11 OSMesa to use
> GLSurfaceOSMesaX11. This copies the bitmap that OSMesa generated to the
> XWindow so it's visible.
>
> BUG=698780
>
> Review-Url: https://codereview.chromium.org/2730993002
> Cr-Commit-Position: refs/heads/master@{#455306}
> Committed: https://chromium.googlesource.com/chromium/src/+/1df13216e40fed4c8fa2531fc4c764eca1aae018

TBR=kbr@chromium.org,kylechar@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=698780

Review-Url: https://codereview.chromium.org/2742713002
Cr-Commit-Position: refs/heads/master@{#455684}

The gitiles renderer doesn't require URLs to be bracketed with <...>.
Add an extension to support that.

R=dpranke@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2743553002
Cr-Commit-Position: refs/heads/master@{#455683}