GitLab

Remove code for histograms which aren't yielding additional useful
info.  Cleanup naming slightly.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10802098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148301 0039d316-1c4b-4281-b951-d872f2087c98

 We probably want to change this for window dragging and/or drag&drop.

BUG=123160
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10826005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148300 0039d316-1c4b-4281-b951-d872f2087c98

Intending to use this to track down suspected memory corruption.

BUG=71832
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10818042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148299 0039d316-1c4b-4281-b951-d872f2087c98

Added debug only shortcut to activate screen locker.

BUG=123160
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10800095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148297 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=138857

R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148296 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mihaip@chromium.org,rsesek@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10820010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138873
TEST=ash_unittests:BaseLayoutManagerTest.BoundsAfterRestoringToMaximizeFromMinimize

Review URL: https://chromiumcodereview.appspot.com/10821008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148294 0039d316-1c4b-4281-b951-d872f2087c98

It turned out these shortcuts were accidentally added to the global shortcuts.
This CL reverts the part of adding keyboard shortcuts in the CL below.
http://src.chromium.org/viewvc/chrome?view=rev&revision=147127

TBR=xiyuan@chromium.org
BUG=137708
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10809088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148293 0039d316-1c4b-4281-b951-d872f2087c98

first, we don't create file on disk when it is selected anymore (since we can't really know exact file path for drive files), we just setup permissions for the file.

second, we have to give read permissions for drive cache paths as well in order to enable file reading. 

TEST=existing
BUG=138089

Review URL: https://chromiumcodereview.appspot.com/10664002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148292 0039d316-1c4b-4281-b951-d872f2087c98

(Separated from a bigger patch: https://chromiumcodereview.appspot.com/10810053)

BUG=138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10817006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148291 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=92148

Also, while I'm here, don't include the webkit .cur files on
platforms other than windows.

BUG=137588
TEST=Cursors show up fine in component builds.

Review URL: https://chromiumcodereview.appspot.com/10817031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148290 0039d316-1c4b-4281-b951-d872f2087c98

The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event.

Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened.

BUG=None
TEST=Test shutdown 


Review URL: https://chromiumcodereview.appspot.com/10800031

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148289 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/bloat-http/times: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=150&rev=-1

TBR=cmp
BUG=138894
Review URL: https://chromiumcodereview.appspot.com/10828004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148288 0039d316-1c4b-4281-b951-d872f2087c98

For Android, it doesn't use views but use skia natively.

BUG=
TEST=run_tests.py -s ui_unittests


Review URL: https://chromiumcodereview.appspot.com/10817025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148287 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ability to change the value of the WebKit runtime flag added in http://trac.webkit.org/changeset/121229


Review URL: https://chromiumcodereview.appspot.com/10815069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138739
TEST=Manually check debug shortcuts work with --ash-debug-shortcuts enabled and do not work otherwise.

Review URL: https://chromiumcodereview.appspot.com/10825002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148285 0039d316-1c4b-4281-b951-d872f2087c98

UninitCondition
Conditional jump or move depends on uninitialised value(s)
  media::mp4::TrackRunIterator::Init(media::mp4::MovieFragment const&)
    (media/mp4/track_run_iterator.cc:134)
  media::mp4::TrackRunIteratorTest_BasicOperationTest_Test::TestBody()
    (media/mp4/track_run_iterator_unittest.cc:114)
Uninitialised value was created by a stack allocation
  media::mp4::TrackRunIteratorTest::CreateFragment()
    (media/mp4/track_run_iterator_unittest.cc:62)

BUG=none
TEST=media_unittests + valgrind.


Review URL: https://chromiumcodereview.appspot.com/10825005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148284 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148283 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/dom_perf/total/score:
http://build.chromium.org/f/chromium/perf/linux-release-lowmem/dom_perf/report.html?history=150&rev=148265

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10829004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148282 0039d316-1c4b-4281-b951-d872f2087c98

The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event.

Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened.

BUG=None
TEST=Test shutdown 


Review URL: https://chromiumcodereview.appspot.com/10800031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148281 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, cmd.exe crops the command-line string for build_nexe.py and build_nexe.py does not get all base files now. This change removes all files not needed by build_nexe.py on Windows to prevent cmd.exe from cropping the command-line string to build_nexe.py.

BUG=138687
TEST=build Chromium without errors.

Review URL: https://chromiumcodereview.appspot.com/10806082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
TBR=tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10805092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148279 0039d316-1c4b-4281-b951-d872f2087c98

Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too.

R=bshe@chromium.org,csilv@chromium.org
BUG=None.
TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed.


Review URL: https://chromiumcodereview.appspot.com/10790084

TBR=rkc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148278 0039d316-1c4b-4281-b951-d872f2087c98

chrome/test/data/plugin was moved to content/test/data/plugin
Update tests

BUG=138857
TEST=pyauto tests

R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148275 0039d316-1c4b-4281-b951-d872f2087c98

Expected images of following tests are update by WebKit r123302.
* fast/forms/number/number-appearance-rtl-expected.html
* fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.html
* fast/forms/number/number-appearance-spinbutton-layer-expected.html

TBR=atwilson@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10795085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148274 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/dom_perf/total score: http://build.chromium.org/f/chromium/perf/linux-release/dom_perf/report.html?history=550&rev=148261

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10820006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148273 0039d316-1c4b-4281-b951-d872f2087c98

Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too.

R=bshe@chromium.org,csilv@chromium.org
BUG=None.
TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed.


Review URL: https://chromiumcodereview.appspot.com/10790084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148272 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/moz/vm_peak_r: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=200&rev=148240&graph=vm_peak_r

TBR=cmp
BUG=138877
Review URL: https://chromiumcodereview.appspot.com/10822005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148271 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/moz/total_byte_b:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=300&rev=148240&graph=total_byte_b

TBR=cmp
BUG=138872
Review URL: https://chromiumcodereview.appspot.com/10820004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148266 0039d316-1c4b-4281-b951-d872f2087c98

The "Params" class is not used; the params are just directly stuck in the message.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10819004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148265 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148264 0039d316-1c4b-4281-b951-d872f2087c98

Peformance improvement.

xp-release-dual-core/moz/total_byte_r:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=148240&graph=total_byte_r

TBR=cmp
BUG=138864
Review URL: https://chromiumcodereview.appspot.com/10826004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148263 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9188: (mseaborn) Remove the unused build/cook_tarball.py script
r9189: (mseaborn) Remove obsolete references to Doxygen, which NaCl does not use these days
r9191: (dschuff) Update pnacl UPSTREAM_REV to pick up arm peephole codegen fix
r9193: (bradnelson) Turning on checkdeps for nacl.
r9195: (dschuff) Run SPEC benchmarks twice on ARM to hopefully get more stable numbers
r9196: (khim) Use validator to filter out invalid instructions
r9197: (eaeltsin) Debug stub: restore registers of suspended threads
r9198: (eaeltsin) Debug stub: pass test name into gdb test guest
r9199: (eaeltsin) - disable interrupt test on ARM
r9200: (bbudge) Add a compile time flag to distinguish between the SRPC and IPC proxies.
r9201: (mcgrathr) Leave a gap at the top of the address space above the useful stack contents
r9202: (dschuff) Update UPSTREAM_REV and GOLD_REV and add include flag to fix translator build
r9203: (bsy) Increase detail level of debugging log statements.
r9204: (bradnelson) Adding exclusion of BACKPORTS from checkdeps.
r9205: (khim) Accept lzcnt & tzcnt unconditionally
r9206: (khim) Add "THIS FILE IS AUTO-GENERATED" header to generated files.
r9207: (khim) Split special_instructions machine in validator-x86_64.rl
r9208: (khim) Disable lfs, lgs, and lss instructions
r9209: (khim) Move common code from validator-x86_*.rl to validator-internal.h
r9210: (khim) Remove hyphen from validator_ragel file names.
r9211: (halyavin) Add test that checks stack trace functionality with real gdb.
r9212: (pasko) validator_ragel: compile with scons, gyp, run a test on bots
r9213: (robertm) create a hook for various rcs tools so we can change them for the windows bot.
r9214: (dschuff) Add option to run.py to use QEMU's execution tracing feature
r9215: (khim) Simplify normal_instruction logic.
r9216: (jvoung) Enable structs in callingconv test for pnacl x86-32.
r9217: (bbudge) Fix compile time flag for NaCl IPC-based PPAPI Proxy.
r9218: (bradnelson) Use HTTPS for downloading code.
r9219: (arbenson) Properly handle failure of prereserved memory detection on ARM
r9220: (dschuff) Update pnacl DEPS to 9213
r9224: (bradnelson) Switching on checkdeps for c, fixing some issues.
r9225: (mseaborn) Fix nacl_bootstrap args in debug_stub and thread_suspension tests
r9226: (khim) Add support for IRT's shadow TLS accesible via %gs:4
r9227: (khim) Fix typos introduced in CL9207
r9228: (robertm) Disable svn marker generation for pnacl windows TC bot
r9229: (khim) Simplify check_access function.
r9230: (dschuff) Check out upstream clang using git instead of SVN
r9231: (pasko) validator_ragel: move validator_test.py from Makefile to scons
r9232: (nfullagar) Bump chrome rev to r147940

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10795094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148262 0039d316-1c4b-4281-b951-d872f2087c98

- adjusted some code to handle the fact that the binaries are in the set of products now
- added new process exit codes for some situations that should never happen (only if we mess up invoking setup.exe, nothing for a user to do, so no new strings)

BUG=138658
TEST=install beta channel chrome then update with only "--multi-install --do-not-launch-chrome --verbose-logging" on the command line.  also test single to multi migration of chrome, multi-installs with chrome frame, etc.

Review URL: https://chromiumcodereview.appspot.com/10806086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148261 0039d316-1c4b-4281-b951-d872f2087c98

Added the search feature to the samples page, and also added icons next to the
samples.

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10809062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137139, 137137, 137136
TEST=none
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10800103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148259 0039d316-1c4b-4281-b951-d872f2087c98

provided by the newly added class HungRendererDialogMetro. 

The actual dialog box is displayed by the metro driver.dll and the functionality to create and display
this is invoked via the exported functions ShowDialogBox and DismissDialogBox. The handlers to be run when
the user clicks on the kill process/wait buttons are passed into the ShowDialogBox function.

Factored out the platform specific portion of the kill process functionality in the static function
HungRendererDialogView::KillRendererProcess which is conditionally compiled for the platform.

BUG=125672
R=sky
Review URL: https://chromiumcodereview.appspot.com/10806079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148258 0039d316-1c4b-4281-b951-d872f2087c98

R=asanka@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10802056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136494


Review URL: https://chromiumcodereview.appspot.com/10808043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148255 0039d316-1c4b-4281-b951-d872f2087c98

Disabling a few tests to make the bots go green while I look into what's
going wrong.

R=craigdh@chromium.org
BUG=138857
TEST=green pyauto bots.

Review URL: https://chromiumcodereview.appspot.com/10825004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148254 0039d316-1c4b-4281-b951-d872f2087c98