- 02 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/38f24ee666e1..0da73fedd900 git log 38f24ee666e1..0da73fedd900 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 jmadill@chromium.org Vulkan: Add dumping of the command graph to GraphViz. Created with: gclient setdep -r src/third_party/angle@0da73fedd900 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6743cae4f182c0795f2e11819b40d8199b8f1411 Reviewed-on: https://chromium-review.googlesource.com/1257186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595891}
-
Lily Chen authored
This change avoids erroneously deleting an equivalent pre-existing (insecure) cookie when attempting to add a new insecure cookie that path-matches a pre-existing secure cookie. Previously, the pre-existing insecure cookie would be deleted because it is equivalent to the new cookie, even if a matching secure cookie was encountered and skipped. This change adds a check that no secure cookie was skipped while attempting to add the new cookie. Bug: 703627 Change-Id: I471f5887fecd84afc4b746ae78bb73fbf4449cdf Reviewed-on: https://chromium-review.googlesource.com/1252866 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595890}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/48348e91f2d7..a115d8de1c98 git log 48348e91f2d7..a115d8de1c98 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 achuith@chromium.org cros_unittest: Update test gaia account. Created with: gclient setdep -r src/third_party/catapult@a115d8de1c98 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879353 TBR=sullivan@chromium.org Change-Id: Ibe3bc0fe3b14f5f805d4bf4b0421dbd07a7c575d Reviewed-on: https://chromium-review.googlesource.com/1256081Reviewed-by:
-
Josh Pratt authored
Updates the string for kErrorStartingTermina and adds strings for kErrorOffline, kErrorFetchingSshKeys and kErrorMountingContainer. Change-Id: I0a1fba8179d4f32f99cb376922633578b332a912 Reviewed-on: https://chromium-review.googlesource.com/1255762 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595888}
-
Fabrice de Gans-Riberi authored
The test launcher creates a /data directory for each of its children. This is implemented as a directory with a unique number in its name. Access to the number was not thread-safe, which this CL fixes by using atomic operations to increase the number. This is a potential fix for the content_unittests failure seen here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/117497 Change-Id: I42614b0de36e65ffb8bc811813132a8781036896 Reviewed-on: https://chromium-review.googlesource.com/1255926Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595887}
-
Pete Williamson authored
This also adds a unit test for existing headers. To make the testing easier, we added a languages parameter to the call to UpdateCatalogFromNetwork. Change-Id: I871b8461afcd31c6e74d6bab9682134cf5e26943 Reviewed-on: https://chromium-review.googlesource.com/1256008 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#595886}
-
Xida Chen authored
This CL corrects a typo in input_router_impl.cc, it doesn't introduce any behavior change. TBR=nzolghadr@chromium.org Bug: None Change-Id: I899b936cafbd61215a30f39f53d2514b570fcda2 Reviewed-on: https://chromium-review.googlesource.com/1255572Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595885}
-
Aldo Culquicondor authored
Bug: 884803 Change-Id: I20378649418949c2d00097ff8ca204972c54b2ab Reviewed-on: https://chromium-review.googlesource.com/1240169Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595884}
-
Khushal authored
This reverts commit 7f6cb854. Reason for revert: We have the diagnostic data we needed. Original change's description: > android: Add diagnostic crash dump for GPU OOM crashes. > > R=cpu@chromium.org > > Bug: 879259 > Change-Id: I4ad88bcf863be355a286b6e0271a08dc470d1cda > Reviewed-on: https://chromium-review.googlesource.com/1220769 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Carlos Pizano <cpu@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590562} TBR=boliu@chromium.org,cpu@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879259 Change-Id: Icc66bdc3d72fa396cbb107ba86c266ef79ab0ad7 Reviewed-on: https://chromium-review.googlesource.com/1257242Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595883}
-
Alexei Filippov authored
BUG=889545 Change-Id: I880fae90be175883b70915e1d992ea00a4363cc4 Reviewed-on: https://chromium-review.googlesource.com/1252365Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#595882}
-
Filip Gorski authored
* Adding ability to configure values requested by the Feed team, except 2 that are not available in Configuration class. * Updating FeedProcessScopeFactory to consume configuration. * Adding javatests to cover the code. Bug: 886972 Change-Id: Ib38fe2ea062fa7014ff5e4ecff02150f24e96f67 Reviewed-on: https://chromium-review.googlesource.com/1248121Reviewed-by:
-
Ovidio Henriquez authored
This change adds a new policy template for WebUsbAllowDevicesForUrls. The new policy will allow a list of devices to be automatically granted permission to be used for a list of URL patterns. This change also adds a policy handler to validate the policy value and add the validated value to Preferences using the pref name defined for this policy. The design document for the new WebUSB policy is located at: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w/ Bug: 854329 Change-Id: I03657906834ba12f43735d7339a8ca404dc50718 Reviewed-on: https://chromium-review.googlesource.com/1225692 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595880}
-
Sami Kyostila authored
TBR=nyquist@chromium.org Bug: 879922 Change-Id: If59565e8610e6307868f9f7ad5ffe8cba54d5f1e Reviewed-on: https://chromium-review.googlesource.com/1256946Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595879}
-
Yves Arrouye authored
When the management server sends this new option, wire it to an unescapable Zero-Touch flow. Bug: chromium:891281 Test: N/A for now as the server doesn't return this option Change-Id: Iaaa3dd531ccb8f8a5fb2788ca61171ad8abc487e Reviewed-on: https://chromium-review.googlesource.com/1256906Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#595878}
-
Lei Zhang authored
Remove a comment that was suppose to be useful. It instead split the list in two, which in turn allowed developers to randomly put files in either list. Change-Id: Ib65a4505ef7e7e18a0e4a8bb462bdf894d7f4d09 Reviewed-on: https://chromium-review.googlesource.com/1256369Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595877}
-
Vasilii Sukhanov authored
Bug: 887914 Change-Id: I76658cd1d001653da0f32f2d955646f8cd365d64 Reviewed-on: https://chromium-review.googlesource.com/1256777Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595876}
-
Ben Pastene authored
This is now done automatically after crrev.com/c/1252005 Change-Id: Iddcd43de19376bf2d6d522dd2ceed5060b880bf6 Reviewed-on: https://chromium-review.googlesource.com/1256102Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595875}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e928488baf66..aa7c7ba5051f Created with: gclient setdep -r src-internal@aa7c7ba5051f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8be04c9c99939ac8467ce3e8c0456d3c48978a8f Reviewed-on: https://chromium-review.googlesource.com/1256903Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595874}
-
Mike Klein authored
Change-Id: Idb6e66c655015000df132ac357f07b7bea7a9cdc Reviewed-on: https://chromium-review.googlesource.com/1254442 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595873}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/146eb3bdcf5b..a77bb2e54b35 git log 146eb3bdcf5b..a77bb2e54b35 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 alanbaker@google.com Add validation for execution modes Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a77bb2e54b35 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic098caa47274dd4af11d79272383ab7c95ef2502 Reviewed-on: https://chromium-review.googlesource.com/1256079Reviewed-by:
-
Mustaq Ahmed authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I81d8e42cfe0b1affe5568c694f3526df6e273fc8 TBR: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1252261 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595871}
-
Andrey Kosyakov authored
Network conditions management is now done in content, so support for this in headless is redundant. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1255610 fix network_dp.{h,cc} being removed from BUILD.gn. Change-Id: I6903c58f72bfc20588bf795da7b9f2e647dd0801 Reviewed-on: https://chromium-review.googlesource.com/1255726Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595870}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2be8456. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" 8c84af9b "Update beacon WPTs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25751 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iba3bbb64fe5b0f19b175d6b72ca85372cedd92c1 Reviewed-on: https://chromium-review.googlesource.com/1256627 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595869}
-
Clark DuVall authored
Browser initiated requests were getting the "main_frame" type in the web request listener details, this gives them the correct "other" type. Bug: 888672 Change-Id: Ie5e24c6f51c21ad57babb710e54cc5af47bb02c2 Reviewed-on: https://chromium-review.googlesource.com/1256562Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595868}
-
Hans Wennborg authored
The new Clang warning points out that the class can't be copy assigned because the current_ member is const. Copy or move constructing it is fine though, and that's all that's needed. Bug: 890307 Change-Id: I3f4d5e69485b84166ba4dd2356cc7973a5e58da6 Reviewed-on: https://chromium-review.googlesource.com/1255613Reviewed-by:
-
Devlin Cronin authored
Move the mediaGalleries API out of extensions code and into apps code. This includes the API implementation, schema definition, features entries, and API permission info. Bug: 877240 Change-Id: I8b750143cdcd36700f36d9da088ebaec4abd4cfe Reviewed-on: https://chromium-review.googlesource.com/1255584Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595866}
-
Florin Malita authored
Manual rebaseline for some layout tests left in a bad state after https://chromium-review.googlesource.com/c/chromium/src/+/1254341. TBR=reed Bug: 891230 Change-Id: I8e2c43c972d63f1d3eeb44ecbcaeffea2242fb34 Reviewed-on: https://chromium-review.googlesource.com/1256085Reviewed-by:
-
Mugdha Lakhani authored
Bug: 616321 Change-Id: I6a9f570f7f100fa8e1515f7736b6294644483f83 Reviewed-on: https://chromium-review.googlesource.com/1234475 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#595864}
-
Torne (Richard Coles) authored
Several places in the code convert between Java byte arrays and C++ std::string, and some had implemented a local helper function for this. Add a generic helper for this to base instead, and convert existing places that do this to use the helper. Test: base_unittests Change-Id: Ia56fb6333bd6c453207814b0bcb5ac58b5488c20 Reviewed-on: https://chromium-review.googlesource.com/1255342 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
This was requested during UI review for the Autofill settings toggle split, because the new proposed order (passwords, payment methods, addresses) is more useful. Screenshot linked in the bug. Bug: 891305 Change-Id: Iabd587538b54fd579837c4aec8c762d91e1cfb8d Reviewed-on: https://chromium-review.googlesource.com/1256084Reviewed-by:
-
Scott Violet authored
And replaces it with a boolean. This makes more sense as EMBED_IN_OWNER is really something that changes depending upon whether the Window has an embedding or not. BUG=834487 TEST=covered by tests Change-Id: If5d46331b1c54e329247996f3fc012448435aabf Reviewed-on: https://chromium-review.googlesource.com/1239371 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595861}
-
Mason Freed authored
There is a Windows-only limit on stack trace depth of 62. It seems to only apply to Server 2003 and XP, though it might exist for later OSes. See https://msdn.microsoft.com/en-us/library/bb204633.aspx for reference. I've left the limit at 62 for all of Windows in this CL. This limit does not (seem to) apply to other operating systems, so I've relaxed the limit to 250. The prior 62 limit does impede some real debugging efforts, as our stack depth can grow significantly past 62 in some cases, for example when performing layout on a deeply nested page. For example, see crbug.com/877093, which quotes the 62/63 limit. In addition, testing seems to show that Android has a problem with larger limits also, so I've left the Android limit at 62. Bug: 877093 Change-Id: Ie6521aa5da5e577cf28a312791fba873df6930cc Reviewed-on: https://chromium-review.googlesource.com/1252002 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595860}
-
Jordan Demeulenaere authored
Chrome Java style discourages usage of List<> and prefers to use ArrayList<>. Returning an ArrayList explicitly allows callers to pass this list in a method that requires an ArrayList as input. Bug: None Change-Id: Icbb4d3f5b0c9d38b654dc73bb3c2d3dc935427c1 Reviewed-on: https://chromium-review.googlesource.com/1256795 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595859}
-
Antonio Gomes authored
InitDataReductionProxySettings constructs DataReductionProxyService, which later on is provides data to DataReductionProxyIOData to construct DataReductionProxyConfig. Ultimately, DataReductionProxyConfig constructs WarmupURLFetcher instances. This CL is a preparation CL for [1], where we migrate WarmupURLFetcher from URLFetcher to SimpleURLLoader. In [1], |url loader factory| is mandatory to be non-null. Passing an actual instance at the beginning of the call chain now has no immediate effect, but is harmless too. [1] https://crrev.com/c/1251641 BUG=879777 Change-Id: I3f3009e6e6d9db9659e7783cbed65a1a82c6a34e Reviewed-on: https://chromium-review.googlesource.com/1256945Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#595858}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 874080 Change-Id: I449d164d700298ec166451458a5f9b135514156d Reviewed-on: https://chromium-review.googlesource.com/1190933Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#595857}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73d117f64ebb..1ac95546dd12 git log 73d117f64ebb..1ac95546dd12 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 eladalon@webrtc.org Include optional.h in rtc_event_log_parser_new.cc 2018-10-02 nisse@webrtc.org Delete VideoReceiveStream::EnableEncodedFrameRecording 2018-10-02 danilchap@webrtc.org Add RtpPacket::GetRawExtension function Created with: gclient setdep -r src/third_party/webrtc@1ac95546dd12 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3266b39da17f5a3fd64798d6874dc1a39a197049 Reviewed-on: https://chromium-review.googlesource.com/1256904Reviewed-by:
-
Stephane Zermatten authored
Before this patch, scripts were checked for the url from DidFinishLoad. This generally works, because most URLs loaded from a page belong to the same domain, but not all. In some cases, depending on loading order, this resulted in the set of runnable script being cleared unexpectedly. With this patch, the controller always uses the page URL. In most cases, since DidFinishLoad reports loading resources, this reports the same URL, wehich is a no-op for GetOrCheckScripts. The set of runnable scripts should now be stable on a given page. Bug: 806868 Change-Id: Ifb8f5955c00396a9d2165eb0bacf73c8c825f76d Reviewed-on: https://chromium-review.googlesource.com/1257002Reviewed-by:
-
Max Morin authored
Reasonably, nullptr isn't a frame, so it cannot be deleted. This call also isn't necessary, since the destructor of |factory_| is going to clean everything up soon anyways. Adds a DCHECK to ForwardingAudioStreamFactory::FrameDeleted to assert that |render_frame_host| is non-null. Bug: 734672 Change-Id: Ide1679e93923b70182498f57b92eb21f08f8e5f6 Reviewed-on: https://chromium-review.googlesource.com/1256962Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595854}
-
Daniel Bratell authored
In some builds there were duplicate symbols because a cc file was compiled twice and linked with itself. This happened because some code accidentally included the cc file instead of the header. Change-Id: Ifa145ce13190a9fa855e06986ca60605005aa9fc Reviewed-on: https://chromium-review.googlesource.com/1255824 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595853}
-
Theresa authored
Rather, wait to record until the user exits the tab switcher to try to record. The user must exist the tab switcher on the tab for which results were returned. Also logs a histogram indicating whether results were returned while the user was in the tab switcher so that we can ballpark estimate adjustments needed to M69 metrics. BUG=890366 Change-Id: Ic5726907911df15d4bc6a5cbd97633fcf7415595 Reviewed-on: https://chromium-review.googlesource.com/1252627Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595852}
-
