- 24 Nov, 2020 40 commits
-
-
Hiroshige Hayashizaki authored
This is to unify the behavior of classic script evaluation code paths, because other callers of ExecuteScriptAndReturnValue() (for isolated worlds and workers) don't have corresponding `EscapableHandleScope`s. This CL is unlikely to affect GC performance, because: - The `EscapableHandleScope` was originally introduced in https://codereview.chromium.org/314953005/ that is not performance related. - ClassicScript::RunScript(), which is the primary caller of EvaluateScriptInMainWorld(), has already a `HandleScope` covering the same region. Particularly, script evaluation via `<script>` shouldn't be affected by this CL. Bug: 1111134 Change-Id: I599042b8172b393f4108317c5c349d256784a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544078Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#830718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/751250705016..bc75ebb1afc4 2020-11-24 johnstiles@google.com Fix crash with boolean vectors in is_constant<T>. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I0998f87399f5ecc3841302f3e09d8aedb3fe45cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830717}
-
Collin Baker authored
Some IPH promos want to customize their text at runtime, based on where it's showing. For example, a PWA install promo may want to include the app's name to be more clear to the user. This CL adds the infrastructure required. While it is a work in progress, this adds support for filling one placeholder in a string resource with a provided string. In the future, including icons in promo text is desired. The infrastructure in this CL is a step toward this. Bug: 1143971 Change-Id: Ica58bc92c59498b18fa1e988e1c3b1f1725bf413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551573 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#830716}
-
Eugene Zemtsov authored
More tests that are flaking on Win7 32. Failure examples: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/66823 https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/66824 TBR: dschuff@chromium.org Bug: 1059468 Change-Id: If7acfba0252f1dacf39b81826bba261e7ed28111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558841Reviewed-by:
Eugene Zemtsov <ezemtsov@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#830715}
-
Gordon Seto authored
Add UI for informing when an activation code is invalid in the activation code page. Screenshot: https://screenshot.googleplex.com/3gLCppUSwZbqovc.png Bug: 1093185 Change-Id: Ieb9959cdbd0dd754454eaa69d5c5f4ac5453c8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555917 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830714}
-
Sophey Dong authored
This is a reland of 974e1b68 Original change's description: > Remove enable-send-tab-to-self-omnibox-sending-animation flag. > > This bug fix has been launched since M84. > > Bug: 1124205 > Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508 > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819562} Bug: 1124205 Change-Id: I52065dc2e1dd4938a3bd7efc5232fc5959a203ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542733Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830713}
-
Daniel Libby authored
These need to be updated, same as the Win10 baselines in crrev.com/c/2529950. Bug: 1151844 Change-Id: Ibaf1f2bb084bc4c9295e6dc74370c9939fd63207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556013Reviewed-by:
Alex Keng <shihken@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#830712}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35f663e4..3b5297a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I333255238abe114c30fbe0c2a9179e753c1b8706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558893Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830711}
-
Nina Satragno authored
Fix a bug where trying to set a new PIN on a security key shows the update PIN dialog instead. Attempting to use that dialog results in a CHECK, since a PIN that is not set in the first place can't be changed. Fixed: 1152548 Change-Id: I375b4b550009726fe3ec865400443871cda1ea2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558916 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#830710}
-
Ivo Creusen authored
This is a useful metric that is in active use. Change-Id: I2d8cacbe5aa1fe30ffa71826841d18342d4f4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558417Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Ivo Creusen <ivoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830709}
-
Elly Fong-Jones authored
This is preparatory to adding a new kDefaultInitialPrefs, which will be "initial_preferences", and adding support for reading preferences from that file in addition to the legacy file. Bug: 1097209 Change-Id: I35508175274451171eb6bd5fa10a528de7bdfe1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555563 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830708}
-
Elly Fong-Jones authored
The comment at the head of this file predates automated expiration, and has become outdated. Fix it to reflect that :) Bug: None Change-Id: I804f04e66a5af9a0dafebed1dd4d1ce10e076c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558592 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830707}
-
Yi Gu authored
The test has been very flaky on win10: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=DevToolsSanityTest.TestOpenInNewTabFilter TBR=yangguo@chromium.org Bug: 1127051 Change-Id: Id5c6531b7896bd4a1d070ed26c037946255e55b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558995Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830706}
-
Liquan (Max) Gu authored
Changes: * CPRService takes over mShouldSkipShowingPaymentRequestUi from PaymentUiService. * Simplifies calculateWhetherShouldSkipShowingPaymentRequestUi as shouldSkipShowingPaymentRequestUi. Bug: 1025619 Change-Id: Id57c9225f85e99b8a174072e0e54c708eabbf876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556473 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830705}
-
Adithya Srinivasan authored
Bug: 1126901 Change-Id: I555e37125e1deab4b470293e59efb40c340943d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386012Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#830704}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5fac02c8e485..9041ca0c3407 2020-11-24 syoussefi@chromium.org Limit testing of in-progress work to ANGLE's build of dEQP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Id3c1d41c0dee698f13ad661539cd45e049acc5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558591Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: Ifacc158eb1442b35e3ce1f65f78636f2f3648ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554899 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#830702}
-
Nate Fischer authored
The underlying issue was a component build problem fixed by https://crrev.com/c/2553969. These are safe to reenable now. Fixed: 1144945 Test: run_webview_instrumentation_test_apk -f AwSettingsTest.testMediaPlaybackWith*UserGesture Change-Id: I750a7c7c8163586f35dc86224e3eaf6047f0786c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558778 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830701}
-
Yi Gu authored
The entire test suite has been disabled on TSAN. This patch disables some tests (flakiness score >1000) on all platforms. TBR=guidou@chromium.org Bug: 1127211 Change-Id: I06e5de9da09ecdbab0fab612587f694d8cddb3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558994Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606218923-9c6085eb8d1087e580649b9899e3b8b35853f279.profdata to chrome-linux-master-1606240669-c1104e164a95943470032f861bc56133b735d819.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06ab437d69b45e81347f734b716df83007981cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558993Reviewed-by:
-
Sharon Yang authored
Improve and add unit tests. Bug: 1117601 Change-Id: Ida2c296d61042b3217e399d2ce4a349f24dbddc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545767Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#830698}
-
Elly Fong-Jones authored
This document outlines how to go from: class MyDialogDelegateView to: class MyDialog creates/configures a separate DialogDelegate creates/configures a separate View Change-Id: Ied2f1e9dfa7c910100c2485016e8eda4531e53b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545751 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830697}
-
Jamie Madill authored
EGL_EXT_device_query is now exposed as a client extension in ANGLE. We can remove the code and TODO that checks for a display extension. Bug: angleproject:5372 Change-Id: I452657c25be017336c07caa091b5e594c1be2a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557219 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#830696}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iee955e7eac105236d440102aadaf4fe09b96bbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558736Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#830695}
-
Robbie McElrath authored
Bug: 1097244 Change-Id: If4b88e957f0a91d76694f68dce2a91515cff6ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551620Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#830694}
-
Klaus Weidner authored
The attributes were defaulting to optional, leading to invalid access. Mark as required in IDL and add an additional check to enforce a positive number for widthInMeters. Bug: 1151619 Change-Id: Ib2353478f93330d76072b9bfc69bc189bc5523aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556918 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#830693}
-
Alice Wang authored
This CL moves WebSigninBridge to signin.services target. Bug: 1152432 Change-Id: I5736852287f6dfdfd6577ec7cca7b6b99ef5a8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556845Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830692}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606218923-39c9d0a9fc77b1c3938c028a8199ea0790d9dbca.profdata to chrome-mac-master-1606240669-251229982c87402ee7b9ccf8ab49774406a74762.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic8d8235c85d51b28c13464fc71f42830f1c94c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558991Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c983c977f266..f66650677465 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ezemtsov@google.com,yigu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ezemtsov@google.com,yigu@google.com Change-Id: Ia958cda0e06e431afcf7ffe475110cbaf3a8fc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830690}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4314.0-1605523684-benchmark-88.0.4324.12-r1 to 89-4324.9-1606128713-benchmark-89.0.4334.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8cb2134036d0a85cc69cafea3c0a51d9023e07bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558833Reviewed-by:
-
Yi Gu authored
The two tests are still very flaky with high score (>1500): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=not_site_per_process_blink_web_tests%20(with%20patch)&tests=external%2Fwpt%2FFileAPI%2Fblob%2FBlob-stream TBR=mek@chromium.org NOTRY=True Bug: 1092048 Change-Id: I0375ea2a60f9a95ada3108539fb053ac297999c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558996Reviewed-by:
-
Yi Gu authored
TBR=yaoxia@chromium.org Bug: 1152528 Change-Id: Idd35652c77e2ed921f7241373a88cf70b8069225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558171Reviewed-by:
-
Thomas Tellier authored
Bug: 1147043,1104336,1050589 Change-Id: Ib3b327975298edc35c53322cf1aba03f8342b010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547292 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#830686}
-
Wenyu Fu authored
Add a privacy disclosure when ToS is skipped by policy in the FRE. The privacy disclaimer will be displayed on screen for 1 second before FRE is finished. Bug: 1108564, 1128158 Change-Id: I5f912e62484a5255bfda27db0318c0e92d541903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548293 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830685}
-
Dave Tapuska authored
The View implementation had a few more things that the frame left as a todo. Talking with wjmaclean@ it seems that the view implementation should just be used for this code as it handles things like long press gestures which were added after the frame code was written. BUG=1097816 Change-Id: Ic912c5d6fe9fda4183b25006c4b7631b37dade3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551791 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830684}
-
Eric Seckler authored
Not doing this may be causing flakes in other tracing tests later. Bug: 1141233 Change-Id: I67f5ad3b746a06a23de055b34b7c3236105b1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558791 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#830683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9490b30c229adb7b7ddcc5286b2895393a1ce6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557783Reviewed-by:
-
David Maunder authored
This is for a new feature where we display price alerts in the Tab card in the Tab grid switcher as price drops are identified for shopping related websites. Bug: 1151401 Change-Id: Id2adfed52195da36ced7ca6baf37a70ac536f686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552624Reviewed-by:
-
Andrew Grieve authored
This reverts commit 4727f47b. Reason for reland: Cronet test fixed in crbug.com/1136963 Original change's description: > Revert "Enable whole-program devirtualization for arm64 Android build." > > This reverts commit 4f9f1598. > > The CL being reverted causes cronet_test_instrumentation_apk to crash > on builder "android-cronet-marshmallow-arm64-rel". > > Bug: 1115229 > Change-Id: I2b177353b00a57befe488e0bbef242a2b585162c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376316 > Auto-Submit: Nick Harper <nharper@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802814} TBR=nharper@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1136962 Change-Id: Ib9dd654111d6f45915c0b7ed1e454fb29668ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416569 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830680}
-
Sam Maier authored
Bug: 1139446 Change-Id: I3613007c5480aa59d4931b82dbaf352a30576179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553856 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
