GitLab

If a CancellableTaskFactory is used by an Oilpan heap object, the
closure that the factory works with/over, cannot embed a reference
back to that object by way of an off-heap Persistent<> (WTF::Closure
is not on the heap.) If it does, such a reference will keep the heap
object alive, without it ever being released. Memory leaks are very likely.

This is too easy a slip-up to make with the current CancellableTaskFactory
constructor, so rephrase the constructor so as to make leaks no longer (easily)
possible. For Oilpan heap objects baked into the closure, the persistent reference
now held will be weak.

At the same time, take the opportunity to have this object no longer be a part object,
but a separate (off-heap) allocation. This lets us drop the ad-hoc ASan unpoisoning
support that was previously needed if CancellableTaskFactory was a part object
of an Oilpan heap object. Less magic.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1312843009

git-svn-id: svn://svn.chromium.org/blink/trunk@201787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just for consistency. This won't affect practical performance.

BUG=

Review URL: https://codereview.chromium.org/1317033008

git-svn-id: svn://svn.chromium.org/blink/trunk@201786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |VisibleSelection::ChangeObserver| out from |VisibleSelection|
class as |VisibleSelectionChangeObserver| as preparation of introducing
composed tree version of |VisibleSelection| since it doesn't depend on
DOM tree traversal and composed tree traversal.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309413006

git-svn-id: svn://svn.chromium.org/blink/trunk@201785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1319123003

git-svn-id: svn://svn.chromium.org/blink/trunk@201784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1329853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1328593005

git-svn-id: svn://svn.chromium.org/blink/trunk@201782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #1 id:1 of https://codereview.chromium.org/1315543009/ )

Reason for revert:
Reland: The Android build went green one build before this revert.

Original issue's description:
> Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ )
> 
> Reason for revert:
> I suspect this change broke webkit_unit_tests on Nexus 4:
> All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0
> All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1
> 
> First failing build:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423
> 
> Blamelist:
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html
> http://test-results.appspot.com/revision_range?start=347178&end=347178
> 
> Original issue's description:
> > OOPIF: Call setCoreFrame on remote-to-local swaps.
> > 
> > This ensures that various initializion in setCoreFrame is triggered when
> > doing remote-to-local swaps.
> > 
> > BUG=525285
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726
> 
> TBR=dcheng@chromium.org,alexmos@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=525285
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201756

TBR=dcheng@chromium.org,alexmos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525285

Review URL: https://codereview.chromium.org/1304093005

git-svn-id: svn://svn.chromium.org/blink/trunk@201781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Similar to https://codereview.chromium.org/1312353004/

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

Must be submitted after https://codereview.chromium.org/1303153005/

BUG=497761, 510398

Review URL: https://codereview.chromium.org/1305933007

git-svn-id: svn://svn.chromium.org/blink/trunk@201780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Persistent handle introduced to SVGInterpolation in 201698 created the following cycle.

SVGInterporation =(Persistent)=>
SVGAnimatedProperty =(Member)=>
SVGElement =(Member)=>
ElementRareData =(Member)=>
ElementAnimations =(part of object)=>
CSSAnimations =(part of object)=>
CSSAnimationUpdate =(Member)=>
NewTransition =(Member)=>
InertEffect =(Member)=>
EffectModel =(RefPtr)=>
InterpolationEffect =(RefPtr)=>
InterpolationRecord =(RefPtr)=>
SVGInterpolation

This CL breaks the cycle by making SVGAnimatedProperty::m_contextElement a raw pointer.

BUG=

Review URL: https://codereview.chromium.org/1325433005

git-svn-id: svn://svn.chromium.org/blink/trunk@201779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1324843003

git-svn-id: svn://svn.chromium.org/blink/trunk@201778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201759

BUG=522797
TBR=falken@chromium.org

Review URL: https://codereview.chromium.org/1313103003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correct old bug numbers, which were assigned to fix flaky crashes
of WPT shadow-dom tests.  The crashes are gone now, and reassign
to regular WPT shadow-dom issue (505364).

NOTRY=true
TBR=tkent@chromium.org
BUG=505364

Review URL: https://codereview.chromium.org/1326123003

git-svn-id: svn://svn.chromium.org/blink/trunk@201776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1315303010

git-svn-id: svn://svn.chromium.org/blink/trunk@201775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently each call site is calling V8GCController:collectGarbage multiple times
to collect all V8 & Blink objects. We should have a helper method that does this.

BUG=

Review URL: https://codereview.chromium.org/1328653002

git-svn-id: svn://svn.chromium.org/blink/trunk@201774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528110,528120,528122
TBR=pdr
NOTRY=true

Review URL: https://codereview.chromium.org/1322373002

git-svn-id: svn://svn.chromium.org/blink/trunk@201773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DeprecatedPaintLayer::physicalBoundingBox() returns the layer bounding box
in physical direction, translated to an ancestor layer's space. The caller
can either specify the ancestor layer or a pre-computed translation. Only one
of the parameter will be used.

This CL overloads the function to remove the extraneous argument at callers.

No behavioral change, no test added.

BUG=508383

Review URL: https://codereview.chromium.org/1315303009

git-svn-id: svn://svn.chromium.org/blink/trunk@201772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
  instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1328773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This plumbing doesn't go anywhere anymore.

R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/1310583005

git-svn-id: svn://svn.chromium.org/blink/trunk@201770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1314543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1310713006

git-svn-id: svn://svn.chromium.org/blink/trunk@201768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds base support of JQuery event listeners. Listeners which was installed by JQuery are shown in Event Listeners sidebar.
API for frameworks are provided. Developers can add own event listeners provider to global devtoolsFrameworkEventListeners array (it should be created if undefined). Provider functions should return two arrays:
1. Array with framework event listeners for current object in eventListeners field in format {type: {string}, useCapture: {boolean}, handler: (function()|Object)}.
2. Array with internal framework event handlers for current object in internalHandlers field - one function per each handler. This array is used for filtering out native internal event handlers.
BUG=61643
R=paulirish@chromium.org, pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/1268353005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1305343007

git-svn-id: svn://svn.chromium.org/blink/trunk@201766 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces template class |VisiblePositionTemplate| like
|PositionWithAffinityTemplate| as a preparation of introduce composed tree
version of |VisiblePosition|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1330563005

git-svn-id: svn://svn.chromium.org/blink/trunk@201765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=506468

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201676

Review URL: https://codereview.chromium.org/1327593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's failing on Linux Leak. Probably r201736
https://codereview.chromium.org/1236913004 missed adding the
expectation.

Build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13880
Leak log:
({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,2]})

BUG=410974
TBR=tdresser
NOTRY=true

Review URL: https://codereview.chromium.org/1326083003

git-svn-id: svn://svn.chromium.org/blink/trunk@201762 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=386142

Review URL: https://codereview.chromium.org/1314903010

git-svn-id: svn://svn.chromium.org/blink/trunk@201761 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Longer term we should clean up initialize code as in crbug.com/519111.

BUG=527636
TEST=WorkerThreadTest.StartAndStopImmediately

Review URL: https://codereview.chromium.org/1325193002

git-svn-id: svn://svn.chromium.org/blink/trunk@201760 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some tests have slightly different results after r201644
https://codereview.chromium.org/1308033003, looks like
they were just missed when adding the Rebaselines in that
patch.

BUG=522797
TBR=jbroman
NOTRY=true

Review URL: https://codereview.chromium.org/1321233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201759 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524107

Review URL: https://codereview.chromium.org/1310343007

git-svn-id: svn://svn.chromium.org/blink/trunk@201758 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With
https://codereview.chromium.org/1285413002
now some of WPT shadow-dom tests that used to be flaky
are fixed.

BUG=503445, 505364, 521960, 520616, 521907, 521913, 521914, 521918, 521929, 521937, 521941
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1315523011

git-svn-id: svn://svn.chromium.org/blink/trunk@201757 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ )

Reason for revert:
I suspect this change broke webkit_unit_tests on Nexus 4:
All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0
All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1

First failing build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423

Blamelist:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html
http://test-results.appspot.com/revision_range?start=347178&end=347178

Original issue's description:
> OOPIF: Call setCoreFrame on remote-to-local swaps.
> 
> This ensures that various initializion in setCoreFrame is triggered when
> doing remote-to-local swaps.
> 
> BUG=525285
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726

TBR=dcheng@chromium.org,alexmos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525285

Review URL: https://codereview.chromium.org/1315543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201756 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes our namespace handling code in selector parsing to use
emptyAtom to represent empty namespaces and nullAtom to represent no
namespace (e.g. "|a" vs. "a"), instead of having both as nullAtom and
a separate hasNamespace bool. This fixes a bug where we would interpret
in prependTypeSelectorIfNeeded an empty namespace as no namespace (i.e.
the default namespace).

Review URL: https://codereview.chromium.org/1305973007

git-svn-id: svn://svn.chromium.org/blink/trunk@201755 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1305353008

git-svn-id: svn://svn.chromium.org/blink/trunk@201754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=506468

Review URL: https://codereview.chromium.org/1308173008

git-svn-id: svn://svn.chromium.org/blink/trunk@201753 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported/web-platform-tests/shadow-dom/shadow-trees/upper-bounary-encapsulation/test-011.html
caused a flaky crashes on trybots.

When an link element started fetching CSS resource the resource loading happens asynchronously in the background, and
when it completes, owner element's state may have changed.

In the test, the owner element moved under shadow tree,
then asserting condition
ASSERT(!linkStyle() || !linkStyle()->hasSheet()).
happened.

BUG=503445
TEST=imported/web-platform-tests/shadow-dom/shadow-trees/upper-boundary-encapusulation/test-011.html

Review URL: https://codereview.chromium.org/1285413002

git-svn-id: svn://svn.chromium.org/blink/trunk@201752 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=joelo@chromium.org
NOTRY=true
BUG=30536,528062

Review URL: https://codereview.chromium.org/1313783009 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201751 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527736

Review URL: https://codereview.chromium.org/1301323008

git-svn-id: svn://svn.chromium.org/blink/trunk@201750 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change updates the UI of the animation timeline and removes the
pause button. Instead, the pause button is combined into a single
control button to pause, play and replay the timeline.

BUG=492679,447083

Review URL: https://codereview.chromium.org/1156323003

git-svn-id: svn://svn.chromium.org/blink/trunk@201749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1323293004

git-svn-id: svn://svn.chromium.org/blink/trunk@201748 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=468550

Review URL: https://codereview.chromium.org/1315043008

git-svn-id: svn://svn.chromium.org/blink/trunk@201747 bbb929c8-8fbe-4397-9dbb-9b2b20218538