- 28 May, 2019 40 commits
-
-
John Abd-El-Malek authored
These tests reach into the net::URLRequestContext from StoragePartition, which isn't possible when network service feature flag is enabled. Bug: 967698 Change-Id: Ie0bd2ae1b8ba96c3ff7227df62702aab4546fc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631892 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#663784}
-
Ioana Pandele authored
The origin passed into PasswordAccessoryController::RefreshSuggestionsForField is never used. This CL removes it. TBR=tmartino@chromium.org (for trivial mock change) Bug:none Change-Id: Ibe6d487143137220bf4692ea3c919a2a39d86e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632149 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#663783}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 887407 Change-Id: I539b49ee3a87ffa73c43add69c4a6006de490918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632161 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#663782}
-
danakj authored
See discussion thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/338WKwWPbPI/discussion Removes OS_ANDROID support for running web tests since we are no longer running them on Android bots. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1629049 which disabled the test suite on bots. R=avi@chromium.org, dpranke@chromium.org Bug: 567947 Change-Id: Ia0420056e3a7982b24c29f94945fb1034523d7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628956Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663781}
-
Avery Musbach authored
This reverts commit 40165b9a. Reason for revert: This CL is suspected of causing Issue 967196, according to Comment 2 on that issue: https://bugs.chromium.org/p/chromium/issues/detail?id=967196#c2 Original change's description: > overview: Show drop target even if split view is disabled > > The purpose of the present CL is to add a drop target in a certain > workflow. As of [1], the "drag to snap" mode has become a "normal drag" > mode which is available even when split view mode is not available. For > testing, you can note that in clamshell mode, with the functionality of > [2] disabled (the current default), split view mode is not available, > but you can still do a "normal drag" from overview. There is presently > no drop target in that workflow. There is no drop target depicted in [3] > either, but I am pretty sure a drop target is actually appropriate, > because of [4] (which is assigned to me) if for no other reason. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1612121 > [2] https://crbug.com/890029 > [3] https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c33 > [4] https://crbug.com/961170 > > Test: manual > Bug: 866622, 961170 > Change-Id: I079d01c3e449b10f23a19a9993fbdd44d0c1482e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627562 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Avery Musbach <amusbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663305} TBR=afakhry@chromium.org,sammiequon@chromium.org,amusbach@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866622, 961170 Change-Id: Ie2317389231366bdbc86667140cbd87c5d7259eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632550Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#663780}
-
John Abd-El-Malek authored
Bug: 966633 Change-Id: I840509fcf2e0cf27ed1bdf8a384023a95d424b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629690 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663779}
-
Ilia Samsonov authored
This CL removes unused code, and does not change the TestLauncher behavior. This code was introduced here https://codereview.chromium.org/1806353003 to allow launching unit tests in Mash. The Mash tests launcher no longer exist, and no other implementation of PreRunTest exist. Bug: 936248 Change-Id: Ie7e968d52904b249d57f23dc7c404d477265ed47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626023 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663778}
-
Tommy C. Li authored
BLOCK is now the default setting for Flash. Update the strings in Content Settings Page to make BLOCK "(recommended)" instead of ASK. Bug: 967046 Change-Id: I515e70e2ba2bbd9a716b46af1567522ebab3a2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628422Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#663777}
-
Cliff Smolinsky authored
Address sanitizer runs were flaky for the chrome and chrome_child dll load sanity tests. While it's not 100% clearly exactly what is causing the issues because they can't be repro'd, it does appear that the failures relate to unloading the dlls (with FreeLibrary). These dlls have never been intended to be freed like this, however. During normal execution they are never unloaded but instead just go away when the process is terminated. This change updates the tests to match that behavior and simply let the process exit. Bug: 964861 Change-Id: I46384f42b87e99d9615fa754097d0d589bd4a62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627755Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663776}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=guidou@chromium.org, liberato@chromium.org Bug: 953861, 751838 Change-Id: Iadb80d5367adc68d9fcc7e98e992a1b65ff7a890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629070Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663775}
-
Benoît Lizé authored
This is required to pin ordered code in memory on platforms that support it. This forwards the file and locations within it of the ordered code to Java, from native, as this is not discoverable purely from Java. This is controlled by a feature which is disabled by default, and the logging code will be replaced by the actual pinning one on supported platforms. Bug: 929926 Change-Id: I8c79c0609dd2709e3e4eefc5d8c971d84df6f4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631659 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663774}
-
Peng Huang authored
VkSubmitInfo::pWaitDstStageMask must be must be a valid pointer to an array of waitSemaphoreCount valid combinations of VkPipelineStageFlagBits values. Bug: None Change-Id: I23fe8210f724cbb11c48e6dcab7e6452fe0cab3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630540Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#663773}
-
Fergus Simpson authored
Remove aura::Env from WMHelperCastShell: Upstream has removed aura::Env from the WMHelper interface, this CL removes it from the CastShell specialization as well. NoGnCheck views_delegate: The header include and dep in the BUILD.gn file are both guarded correctly, but gncheck still thinks the include is illegal. Don't gncheck the include. Bug: b/133174544 Test: Chromecast build Change-Id: Id5de601311c8285416172cb1e97b74957f341fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628999Reviewed-by:
Sergey Volk <servolk@chromium.org> Auto-Submit: Fergus Simpson <afergs@chromium.org> Commit-Queue: Fergus Simpson <afergs@chromium.org> Cr-Commit-Position: refs/heads/master@{#663772}
-
Joanmarie Diggs authored
* Emit ATK focus and object:state-changed:focused events in response to ax::mojom::Event::kActiveDescendantChanged * Add ATK_STATE_FOCUSED to the state set of the active descendant * Update tests to reflect new events and states Bug: 959857 Change-Id: Idb97671e1c4f65aa293e1e4e7dbd5a9ecf47fb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631404Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#663771}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I49ef7868dfc7aedf4ad44ecf26dd9ef5884fdb91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632552Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#663770}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6925d000325a..5ca8b4622a59 git log 6925d000325a..5ca8b4622a59 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 eseckler@google.com Merge "public: Only build on platforms with IPC support for now" 2019-05-28 ilkos@google.com Merge "Allow final metrics result to be empty" 2019-05-28 lalitm@google.com Merge "metrics: fix crash when metric name not found" 2019-05-28 lalitm@google.com Merge "metrics: add tests for protobuilder functions" 2019-05-28 lalitm@google.com Merge "trace_processor: add support for text proto out and interactive metrics" 2019-05-28 treehugger-gerrit@google.com Merge "Fix chrome build" 2019-05-28 lalitm@google.com Merge "trace_processor: add support for proto and sql metric from shell" 2019-05-28 lalitm@google.com bazel: remove support for generate descriptors 2019-05-28 lalitm@google.com Merge "metrics: add support for extension fields in descriptors" 2019-05-28 lalitm@google.com Merge "metrics: add support for non-message repeated fields" 2019-05-28 khokhlov@google.com Merge changes Ie6400c7f,Ia8ac1a7f 2019-05-28 lalitm@google.com Merge "traceconv: bump shas" 2019-05-28 lalitm@google.com Merge "protos: add descriptor set build import" 2019-05-28 hjd@google.com Merge "Add zlib to buildtools" 2019-05-28 lalitm@google.com perfetto: ensure that ftrace descriptor is only built in standalone 2019-05-24 lalitm@google.com trace_processor: expose metric registration and proto extension fns 2019-05-24 lalitm@google.com metrics: introduce properly namespace metric file paths 2019-05-24 lalitm@google.com trace_processor: metrics: register built-in metrics upfront 2019-05-23 primiano@google.com Merge "Perfetto Client API (4): Add initial integration test" 2019-05-23 treehugger-gerrit@google.com Merge "TracingMutexImpl: Fix DestroyTracingSession()" 2019-05-23 treehugger-gerrit@google.com Merge "Add gen_amalgamated to gen_all" 2019-05-23 ilkos@google.com Merge "Simplify error and data loss stats" 2019-05-23 treehugger-gerrit@google.com Merge "Trace processor: add trace_metadata table" 2019-05-23 lalitm@google.com metrics: add proper support for repeated fields 2019-05-23 lalitm@google.com trace_processor: improve helper proto design 2019-05-23 ilkos@google.com Add statistics as a proto 2019-05-23 lalitm@google.com metrics: refactor metrics code into proper builder class 2019-05-23 ilkos@google.com Merge "Add count of spawned processes and other minor improvements" 2019-05-23 lalitm@google.com Merge "loadtool: fix loadtool sleeping longer than intended" 2019-05-23 primiano@google.com Merge "Remove gen_amalgamated from gen_all" 2019-05-23 eseckler@google.com service: Let producers choose whether to enable SMB scraping 2019-05-22 lalitm@google.com Merge "perfetto: refine proto descriptor support" 2019-05-22 lalitm@google.com Merge "metrics: add typechecking to metric result protos" 2019-05-22 treehugger-gerrit@google.com Merge "Extract common code from our various build generators into a library" 2019-05-22 lalitm@google.com Merge "trace_processor: fix overflow of window size" 2019-05-22 skyostil@google.com Unify include statements for protobuf 2019-05-22 ilkos@google.com Merge "Filter out failed launches" 2019-05-22 primiano@google.com Fix autoroller, remove extra ../ in GN file 2019-05-22 skyostil@google.com Merge "Add retired instruction count field for legacy events" 2019-05-22 lalitm@google.com Merge "traceconv: add comment about catapult" 2019-05-22 lalitm@google.com trace_processor: fix debug dcheck 2019-05-22 lalitm@google.com Merge "trace_processor: fix typo" 2019-05-21 primiano@google.com Perfetto Client API (3): Tracing muxer implementation 2019-05-21 primiano@google.com Perfetto Client API (2): public interfaces and backend implementation 2019-05-21 primiano@google.com Perfetto Client API (1): initial refactorings Created with: gclient setdep -r src/third_party/perfetto@5ca8b4622a59 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:129747127,chromium:b/133324726,chromium:133268735,chromium:132678367,chromium:132678367,chromium:132678367 TBR=perfetto-bugs@google.com Change-Id: I411cb3737e9f4b32f7f933ca9bbb05a4c29bc5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663769}
-
John Abd-El-Malek authored
Disable some unit tests in NavigationURLLoaderTest and ResourceDispatcherHostTest and fix one test in the former when network service is enabled. Fix NavigationURLLoaderTest.RequestFailedCertErrorFatal to work with network service. The other tests that are disabled in NavigationURLLoaderTest depend on net:: test objects that are an implementation detail of the old path, to ensure that the request is cancelled correctly when the navigation or context goes away. It's not clear how much value these tests actually provide, and this is a bit hard to test in a unit test with network service, so I'm disabling them for now. ResourceDispatcherHostTest.ForbiddenDownload is disabled because it's a regression test for a ResourceDispatcherHost bug. Bug: 966633 Change-Id: If979805546875ca616a1c54ff559d9f40498038a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631768 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663768}
-
Martijn Croonen authored
This updates from revision 0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21) to revision c3a44bfc61dcf0feb1cc0e37a95fb281799d43c6 (2019-05-24) Bug: 951494 Change-Id: Iaa722617a8c48a4b22daa1d872508871608debc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615741 Auto-Submit: Martijn Croonen <martijnc@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663767}
-
Gauthier Ambard authored
The accessibility of the TableView isn't great. This CL improves it by increase the contrast of the sublabels. It also use a shared constant for the font of the sub labels in case we need to modify it in the future. Bug: 960264 Change-Id: I962f66082c459ccf9999848e510670d9e12dca11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627364Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#663766}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b6aded661de..46fe0e4be950 git log 1b6aded661de..46fe0e4be950 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 jonahr@google.com Cleanup Features headers. 2019-05-28 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D array textures Created with: gclient setdep -r src/third_party/angle@46fe0e4be950 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: Ie2e264678d91f7f859c1bffb9d4c5f2225892523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663765}
-
Avi Drissman authored
This allows it to show dialogs and work as required. BUG=948882 TEST=as in bug Change-Id: Ifc339187093e571f8f6062cfa4a9d3130a357e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631873 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663764}
-
Ivan Sandrk authored
There's a P0 escape from the locked mode currently in M75 which is just days away from stable. This is a very quick and simple fix that addresses the problem for now and it will be backmerged immediately to M75. Bug: 957950 Change-Id: I2c39c04d4bc0219c000977928b538c60619a6bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632251 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#663763}
-
Devlin Cronin authored
Opaque origins (such as about:blank and data: URLs) inherit the security and privileges of their creator origins, which are tracked in precursor tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine the precursor origin of an opaque URL today by traversing the creation chain and looking for the first non-about:blank opener or parent. However, this is not always strictly correct for all opaque origins; for instance, the precursor tuple of a data: frame may not be that of its immediate parent in the case of nested iframes. Update ScriptContext::GetEffectiveDocumentURL() to use Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this. Note that we still have to do the opener/parent traversal case because content script matching needs to have the full URL (including path), and not just the scheme, host, and port tuple. To balance these, we simply return the document URL (which is potentially opaque) in the case of a mismatch between opener/parent traversal and the precursor tuple. This should be an exceptionally rare case in practice. Updating this method to use the precursor tuple is a prerequisite for adding support for data:-URL content script injection. ----- Reland Notes ----- The original patch didn't account for a parent being null in the iteration of the frame tree, which could cause issues in edge cases (that are not terribly uncommon). The reland adds a graceful return in those cases, and adds a regression test. Bug: 55084 Change-Id: Ib46d67dddc3fe0b769e30abe383534e5c490c912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621196 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663762}
-
Saman Sami authored
This CL enables all viz_unittests that pass with Vulkan. Bug: 961373 Change-Id: Ie0d0c590d58a930bf5e005dc233240203d76e773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625015 Commit-Queue: Saman Sami <samans@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663761}
-
Koji Ishii authored
This patch stops propagation of setting NeedsCollectInlines at atomic inlines. Usually atomic inlines that have children are LayoutBlockFlow, but LayoutSVGRoot is one example that are not LayoutBlockFlow. This patch also clarifies the distinction when a parent of object needs to collect from when the object itself needs to collect. Bug: 966699 Change-Id: I260824f3e8e211f842aa7990c6d504a3c72549b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631016 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663760}
-
Koji Ishii authored
This patch adds CHECKs to `LazyLineBreakIterator:: NextBreakablePosition` before reading from a raw pointer. This is a speculative fix. It is likely that there's a case where `NGLineBreaker` over runs `NGInlineItem::EndOffset()`, but we have not be able to find a locally reproducing case yet. The case in issue 967167 has a broken surrogate pair at the end, but it's still not enough to reproduce. Bug: 967167, 967439 Change-Id: I64973e8e7e41b5089147b0383178af6217b4db47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630141 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663759}
-
Lan Wei authored
In WebDriver spec, we assume that the actions with the same id and type are the same, we should give the pointer actions of different source types a different id. Bug: 606367 Change-Id: I1d8f6a08ee8d98c4afd281f077e23067ad915ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626960Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#663758}
-
Yi Su authored
This CL moves //ios/web/web_state/error_translation_util* into //ios/web/web_view:util. Bug: 942244,956511 Change-Id: Iee866e5f371e203720dfa3e128f848272ef78f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630160Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#663757}
-
Eric Stevenson authored
Change-Id: I54c4f60513076030258b1b6b3a6a6e681f353578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632300 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663756}
-
Daniel Libby authored
This is a reland of 7e329171 Original change's description: > Log SCROLLBAR LatencyInfo's for main thread injected scrolls > > Note: based on crrev.com/1595296 > > When scroll gestures are injected during the handling of an input on > the main thread, we want to dispatch the scroll gesture with the > LatencyInfo information from the original input event, but with a > different type. This allows the end to end latency metrics to be > computed correctly and classified separately as a specific type of > scroll (not just, e.g. as mouse latency). > > Bug: 954007 > Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659630} TBR=tdresser@chromium.org, bokan@chromium.org Bug: 954007 Change-Id: I70f2c0e445c872bf357469f64f1d8104c1da62f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628955 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663755}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf49b6472020..176b214f91bc git log cf49b6472020..176b214f91bc --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@176b214f91bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: Ia53e61f4d36b75bd62e2e8a0fcef38ea0a7b34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663754}
-
Ivan Sandrk authored
Extending the histogram for another 6 months as the feature this is tracking is in public beta currently, and not fully launched yet. Bug: 967501 Change-Id: I6e66d4c9feabfa1a8d2883d33f17fedb2dbff6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631381Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#663753}
-
Sky Malice authored
Touchless doesn't support snackbars so use toasts instead. Bug: 959333 Change-Id: I14fcea19a53e6d3d7e7bfee6542ff71775dbed03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626884Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#663752}
-
Nico Weber authored
After clang r360674, each .obj file embeds the path to the profile library as a dependent lib. No intended behavior change. Change-Id: Ie892fccdb8aaefc2545db56fb3274dc6f0992a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630986Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663751}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/71c012b1b956..51e9e5659a55 git log 71c012b1b956..51e9e5659a55 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 capn@google.com Implement Y′CbCr conversion 2019-05-28 capn@google.com Fix single-plane views of YCbCr formats 2019-05-28 capn@google.com Refactor writing texture level descriptor info 2019-05-28 capn@google.com Take the plane/aspect into account when copying/blitting 2019-05-28 capn@google.com Implement VkSamplerYcbcrConversion object 2019-05-28 capn@google.com Claim support for YCbCr 3- and 2-plane 420 format 2019-05-28 capn@google.com Allow additional info to be passed to object's Create functions 2019-05-28 capn@google.com Add 8-bit YCbCr 420 format info 2019-05-28 capn@google.com Refactor obtaining format aspect info 2019-05-28 capn@google.com Implement OpImageGather 2019-05-28 capn@google.com Refactor texel names 2019-05-28 capn@google.com Fix taking the sampling instruction type into account Created with: gclient setdep -r src/third_party/swiftshader@51e9e5659a55 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/132437008,chromium:b/116336664,chromium:b/132437008,chromium:b/132437008,chromium:b/129523279,chromium:b/129523279,chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: I93e2f4c68994dfd5097f61ccfb3a85c0b7157f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663750}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b42d4c7a..68951d2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5f552b17b8bfb7b0df5fec77e4428c2c51e51322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663749}
-
Eric Stevenson authored
Also added a note about a known issue that can cause build failures. Bug: 967618 Change-Id: Iebf4df4a15453e525653ee2052f61e84c0e169f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632299 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663748}
-
Stepan Khapugin authored
When the DSE is Google, omnibox should use the bundled icon instead of the google favicon. Bug: 966389 Change-Id: I95d683a7bf1c3f460ec2d73ccd39d1b8fa305fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631697 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#663747}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c66b67119b9..15902f4c7d5d Created with: gclient setdep -r src-internal@15902f4c7d5d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I1094223b1dadbd3cb23e06b5c2a4a2ac4c6ed0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663746}
-
Tomasz Wiszkowski authored
Bug: 961158, 960421 Change-Id: I584060d95247b66e38fd6dfb765356ebf193664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603684 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663745}
-