GitLab

This change removes logic that would issue a request through
the data reduction proxy immediately after every network change.

BUG=411448

Review URL: https://codereview.chromium.org/548993002

Cr-Commit-Position: refs/heads/master@{#294223}

This change changes heap_dump to use ptrace rather than SIGSTOP to
freeze the target process. Recent kernels (Android L) forbid to attach
to /proc/PID/mem if the process is not ptrace-d.
This has also two advantageous side effects:
1. PTRACE_ATTACH is independent of the process state (if it was STOPped
   it will stay stopped after the detach).
2. If heap_dump crashes or is killed, the process is automatically
   detached by the kernel (so we can get rid of the SIGPIPE/INT logic).
Furthermore this CL makes the consistency checks optional (adding a -n
switch to disable them).

BUG=382489

Review URL: https://codereview.chromium.org/553403002

Cr-Commit-Position: refs/heads/master@{#294222}

BUG=

Review URL: https://codereview.chromium.org/558213003

Cr-Commit-Position: refs/heads/master@{#294221}

TEST=see crbug.com/412875

BUG=412749

Review URL: https://codereview.chromium.org/565433002

Cr-Commit-Position: refs/heads/master@{#294220}

R=estade@chromium.org
BUG=411771

Review URL: https://codereview.chromium.org/558723003

Cr-Commit-Position: refs/heads/master@{#294219}

Prior to this change UploadState objects would synchronously notify
AttachmentUploaderImpl that they were done and could be deleted.  This
meant they were still on the call stack when their destructor was
invoked.  While it worked, it was subtle and might lead to bugs in the
future.

BUG=

Review URL: https://codereview.chromium.org/556083002

Cr-Commit-Position: refs/heads/master@{#294218}

only occur when we haven't drawn anything and as a result the
color_ member needs to be initialized to transparent.

BUG=412377

Review URL: https://codereview.chromium.org/552633004

Cr-Commit-Position: refs/heads/master@{#294217}

cast.streaming API will be notified if there is a hardware
initialization error. This way extension can decide whether to restart
with a different codec or just fail.

Also fixed a small issue that Framer is printing too many messages.

BUG=402182

Review URL: https://codereview.chromium.org/555563003

Cr-Commit-Position: refs/heads/master@{#294216}

Now that CrOS has Noto Sans Sinhala. There's no need to block it any
more in the Accept-Language list.

BUG=240586
TEST=In accept-langauge selection UI, Sinhala is listed.

Review URL: https://codereview.chromium.org/552063002

Cr-Commit-Position: refs/heads/master@{#294215}

BUG=386441

Review URL: https://codereview.chromium.org/471243002

Cr-Commit-Position: refs/heads/master@{#294214}

This change removes some unnecessary includes in the trusted plugin and
replaces uses of nacl::string with std::string. This is intended to make it
easier to (eventually) include headers from Chromium, which currently conflict
with nacl_log.h.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/552533006

Cr-Commit-Position: refs/heads/master@{#294213}

SecureRandom is being removed from the name service on the NaCl side.

This test also checks for ManifestNameService, which we are in the
process of replacing with a Chrome-IPC-based implementation.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3864
BUG=394130
TEST=browser_tests

Review URL: https://codereview.chromium.org/563583002

Cr-Commit-Position: refs/heads/master@{#294212}

Extension now has to call udptransport->setOptions(":DSCP") to get dscp set.

This framework should also let us experiment with different wifi settings in windows and different pacing settings.

Review URL: https://codereview.chromium.org/551883004

Cr-Commit-Position: refs/heads/master@{#294211}

This change completes the plumbing to join cross-process iframes into a single composed accessibility tree on platforms that implement native accessibility APIs (Windows, Mac, Android).

Further work will be needed to update some accessibility API implementations to be multi-frame-aware.

BUG=368298

Committed: https://crrev.com/387942c041da17ea6337bc0a81e96619e67e4ac4
Cr-Commit-Position: refs/heads/master@{#294118}

Review URL: https://codereview.chromium.org/268543008

Cr-Commit-Position: refs/heads/master@{#294210}

Revert of cc: Add occlusion checker as a fixed view of occlusion tracker. (patchset #7 id:120001 of https://codereview.chromium.org/547723002/)

Reason for revert:
Broke linux GN build: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/11591

[496/2225 | 35.477] CXX obj/ui/views/controls/views.focusable_border.o
[497/2225 | 35.633] CXX obj/ui/views/controls/views.glow_hover_controller.o
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/cc/layers/cc_unittests.picture_layer_impl_unittest.o.d -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_FULL_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1 -DUSE_X11=1 -DUSE_XI2_MT=2 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DCR_CLANG_REVISION=214024 -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DGL_GLEXT_PROTOTYPES -DMEDIA_DISABLE_LIBVPX -DSK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS -DSK_IGNORE_PROPER_FRACTIONAL_SCALING -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_SUPPORT_LEGACY_IMAGECACHE_NAME -DSK_LEGACY_PICTURE_SIZE_API -DSK_LEGACY_PICTURE_DRAW_API -DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\" -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DUNIT_TEST -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -Igen/ui/gl -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../testing/gtest/include -I../../testing/gmock/include -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wextra -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unused-function -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -fno-ident -fdata-sections -ffunction-sections -O2 -g2 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c ../../cc/layers/picture_layer_impl_unittest.cc -o obj/cc/layers/cc_unittests.picture_layer_impl_unittest.o
../../cc/layers/picture_layer_impl_unittest.cc:2578:31:error: reference to type 'const cc::Occlusion' could not bind to an rvalue of type 'long'
  pending_layer_->UpdateTiles(NULL);
                              ^~~~
/mnt/data/b/build/slave/Linux_GN/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.5.0/include/stddef.h:96:18: note: expanded from macro 'NULL'
#    define NULL __null
                 ^~~~~~
../../cc/layers/picture_layer_impl.h:113:24: note: passing argument to parameter 'occlusion_in_content_space' here
      const Occlusion& occlusion_in_content_space) OVERRIDE;
                       ^
../../cc/layers/picture_layer_impl_unittest.cc:2608:31:error: reference to type 'const cc::Occlusion' could not bind to an rvalue of type 'long'
  pending_layer_->UpdateTiles(NULL);
                              ^~~~
/mnt/data/b/build/slave/Linux_GN/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.5.0/include/stddef.h:96:18: note: expanded from macro 'NULL'
#    define NULL __null
                 ^~~~~~
../../cc/layers/picture_layer_impl.h:113:24: note: passing argument to parameter 'occlusion_in_content_space' here
      const Occlusion& occlusion_in_content_space) OVERRIDE;
                       ^
2 errors generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> cc: Add occlusion checker as a fixed view of occlusion tracker.
>
> This patch adds an occlusion checker to get the state of
> occlusion tracker for permanent checks. That is, occlusion
> checker does not have to be queried during a layer walk.
>
> BUG=410932
> R=danakj
>
> Committed: https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b
> Cr-Commit-Position: refs/heads/master@{#294205}

TBR=danakj@chromium.org,vmpstr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410932

Review URL: https://codereview.chromium.org/551463005

Cr-Commit-Position: refs/heads/master@{#294209}

This registers an IRT interface in Chromium instead of using the one provided
by NaCl. This reuses the ManifestServiceChannel used for providing
irt_open_resource() in non-SFI mode.

In this change, the Chromium implementation of NACL_IRT_RESOURCE_OPEN_v0_1
takes precedence over the one supplied by NaCl (which is SRPC-based).

The SRPC-based codepath in service_runtime.cc needs to be kept because the
PNaCl translator doesn't have the IRT available yet. I've added a check to
enforce that's the only user of that codepath.

BUG=394130
TEST=Manually tested with a file token that didn't resolve with a local patch
that forced GetFilePath to fail in nacl_process_host.cc and confirmed
that URLLoader* still passed.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32
R=dmichael@chromium.org, mseaborn@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/418423002

Cr-Commit-Position: refs/heads/master@{#294208}

Temporary measure until both Pipeline is reworked to provide a time
estimate to the main thread and VideoRendererImpl's internal thread
is eliminated.

This is similar to the the locking currently present in
AudioRendererImpl.

BUG=412764

Review URL: https://codereview.chromium.org/562673003

Cr-Commit-Position: refs/heads/master@{#294207}

Review URL: https://codereview.chromium.org/545663002

Cr-Commit-Position: refs/heads/master@{#294206}

This patch adds an occlusion checker to get the state of
occlusion tracker for permanent checks. That is, occlusion
checker does not have to be queried during a layer walk.

BUG=410932
R=danakj

Review URL: https://codereview.chromium.org/547723002

Cr-Commit-Position: refs/heads/master@{#294205}

https://skia.googlesource.com/skia/+log/841010f4bd54663e41900359fd32640767e6c8cd..cc0e3110bde60201882a2c512a5cdd73c838f351

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/561843002

Cr-Commit-Position: refs/heads/master@{#294204}

Previously we invalidated only new recorded pixels on tiles that
resized but ignored new recording tiles. The problem with this is that
if the old layer size is on the boundary of recording tiles, then we
invalidate nothing. But there may be raster tiles that would like to
use the new recording tiles, and currently have uninitialized content
in them, but they don't get invalidated to hear about it.

R=vmpstr
BUG=411774

Review URL: https://codereview.chromium.org/556973003

Cr-Commit-Position: refs/heads/master@{#294203}

Remove all the embedded resources from blink and migrate to using grd generated
pak files

BUG=312586

R=haraken@chromium.org, jochen@chromium.org
NOTRY=true

Part 1: https://codereview.chromium.org/558933002
Part 3: https://codereview.chromium.org/560763002

Review URL: https://codereview.chromium.org/561653002

Cr-Commit-Position: refs/heads/master@{#294202}

This is a new requirement in L during functor teardown.

BUG=412617

Review URL: https://codereview.chromium.org/561553002

Cr-Commit-Position: refs/heads/master@{#294201}

BUG=358271

Review URL: https://codereview.chromium.org/558813004

Cr-Commit-Position: refs/heads/master@{#294200}

BUG=

Review URL: https://codereview.chromium.org/557353002

Cr-Commit-Position: refs/heads/master@{#294199}

bbffd55 Add a TexSubImage benchmark.
9e16d40 Fix Win32Window::resize breaking angle_tests.
dd8488d Get stencil buffer clear parameters format directly.
82cceb2 Only use direct buffers for static data in D3D11.
c9610c5 Starting refactor of ProgramBinary

BUG=365078

Review URL: https://codereview.chromium.org/557993003

Cr-Commit-Position: refs/heads/master@{#294198}

This is no longer used after the removal of FileDownloader from the trusted
plugin.

BUG=

Review URL: https://codereview.chromium.org/560073002

Cr-Commit-Position: refs/heads/master@{#294197}

This is necessary as we don't always load 1x resources. In particular
when I run views_example_exe with --force-device-scale-factor=2 then
1x isn't loaded.

BUG=none
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/564473002

Cr-Commit-Position: refs/heads/master@{#294196}

Add TaskQueue, a class that provides retry and backoff semantics for
tasks.  Used by AttachmentServiceImpl.

AttachmentUploaderImpl and AttachmentDownloaderImpl now differentiate
between transient and non-transient errors.  Almost all errors are
assumed to be transient.  "403 Forbidden" is the exception and is
returned by the sync server if attachment are disabled for the user.

Transient errors encountered during attachment upload will be retried
with exponential backoff (using TaskQueue and BackoffEntry).  The idea
is to consolidate retry logic at the AttachmentServiceImpl level.

In a future CL, changes in network connectivity will affect retry and
backoff.

BUG=372622, 380437

Review URL: https://codereview.chromium.org/554743004

Cr-Commit-Position: refs/heads/master@{#294195}

Remove http://aws1.mdw.la/piatek/bypass-demo, which is not bypassed by the server now.

BUG=412497

Committed: https://crrev.com/478bfc70f088fdabd3e0e2da1d399a04d4610a92
Cr-Commit-Position: refs/heads/master@{#294027}

Review URL: https://codereview.chromium.org/553543004

Cr-Commit-Position: refs/heads/master@{#294194}

This is a set of bug / UI fixes for memory inspector, in preparetion
for next CLs which will introduce integration with libheap_profiler.
Changes in this CL:
- Introduce mmap de-offset heplers (will be used soon for intersecting
  native heap traces).
- Fix symbol lookup for shared_library Chrome builds.
- Add RSS column to mmaps table.
- Add server crash / unreachable detection.
- Update prebuilts (add also desktop ones for paul.whitton@)
- Make it possible to filter tests ran by run_tests.
- Minor cosmetic bugfixes.

BUG=340294

Review URL: https://codereview.chromium.org/559023002

Cr-Commit-Position: refs/heads/master@{#294193}

Considers unknown signin status as a valid status when browser is added (For mac, it's possible to have chrome running with no browser window open, which should be signin-status-unknown).

Collects more stats when getting signin status. (record it in histograms whenever any error is seen.)

BUG=412794

Review URL: https://codereview.chromium.org/554863002

Cr-Commit-Position: refs/heads/master@{#294192}

TouchActionTest.Pan will start failing upstream as soon as
L bots are added.

BUG=412145

Review URL: https://codereview.chromium.org/557953002

Cr-Commit-Position: refs/heads/master@{#294191}

BUG=391109
NOTRY=true

Review URL: https://codereview.chromium.org/552013008

Cr-Commit-Position: refs/heads/master@{#294190}

Review URL: https://codereview.chromium.org/547753004

Cr-Commit-Position: refs/heads/master@{#294189}

Fix the constructor of the layer raster tile iterator to never advance
a tiling raster tile iterator. This fixes the iterator not to skip the
first tile returned by a tiling raster tile iterator even if there are
no NOW tiles but only SOON and/or EVENTUALLY tiles.

Review URL: https://codereview.chromium.org/555183002

Cr-Commit-Position: refs/heads/master@{#294188}

It was introduced by https://codereview.chromium.org/10344009 for
keychain reauthorization, now that keychain reauthorization was
removed by https://codereview.chromium.org/183713003 we no longer
need most of it.

BUG=411926

Review URL: https://codereview.chromium.org/558233002

Cr-Commit-Position: refs/heads/master@{#294187}

This cl also includes some small changes to remove
chrome/extensions dependencies in these files, e.g.
it gets IsIncognitoEnabled() from ExtensionPrefs()
instead of util::IsIncognitoEnabled().

BUG=352293

Review URL: https://codereview.chromium.org/550403003

Cr-Commit-Position: refs/heads/master@{#294186}

* Extracting DelayedTaskController from GCMDesktopDriver
* Renaming it to GCMDelayedTaskController
* Adding tests for GCMDelayedTaskController

BUG=374969
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/551163002

Cr-Commit-Position: refs/heads/master@{#294185}

BUG=371463

Review URL: https://codereview.chromium.org/555523003

Cr-Commit-Position: refs/heads/master@{#294184}