- 06 Mar, 2020 40 commits
-
-
Marijn Kruisselbrink authored
Instead have a separate nataive_file_system_dialogs.h file for these methods. Bug: none Change-Id: I3c752c604cd29d4f7703503673b9b8530a04cd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091724Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747898}
-
Karan Bhatia authored
Add rule limits for regex rules. Initially we are going with a limit of 1000 rules applied separately to the extension's static and dynamic ruleset. BUG=974391 Change-Id: Ifdeca957ebf5fb85310fff64d96e545c1deb9e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016201 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#747897}
-
Connie Wan authored
This is similar to crrev.com/c/2040060. I still don't have a repro for this crash, but the stack trace indicates that it's receiving an index that is out of bounds. Similar to in crrev.com/c/2040060, the change at line 2727 is to match previous behavior from before the crash: https://chromium-review.googlesource.com/c/chromium/src/+/1999088/10/chrome/browser/ui/views/tabs/tab_strip.cc#b1081 The addition at line 2742 is to catch any other possible -1s, since I don't have a repro. Bug: 1049240 Change-Id: I86baec38039cfac7b4d96815ffbbe14f01efa555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091594Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#747896}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/c3316f30c075..a66f68433ddd $ git log c3316f30c..a66f68433 --date=short --no-merges --format='%ad %ae %s' 2020-03-06 fayang gfe-relnote: In QUIC, let GetMinAckFrameSize use actual ack_frame instead of passed in largest_observed_length. Protected by gfe2_reloadable_flag_quic_use_ack_frame_to_get_min_size. 2020-03-05 danzh gfe-relnote: move stop/start accepting new connection feature from GfeQuicDispatcher to QuicDispatcher. Protected by --gfe2_restart_flag_quic_should_accept_new_connection. 2020-03-05 dschinazi Add --quic_versions to QuicToyServer and improve version parsing Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8d3bf48892dcfb8e8ffce8c62f4d7f244bd7067f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091221 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#747895}
-
Eugene But authored
This CL adds user Actions for closing or tapping "Restore". These actions are helpful for Breadcrumbs feature that attaches steps to reproduce to crash reports. Bug: 1046231 Change-Id: I536c0de815a0bc0e4b14afe3c35ff06bc14474ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089860 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#747894}
-
Domenic Denicola authored
This plumbs the origin policy IDs from the net-side OriginPolicyContents through to the renderer, where they get exposed on Window. This does not yet tackle WorkerGlobalScope, but it does add idlharness tests for it, which fail for now. Bug: 1057123 Change-Id: Ie611f03bab99ccdaa6221733d9305cf2323a129e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089994 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#747893}
-
Becca Hughes authored
Media History needs to support incognito for Media Feeds. For an OTR profile we allow reads from the original profile but no writes. BUG=1051239 Change-Id: I03d152d6701ef034d4ce05d9970c64c720b22011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091592Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#747892}
-
Mei Liang authored
Change-Id: Ia1da9ea77ada858a8d8e8b502e993257a2e2fda8 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092124Reviewed-by:
David Maunder <davidjm@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747891}
-
Charlene Yan authored
Currently, the tab_strip_index is not set allowing the tab_strip_model_order_controller.cc to decide on where to insert the tab (which is currently based on the last active index). This can insert a tab in the middle of a tab group breaking group continuity. Bug: 1049195 Change-Id: I9a7f7cacdcb01845cd736818bc07d0efc9a594e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080079Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747890}
-
Evan Stade authored
This relands 5c7bccda but with a fix for the transitive Context reference in FragmentWindowAndroid. Bug: 1057127,1056468 Change-Id: Iad9f0f3ba68319de160a9645f66c2972811104f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081254Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#747889}
-
Greg Thompson authored
- Don't alias namespaces in header files as per https://google.github.io/styleguide/cppguide.html#Namespaces - A few iwyu cleanups. - Use AddAllocated to pass an element's memory to a repeated proto field. - Move a pair of funcs in BrowserReportGenerator into an unnamed namespace. - Avoid copies when iterating over plugins in BrowserReportGenerator::OnPluginsReady. BUG=none Change-Id: Ib47925de22d6a0872f40e068a246183888736046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091493 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747888}
-
Vladimir Levin authored
When we are activated by viewport (auto case), we need to ensure that we clear activation if we're switching to a non-activatable state (hidden). R=chrishtr@chromium.org Fixed: 1059340 Change-Id: I0e9ef5a9f22c1cf479536d378e37fe60f70d47aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090035 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747887}
-
Daniel Rubery authored
This CL adds the digest field to the metadata uploaded when deep scanning a file. This allows for a very early return before any processing of file contents has occurred at all, in cases where the file is not unique. Fixed: 1056929 Change-Id: I75e703a516cbb06b4f1aa480fd46c66ac20e37c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090607 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#747886}
-
Xinghui Lu authored
Add tests for the StartLookup method. The original CL was reverted https://crrev.com/c/2089440. The error is "Trying to register a previously registered pref" Remove the double registered pref in this CL and reland. Bug: 1050859 Change-Id: Ia5f88145f6c7fdbe98b7c1adf8e020602f341437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091593Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747885}
-
sczs authored
This reverts commit cf95a282. TBR = gambard@chromium.org Bug: 1038034, 1056613 Change-Id: Ib3cf8b9eb14d67a1a48dd757577604e82c7ea4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090804Reviewed-by:
-
Collin Baker authored
TBR=mcnee@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059322 Change-Id: I94b1216fdd9baf444d58a534a0a2bdf95579af3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092179Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#747883}
-
Greg Thompson authored
These tests use GoogleTest assertions without using GoogleTest's testing framework. Since UnitTest::Run() and friends (via RUN_ALL_TESTS) aren't used to run the tests, Google Test's stack trace getter's UponLeavingGTest method isn't called prior to running the actual test code. Upon assertion failure, there is no basis on which to trim the failure's stack trace. This CL adds a single call to UponLeavingGTest in LLVMFuzzerTestOneInput to provide such a basis. Better alternatives are to either run the tests via RUN_ALL_TESTS (after calling testing::InitGoogleTest) or not use GoogleTest assertions out of context. BUG=1039559 Change-Id: I3aa5fa5a36361450548403babddb337af41d25d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089845Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747882}
-
John Smith authored
NativeThemeDarkAura creates some complexity in other parts of the code where we need to be aware of high/increased contrast colors and changes. Removing it and replacing it with a version of the platform native theme would allow us to remove all of the logic where we call GetInstanceForNativeUi without losing any of the benefits that we get from it. This streamlines the code as we move towards the Color Pipeline. This adds an additional instance to the NativeThemes, GetInstanceForDarkUI, which is a version of the platform native theme that would be forced to use only dark mode. It also avoids setting up any links to the webinstances in order to not pollute their state. The IsForcedDarkMode behavior was not used or changed as that flag is meant to override any other behavior. We would still want to be able to apply high contrast where appropriate in incognito mode. Additionally, this fixes an issue where the IncreasedContrastThemeSupplier was not being removed correctly on native theme changes. See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/2068882 for the additional context for this change. Bug: 1003612, 953978 Change-Id: Ifaff1e755b69c8510a6e9f300443bb6bc8f39a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079840 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#747881}
-
Mason Freed authored
See launch bug: crbug.com/1042127 Bug: 1042127 Change-Id: Icd5d4977f0700ed40c1e3f2fbfaed39b5ee866fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089708 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch ensures that we don't recurse into paint layers that have display locked subtrees. We need to do this since the subtrees don't paint and might not have up-to-date layout information, which is needed to calculate their rects. R=chrishtr@chromium.org Fixed: 1059330 Change-Id: I832dfed1a47fba090c6e3ddd92de1846a47c3f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091599Reviewed-by:
-
Bence Béky authored
Change-Id: Ifdc5c616db4960a92a2df27a93700d894c263f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036405 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747878}
-
Oksana Zhuravlova authored
This change modifies BrowserInterfaceBrokerImpl::GetInterface() to trigger a bad message error on its host's receiver. Browser test added to verify the behaviour. Empty binders added for interfaces requested by blink but not bound by content (will mostly be called in tests). Bug: 1047680 Change-Id: I242cb11fff56666b6b6bd29e49c2180954aa1227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062696Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747877}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I28410d27a23d4491b13070f7377018249cc58a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087872 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747876}
-
Eric Orth authored
Take the Windows parental controls logic in IncognitoModePrefs and generalize it for use by other code in chrome/browser. Move it to its own file in chrome/browser/win, and allow checking some additional properties besides just logging_required. Additional minor changes to the moved logic: *Remove expired histograms. *Convert banned ComPtr::GetAddressOf() to operator&. Bug: 1037961 Change-Id: I31a247a0f571177507ea561002dea6c67bd749b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090032 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#747875}
-
Hailey Wang authored
Properties of PageNode that are tabs. This class will be used for background page loading policy. Bug: 1059341 Change-Id: Ic25aa92d06f6690a91d8e2de310478427ca97964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085633 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#747874}
-
Collin Baker authored
This reverts commit 57d362b5. Reason for revert: test failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests?limit=100, several of which seem related to OOBE Original change's description: > Turn on Polymer v2 on OOBE by default > > Bug: 955194 > Change-Id: I6581822689118b554107689e3cbca29b16d240df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080427 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745923} TBR=sky@chromium.org,antrim@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 955194 Change-Id: I46cd070a5162d18ce8ff41cf892ccebfe11340b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090801Reviewed-by:
-
Leonid Baraz authored
Refactor ActivityStorage and its derivatives to use IntervalMap for handling activity periods. Modify unittest to no longer expect activity resubmitted after the successful submit. Bug: b/144279234 Change-Id: Ia929371ef06dd7ff185d7ad9e27075b6c2825607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080821 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747872}
-
Steve Kobes authored
When the layout_shift.debug trace category is enabled, the LayoutShift trace event includes an impacted_nodes property containing the node ID and the old and new visual rects for up to 5 shifted elements, selected on the basis of their contribution to the impact region. Bug: 1046212 Change-Id: I5d1833fbf831f0894b7036b73fa3c242b695ed64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042674Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#747871}
-
Avi Drissman authored
Chromium already drops fullscreen when a dialog is first displayed. Extend that behavior so that a WebContents may not enter fullscreen for the duration of a dialog's display. This is part 1: Extend the fullscreen IPC so that the browser can decline a renderer's request to enter fullscreen. Bug: 1042210, 1020026, 1037730 Change-Id: Iafba087b22c51bf3c8fb6f9a4ce02921d51f0044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041871Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747870}
-
Alex Cooper authored
Update scoping comment to reflect the types of reviews/changes I've been making. Change-Id: Ida49c4e23401e6f37b1215181b263d6992e7418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091723 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#747869}
-
Connie Wan authored
Bug: 1043316 Change-Id: I3793008f9ad26e36e1d73ca9d299e905cf31821e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036889 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
ckitagawa authored
Audit uses of base::Unretained for Paint Preview related code. This removes possibly unsafe cases by passing IDs or weak pointers instead. Bug: 1059347 Change-Id: I1ba1d10e9b39e14cbdcd4c2acacba6feb91607ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091936 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747867}
-
Sasha McIntosh authored
Separate large if-block into a single statement for easier readability. No change in functionality is expected. Change-Id: Ieb7476e51d245cc2a0b97cdd0c158e3d0272a823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079161 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#747866}
-
Sorin Jianu authored
It's been failing because of breaking threading preconditions when creating the configurator. Bug: 1059138 Change-Id: I021c8bbf000d1c7372d3cbf9b821e57ea188a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091941Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747865}
-
ckitagawa authored
This CL introduces a TabService which provides an interface by which to capture Paint Previews and hooks to call on tab closure and startup. It is largely a wrapper around PaintPreviewBaseService, but handles file management for per-tab storage. Follow-up work is - Add a factory for this service. - Hook this service up to observers for the events it handles. Bug: 1058093 Change-Id: Ic1d7e880052090b5150ee5e63e21def374a20f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087994 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747864}
-
Sergio Collazos authored
This reverts commit 22339214. Reason for revert: This is still flaky. Original change's description: > Re-Enable testEditTextOnSingleURL on EG2 > > At the time there were various failures on iOS12. I can't repro locally now > I'll re-enable and monitor since I'm sheriffing. > > Bug: 1049972 > Change-Id: I0345fd704dcef24285d461ca07244baafb06c163 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090608 > Auto-Submit: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747487} TBR=kkhorimoto@chromium.org,sczs@chromium.org Change-Id: I49c6d7b605c7cbe01f0a31a84e084168d8d1dcba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091945Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e3f3e9a80d5f..7d20b4450182 git log e3f3e9a80d5f..7d20b4450182 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 natlee@microsoft.com Respect external clear status for Textures 2020-03-06 cwallez@chromium.org Roll third_party/swiftshader/ bdfcfe9cf..51b2800bb (23 commits) Created with: gclient setdep -r src/third_party/dawn@7d20b4450182 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080 Tbr: cwallez@google.com Change-Id: Ia6babb2cac3e785db8a20bdc4cbaad96f87c3209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091681Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747862}
-
Mark Schillaci authored
This CL expands on our work of improving the performance of accessibility features on Android. Here we create a SparseArray<AccessibilityNodeInfo> to store a mapping of view ids to their corresponding AccessibilityNodeInfo objects. When the system asks us to create a new object for that view, we leverage the object stored in our array (cache) rather than constructing one from scratch. There are helper methods so the native code can drive clearing the cache at appropriate times. We are clearing the cache on a given node during OnDataChanged or during OnNodeWillBeDeleted. Change-Id: Iaf817886b8d7038d268d4b459d135c46f60cbfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080857 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747861}
-
Mustafa Emre Acer authored
A previous fix introduced a top domain list to prevent phishing attempts using IDN. That fix compares a domain against a top domain, removes a label, and checks again until only a single label is left. This is problematic because it assumes subdomains of top domains cannot be IDN. As a result, subdomains of top domains are not decoded as unicode. This CL fixes this problem by adding an extra test to check if the hostname is a top domain itself or a subdomain of a top domain. If true, it's not treated as a lookalike and decoded as unicode. Bug: 769547 Change-Id: Id3b0589128bce974f6789c4151738ad74ca0ba6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1320813Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747860}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d14525eb59b9..04f7bfc4192f git log d14525eb59b9..04f7bfc4192f --date=short --first-parent --format='%ad %ae %s' 2020-03-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4dc8a310..599bebd3 (747587:747722) 2020-03-06 hbos@webrtc.org [Overuse] Make EffectiveDegradationPreference() private. 2020-03-06 jakobi@webrtc.org Add minimum overhead to configured priorty bitrate instead of maximum. 2020-03-06 minyue@webrtc.org Feed the clock skew to AbsoluteCaptureTimeReceiver. 2020-03-06 srte@webrtc.org Cleanup: Improving readability in AimdRateControl 2020-03-06 minyue@chromium.org Refactor TimestampAligner for more general use. Created with: gclient setdep -r src/third_party/webrtc@04f7bfc4192f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054403 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id1fc6365013f6006d676d9558494a6839e189a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091679Reviewed-by:
-
