GitLab

Remove gray background color for non-focused selected list items on chrome://settings/autofillEditAddress page.

BUG=444770

Review URL: https://codereview.chromium.org/840503002

Cr-Commit-Position: refs/heads/master@{#312927}

When DelegatedFrameHost was split off from RenderWidgetHostViewAura,
I had DelegatedFrameHost access the ui::Compositor via a call into the
client. This is harder to reason about than it should be, and leaves open
the possibility of keeping the DelegatedFrameHost as an observer of a
dead ui::Compositor.

Explicitly detach the DelegatedFrameHost from the ui::Compositor
when the ui::Compositor is being destroyed. Add a check to the
observer list, to ensure that it is empty at destruction.

BUG=(paying down technical debt)

Review URL: https://codereview.chromium.org/859423002

Cr-Commit-Position: refs/heads/master@{#312926}

This patch changes the way eviction queue is built to be more like the
raster queue. That is, instead of taking a pointer to the queue to be
built, the function returns a scoped_ptr to the queue that it built.

R=reveman, danakj

Review URL: https://codereview.chromium.org/862263004

Cr-Commit-Position: refs/heads/master@{#312925}

This is never null anymore, no need to check for null-ness.

R=vmpstr

Review URL: https://codereview.chromium.org/865973007

Cr-Commit-Position: refs/heads/master@{#312924}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/868153002

Cr-Commit-Position: refs/heads/master@{#312923}

For future CL: queueing messages, sending messages from Java to JS through message channel, transferring ports in message channels, closing channels.

BUG=393291

Review URL: https://codereview.chromium.org/831523004

Cr-Commit-Position: refs/heads/master@{#312922}

The idea here is that for reasons not fully understood at the moment, the
files in this CL failed the checkperms script, so 808773005 can't land.

This CL attempt to land the offending files, with two goals in mind. First,
unblock 80877300. Second, provide a clear repro for the chrome-infra team to
look at, in case something fails.

There is something going on uploading binary patches and permissions using
git cl upload.

BUG=450337
R=blundell@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/866143002

Cr-Commit-Position: refs/heads/master@{#312921}

BUG=444242

Review URL: https://codereview.chromium.org/813873005

Cr-Commit-Position: refs/heads/master@{#312920}

This removes another source of raw process handles.

BUG=417532

Review URL: https://codereview.chromium.org/860453002

Cr-Commit-Position: refs/heads/master@{#312919}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f803da1..1c40292

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/867123004

Cr-Commit-Position: refs/heads/master@{#312918}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f492958..5b18308

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/872853002

Cr-Commit-Position: refs/heads/master@{#312917}

This CL adds a column in the bookmarks images database.
It contains the dominant color extracted from the image.
Since this computation can be lengthy, it is done in the background, when the
image is stored in the database.
For old databases, a migration path is provided and the dominant color is
computed and stored upon querying the image for the first time.

BUG=448443

Review URL: https://codereview.chromium.org/875463003

Cr-Commit-Position: refs/heads/master@{#312916}

Also renamed a bunch of the public methods for clarity.

The old SyncStatusHelper class will be removed once downstream is
updated.

Review URL: https://codereview.chromium.org/845543005

Cr-Commit-Position: refs/heads/master@{#312915}

* Keep lines within 80 chars, taking care around backslashes.
* Surround key names with '"'.
* Put a ',' between phones and tablets when concatenating.

Review URL: https://codereview.chromium.org/749353003

Cr-Commit-Position: refs/heads/master@{#312914}

<webview>, <appview> and <extensionoptions> can now navigate on creation.

This means that an initial navigation of these elements can begin even if the container is set to display:none. This sets the underpinnings for teleporting content across containers.

TODO: contentWindow should become available prior to attachment.

BUG=434226
TBR=lazyboy@chromium.org for guest_view OWNER (lazyboy@ is OOO)

Review URL: https://codereview.chromium.org/845363004

Cr-Commit-Position: refs/heads/master@{#312913}

2027: win: 'EnableEnhancedInstructionSet': '5' now enables /arch:AVX2.

BUG=451290
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/873793002

Cr-Commit-Position: refs/heads/master@{#312912}

BUG=442526

Review URL: https://codereview.chromium.org/868163002

Cr-Commit-Position: refs/heads/master@{#312911}

BUG=450790

Review URL: https://codereview.chromium.org/867973002

Cr-Commit-Position: refs/heads/master@{#312910}

Taking over some TODOs for noelallen and adding myself
to OWNERS files in a few places.

BUG=None
TEST=None
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/875543002

Cr-Commit-Position: refs/heads/master@{#312909}

CaptivePortal and SafeBrowsingBlockingPage tests wait for the interstitial to get ready in different ways. This CL unifies them.

BUG=448486

Review URL: https://codereview.chromium.org/829263004

Cr-Commit-Position: refs/heads/master@{#312908}

https://bit.ly/AutoBlobToDisk

R=michaeln, piman
BUG=375297

Committed: https://crrev.com/4e45f41babddb10985c8c0afb9b0b6b9e8356094
Cr-Commit-Position: refs/heads/master@{#312770}

Review URL: https://codereview.chromium.org/821913004

Cr-Commit-Position: refs/heads/master@{#312907}

There are issue with the Guest Profile's cookies not being cleared as they should be when Guest Mode is closed. To ensure the Guest Profile isn't being used when there are no Guest browsers open, move the User Manager onto a new profile.

This is a modern version of this older CL: https://codereview.chromium.org/239543012/

BUG=445036

Review URL: https://codereview.chromium.org/847733005

Cr-Commit-Position: refs/heads/master@{#312906}

We set this variable in a few places but never read it.

R=vmpstr

Review URL: https://codereview.chromium.org/872863002

Cr-Commit-Position: refs/heads/master@{#312905}

Changed the code not to load server config if there is no alternative
protocol entry for QUIC. During our experiments, we found that
disable_loading_server_info_for_new_servers being set to true has
reduced the latency until crypto handshake completion.

This is a revert of https://codereview.chromium.org/811073004/

We check for alternative protocols only if there is a http_server_properties_ object.

R=rch@chromium.org

Committed: https://crrev.com/6a454624b8f2827af3ec154bb96e61e7fdcf9e3a
Cr-Commit-Position: refs/heads/master@{#312741}

Review URL: https://codereview.chromium.org/858323002

Cr-Commit-Position: refs/heads/master@{#312904}

I recently introduced a change which caused SQLitePersistentCookieStore to load
the cookies for one eTLD every 200ms, instead of every 0ms. That change
appeared to cause a hang during shutdown.

This CL changes the delay from 200ms back to 0ms while I investigate the hang.

BUG=436152, 448910

Review URL: https://codereview.chromium.org/844533005

Cr-Commit-Position: refs/heads/master@{#312903}

Once we support multiple DRM devices we'll want to share the helper
thread between the different wrappers.

BUG=427959
NOTRY=true

Review URL: https://codereview.chromium.org/856423002

Cr-Commit-Position: refs/heads/master@{#312902}

Anything relying on the filter being added would not be initialized
otherwise.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/872473002

Cr-Commit-Position: refs/heads/master@{#312901}

Note: This doesn't occur under normal circumstances, but if a DBus crash
(or something else) causes an immediate shutdown, we sometimes crash in
NetworkPortalDetector::Get() which obscures the actual problem.

This also updates the portal detector logging to use device_event_log.h.

BUG=none

Review URL: https://codereview.chromium.org/865813005

Cr-Commit-Position: refs/heads/master@{#312900}

Do not discard symbols which aren't present in the uninstrumented build (for
example if they were inlined).  This should make the orderfile more robust
against minor changes in compiler decisions.

From local testing, I expect this to fix the out-of-order symbol error that is
keeping the bot red.

Review URL: https://codereview.chromium.org/871043002

Cr-Commit-Position: refs/heads/master@{#312899}

Once the problem in PPB_VideoDecode API implementation that causing
plugin crash is fixed PepperVideoRenderer3D can be enabled. This CL
enables it for Chrome 42 and above.

BUG=447403

Review URL: https://codereview.chromium.org/855553003

Cr-Commit-Position: refs/heads/master@{#312898}

BUG=451476
NOTRY=True

Review URL: https://codereview.chromium.org/861033004

Cr-Commit-Position: refs/heads/master@{#312897}

BUG=

Review URL: https://codereview.chromium.org/868123003

Cr-Commit-Position: refs/heads/master@{#312896}

This should be removed once the compile time error in ffmpeg is fixed.

BUG=450771,371125

Review URL: https://codereview.chromium.org/867333003

Cr-Commit-Position: refs/heads/master@{#312895}

- Makes Plugin Power Saver posters (using LoadablePluginPlaceholder) generate correct metrics.
- Makes the PluginInstanceThrottler report the NEVER unthrottle method correctly.

BUG=449251,403800

Review URL: https://codereview.chromium.org/863813002

Cr-Commit-Position: refs/heads/master@{#312894}

Adds a fake video encode accelerator (hardware encoder) implementation that can be used for testing (on devices without hardware encoder or missing implementation) and testing the efficiency of an existing hardware encoder.

BUG=440843

Review URL: https://codereview.chromium.org/760963003

Cr-Commit-Position: refs/heads/master@{#312893}

BUG=

Review URL: https://codereview.chromium.org/802523004

Cr-Commit-Position: refs/heads/master@{#312892}

the '*_eh_a' outputs doesn't seem to be generated anymore, because of this you get the following log if you compile the pnacl_support_extension target twice:

[master]E:\src\chrome\src>ninja -C out\Release pnacl_support_extension -d explain
ninja: Entering directory `out\Release'
ninja explain: output pnacl/pnacl_public_x86_32_libgcc_eh_a doesn't exist
ninja explain: pnacl/pnacl_public_pnacl_json is dirty
ninja explain: pnacl/pnacl_public_x86_32_crtbegin_o is dirty
ninja explain: pnacl/pnacl_public_x86_32_ld_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_32_libcrt_platform_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libgcc_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libgcc_eh_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_libpnacl_irt_shim_a is dirty
ninja explain: pnacl/pnacl_public_x86_32_pnacl_llc_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_64_crtbegin_o is dirty
ninja explain: pnacl/pnacl_public_x86_64_ld_nexe is dirty
ninja explain: pnacl/pnacl_public_x86_64_libcrt_platform_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libgcc_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libgcc_eh_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_libpnacl_irt_shim_a is dirty
ninja explain: pnacl/pnacl_public_x86_64_pnacl_llc_nexe is dirty
ninja explain: obj/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.actions_rules_copies.stamp is dirty
[2/2] STAMP obj\ppapi\native_client\src\untrusted\pnacl_support_extension\pnacl_support_extension.actions_rules_copies.stamp

BUG=439228

Review URL: https://codereview.chromium.org/873773002

Cr-Commit-Position: refs/heads/master@{#312891}

Now remoting_webapp_v2 doesn't use PNaCl. Also added new target
remoting_webapp_v2_pnacl that does use PNaCl.

BUG=451184

Review URL: https://codereview.chromium.org/865363002

Cr-Commit-Position: refs/heads/master@{#312890}

Revert of Roll Web Page Replay to pick-up HTTPS certificate fixes. (patchset #1 id:1 of https://codereview.chromium.org/855603002/)

Reason for revert:
This CL might cause the android perf bot redness
crbug.com/449889

Reverting it for now see if the perf bot recovers.

Original issue's description:
> Roll Web Page Replay to pick-up HTTPS certificate fixes.
>
> Includes fixes for:
>
> Generated certificates use different common name than original.
> https://github.com/chromium/web-page-replay/issues/37
>
> Replay uses wrong root CA during replay.
> https://github.com/chromium/web-page-replay/issues/38
>
> Android: Error installing cert from Mac host
> https://code.google.com/p/chromium/issues/detail?id=431686
>
> BUG=431686
>
> Committed: https://crrev.com/aa498cbeed50f119e76f08d2681b136325f191df
> Cr-Commit-Position: refs/heads/master@{#311829}

TBR=wuhu@google.com,tonyg@chromium.org,vmiura@chromium.org,sullivan@chromium.org,slamm@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=431686

Review URL: https://codereview.chromium.org/874483004

Cr-Commit-Position: refs/heads/master@{#312889}

Revert of Run task queue manager work in batches (patchset #9 id:160001 of https://codereview.chromium.org/845543004/)

Reason for revert:
Trying to see if this is the cause of MediaTest.Yuv* failures on Mac:

http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2373
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/3274

Original issue's description:
> Run task queue manager work in batches
>
> This patch lets the task queue manager run more than one posted task
> per invocation. This helps reduce the overhead of yielding to and from
> the main message loop and can speed up cases where tasks are posted
> very frequently. One example is indexeddb, where some operations such as
> index building can result in 2500 posted tasks/s (Nexus 7).
>
> This patch also adds accounting for the desired run time of the next
> pending delayed task. This information is used to break out of a work
> batch if a delayed task should be run instead. Doing this avoids adding
> extra delay to delayed tasks.
>
> A potential downside of this change is that it can penalize work that
> runs on the message loop without going through the task queue manager.
> Based on performance tests[1], almost all tasks on the renderer main
> thread are already getting executed by the task queue manager, so I
> believe this change shouldn't cause a regression.
>
> [1] https://docs.google.com/a/chromium.org/spreadsheets/d/1IJZpBabW1pr4fb2T8BlkleHcOvHYrjvmCx_dLesxfMA/edit#gid=1492760051
>
> BUG=444764
>
> Committed: https://crrev.com/d9684457b5349dfc1cc19e8a2d98a69ba00ed058
> Cr-Commit-Position: refs/heads/master@{#312839}

TBR=rmcilroy@chromium.org,alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444764

Review URL: https://codereview.chromium.org/867353002

Cr-Commit-Position: refs/heads/master@{#312888}