- 05 Sep, 2018 40 commits
-
-
Joel Einbinder authored
When a script has a function with multiple const declarations for the same variable, ex: function hey(){ const duplicate = 0; const duplicate = 1; } The script that contains this function will parse correctly, but when the function `hey` is run a scriptFailedParse event will be emitted. DevTools only ever expects to get one script parsing event per scriptId, and this causes flickering of the script in the Sources panel. This patch swallows subsequent script parsing events for a script. Bug: 864296 Change-Id: I55a2e865b665e8fe1283a3dd19e9f152d0982b97 Reviewed-on: https://chromium-review.googlesource.com/1140782 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#588901}
-
Kush Sinha authored
ChromeOSOAuth2TokenServiceDelegate should notify SigninErrorController about auth error updates. These updates will be provided for Device Account and Secondary Accounts, both. Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I1e3d218969350a3dc3b11755870b2e281045f2ef Reviewed-on: https://chromium-review.googlesource.com/1202802 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588900}
-
Sammie Quon authored
The backdrop now moves with the window when swiping up or down to use home launcher gestures. This also allows non resizable windows to be swiped up or down now. Test: manual Bug: 880605 Change-Id: I020f21fc04f95da55cd2c897841ade0b105d66ed Reviewed-on: https://chromium-review.googlesource.com/1205593 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch adds a notion of IsParentAlias to paint property tree nodes. In this patch, we make the root transform be an "alias for parent". Also, this adds some tests for various interactions with these nodes, as well as code in PaintChunksToCcLayer to ensure we don't emit unnecessary save/concat/restores for these nodes. We also need to do this for clips and effects, but this patch can land on its own. R=trchen@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibf1a0cd21754dc226f7c19716028eafad63339c9 Reviewed-on: https://chromium-review.googlesource.com/1200382 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588898}
-
James Wallace-Lee authored
Refactoring code from BrowserView and ViewAXPlatformNodeDelegate into a static helper. Change-Id: I247ca4c8a7da4eeb02dfd0cd7886ae82c2bc3280 Reviewed-on: https://chromium-review.googlesource.com/1195898Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#588897}
-
Eric Orth authored
Added injectable TickClock to MockHostResolver to fix some timing issues I ran into while debugging some of the new cache tests. Note: HostResolverSource still has an ANY value for now, despite recent conversations that it's not the clearest name. Still trying to decide on the best name for that value, so not renamed yet. Bug: 846423 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I22431d47f76d831bbf67d0f4010c1753093a3f32 Reviewed-on: https://chromium-review.googlesource.com/1195550Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#588896}
-
Lei Zhang authored
cr.isWin() does not exist. Also fix formatting for some TODO entries. Change-Id: Ib64b2eeac0166484e60bf93c5a60159def81afec Reviewed-on: https://chromium-review.googlesource.com/1204590Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588895}
-
Evan Stade authored
The client-side window frame/client layout code uses a per-window property (the pre-existing kTopViewInset) to layout the contents, rather than hardcoded values plus logic related to window state. This is necessary so that apps will be laid out appropriately in immersive mode when not fullscreened (i.e. maximized in tablet mode). Also, propagate some window properties across processes. Bug: 640365 Change-Id: I485920c242e1c98450d0868e078f534489525f7c Reviewed-on: https://chromium-review.googlesource.com/1195886Reviewed-by:
-
Misha Efimov authored
Bug: 744567 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I34b5f7c5446ab88a6a66acad8c77c99a8dcb984b Reviewed-on: https://chromium-review.googlesource.com/1191464Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#588893}
-
Karan Bhatia authored
This CL removes the UrlPattern constructor which takes a proto::UrlRule. It is not used anywhere. BUG=None Change-Id: I011a45cf35000d359aad5f5c59cf5f5bf9664bcd Reviewed-on: https://chromium-review.googlesource.com/1205494Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#588892}
-
Mihai Sardarescu authored
Unified Consent feature is no longer dependent on Desktop Identity Consistency being enabled. This means that the Unified Consent feature is no longer a per-profile feature. This CL removes the argument profile from IsUnifiedConsentFeatureEnabled and IsUnifiedConsentFeatureWithBumpEnabled and moves these functions in the unified consent component. Bug: 873064 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifc338dbcb48500bc17d52bf5bcf52a45ea46860d Reviewed-on: https://chromium-review.googlesource.com/1202702 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is a reland of 6493250f There were reports of crashes when opening devtools because of a DCHECK deep inside GetActiveUserProfile. This switches to using the system network context, as suggested by mmenke@. This also simplifies things quite a bit as we don't have to pass around a BrowserContext. Original change's description: > Reland "Convert tcp_device_provider.cc to mojo host resolver" > > This is a reland of ac880b3a > > Switched to using > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which > outlives TCPDeviceProvider. The original was reverted because of a > crash when TCPDeviceProvider tried to access a destroyed > BrowserContext, see http://crbug.com/879060. > > Original change's description: > > Convert tcp_device_provider.cc to mojo host resolver > > > > Bug: 874653 > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd > > Reviewed-on: https://chromium-review.googlesource.com/1185626 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586738} > > Bug: 874653 > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24 > Reviewed-on: https://chromium-review.googlesource.com/1197265 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587750} Bug: 874653 Change-Id: Ifc6eddc0d05bd65792165d5542fe98b09ff0fb05 Reviewed-on: https://chromium-review.googlesource.com/1199848Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588890}
-
Becky Zhou authored
Bug: 880185 Change-Id: Iab70cc35d97c809b8e28d59e22d45b8bc54f18df Reviewed-on: https://chromium-review.googlesource.com/1205373 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588889}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d636bf7f5a63..09307abef3dd Created with: gclient setdep -r src-internal@09307abef3dd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia3fcde501f3a5e47e207ae20202fb399ec5375ad Reviewed-on: https://chromium-review.googlesource.com/1207150Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588888}
-
Sergey Ulanov authored
This is a reland of e6df6345 Original change's description: > Cleanup lifetime handling in P2P sockets. > > Several fixes for P2P sockets: > 1. P2PSocketTcpBase no longer posts tasks with base::Unretained(). > 2. Previously P2P sockets were destroyed only in response to Mojo > interfaces errors. They were not destroyed on other error. Fixed > it now. > 3. Simplified TCP server socket protocol. Now the accepted socket is > passed directly in IncomingTcpConnection. > 4. Updated unittests to verify that P2P sockets are destroyed in > response to errors. > 5. Other minor cleanups, particularly moved packet dump logic to > SocketManager and removed some unittests that are not relevant > after migration to mojo. > > Bug: 877515, 877514 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc > Reviewed-on: https://chromium-review.googlesource.com/1189083 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588430} TBR=jam@chromium.org,wfh@chromium.org Bug: 877515, 877514,880218 Change-Id: I0cc79616b70f7900e6c551a7c91e404de2fb7dd3 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1206338 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588887}
-
Wez authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: If8e680c80def495222aee51056c919e961f0c098 Reviewed-on: https://chromium-review.googlesource.com/1206006 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588886}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/86b118ed994e..f056cc5a549e git log 86b118ed994e..f056cc5a549e --date=short --no-merges --format='%ad %ae %s' 2018-09-05 anthonyalridge@google.com Implements error bars for bar plotter. Created with: gclient setdep -r src/third_party/catapult@f056cc5a549e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Icdc22b70d6b92f04b242ba4f9b05705ea34058a2 Reviewed-on: https://chromium-review.googlesource.com/1207072Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588885}
-
Javier Ernesto Flores Robles authored
self.browserState was nil at the point of initialization. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id3fb457b493cecc1686144160a486fb6446fdea2 Reviewed-on: https://chromium-review.googlesource.com/1186334 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588884}
-
kereliuk authored
Change-Id: Ib619f3bdc7f3c6e6da3a0f16b2b3feddf9592478 Reviewed-on: https://chromium-review.googlesource.com/1207010Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@google.com> Cr-Commit-Position: refs/heads/master@{#588883}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a8d99e51faf0..1d289218f53f git log a8d99e51faf0..1d289218f53f --date=short --no-merges --format='%ad %ae %s' 2018-09-05 hjd@google.com perfetto-ui: Plumb notifyEof from UI to WASM Created with: gclient setdep -r src/third_party/perfetto@1d289218f53f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibb3e2a2619a1f0c3f09df4337e0f8f5846bfcd5c Reviewed-on: https://chromium-review.googlesource.com/1207030Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588882}
-
Eric Roman authored
Bug: 880608 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I065803782935f7e69310a791ecb3053d573fcc61 Reviewed-on: https://chromium-review.googlesource.com/1205534Reviewed-by:
-
Peng Huang authored
We would like to verify Skia DDL correctness for rastering work. So a new flag --enable-oop-rasterization-ddl is added. With this flag, the raster decoder will record raster work into a DDL first, and then play it back into a SkSurface. Right now, recording and playing back are on the GPU main thread. In future, the recording could be moved to raster worker threads. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iba462c6a2376b9ab6fc663c97b913e568a5a8bce Reviewed-on: https://chromium-review.googlesource.com/1169150Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b29409064e87..e10f3b7403d0 git log b29409064e87..e10f3b7403d0 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 yinwa@webrtc.org Reland "Remove steveanton from api/ watchlist" 2018-09-05 sakal@webrtc.org Update Android to use limited range YCbCr. 2018-09-05 ssilkin@webrtc.org Test setting of spatial index. 2018-09-05 danilchap@webrtc.org Replace WeakPtr with CancelablePeriodicTask in RtcpTransceiverImpl 2018-09-05 henrika@webrtc.org Relands Adds WebRTC.Audio.Record/PlayoutSampleRateOffsetInPercent UMA stats to native WebRTC Created with: gclient setdep -r src/third_party/webrtc@e10f3b7403d0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/113648245 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27e09caa0437a51fcf4b874c7de14cff6f62f53b Reviewed-on: https://chromium-review.googlesource.com/1206931Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588879}
-
Mike Klein authored
Some of these files were including SkColorSpaceXform.h where they really just wanted SkColorSpace.h. One file was including SkColorSpaceXformCanvas.h but not using it, and relying on a transitive include for SkColorSpaceXform.h from another header that wasn't using it at all. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I62774b88da06b98899aa9ed52633aa4acbb0073f Reviewed-on: https://chromium-review.googlesource.com/1203912Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588878}
-
Andres Calderon Jaramillo authored
This CL moves features::kVaapiJpegImageDecodeAcceleration so that it can be accessed easily by GpuServiceImpl. GpuServiceImpl will use it to decide whether it should instantiate an implementation of the image decode acceleration mojo interface when requested by a renderer. Bug: 868400 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I93aa630792adae723236c8403ff807a31469ea8c Reviewed-on: https://chromium-review.googlesource.com/1203430Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#588877}
-
Andrew Grieve authored
Can repro the failure via: cd out/Debug rm gen/arsc/apks/MonochromePublicTestAr.ap_ rm lib.java/third_party/android_system_sdk/android_system.jar ninja gen/arsc/apks/MonochromePublicTestAr.ap_ Change-Id: I6885219d272510ec024263a3567fb27acf68050f Reviewed-on: https://chromium-review.googlesource.com/1205500Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#588876}
-
Chris Lu authored
[ios] Subclass MDCAppBarViewController to prevent it from dismissing on Accessibility Z-gesture in Settings This is already managed well by SettingsNavigationController. Video: https://drive.google.com/open?id=1P3kKX_m8_xnaS2lF58BKvaRL5tTbsuyw Bug: 877162, 874471 Change-Id: Ieb95fe427cece1d1fdb8f223bb16c0f0bbf05ce3 Reviewed-on: https://chromium-review.googlesource.com/1197411 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#588875}
-
danakj authored
Split the condition on viewport-enabled between the gpu-raster decision and the setting-up-the-viewport state. Expand the comment about the gpu-raster decision. Remove an if condition for a possible null pointer that was already dereferenced above. R=bokan@chromium.org Change-Id: I93110b078cc372fde1b1e490101d879a392acdd1 Reviewed-on: https://chromium-review.googlesource.com/1205310Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#588874}
-
danakj authored
R=enne@chromium.org Bug: 854256 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieeae7911be96a95f961062262d24a454ec10da26 Reviewed-on: https://chromium-review.googlesource.com/1204925Reviewed-by:
-
Matthew Jones authored
This patch adds ActivityTabProvider to ChromeActivity. This class provides an easy mechanism for classes that care about the tab that is currently in the foreground (i.e. not in the tab switcher/toolbar swipe/animation layout). The observer provides either the activity's tab or null depending on the state of the browser. The null event can be ignored depending on the listener. The ActivityTabObserver interface only has a single method: onActivityTabChanged(Tab t) When an observer is attached to the provider, onActivityTabChanged is called on only that observer with the current tab (giving it access without requiring a handle to a larger object). Bug: 871279 Change-Id: Ice961224c6690dc79c38f5d6cb255fed4730c8ce Reviewed-on: https://chromium-review.googlesource.com/1165489 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 760811 Change-Id: If4f19ebfeb32cfdfca8aa94eac26c9c7afbf44fa Reviewed-on: https://chromium-review.googlesource.com/1204591 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0f0cb8ffc5e..74b1c01cdd1d git log d0f0cb8ffc5e..74b1c01cdd1d --date=short --no-merges --format='%ad %ae %s' 2018-09-05 egdaniel@google.com Fix freeing of vulkan feature structs is test context. Created with: gclient setdep -r src/third_party/skia@74b1c01cdd1d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I45590a5c0ca19f861c604407a42486ea8cafaafa Reviewed-on: https://chromium-review.googlesource.com/1206950Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588870}
-
Joe Mason authored
RegKeyPath in pup.mojom has the only registry handle passed from the chrome_cleaner target process to the broker process. This handle is always a root key (eg. HKCU or HKLM) so it can be represented directly using the PredefinedHandle enum. This simplifies the serialization slightly and is a first step to switching to a move-only interface for registry handles. Also update copyright headers and an obsolete comment on the EngineCommands interface. R=wfh Bug: 830892 Change-Id: I687773b545d199b765345b2a7dd8e310b7609265 Reviewed-on: https://chromium-review.googlesource.com/1197223Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#588869}
-
Xiaoqian Dai authored
If a tab dragging is ended by a second finger tap down, PerformDeferredAttach() might be called to merge the dragged tab into an overview window under the current event position. The event position is calculated based on the current attached tabstrip if it's a touch down event, thus we need to make sure the current attached tabstrip is not nullptr when GetCursorScreenPoint() is called. Bug: 877698 Change-Id: Ic2dcf9f2d4e79c00f3fd7ff0b724a8a45ba64781 Reviewed-on: https://chromium-review.googlesource.com/1200526Reviewed-by:
-
Maja Kabus authored
Element::setAttribute() modified to accept generic TrustedType (StringOrTrustedHTMLOrTrustedScriptOrTrustedScriptURLOrTrustedURL) (the name will be changed later). This is the implementation used for setting attributes explicitly. Added virtual GetCheckedAttributesNames() method, overriden in HTMLXXXElement files, to return list of names of attributes that need to have values checked against Trusted Types. Added new implementations of Element::setAttribute(), one per each Trusted Type, to be used internally in HTMLElement functions. Corrected existing TrustedXXX::GetString() implementations to be concise. Added TrustedScriptURL::GetString(). Bug: 739170 Change-Id: I3a9f51cbed5d75f8059141738b419cc66e529006 Reviewed-on: https://chromium-review.googlesource.com/1146563 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#588867}
-
Vladislav Kuzkokov authored
Managed icon on the setting is read out as "This setting is managed". Bug: 878607 Change-Id: I8dcff087f8280fb1c9fdabdb17946c2917f94461 Reviewed-on: https://chromium-review.googlesource.com/1203375Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f20223d3..a330ed95 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie83c1e9caf9294db2ecbc546ffa7e182e1041637 Reviewed-on: https://chromium-review.googlesource.com/1205608Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588865}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d15b2011d9c0..bf7940726346 git log d15b2011d9c0..bf7940726346 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 shapiroc@chromium.org Switch scarlet back to non-experimental 2018-09-05 vapier@chromium.org cros_portage_upgrade: drop x86 from required list 2018-09-05 vapier@chromium.org cros_mark_chrome_as_stable: stop passing CROS_SVN_COMMIT through Created with: gclient setdep -r src/third_party/chromite@bf7940726346 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7af1dceaad7a3f56a37663d4643efab87ffb8227 Reviewed-on: https://chromium-review.googlesource.com/1206774Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588864}
-
Samuel Huang authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1205917: "Set longer timeout to all tests in wpt/editing/run/", the test external/wpt/editing/run/removeformat.html 's Timeout expectation was removed (along with reference to crbug.com/813098). Likely as a result, WebKit Linux Trusty Leak is flaking in webkit_layout_test for removeformat.html. This CL undos the particular change to remove noise. TBR=tkent@chromium.org,yoichio@chormium.org Bug: 813098 Change-Id: I632084ec48cd8e3fb670a8d20c1210440b13fdc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1207011Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588863}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/390e80705d70..86b118ed994e git log 390e80705d70..86b118ed994e --date=short --no-merges --format='%ad %ae %s' 2018-09-05 chiniforooshan@chromium.org Telemetry: first_gesture_scroll_update_latency Created with: gclient setdep -r src/third_party/catapult@86b118ed994e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: I61b285211a6383252f79fef7af7d4cc36fc7f82a Reviewed-on: https://chromium-review.googlesource.com/1206775Reviewed-by:
-
