GitLab

TBR=brianderson

Bug: none
Change-Id: I3951025d11cf4d0be8308fcacfabcf73866c9291
Reviewed-on: https://chromium-review.googlesource.com/975121Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545035}

Like the equivalent helper on LayoutSVGModelObject, this provides a more
specific type of Node (an SVGElement), since is guaranteed for
subclasses of LayoutSVGBlock.
Also update the documentation in LayoutSVGModelObject to reflect the
current name.

Bug: 769774
Change-Id: I720af53e5a24e960773059f7d2a113e74bd5bdc5
Reviewed-on: https://chromium-review.googlesource.com/973378
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545034}

Bug: 810854
Change-Id: I90e5eb0c82e4d5495e760b631bb61e69eb6aaa43
Reviewed-on: https://chromium-review.googlesource.com/973521Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545033}

clang produces errors for conditional mutex locking in
HashTableStats::recordCollisionAtCount() and
HashTableStats::DumpStats().

> .../wtf/HashTable.cpp:56:7: error: mutex 'hashTableStatsMutex()' is not held on every path through here [-Werror,-Wthread-safety-analysis]
>   if (count > maxCollisions)
>       ^

Avoid such errors by moving lock() and unlock() into a single block.

This CL has no behavior changes.

Change-Id: If64ca5700bda0d881fd96ee84b8115b419a8aa63
Reviewed-on: https://chromium-review.googlesource.com/974667Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545032}

This patch changes |HonorEditingBoundaryAtOrAfter()| to handle nested editable.

Before this patch, |HonorEditingBoundaryAtOrAfter()| returns null position for
editable position anchored by non-editable position.

After this patch, |HonorEditingBoundaryAtOrAfter()| returns the last position in
the highest non-editable ancestor of |anchor|

Note: This patch is a preparation of the patch[1] which changes finding word
boundary in the block instead of inside editing boundary.

Example:
In below HTML, current code finds word boundary in "ABC", but the patch[1]
finds from "abcABCdef".

<div contenteditable>abc<span contenteditable=false>A^BC</span>def</div>
where "^" is starting position to find word boundary.

[1] http://crrev.com/c/737981 Simplify word granularity handling

Change-Id: I1fa702cba0bd48e8eec642c008ddda8fd063a6b8
Reviewed-on: https://chromium-review.googlesource.com/970130
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545031}

This patch introduces |FindWordBackward()| and |FindWordForward()| for a
preparation of the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Change-Id: I405683cd07a0dc3a5f8cc26c307e1d980dcb2961
Reviewed-on: https://chromium-review.googlesource.com/970191
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545030}

Change to use test.html rather than test/main.html.  Having the
file in the regular dir makes it much better for many files
that load other resources assuming that relative paths of
'foreground/foo/bar' will be valid.  This has simplified the
create_test_main.py script.

Bug: 813477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I388b3a914fde3cc99b76503251cbf6ffdd659e81
Reviewed-on: https://chromium-review.googlesource.com/972222Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545029}

Fixed potential test hanging caused by improper exit from the message loop.

When the test begins to wait for the result from JS, it runs loop.
After the test is done, it quits current loop using QuitCurrentWhenIdleDeprecated().
The problem is that browser can run its own loop together with test's loop,
and this loop become the current. After the test calls QuitCurrentWhenIdleDeprecated(),
the browser's loop quits, but the test's loop is still running. That's why the test hangs.
In this CL we create loop, put it into a variable and quit exactly this loop after the test is done.

Bug: 
Change-Id: I0f5a0e55cab583832578bbb4b21069fe815e0339
Reviewed-on: https://chromium-review.googlesource.com/866507
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545028}

This CL tweaks the dismissal animation into the tab grid when only the
selected cell is present.

Prior to this CL, because there were no non-selected cells animating, the
animation which runs the completion block ("(4)" in the comments) would
(I think) be a no-op, so the completion block would run immediately. The
net effect is that the selected cell just jumps into place with no real
transition.

To handle this, this CL restructures the animations when there is only a
single (selected) cell to animate. Updated comments explain the new
structure.

This CL also factors out the completion block and longer animation blocks
for readability, and renumbers the animations for clarity.

Bug: 820410
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaedbc131fd44b28a7fcc8b94cf5e97e46a86241c
Reviewed-on: https://chromium-review.googlesource.com/973206Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545027}

Element::CanAttachShadowRoot() needs to be updated because it returns wrongly true for
customized built-in elements.

The spec: https://dom.spec.whatwg.org/#dom-element-attachshadow

Bug: 823033
Change-Id: Ia9aeb47569414830f5435f37f85d96101b9fe432
Reviewed-on: https://chromium-review.googlesource.com/970142Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545026}

This bug made @font-face and @viewport descriptor names become valid
properties in style rules when the value included var() references.

Bug: 823034
Change-Id: I1087f110af07d8b92989d55e8bebe9cab19d3e0d
Reviewed-on: https://chromium-review.googlesource.com/968489
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545025}

Provide (chromium-side) support for ServiceWorkers in the WebView
Support Library.
We'll add feature flags for the ServiceWorker APIs in a follow-up.

Bug: 819595
Change-Id: Id4c79e3970706633e36b28538c443a00c7e59e03
Reviewed-on: https://chromium-review.googlesource.com/964142Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545024}

This avoids invoking a null callback in case a device is opened more
than once due to multiple open requests coming from the same renderer
process.

Bug: 821362
Change-Id: If55189b5f08c230f56925e2f8c810ec22a5ecd84
Reviewed-on: https://chromium-review.googlesource.com/973163Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545023}

No-Try: true

Change-Id: Ic5f388ab46010599e7240edf5d1cc5f4694f41ea
Reviewed-on: https://chromium-review.googlesource.com/975042
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545022}

Change-Id: I525cbd7c54ca033c54b705116b3a752cb7b81974
Reviewed-on: https://chromium-review.googlesource.com/971322
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#545021}

If the notification view is invalid state, FindVisibleNotificationById
may returns null and it caused the crash. This CL fixes it.

Bug: 824039
Test: None
Change-Id: I0ebc0ddd0cd77c9af235bef07a92fe635135e96c
Reviewed-on: https://chromium-review.googlesource.com/974665Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545020}

Done by mass-rename.sh

BUG=735078
TEST=None

Change-Id: I2d111218065a991817534f4cc4a3f3d974f2c8c1
Reviewed-on: https://chromium-review.googlesource.com/967049
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545019}

The specification for DOMTokenList's replace() method
which would make it return a boolean.

Indicating true if a token was replaced, and false otherwise.

Bug: 820988
Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: I8e500a74a2504e13522c4e85b17d441cd2d4299f
Reviewed-on: https://chromium-review.googlesource.com/965683Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545018}

GoogleURLTracker registers itself as a NetworkChangeObserver at the
NetworkChangeNotifier singleton, and unregisters itself again in Shutdown().
In non-test code, GoogleURLTracker is a KeyedService and so its Shutdown()
gets called at the proper time automatically. But in unit tests that
instantiate it directly, we have to explicitly call Shutdown(),
otherwise we leave behind a dangling pointer.

Bug: 823858
Change-Id: Idc215823ad81c983c8693c04688eccce40f9f26c
Reviewed-on: https://chromium-review.googlesource.com/973603Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545017}

This change fixes GattServicesDiscovered on Windows to only be called
once all services, characteristics and descriptors are discovered.
Furthermore it removes the deprecated GattDiscoveryCompleteForService
notification.

Bug: 507419, 821766
Change-Id: I234409cb159a022e0443b8c2d2a4b1c90fac9b15
Reviewed-on: https://chromium-review.googlesource.com/850357Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545016}

This CL adds a switch used to change the positions of the toolbars
buttons, allowing to test different layouts.

The 3 layouts possible are:
- Navigation controls in the bottom and nothing in top toolbar (default)
- Navigation controls in the bottom and share button in the top toolbar
- Navigation controls in the top toolbar and bookmark/share in the
   bottom toolbar

Those layout will mainly change the visibility of the different buttons.
Also the second forward button is added to the toolbar views.

Bug: 824175
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8e76b081038fb444bdac8f9e823dc023b4b9e883
Reviewed-on: https://chromium-review.googlesource.com/973609
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545015}

Three refactorings are done, as follows:

1. Loader's "loader_" member becomes "threadable_loader_"

   Rationale: This aims to reduce confusion between the Loader type,
   its "loader_" member, the ThreadableLoader type, and the
   SRIVerifier::loader_ member, which are all used in this same cpp
   file.

2. Loader's "request_" member becomes "fetch_request_data_".

   Rationale: to reduce confusion with the |request| local variable
   that's used in FetchManager::Loader::PerformHTTPFetch(). PerformHTTPFetch()
   references both |request| and |request_| extensively, resulting in code
   that is very hard to follow, since they have different types.

3. Add a using-decl for network::mojom::FetchRequestMode.

   Rationale: this typename is used more than twenty times times in
   this file; a using-decl cuts down on the noise.

Bug: 
Change-Id: I077f30fb08aebe8fe3e5f8911a2eb6df614df9cc
Reviewed-on: https://chromium-review.googlesource.com/731620Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545014}

Change-Id: If9fec539c2fc140d755033a1ed5dbaff141230d4
Reviewed-on: https://chromium-review.googlesource.com/974725Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545013}

The current autofill implementation uses the name field for two usages
- it is used as a hint to infer the type of the field
- it is used as a technical pointer to the field that will be used to fill the field later.

This has multiple consequences:
- if multiple fields have the same name, there is a collision when autofilling,
- if a field name is empty, there is no way to set its value using autofill,
- any workaround on these issues may have consequences on the type of field deduction.

On the other hand, form_field_data has an id field that is not used on iOS.
This CL splits the name field in two
The name will be used to deduce the field type in the form.
The name of the field is (in order of priority)
- the name attribute if present,
- the id of the element if present.
Otherwise, the name field is empty.
This restores the behavior of the name field before https://chromium-review.googlesource.com/751241
This can be extended using other attributes known to carry information on content as suggested
in crbug.com/791578.

The identifier will be used as a unique identifier of the field and is the key to set the field
value.
The identifier is (in order of priority)
- the id of the element if present.
- the name attribute if present and in a form,
- the index of the control element in the form if the element is in a form
- an XPath query pointing to the element consisting in the closest ancestor with an ID,
  then the index of the element with the same tag name.
This identifier *cannot* be empty.
The JS API does not provide a way to retrieve an element knowing its identifier. Retrieving it
requires to loop through the potential matches and check the identifier.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieaa196d8fb9a55d7c446ffbfe39a3ea6699c9acf
Reviewed-on: https://chromium-review.googlesource.com/814434Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545012}

https://pdfium.googlesource.com/pdfium.git/+log/19a33e4ece99..0f494c86440d

$ git log 19a33e4ec..0f494c864 --date=short --no-merges --format='%ad %ae %s'
2018-03-22 thestig Roll DEPS for buildtools to 3748a2a9
2018-03-22 thestig Roll DEPS for build to 4b1fc75d
2018-03-22 thestig Remove testing/{gmock,gtest}/dummy.
2018-03-22 thestig Update gtest and gmock to 1.8.x.
2018-03-22 thestig Add testing/{gmock,gtest}/dummy.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:823586,chromium:823586


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I23df90f832e9981f4c07702dabdb325b155055f4
Reviewed-on: https://chromium-review.googlesource.com/974901
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545011}

Embedded devices have limited storage capacity generally. So current maximum disk
cache size(250MB) can make their storage fully used in the embedded devices.
For the embedder, it would be good if we give the power them to set the maximum
disk cache size through the command line.

Bug: 824619
Change-Id: Ib4fae34934eadf23f1165907b5c547fff205b827
Reviewed-on: https://chromium-review.googlesource.com/974804Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#545010}

https://skia.googlesource.com/skia.git/+log/f5720cc4d1dd..4259797efdf3

$ git log f5720cc4d..4259797ef --date=short --no-merges --format='%ad %ae %s'
2018-03-22 update-docs Update markdown files

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I5d5854743c09f0bce07b0f3b6d0e0cee4278e05d
Reviewed-on: https://chromium-review.googlesource.com/974902
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545009}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f531298e1a3..869a2857a4f3

$ git log 9f531298e..869a2857a --date=short --no-merges --format='%ad %ae %s'
2018-03-22 thestig Revert "Add debugging info when gclient deletes an old DEPS entry."

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:823586


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ief0ad99707d16924e86b7b1f475310fc71bd7b82
Reviewed-on: https://chromium-review.googlesource.com/974897Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545008}

This reverts commit 13dc6be4.

Reason for revert: Broke official Chrome builder.

Original change's description:
> Remove localhost from Hangouts services extension manifest.
> 
> Bug: 819406
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I9ec4028146c3a561f847a649848c5c16dde6e2a8
> Reviewed-on: https://chromium-review.googlesource.com/951684
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Henrik Grunell <grunell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544656}

TBR=grunell@chromium.org,phoglund@chromium.org,jansson@chromium.org

Change-Id: Id11dbe77e63a4ca73badce8efe959f601ccf4306
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819406, 824632
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/974382Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545007}

https://chromium.googlesource.com/angle/angle.git/+log/3395c8b96333..8b92c53b8a8c

$ git log 3395c8b96..8b92c53b8 --date=short --no-merges --format='%ad %ae %s'
2018-03-22 jmadill Skip EnableQueryExtensions test on Win/AMD/GL.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ie4d5ac12678842c41765eb3ff5585a4cf43adeaa
Reviewed-on: https://chromium-review.googlesource.com/974890Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545006}

This client is needed by downstream (Mountain) repo.

Bug: b/75308868
Change-Id: I06829202017f8244db7787ff0cb3f09b01662032
Reviewed-on: https://chromium-review.googlesource.com/972224Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Rudy Xie <rudyxie@google.com>
Cr-Commit-Position: refs/heads/master@{#545005}

This CL adds the metrics for the new tools menu actions.

Bug: 804770
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic39f8043906b7c5db2cd6ed390a6afbcf5f5037c
Reviewed-on: https://chromium-review.googlesource.com/973601Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545004}

BUG=787020
TBR=thestig,dpranke
CC=​drott

Change-Id: I794aab43f62f9c56f00a8c4d9d3959f1a8f36e85
Reviewed-on: https://chromium-review.googlesource.com/973560
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545003}

Bug: chromium:757440
Change-Id: I3b691a2ac8ca9d10a5540fe7385f2278cdef94ec
Reviewed-on: https://chromium-review.googlesource.com/973169
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545002}

- Rename DataLogF() to DeprecatedDataLogF().

- Remove commented-out code in Heap.cpp

- Prevent us from adding new dependencies on DataLog.h

This CL has no behavior changes.

Bug: 720442
Change-Id: I188ef5a69f3426b8b49eea508e50f68fa744f7a0
Reviewed-on: https://chromium-review.googlesource.com/974807
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545001}

changes:
For contacts that don't have profile photo set, the image info passed
to chrome is null. This CL handles this case. We should provide
appropriate default images for this case on Chrome side.
Android side change: ag/3774689.

Bug: 818902
Test: manual test
Change-Id: I03ebe42d8c8930b25c50a3968a9c7c89477f6a76
Reviewed-on: https://chromium-review.googlesource.com/973552Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#545000}

Change-Id: I09440837fddc4ed6a7163b6adcd08ee7ef13634a
Reviewed-on: https://chromium-review.googlesource.com/973915Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544999}

Bug: 805369
Test: Fix failed test and `git cl try`
Change-Id: If77f7d2502cb17891d82914928c031f62d4e5f94
Reviewed-on: https://chromium-review.googlesource.com/954163Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544998}

Following bot results are included.
4316 4317 4318 4320 4321 4322

1 lines were removed and 1 lines were deflaked by consecutive
results since 4288.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I53b86a1df9840baa0c0b1a50199d60047d09c469
Reviewed-on: https://chromium-review.googlesource.com/973422
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544997}

This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object.  We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.

KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API

Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();

New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();

Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.

BUG=680809

Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}