- 01 Oct, 2019 40 commits
-
-
Darren Shen authored
These aren't actually used in rule-based engine. No point sending them. Bug: 1009903 Change-Id: Ic0add4ecba3d4341c2976f6abce8e9c86465d116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833032Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#701472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/839a023619b5..c912690d22ab git log 839a023619b5..c912690d22ab --date=short --no-merges --format='%ad %ae %s' 2019-10-01 apodtele@gmail.com * src/base/ftstroke.c (ft_stroker_inside): Speed up. 2019-09-30 wl@gnu.org * src/sfnt/sfwoff2 (woff2_open_font): Initialize `woff2.ttc_fonts'. Created with: gclient setdep -r src/third_party/freetype/src@c912690d22ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I27a51d179205fb38034959648f91910990916e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833105Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#701471}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e06f01be719a..deb28ea45d0d git log e06f01be719a..deb28ea45d0d --date=short --no-merges --format='%ad %ae %s' 2019-10-01 jiawei.shao@intel.com D3D12: Implement ASSERT_SUCCESS as macro instead of function 2019-10-01 bryan.bernhart@intel.com D3D12: Use ringbuffer allocator for descriptor heaps. Created with: gclient setdep -r src/third_party/dawn@deb28ea45d0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6d9e0cd64a2af9db3bf4172a45a331acfe8a4091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701470}
-
Marc Treib authored
Bug: 1007942 Change-Id: Ibf1dd753fbd6a8922b0c909a8657728eab6af2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831901Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701469}
-
Piotr Bialecki authored
Bug: 1009129 Change-Id: Iea0ee4259c894db49a76f8f4e1ca9b53f95f69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829296 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701468}
-
Hwanseung Lee authored
Use enum class instead of enum for PaintButtonMode enum class is more type safety. Bug: 940736 Change-Id: If4135af54748a1f9383aba3605916a593aaba0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824052 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701467}
-
Ricky Liang authored
When we use VideoFrame::WrapVideoFrame to soft-apply a different set of format, visible rectangle, and natural size on a source VideoFrame, we have to make sure the source VideoFrame outlives the wrapping frame in most if not all the scenarios. This CL explicitly retains a reference to the wrapped frame inside the wrapping frame when WrapVideoFrame is called. Along with the change, we can remove several empty destruction callbacks that are only used for retaining a reference to the wrapped frame. Bug: 982201 Change-Id: Id81ad65c500fe4f0b47a60d98819408522314129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830241 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#701466}
-
Benedikt Meurer authored
When hovering an expression within the Sources panel (during debugging), we try to evaluate it's value and show a popover with the result of that. However this is all best effort and might fail for various reasons. If it fails because we guessed the wrong substring (for an expression), we currently display a popover with a SyntaxError or a ReferenceError in that. But this popover is confusing and doesn't serve a purpose. Instead we should just not display anything in this case as well. Bug: chromium:995036 Change-Id: Id70e2212fe0af58078b2a33731688ec1c5507434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831814 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701465}
-
Fredrik Söderquist authored
While flag-waving may be considered somewhat ugly, it's quicker (no hash lookups) and slightly more flexible (then providing access to the tracking set) if you want check for reentrance earlier (which is what we want to do). Bug: 998526 Change-Id: I91f9df93879e4446bd5908513cd8a4226c657bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831906Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701464}
-
Rune Lillesveen authored
When the runtime flag for flat tree style recalc is enabled, traverse children of slots and v0 insertion points directly. Also, skip traversing light tree children of shadow hosts. Bug: 972752 Change-Id: I7585bbbe9b880913887da48ea59fadfb5b4083b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829704Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701463}
-
Fredrik Söderquist authored
We check this member field, but we never set it, so it's of no use anymore. Bug: 998526 Change-Id: I6de7399574828fe26f413d0dfcd2a0556540f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831767Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701462}
-
Benedikt Meurer authored
Remove the `ACORN_ECMA_VERSION` constant, and instead rely on the official `ecmaVersion` default in acorn, which is now 10 (corresponding to ES2019). Bug: chromium:995036, chromium:1009927 Change-Id: Ie6b4c5e2839012f498c2c561c33d811b37749eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829713 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701461}
-
Rune Lillesveen authored
For subtree recalc when scheduling sibling invalidations as descendant invalidations on the ancestor, mark the shadow host instead of the shadow root for style recalc. In preparation for flat tree style recalc where we only want to consider elements and text nodes for style recalc. Bug: 972752, 990743 Change-Id: I00921e298d50be2667e7b26b3149f4f1b72a2d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831761Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701460}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a305a6276dfe..1ffc2e453b00 git log a305a6276dfe..1ffc2e453b00 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 71c1138d6739..087f1384f233 (3 commits) 2019-10-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 26279492..b26cb15a (404 commits) Created with: gclient setdep -r src/third_party/skia@1ffc2e453b00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None,chromium:None Change-Id: Iee6403217fc1c68cf5a2060c1115a824fd3b34eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701459}
-
Benedikt Meurer authored
Bug: chromium:1009876 Change-Id: Id4983d9b7be445fd4d935b27195f1b53bb1cb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832265Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701458}
-
Peter Kasting authored
Bug: 82078 Change-Id: I471bc6109877cebbbbdb2467ceb0197b9d2906ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824647Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701457}
-
Morten Stenshorne authored
This was just meant to be a preparatory CL for adding support for avoiding breaks using the break-before and break-after properties, but ended up fixing bugs as well. :) This makes 3 web tests pass, because we now have more control over break avoidance, so that we can keep last resort breaks inside a child if breaking before would be just as bad. When two breakpoints are equally bad, prefer the one that takes us the furthest in the content. Rename BreakBeforeChild() to BreakBeforeChildIfNeeded(), and introduce BreakBeforeChild(), which actually always breaks before a child. BreakTypeBeforeChild() only partially contained the logic to determine whether and how to break, and has now been swallowed by BreakBeforeChildIfNeeded(). Bug: 829028 Change-Id: Ia620c19e1dfd31e88cf76eb7cea150a9e1152865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829101Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#701456}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 1008029 Change-Id: Ife5414a0331ab74fd0c2f1102de86a77f72f43fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832845Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701455}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2a6ac81ca46..94a459c0b4c7 git log c2a6ac81ca46..94a459c0b4c7 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org cros_build_lib: run: drop unused error_message setting 2019-10-01 vapier@chromium.org unittests: handle some renamed assert methods 2019-10-01 vapier@chromium.org cros_test_lib: deprecate some more unittest aliases Created with: gclient setdep -r src/third_party/chromite@94a459c0b4c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ieba503f928e77cd65551bbaa59d53c11705a98d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701454}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86a375c756f2..35e16bac7b41 Created with: gclient setdep -r src-internal@35e16bac7b41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia1d5e1d4371c941f4fb9cb508e104edb77e0893f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833110Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701453}
-
Jay Harris authored
Previously, the flag was only shown on ChromeOS, however there is currently implementation work on Linux and Windows (and soon, on MacOS), so it makes sense to show it on other platforms. Bug: 829689 Change-Id: I91e0e37828bea9ebd3888d18def5ace42a475e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833019 Commit-Queue: Jay Harris <harrisjay@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#701452}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 248894, 1008848 Change-Id: Iac61f0d1e8b1046c05f2b9c8c4b0efdb8a717abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833342Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701451}
-
Alex Danilo authored
When the connectedCallback is called on the panel item custom element, set any button onclick handlers since they could have been null'ed out if the panel item was removed from the DOM. Bug: 1009318 Change-Id: I621bf1bcda85c877c1c52a182474e6ec294c63ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832188 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701450}
-
Jay Harris authored
This is the result of some discussion at TPAC. Previously the BadgeManager applied badges to scopes. This CL changes the BadgeManager to work with AppIds instead (as the web facing API has been changed). Previous CLs have changed the API exposed to the Web, so this change only affects how Chromium stores/applies the badges. TPAC Discussion Summary: https://github.com/WICG/badging/issues/55 Related CLs: https://crrev.com/c/1817999 https://crrev.com/c/1818892 https://crrev.com/c/1816002 Bug: 1006665 Change-Id: I24d18bdad5a8a0a92b0d1b5ac14052b9de8913dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830485 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701449}
-
Patrick Monette authored
When ServiceWorkerContextCore::DeleteAndStartOver() is used, the existing service workers still exist for a short time but new instances are created and they will reuse existing version_id because the count is reset to kInvalidServiceWorkerVersionId. This leads to multiple running notifications for indifferentiable service workers. To fix this, the ServiceWorkerContextWrapper is notified when DeleteAndStartOver() is called and prematurely sends a stopped notification for all currently running service worker versions. Then, to prevent future notifications from all the old versions, the ServiceWorkerContextCore silently drops notifications if the core associated with the version is no longer alive. Bug: 993029 Change-Id: I27b192141265828139416abb37d8e0c762308679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829865 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701448}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 1008790 Change-Id: I4e927365689ff14ecf87df4e3b180492f10645e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833341Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701447}
-
Thanh Nguyen authored
This CL: 1. Adds prefix matching to the class. 2. Uses normalized text rather than raw text of TokenizedString. 3. Combines scores from all sources to give a final score. Bug: 990684 Change-Id: I200986fc38366be117c7c4b8849d4510b4f830bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826745 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701446}
-
Patrick Monette authored
This class observes running shared worker instances, keeps track of the connection to their client frames and manages the lifetime of worker nodes in the Performance Manager graph. Bug: 993029 Change-Id: I2e0c7cd9f194a06405293c22fd543a14ff3c6cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757283 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701445}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 684968, 1008790 Change-Id: If358ae57659927c38fe2d65087f5aa3df1b336d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833031Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701444}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb6de9f661f3..a305a6276dfe git log cb6de9f661f3..a305a6276dfe --date=short --no-merges --format='%ad %ae %s' 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader faa2a365b5c0..3044c24181e9 (4 commits) Created with: gclient setdep -r src/third_party/skia@a305a6276dfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: Ia59a23cdca4a1e6cc57486259643f6b23aec9e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701443}
-
Chinglin Yu authored
This refactors DebugDaemonClient by moving the the client to debug_daemon subfolder under //chromeos/dbus. metrics::DebugdClientProvider is also moved to the subfolder and renamed to to chromeos::DebugDaemonClientProvider to be consistent with chromeos::DebugDaemonClient. Bug: 998364 Test: Build Change-Id: Icfe85f1c2b55146f0130c42ceff3e57f8b376922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794944 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701442}
-
Austin Tankiang authored
File transfers of hosted drive files should be blocked when: - Transferring to outside of drive. - Transferring to another profile's drive. Also change to using URLsToEntriesWithAccess, as URLsToEntries does not work with files from a different profile. The code is covered by existing tests, however some tests are changed to copy non-hosted files from drive to downloads, as hosted files cannot be copied this way anymore. Bug: 1008328 Change-Id: I9cc86035d7955c9ca34d53587affd5786367a608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830491Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#701441}
-
Alan Cutter authored
Web apps that sync across devices are not considered locally installed for non-Chrome OS devices. This CL ensures we don't accidentally install them as part of manifest updating. Bug: 926083 Change-Id: I34ba3610b04a3cf62e6c7bd362bed2fd770d7b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831737 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#701440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c6278001533..86a375c756f2 Created with: gclient setdep -r src-internal@86a375c756f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie4e7d0e1ea1bef16b58ca39de1def0dd759e370f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701439}
-
Anand K. Mistry authored
BUG=972551,977313 Change-Id: Icdc9f46e31f779156ea66b4b3091f786150c08da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827266 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701438}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in CdmProxy interface. CdmProxy::Initialize applies pending_associated_remote to the first argument. Bug: 955171 Change-Id: I6d777b123809c9e56bd25d8204d71ee4d0c8999c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827102Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701437}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6a4a0164d45..c2a6ac81ca46 git log d6a4a0164d45..c2a6ac81ca46 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 dtor@chromium.org usergroup_baseline: note that pluginvm belongs to cups-proxy group Created with: gclient setdep -r src/third_party/chromite@c2a6ac81ca46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I45187ae57cd3e0743aa3bd69445ead4fe6eebce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701436}
-
Dan Beam authored
R=tangltom@chromium.org Bug: 1009445 Change-Id: I75f51a6b3b4e22cc06a130e953d47cfd7fccf203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832264 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701435}
-
Sadrul Habib Chowdhury authored
NOTIFICATION_BOOKMARK_CONTEXT_MENU_SHOWN is used to schedule a callback right before the bookmark context menu is run. This is used only in interactive tests. Instead of using this notification, use a more explicit API to register callbacks to run before running the context menu. BUG=268984 Change-Id: I43c78118d6fd7ef53f0b7e7c70aefc85670cf78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831275 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701434}
-
Jinsuk Kim authored
Moves the internal job handling API to Profile class where it suits better. The API is still present; it will be refactored by updating the call sites to use a helper method in other CL. Bug: 925242, 995903 Change-Id: I292adc2bb9d4bddaccc6857ad33d7b9444c51b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830255Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701433}
-