- 19 Jul, 2018 40 commits
-
-
Kenneth Russell authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html is failing intermittently on all platforms. Going to rewrite the test for better correctness and improve its diagnostics. Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ice9efc8cdcff75753bfd64c231dafc7c7a154790 Tbr: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1142698Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576349}
-
kristipark authored
In order to prevent private information from being leaked to third- party NTPs, information related to editing/adding links will be contained in an iframe. Once the user finishes editing, the information will be sent to the EmbeddedSearchAPI and ultimately be received by the Most Visited iframe by querying EmbeddedSearchAPI with the specified rid. Screenshot: https://screenshot.googleplex.com/FcYM4VCiu3c.png Design Doc: go/chrome-ntp-custom-links Bug: 851293, 865071 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I06f4449f9c3764c5d797b83acbc7c97e6903b787 Reviewed-on: https://chromium-review.googlesource.com/1139108Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#576348}
-
Jesse Selover authored
Work towards consolidating privacy load flags into the single allow_credentials field. In the first stage of this migration, we'll migrate all existing usages of the load flags to the new API, which will force them to all have the same value. This CL just creates the new API and one usage of it (in report_sender.cc). Bug: 799935 Change-Id: Iaec1fa8455d93f234a2d3be11c3b9c5b4d71228f Reviewed-on: https://chromium-review.googlesource.com/1134026 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#576347}
-
Wenzhao Zang authored
This CL is a combination of small changes based on the meeting with PM and UX, It includes: 1) Disable daily refresh when another wallpaper is selected. 2) Make the entire area of daily refresh thumbnail clickable. 3) Add shadow to preview top bar and selected thumbnails. 4) Adjust spacing for buttons in current wallpaper info bar. 5) Switch the colors for enabled/disabled states for the buttons. 6) Change the color of the button text. 7) Prevent restoring the previous active windows in tablet mode after the picker closes (i.e. continue to show the new wallpaper or home launcher). 8) Hide scroll bar if there's no scroll event after a timeout. Bug: 863491 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id0aa1913f2bb0820909d7c714805cb723426a316 Reviewed-on: https://chromium-review.googlesource.com/1137486Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576346}
-
Matt Falkenhagen authored
Also expand on documentation. Rationale: * This interface is the counterpart of ServiceWorkerHost. * It's the initial/master interface for the message pipe for talking to a service worker from the browser, that other interfaces are associated with. So it deserves a more important-sounding name. * It does more than dispatch events already. * This was apparently the original plan in https://docs.google.com/document/d/1FxFISiZKBH2MALypxt-aoGAbmyco-7kEMi1zMe5KrzE/edit Bug: 629701 Change-Id: Iab5969fa60d308300b3fcd8dada4fcca1ddc18b2 Reviewed-on: https://chromium-review.googlesource.com/1142704Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576345}
-
Ted Meyer authored
fuchsia should no longer be racing and taking a page fault on IP. Bug: 864018 Change-Id: I07a21cbc80944822ceb3dcc12cfc39f8978d677c Reviewed-on: https://chromium-review.googlesource.com/1141353 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576344}
-
Chris Harrelson authored
Partial re-land: [IO] Only compute intersection observations if any property tree state has changed, and only for full-frame updates. This CL includes only the refactoring aspect of the original CL, not the part about avoiding intersection observations when possible. Bug: 831762 Change-Id: I6dd2786e61faedd4b3b6fdedc0f6d3080b4a9bf1 Reviewed-on: https://chromium-review.googlesource.com/1141065Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576343}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iaf213e06847c17b38a8742207815062a7c20e5b3 Reviewed-on: https://chromium-review.googlesource.com/1142603Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576342}
-
Kyle Milka authored
Bug: 850701 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iff3f58b719a71e089bd821f030a8345af2620b98 Reviewed-on: https://chromium-review.googlesource.com/1125266 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576341}
-
Dominick Ng authored
This ensures that users holding down the Enter or Space key cannot accidentally trigger an external protocol launch. BUG=865202 Change-Id: I2cec7b3c216b80641200c97dec2517a66b4e0b24 Reviewed-on: https://chromium-review.googlesource.com/1142705 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576340}
-
Travis Skare authored
Bug: 864302 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibe9a8fdf1ae1c9eb1ef401d3f667f261a76ef65d Reviewed-on: https://chromium-review.googlesource.com/1069735 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#576339}
-
Dominick Ng authored
This CL removes the chromeos::AppType enum in favour of the newly introduced apps::mojom::AppType. This new enum is defined in the App Service and will be used for all app types going forward. This CL also makes a number of changes with the eventual aim of cleanly separating ARC dependencies out of AppsNavigationThrottle. These changes include: * moving page_transition_util.{_unittest.cc,cc,h} from components/arc to chrome/browser/chromeos/apps, and removing redundant includes * moving the IntentPickerResponseCallback to apps_navigation_types.h The next CL will refactor and rename ArcNavigationThrottle and AppsNavigationThrottle to encapsulate Chrome OS-only functionality more cleanly. This will allow AppsNavigationThrottle to be moved to chrome/browser/apps and reused on non-Chrome OS platforms where only desktop PWAs will be supported. BUG=853604 Change-Id: Icd8f6607dc7d1e7419564b06481031136e270553 Reviewed-on: https://chromium-review.googlesource.com/1139939 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576338}
-
tanvir.rizvi authored
Rename 15381 to justify_center_do_not_modify_root_editable to identify from file name what this tests does. Bug: 679977 Change-Id: Ic07091aa89a391818705eb5ca0aae26a6c35fcca Reviewed-on: https://chromium-review.googlesource.com/1136264 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576337}
-
Qiyu Hu authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/0eac64e18aba..e0781f23b9e8 $ git log 0eac64e18..e0781f23b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 qiyuh Add kOptionHasSubsequentWrite 2018-07-03 amoylan Remove ML service mojoms from system_api 2018-07-12 jkardatzke Add D-Bus method and proto for launching a Crostini Terminal Created with: roll-dep src/third_party/cros_system_api Bug: b:78650442 Test: CQ Change-Id: Ic600970c01e2f16f33d4d793fc130847f4c104eb Reviewed-on: https://chromium-review.googlesource.com/1140747Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#576336}
-
Dale Curtis authored
This implements reading of the 'seq_profile' value from the 'av1C' atom per the spec description here: https://aomediacodec.github.io/av1-isobmff/#av1codecconfigurationbox https://aomediacodec.github.io/av1-spec/av1-spec.pdf (Section 5.2) This also re-enables previously disabled tests and adds the various bits necessary for av1 fuzzer tests. Bug: 757047, 784993, 784607 Test: Updated unittests and fuzzertests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I05d8d42c8c022b7dc508ab8d212ad846ae1de8b6 Reviewed-on: https://chromium-review.googlesource.com/1107260 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576335}
-
Allen Bauer authored
Under Refresh, as tabs are hovered and the animating hover highlight is active, several highlighted tabs can be visible. This will change the painting order of those tabs so that the lower corners of the tabs are painted such that they aren't likely to look like a "speech bubble" as pbos@ referred to them. As a consequence, last_hovered_tab_ could be removed since it's not needed with the new logic. Bug: None Change-Id: I52c470d22966241e47b8450161e4ab9f31966e1b Reviewed-on: https://chromium-review.googlesource.com/1140954 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#576334}
-
Koji Ishii authored
This patch removes spaces before <br> because the images do not match due to crbug.com/40634, which LayoutNG does not have the problem. TBR=eae@chromium.org Bug: 591099 Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49 Reviewed-on: https://chromium-review.googlesource.com/1142050Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576333}
-
Kim Paulhamus authored
- Remove messages that no longer apply now that CTAP2 is implemented on desktop - Add Android-only error messages. I prepended these with 'ANDROID' for clarity. Bug: 678885 Change-Id: I96e5850752829c0b1e454837a9e1d1fdfa3a9630 Reviewed-on: https://chromium-review.googlesource.com/1139578 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576332}
-
Mounir Lamouri authored
This leads to better memory performance as the last frame will be discarded. Bug: 829813 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7bc753e7e8d74d80d8c8390bd0f33ed45003ed5a Reviewed-on: https://chromium-review.googlesource.com/1141291 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576331}
-
Koji Ishii authored
This patch changes some tests to standard mode. They currently fail in LayoutNG, probably due to quirks mode. Change them to standard mode to see if they still fail. TBR=eae@chromium.org Bug: 591099 Change-Id: Ia41cbc42eb1a114a24c4a13411080ee7fae9cf2e Reviewed-on: https://chromium-review.googlesource.com/1142048Reviewed-by:
-
Devlin Cronin authored
Destructuring assignment is not currently allowed in Chrome WebUI, per the ES6 styleguide: https://chromium.googlesource.com/chromium/src/+/master/docs/es6_chromium.md#Destructuring-Assignment Bug: None Change-Id: I000da1a21e148fe9e8024202fb0e5a6f1bca3cc8 Reviewed-on: https://chromium-review.googlesource.com/1142566Reviewed-by:
-
Kyle Milka authored
When available, attributions for custom backgrounds should be displayed on the NTP. Three new preferences are needed to store the attributions. A new embeddedSearch API, SetCustomBackgroundURLWithAttributions, is used to set these preferences. Bug: 850309, 863942 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib6e5f41f5842d80aac41dd5314f0cdd75aa8f784 Reviewed-on: https://chromium-review.googlesource.com/1129385Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
"Dictioary" is not a type in spec, and it is replaceable with "object". Bug: 816352 Change-Id: I745000e7ce0ef82959870ef40e44f20029acbdd6 Reviewed-on: https://chromium-review.googlesource.com/1141559Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#576327}
-
Alexander Alekseev authored
This Cl fixed bug introduced in https://chromium-review.googlesource.com/1077099, when OOBE Welcome stopped receiving updated strings on localizedStrings update. Bug: 850444 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id8e53ed1a193c6e59df744500470cbeb2ed2d84b Reviewed-on: https://chromium-review.googlesource.com/1142732Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#576326}
-
Justin Donnelly authored
This involves several small changes: - Adjust the layout of IconLabelBubbleView to account for the case where we want to show the separator but not the label. - Move the extra space shown in suggest mode from LocationBarView to IconLabelBubbleView so it can use the logic and spacing values there. - Add LocationIconView::ShouldShowSeparator() to indicate that we want to show the separator in the steady-state case. - Adjust the spacing in the suggestion result view to match the current spec. Also, remove a bit of dead code: GetMaxSizeForLabelWidth() and GetOuterPadding() in IconLabelBubbleView. Bug: 853355 Change-Id: I108dbf80de3c060ca56bbe502101dfbb1123ef4e Reviewed-on: https://chromium-review.googlesource.com/1136493 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Shakti Sahu authored
Hooked up the menu items to their respective functionalites. Implemented functionalities for search and delete. Bug: 850605 Change-Id: I89186c21481ed834f92ac4b5915a41d3e830b273 Reviewed-on: https://chromium-review.googlesource.com/1141208 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576324}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If8304fd344786392300cfe1f45e3246fd18fff76 Reviewed-on: https://chromium-review.googlesource.com/1142514 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576323}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f22b4e2f6682..c15c0b3a1e9a git log f22b4e2f6682..c15c0b3a1e9a --date=short --no-merges --format='%ad %ae %s' 2018-07-18 thestig@chromium.org Roll third_party/skia/ af7700265..588f87967 (1391 commits; 41 trivial rolls) 2018-07-18 thestig@chromium.org Handle wrong tag element count in littlecms. 2018-07-18 tsepez@chromium.org Add pdfium::span::as_bytes() and as_writable_bytes(). Created with: gclient setdep -r src/third_party/pdfium@c15c0b3a1e9a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:864932 TBR=dsinclair@chromium.org Change-Id: If7555664cbb89a71e68d034eacbb6b6be0e87415 Reviewed-on: https://chromium-review.googlesource.com/1142172Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576322}
-
Shimi Zhang authored
With the new algorithm in http://crrev/c/1102157, we won't be able to select cross editing boundary anymore, so layout test search-cancel-button-mouseup.html will violate a DCHECK in |TextControlElement::CacheSelection()|. In fact, we shouldn't allow selection starts with cancel button at all, this CL adds |user-select: none;| to |SearchFieldCancelButtonElement|. Bug: 863651 Change-Id: Id23b50503caaf814b0a8a14ea1b7c243b3c51c68 Reviewed-on: https://chromium-review.googlesource.com/1141350Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#576321}
-
Annie Sullivan authored
Change-Id: I8504e4d3d2ef29ad5c7ade2d059924e4acbf5546 Reviewed-on: https://chromium-review.googlesource.com/1141086Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576320}
-
Katie D authored
This moves all metrics related functionality into a separate class, and is a pure refactor. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idba2a55655c3e67476500618e6c324a10cfa0b37 Reviewed-on: https://chromium-review.googlesource.com/1141115Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#576319}
-
Alex Moshchuk authored
Previously, when a frame with a unique origin, such as from a data URL, created a blob URL, the blob URL looked like blob:null/guid and resulted in a site URL of "blob:" when navigated to. This incorrectly allowed all such blob URLs to share a process, even if they were created by different sites. This CL changes the site URL assigned in such cases to be the full blob URL, which includes the GUID. This avoids process sharing for all blob URLs with unique origins. This fix is conservative in the sense that it would also isolate different blob URLs created by the same unique origin from each other. This case isn't expected to be common, so it's unlikely to affect process count. There's ongoing work to maintain a GUID for unique origins, so longer-term, we could try using that to track down the creator and potentially use that GUID in the site URL instead of the blob URL's GUID, to avoid unnecessary process isolation in scenarios like this. Note that as part of this, we discovered a bug where data URLs aren't able to script blob URLs that they create: https://crbug.com/865254. This scripting bug should be fixed independently of this CL, and as far as we can tell, this CL doesn't regress scripting cases like this further. Bug: 863623 Change-Id: Ib50407adbba3d5ee0cf6d72d3df7f8d8f24684ee Reviewed-on: https://chromium-review.googlesource.com/1142389 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576318}
-
Tien-Ren Chen authored
This CL changes the pre-snapping policy of <video> so that only the size of the contents is pre-snapped, while the location will exactly match the content box's final location. BUG=730284 Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0 Reviewed-on: https://chromium-review.googlesource.com/1141328Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576317}
-
Reilly Grant authored
This change updates the WebUSB WebIDL files to match the recently merged spec pull request #142 by hiding interfaces which aren't useful in insecure contexts. Change-Id: I98625b2634e452c775601525300672d9440ddbcc Reviewed-on: https://chromium-review.googlesource.com/1137435 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#576316}
-
Aidan Wolter authored
We need to enable CMA on some Android devices, but we should continue using MojoAudioDecoder and MojoVideoDecoder in the gpu process. This affects Android-based Cast devices. BUG=b:111465269 TEST=Build, cast YT Change-Id: Ic76d695204720b91d99ab53ae3b40513cea962c5 Reviewed-on: https://chromium-review.googlesource.com/1139103 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#576315}
-
Nicholas Verne authored
When a user's cros-termina component needs upgrading, but the user is not connected to the internet, a dialog is shown. Bug: 862199 Change-Id: I76808e24b0ff1a256331576f56418302bb52bca5 Reviewed-on: https://chromium-review.googlesource.com/1142706Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576314}
-
Jared Saul authored
Changes made by request of UX team. Bug: 848955 Change-Id: I4b5486a97cf3482f98a26657ac2644b9bc2c1bd4 Reviewed-on: https://chromium-review.googlesource.com/1142200Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#576313}
-
Douglas Creager authored
Per https://github.com/w3c/network-error-logging/pull/90, a NEL report's `url` field now contains the (sanitized) URL of the request that the report describes. (Before that spec update, it was supposed to contain the URL of the page that made the request, which isn't relevant for NEL.) Now that the report contains the "right" URL, the NEL body's `uri` field is redundant, and can be removed. Bug: 748549 Change-Id: Ibd2b0213b829e94329ecc7263baecd549d41e40c Reviewed-on: https://chromium-review.googlesource.com/1141271Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#576312}
-
Boris Sazonov authored
This CL changes strings used in sync_and_services_preferences, changing wording to make the string grammatically correct. It also fixes a typo. Bug: 864791, 864789 Change-Id: I38ee3efb2894562606f6997113aa2d9a81787ef5 Reviewed-on: https://chromium-review.googlesource.com/1142149Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576311}
-
Mike Wasserman authored
Make test_ws implement ServiceFactory and package the ui service. Bind a ws2::WindowService instance to requests for the ui service. Bind test WindowTreeHostFactory requests in WindowService's registry. Have the test suites use test_ws + ui services instead of test_wm. Add a TestGpuInterfaceInterfaceProvider with stub binding functions. (that and an EventInjector registration placeholder prevent crashes) Move shadow elevation property registration to ws2::WindowService. Disable some broken mus-only tests, early return if IsMus from some others. Remove the old ws service_unittests (catalog conflict packaging ui service) Bug: 855609 Test: Automated, no regressions. Change-Id: I58f65551c9c0e1c734ed4ac752b5219ecbead0db Reviewed-on: https://chromium-review.googlesource.com/1138749 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
