- 15 Oct, 2018 40 commits
-
-
Justin Cohen authored
Although ContentSuggestionsViewController has been presented as a proper view controller for a while now, it has still used the CRWNativeContent methods wasShown and wasHidden to manage some state. As CRWNativeContent for the NTP will be going away, stop using this methods and instead use normal UIViewController state methods. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I64c3f3aebddd4590d71e0edea927f306c63bb542 Reviewed-on: https://chromium-review.googlesource.com/c/1280048 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599702}
-
Justin Cohen authored
When kBrowserContainerPresentsNTP is enabled, bypass CRWNativeContent and instead present the NTP directly and return nil to ios/web. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I373f43dfe02b3242c87fe997b97238c824bda116 Reviewed-on: https://chromium-review.googlesource.com/c/1280047 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599701}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. Bug: 842194 Change-Id: I0d635e46bbaf3f9cfb7d5083445319c341c0cb76 Reviewed-on: https://chromium-review.googlesource.com/c/1245861Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#599700}
-
Robert Ogden authored
This is a manual workaround so that HTTPS Server Previews can be team fooded in 71 and will need to be merged back into the M71 branch. This checks if the user is on a preview page and is reloading via clicking the "load original" UI and if so, loads the orignal page. Bug: 864187 Change-Id: I2c8ed4edba98f30f398675c38d7f89d3848a0212 Reviewed-on: https://chromium-review.googlesource.com/c/1280853Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#599699}
-
Dmitry Gozman authored
These are helpers to retrieve resources from the bundle. We better place them together. Bug: none Change-Id: I7613c84f7b36872b2fc8ed01e7a57e66e309f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/1278958 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599698}
-
Aaron Leventhal authored
The accessible tree was not being updated when layout tree included nodeless objects, which are used to parent inline objects when they have block siblings. This fixes the closest node logic used to find a node for a layout object or layout ancestor. Bug: 895183 Change-Id: Iec46a5d97f60137a35350a9c4a5c89d45056a9a0 Reviewed-on: https://chromium-review.googlesource.com/c/1280789Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599697}
-
Andrey Kosyakov authored
- enable cookie encryption by default (use --disable-cookie-encryption to turn it off); - configure OSCrypt iff cookie encryption is enabled and profile path is set (there was a bug there, but it was masked by cookie encryption being disabled); - properly configure SSL channel id storage; - use mock keychain on MacOSX Bug: 864744 Change-Id: Ice97864bb80d8988e3e090310b35c509031a8e7d Reviewed-on: https://chromium-review.googlesource.com/c/1274199Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599696}
-
Greg Kerr authored
This reverts commit 8f0c72bc. Reason for revert: Blocking canary signing. Original change's description: > macOS: Remove keychain reauthorizing logic. > > The keychain was re-authorized to support Chrome's new signing > certificate 18+ months ago. At this point, users who haven't re-launch > Chrome in 18 months are unlikely to do so, or need the keychain. This > removes the re-authorization code. > > Bug: 893729 > Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1 > Reviewed-on: https://chromium-review.googlesource.com/c/1271935 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599341} TBR=avi@chromium.org,kerrnel@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893729, 895202 Change-Id: I3a82d2485307e1c3a0702fc486efbe5d1e7a8a7d Reviewed-on: https://chromium-review.googlesource.com/c/1280855Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599695}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79b914075cc5..bbd532d164f0 git log 79b914075cc5..bbd532d164f0 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 jsaarhelo@nvidia.com Fix querying large vertex attrib divisors Created with: gclient setdep -r src/third_party/angle@bbd532d164f0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2a4cb23466ace0df4b3819222cb8a81b912f0520 Reviewed-on: https://chromium-review.googlesource.com/c/1281023Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599694}
-
Xiaoqian Dai authored
When a dialog is added to a window that's currently showig in splitscreen, we should adjust the dialog bounds to show the dialog aligned within its own side of the split, rather than across the divider bar. Note the divider is still placed on top of the snapped windows and its transient children if they are placed in default container. Bug: 878268 TBR=xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1274197 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598827} Change-Id: I3e7377c053d14fcf3fd882abff2f860a88a61332 Reviewed-on: https://chromium-review.googlesource.com/c/1280674Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599693}
-
Morten Stenshorne authored
We incorrectly thought that we had no lines, because we looked for legacy line boxes. Changed the test to a testharness test, because the text dump has some space differences between NG and legacy. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic2ff3b44e222475fcb07700e99f2f0a965fb72ad Reviewed-on: https://chromium-review.googlesource.com/c/1280546Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599692}
-
Fredrik Söderquist authored
The former looks like an open-coded version of the latter. Using the latter will be more consistent (and future-safe.) Change-Id: I3353d0181201df681779575d78fe0df22065a9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1280447Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#599691}
-
Justin Cohen authored
In preparation to make the NTP a contained view controller of the BVC, add helper classes to track activating and deactivating the NTP from a tab helper. Currently the NTP is displayed as native content within the web content area via CRWNativeContent. Rather than go thru ios/web for a native page, instead create and use a new NTP tab helper and display the NTP directly from within ios/chrome. Historically the NTP has been a collection of fake view controllers predating view controller containment. While much of the NTP hierarchy has been updated, this will be the final change required to have a normal NTP presentation with normal UIViewControllers. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8517c0231dbfdf42185a7d82ce4ca009e9002bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1280046 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4f5ccaaecd7e..7c39bf7b87f8 git log 4f5ccaaecd7e..7c39bf7b87f8 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 thestig@chromium.org Make FlateEncode()'s buffer out parameter a unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@7c39bf7b87f8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb6b7074406174b6382c505367ab9ce6e3fc7889 Reviewed-on: https://chromium-review.googlesource.com/c/1281022Reviewed-by:
-
chrome://process-internalsNasko Oskov authored
Bug: 850087 Change-Id: If9f76424b0c2574c67e2a1ed24f3029dfbd798c6 Reviewed-on: https://chromium-review.googlesource.com/c/1268658Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599688}
-
Chan authored
TBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I149449fe0f847f23edc5b0565c76c5ace3c79afd Reviewed-on: https://chromium-review.googlesource.com/c/1281049Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599687}
-
Wei Li authored
UI DevTools have been out of sync with platform DevTools protocol. This will cause some runtime errors due to protocol incompatibility. This CL updates UI Devtools' protocol and corresponding handling code. For protocol update, we update the domain fields and its properties according to browser_protocol.pdl. We also arrange the order to put the name or id at the first, and use consistent order across different fields to make it more readable and easier for future updates. BUG=894623 Change-Id: Ic650c126155044d2e25c4ff068c5a7a17144584f Reviewed-on: https://chromium-review.googlesource.com/c/1277835Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#599686}
-
Jun Mukai authored
The following tests are flaky only on SingleProcessMash. BUG=895070, 895110, 895068 TEST=None TBR=sky@chromium.org Change-Id: I38c1ce550e00472933dbd16fcddec1d6b7af0e54 Reviewed-on: https://chromium-review.googlesource.com/c/1280854Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599685}
-
Lindsay Pasricha authored
Bug: 828031,850125 Change-Id: If24779bb6387cdf06fa2936f3deb2a86ddbe7f3e Reviewed-on: https://chromium-review.googlesource.com/c/1280788 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599684}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03da150665d9..9f274436bd0d git log 03da150665d9..9f274436bd0d --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: partially remove Rietveld support for uploading code. Created with: gclient setdep -r src/third_party/depot_tools@9f274436bd0d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: I64d34ef394a89cf80ad7604f7685c1c6d3b143fd Reviewed-on: https://chromium-review.googlesource.com/c/1280420Reviewed-by:
-
Valeriya Sinevich authored
If PerformSetCookiesAction(...) was called then is_reconcile_started is true and Schedulereconcile.. will return directly. Otherwise it will already be called inside OnSetAccountsInCookieCompleted. Change-Id: I5a849ad4a261fc9ead736792e5639f4e27edd68f Reviewed-on: https://chromium-review.googlesource.com/c/1278815 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599682}
-
Nasko Oskov authored
JavaScript files for WebUI pages in chrome/ already are subject to clang-format, ESLint, and other checkers. This CL is changing all JS files in content/browser/resources/ to be clang-format'd, so a PRESUBMIT rule can be put in place to enforce proper formatting in future commits. PRESUBMIT.py will come separately as part of work to make the process-internals WebUI clang-format and eslint checked in https://chromium-review.googlesource.com/c/chromium/src/+/1268658. Bug: 841000 Change-Id: I22ee7649b3d524d68c5cb2b39a53f057150b181c Reviewed-on: https://chromium-review.googlesource.com/c/1279178Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599681}
-
Ian Kilpatrick authored
This allows web developers to access pre-computed sizes for the border, scrollbar, and padding "edges". This adds two types of tests: 1) Uses the standard "green box" approach of testing the script values match what is expected. 2) Positions four children at each corner (using edges) are positioned the same as using an abs-pos technique. Bug: 726125 Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b Reviewed-on: https://chromium-review.googlesource.com/c/1252776 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599680}
-
Arthur Sonzogni authored
This is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1122629 It makes subframes to stay alive after the navigation commit. Find-in-page needs to stop tracking these frames immediately when they are in pending deletion, not when they are deleted. Bug: 609963 Change-Id: I9c8fa05ec3d571e79ecc22c1609ee59ff90b2b45 Reviewed-on: https://chromium-review.googlesource.com/c/1254262 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#599679}
-
Yoav Weiss authored
When processing multiple Content-DPR headers, the current logic parses all of them as a single float, and understandably, fails in that task. That means that if a server is adding multiple headers (due to configuration error), none of them will be effective, contrary to the RFC. This PR fixes that, copies over relevant tests from internal layout tests to WPT, and adds a test for that issue specifically. BUG=895245 Change-Id: I72b570ad4b1e4db9a2bb03be9d8fb1e3799b902b Reviewed-on: https://chromium-review.googlesource.com/c/1280266Reviewed-by:
-
Anders Hartvoll Ruud authored
The incorrect code style of CSSSyntaxComponent annoyed me: fix by converting to a class and make members private. Change-Id: Ide6d4a007f5c8f9d5c3423576b123a32a53cb396 Reviewed-on: https://chromium-review.googlesource.com/c/1280544Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#599677}
-
Qiyu Hu authored
BUG=b:111367421 TEST=CtsVerifier, not sure whether it verifies anything though Change-Id: I5c3e23cd9958f775ec9ad87580c973fdc3554b89 Reviewed-on: https://chromium-review.googlesource.com/c/1279297Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#599676}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a56b72d4cdcb..4edc5a93c0aa git log a56b72d4cdcb..4edc5a93c0aa --date=short --no-merges --format='%ad %ae %s' 2018-10-15 hidehiko@chromium.org chromite: Add more tast coverage. Created with: gclient setdep -r src/third_party/chromite@4edc5a93c0aa The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8fecdbda7166258e693c7d041b059f5576f7b425 Reviewed-on: https://chromium-review.googlesource.com/c/1280411Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5bc30788fd8a..339d23275d07 git log 5bc30788fd8a..339d23275d07 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 jbolz@nvidia.com Enable precompiled headers for MSVC (#1969) 2018-10-15 33432579+alan-baker@users.noreply.github.com Memory access checks for vulkan mem model (#1909) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@339d23275d07 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iaba11bdd8e69eb12278a585a4e649f0228aff971 Reviewed-on: https://chromium-review.googlesource.com/c/1280414Reviewed-by:
-
kylechar authored
Delete some usage of "namespace test" in components/viz/* that got added back in the year or so since we originally decided to not use it. Bug: 893850 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic4a0c134c6c7dd66d4f1eb89526155111c1f2a10 Reviewed-on: https://chromium-review.googlesource.com/c/1276546 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599673}
-
Scott Violet authored
ArcNotificationContentView adds a pre-target handler, but it never removes it. I'm going to add some DCHECKs to ensure there are no pre-target handlers when an object is destroyed, so this needs to be fixed. BUG=867035 TEST=none Change-Id: I9a0f6ee48a44df5c65ca82db31137a14c7ec66ba Reviewed-on: https://chromium-review.googlesource.com/c/1280848Reviewed-by:
-
Robert Sesek authored
Bug: 832676 Change-Id: Ifbd5d17e8901a9e44f8ff2180459a950648d2fda Reviewed-on: https://chromium-review.googlesource.com/c/1280791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599671}
-
Tibor Goldschwendt authored
This reverts commit 01e91776. Reason for revert: breaks official builds (see crbug/895206). Original change's description: > [bundles] Add getter for whether build is a bundle, activate O split fix > > Add BundleUtils class, which has a method to check whether current build > is a bundle. Use that getter to activate split APK - WebView workaround > for Android O. > > Bug: 889954 > Change-Id: I443584edf8bd55a6c7e2b5d0664dc943466159d4 > Reviewed-on: https://chromium-review.googlesource.com/c/1261969 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599509} TBR=yfriedman@chromium.org,torne@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 889954, 895206 Change-Id: I2dbc1a7073397d26babc4e4238084148651d67df Reviewed-on: https://chromium-review.googlesource.com/c/1280433Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#599670}
-
Ned Nguyen authored
BUG: 894261 Change-Id: Id707ba8a8782a23a41a7dc4680cbc2538e1d3df1 Reviewed-on: https://chromium-review.googlesource.com/c/1278156Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Ben Pastene authored
This reverts commit e767fb51. Reason for revert: crbug.com/895337 Original change's description: > Automated Commit: LKGM 11160.0.0 for chromeos. > > BUG=762641 > TBR=achuith@google.com > > Change-Id: I20f03272b5b8fffca13ebaafac94237c2668ef51 > Reviewed-on: https://chromium-review.googlesource.com/c/1280144 > Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#599586} TBR=achuith@chromium.org,3su6n15k.default@developer.gserviceaccount.com Change-Id: I269fc123a9171afdf0b5077948f7d46b2a226bbd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762641 Reviewed-on: https://chromium-review.googlesource.com/c/1281052Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599668}
-
Scott Violet authored
CastTouchEventGateTest adds a pre-target handler, but it never removes it. I'm going to add some DCHECKs to ensure there are no pre-target handlers when an object is destroyed, so this needs to be fixed. BUG=867035 TEST=none Change-Id: I2b3804ba9a96288d209958af7c8703e99732d32b Reviewed-on: https://chromium-review.googlesource.com/c/1281044Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599667}
-
tzik authored
The move ctor of NGExclusionSpaceInternal has `noexcept` keyword on its declaration, but doesn't have it on its definition. That causes a compile error on the C++17 mode build. This CL adds `noexcept` to the definition too. Plus, adds `noexcept` to move assignment for the consistency. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I16f7f69f6d0a7f513659f57f131aee1e4d7414af Reviewed-on: https://chromium-review.googlesource.com/c/1280083Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599666}
-
Jialiu Lin authored
Since many people may be using incognito to browse "sketchy" sites, we'd like to detect sync password reuse in incognito profile. Meanwhile, this CL also makes sure Chrome don't leak any browsing history related data to the original profile. More specifically, for incognito profile: 1. Chrome will send PhishGuard password reuse ping to SB backend: -Anonymous ping, same behavior as in regular profile. 2. show model warning if the returned verdict is PHISHING or LOW_REPUTATION -same behavior as in regular profile. 3. Chrome will NOT cache verdicts 4. Chrome will NOT show the change password card in chrome://settings 5. Chrome will NOT set user at-risk. Change-Id: Iac0a7872d79438e8204b8fc24eba6d8d1201e606 Bug: 893715 Reviewed-on: https://chromium-review.googlesource.com/c/1277815Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#599665}
-
Katie Dillon authored
Adding perf tests for transferable data. Measures sending transferable data to a worker from the main thread, from the main thread to a worker, and the roundtrip time. Transferable data for this test is an image represented as an array buffer. Change-Id: Ie9f05a5301398b2f11677a2a57c985992b64541a Reviewed-on: https://chromium-review.googlesource.com/c/1275365Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#599664}
-
Avi Drissman authored
There was a Cocoa and MacViews version with a common superclass; this removes the Cocoa version and folds the superclass into the MacViews subclass which is the only one that remains. This also reverts 027233cd as that hack was only needed while we linked against the 10.10 SDK and we no longer do so. BUG=891699 Change-Id: Iefdd30268f1e0b52ee1ecd71bdb252e5b8b5c631 Reviewed-on: https://chromium-review.googlesource.com/c/1277578 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#599663}
-
