- 30 Oct, 2019 40 commits
-
-
Michael Lippautz authored
- Virtual Visit methods are always called through base class Visitor using Trace methods. There's no need to keep them in the header file. - Drive-by: Move inlined definitions out-of-line to allow skimming the class header more easily. - Only mark definition as inline as this is an implementation detail. Change-Id: I44993d515eb18498105b0e592e282fcd536c82ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884731Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710688}
-
Eric Willigers authored
The code in app_browser_controller.cc is within the web_app namespace, so qualifying names with 'web:app::' is redundant. Change-Id: I8852005ec93db644aa9034115d5f6dcafe2f9ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888238 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#710687}
-
Jason Lin authored
Bug: 951132 Test: Enable ChromeVox and open Crostini Installer from settings Change-Id: I703d77cc91177b048f5de0fafdee783611288f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885144Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#710686}
-
David Munro authored
Flag is currently disabled by default, if toggled on it means that enabling linux will install a Debian Buster container instead of a Debian Stretch one. Doesn't affect the default container you get if you start a new container via vmc container start. Bug: chromium:930901 Test: Enable Linux with flag set, cat /etc/os-release to confirm buster Change-Id: I40dea30b019e13301abf081696584162f6a1a7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883351 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#710685}
-
Darin Fisher authored
This is a precursor to defining ContentSettingsType via mojom. That change will require more work as Clank depends on an Java definition of this type that is auto-generated from content_settings_types.h. Change-Id: Ieec565c6332528e6fc5112ad04c675d9b6137f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885973Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb5cf40a8b13..a660eacc675c Created with: gclient setdep -r src-internal@a660eacc675c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie9d482705fae13118b66bfecf15f31ca1c12e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710683}
-
Jinsuk Kim authored
The only caller of these methods is ChromeActivity class. This CL folds them into the call site. Bug: 995903 Change-Id: If11c291d8c366f173fbcb02e8dba5bb81dc5b29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884397Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710682}
-
Anand K. Mistry authored
SmbFs is a FUSE-based filesystem that provides access to SMB file shares. It will have similar capabilities to DriveFs, such as server-side copies, hence the need for a new filesystem type. Bug: 939235 Change-Id: Ibbc21a3211013259a715a9e07760d8050b7bda97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885850Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#710681}
-
Gavin Williams authored
-Creating a new ARIA specific string for the Browse button as the text already displayed next to the button($i18n{selectDriver}) would not make sense spoken out loud. Bug: 987087 Change-Id: I00a3d28672b0ffb85ddc00b49b605975b5e5b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869478Reviewed-by:Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#710680}
-
Manas Verma authored
Logging the number of times an UpdateAutofillUserPreference call is made to payments with the intention to switch opt-in status. Bug: 949269 Change-Id: I97c4c907079b7d953b4fc0104ca093777a84dbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867411 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710679}
-
Yoshifumi Inoue authored
This patch changes |NGCaretPositionTest| to utilize |NGInlineCursor| instead of |NGPaintFragment| and |NGPhysicalTextFragment| for prepration of migrating to |NFragmentItem|. Bug: 982194 Change-Id: I0bba9a20e4ff9150d65632f5c30892c43cf54887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888622 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710678}
-
Yoshifumi Inoue authored
This patch changes |InspectorCSSAgent::CollectPlatformFontsForLayoutObject()| to utilize |NGInlineCursor| for preparation of migration to |NGFragmentItem|. Bug: 982194 Change-Id: Id8550ce0d70def5b1eb1f7d442e0e97152cc7fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880360 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alex Danilo authored
Adds support for showing an error indication marker on the summary panel when a display panel contains a mixture of progress panel items and error panel items. Enables a summary panel that shows an error indicator in the case where there are multiple error panel items hosted by the display panel but there are no progress panel items hosted. Adds unit test to cover these cases and implements a convenience function removeAllPanelItems() to clear out all panel items hosted in a display panel. Bug: 1014771 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I86047d47cb666f069cbe9260504f100d4a63e733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888233 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710676}
-
Shik Chen authored
The i18n process is changed after CCA is migrated as an component app, so update_locales.py is not used now. Bug: 1019581 Test: None Change-Id: Ieefd4ad9ac22df0254e3f3218faca0c0cf3b3b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888237Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#710675}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. A browser end-to-end tests will be added later in a follow up CL. An MVP implementation of the bridge+sync needed first. This is a reland of original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 Patchset#1 is the original CL, rebased. The unit test fix: the offending EXPECT check was removed. TEST_F(WebAppIconGeneratorTest, GenerateIcons) { ... EXPECT_EQ(letter_color, icon_info.data.getColor(center_x, center_y)); ... } Will add it back later in a follow up CL. TBR=alancutter@chromium.org, mpearson@chromium.org Bug: 860583, 1019102 Change-Id: I1e3b514de303429ee774121f31d131139bb6a817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888234Reviewed-by:
-
Marina Sakai authored
In the previous CLs, we replaced all the old GetSymbol(), which uses void* as a key, with the new GetSybmol(), which uses an instance of SymbolKey. So, this CL removes the unused old GetSymbol(). Bug: 715418 Change-Id: I465370f55ed07632c6f4d00804733c3c49aaab43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888858Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#710673}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ae54bc22fc2..c3a51a5e47ba git log 1ae54bc22fc2..c3a51a5e47ba --date=short --no-merges --format='%ad %ae %s' 2019-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f8f6103eb89f..e1cda3916cee (2 commits) Created with: gclient setdep -r src/third_party/skia@c3a51a5e47ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I7d87c7f2fddc0bf3e3b81fe5cf73f16ac0585eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710672}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/082b92e5..80c3ae49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibd28b4f8e9b4f0f7da8f2f27ff37815c3adc87fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889014Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710671}
-
Keith Lee authored
Update files to prevent the following presubmit warning: ** Presubmit Warnings ** Found updated extension api files without updated extern files. Please update the extern files. /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json *************** To update the externs, run: src/ $ python tools/json_schema_compiler/compiler.py /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json --root=. --generator=externs > /usr/local/google/home/keithlee/chromium/src/third_party/closure_compiler/externs/input_method_private.js *************** Change-Id: I8ad20550dfe9acc233e4e437740739b7b1b744f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886137Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710670}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e4dbf3f6432..27bd4e420d28 git log 1e4dbf3f6432..27bd4e420d28 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 ukai@google.com Reland "put goma client in depot_tools" Created with: gclient setdep -r src/third_party/depot_tools@27bd4e420d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: Ife9346d3e73348136114531bc1bc29475a5b0ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889331Reviewed-by:
-
Adam Rice authored
KURL::SetHostAndPort would corrupt IPv6 literals because they contain ":" characters. Make it check for "[]" characters and use the first ":" after an IPv6 address as the start of the port number if one is present. Fixed: 1012416 Change-Id: If07a671b48c8c1b24b16883fb9072a86b0de7ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871449Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710668}
-
Wei Lee authored
chromeosInfoPrivate API We already have the prod key of Chrome Camera App in the whitelist and we also need to add the dev key into it so that the behaviors of prod version and dev version would be identical. Bug: 1019094 Test: None Change-Id: I58921b49c21579db41ebed39bb182443efa84368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886140 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710667}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6c3f862e2a3..87a7b82520b8 git log c6c3f862e2a3..87a7b82520b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 peah@webrtc.org Refactoring of the noise suppressor and adding true multichannel support Created with: gclient setdep -r src/third_party/webrtc@87a7b82520b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/143344262 Change-Id: Ieefc70f1d6fab0e5c8e8698eeb92d57f9f616851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889301Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bc1a479a7027..2cbe458ddd0e git log bc1a479a7027..2cbe458ddd0e --date=short --no-merges --format='%ad %ae %s' 2019-10-30 andrewlamb@chromium.org Include ReplicationConfig in chromite protos. Created with: gclient setdep -r src/third_party/chromite@2cbe458ddd0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I20ab952c6dcb1d78cf034b26a7d660b3489a5dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889302Reviewed-by:
-
Peter Kasting authored
Also replaces bare new with make_unique. Bug: 82078 Change-Id: I2c189d65fab3cee98297f32aa1454ac0f4555453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881942 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This was broken due to a subtle bug introduced the original CL (*). The only field on AncestorInfo which was accessed before it was set for a PaintLayer is last_overflow_clip_layer. This was used for invalidation logic regarding sticky-positioned elements. It's necessary for last_overflow_clip_layer to be the last overflow clip layer seen *before* considering the current PaintLayer. Hence it should not be updated in ApplyAncestorInfoToSelfAndAncestorsRecursively for a compositing inputs root that is not the root, for the PaintLayer that is not the CompositingInputsRoot. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1432155 Test: fast/css/containment/compositing-inputs-root-sticky-crash.html Bug: 986008 Change-Id: I79c84c01999ebe483440fdc3cac277a7f5eb226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857372 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710663}
-
Jiawei Shao authored
This patch adds an enum DawnReturnDataType before the return data from the server side of WebGPU command buffer to the client side. This enum will be used as a flag to specify different type of return data received in the client side of WebGPU command buffer. Currently we only support kDawnCommands, and we will support more kinds of the return values in the following patches. BUG=chromium:996713 Change-Id: I99f65a0b91808cea52728ea10b408c4ee9649d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877907 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eeaad1a5bde..fb5cf40a8b13 Created with: gclient setdep -r src-internal@fb5cf40a8b13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Icf2d29e039686cebeb99b76890067f1bd44a6f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889290Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for VideoDecodeStatsRecorder from comments. Bug: 955171 Change-Id: I3f7bc76f87872773fc7840a78a04d086687789ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883154 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710660}
-
Darin Fisher authored
Introduces NetworkHintsHandler mojom interface as part of //components/network_hints/. This interface is used by the renderer to send hints to the browser. A simple browser- side implementation is provided in //components/network_hints/browser/, which is only used by chromecast. Chrome provides a more sophisticated implementation as part of //chrome/browser/predictors/. Bug: 967834 Change-Id: I8c3c690e3897a950f95c96defdfad2429520d140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881967Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710659}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/87fb5cb2..082b92e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab8d79adb4e6786f120f307fe7a64fe70caabf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889013Reviewed-by:
-
Fergal Daly authored
Attach https://crbug.com/1019077 to the entry in the filters. R=rakina@chromium.org Change-Id: I8aa50cbb9e4fb76eeaf7989a98c6521ff4d12570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885861Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#710657}
-
Robert Sesek authored
Bug: 977637 Change-Id: I46198e40724c0985c2a59b7ac7ebeb1479f286d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888714Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710656}
-
Nate Fischer authored
No change to production logic. This adds tests for already-implemented UMA proto fields. This intentionally skips fields which don't apply to Android OS (ex. os.is_jailbroken, os.arc, os.kernel_version). Bug: 1011991 Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* Change-Id: I35fe2b75164a421a9a5dbc80df621f75ec9b5474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889171 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710655}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: If05a835c62dbb81850b4e0ba3a9a96f606adc2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884366Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710654}
-
Jinsuk Kim authored
Moves the Tab's public API to TabWebContentsDelegateAndroid. - Access from native (TabAndroid::IsCurrentlyACustomTab) is routed to TWCDA. - For the access from Java (externalnav/), ExternalNavigationDelegate is given an interface method |isOnCustomTab|. This is false by default, overriden by CustomTabNavigationDelegate to replace the reference to the deleted API. - Tests uses TabTestUtil (now moved to test support target to make itself available for CustomTabActivityTestRule) to access TWCDA. Bug: 995903 Change-Id: Ie8ef46ef739005de94f990da5ffc7dabf640ec43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880359 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710653}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7146c8fa. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idd6fd11aaf912faf333b3a191425f28b9d2b0dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e662695654ff..1ae54bc22fc2 git log e662695654ff..1ae54bc22fc2 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 csmartdalton@google.com Add sampleVariablesStencilSupport to sksl standalone caps 2019-10-29 mtklein@google.com work around x11/X.h #define pollution 2019-10-29 halcanary@google.com BotsCfg/Perf/RemoteGlyphCache: bots to download and use traces 2019-10-29 nigeltao@google.com Have SkWuffsCodec use two Wuffs decoders Created with: gclient setdep -r src/third_party/skia@1ae54bc22fc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Ieb1268182cfd7aca8c7b3489238fb143fc92132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889051Reviewed-by:
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I0d9241a98c12470a95a772a5d9d59da33a3aae65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888615Reviewed-by:
-
Hiroki Sato authored
This CL adds buttons to set all event stream logging to on or off in ChromeVox Developer option. Bug: None Test: manual Change-Id: If28b6c03427bf2c9a1109346bc79aa601eb2ad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880212Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#710649}
-
