GitLab

In particular:
- when hovering or pressing the thumb, repaint only the thumb
- when thumb position changes, repaint the track only if it changes
  (e.g. due to a button being disabled upon reaching the end)

BUG=549277

Review URL: https://codereview.chromium.org/1525803002

Cr-Commit-Position: refs/heads/master@{#367082}

Reland of Change extension icon load errors to warnings (patchset #2 id:300001 of https://codereview.chromium.org/1554583002/ )

Reason for revert:
this revert managed to break the tree

Original issue's description:
> Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ )
>
> Reason for revert:
> file read from wrong thread
>
> Original issue's description:
> > Change extension icon load errors to warnings
> >
> > During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary.
> >
> > Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake.
> >
> > BUG=570249
> >
> > Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> > Cr-Commit-Position: refs/heads/master@{#366253}
>
> TBR=rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=570249
>
> Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
> Cr-Commit-Position: refs/heads/master@{#367080}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Review URL: https://codereview.chromium.org/1547413002

Cr-Commit-Position: refs/heads/master@{#367081}

Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
>
> During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary.
>
> Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake.
>
> BUG=570249
>
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Review URL: https://codereview.chromium.org/1554583002

Cr-Commit-Position: refs/heads/master@{#367080}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b238476a..3a2f751e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1550293002

Cr-Commit-Position: refs/heads/master@{#367079}

This should have not been committed in r366657, but it was not removed
during the rebase.

BUG=None
TEST=ninja

Review URL: https://codereview.chromium.org/1546343002

Cr-Commit-Position: refs/heads/master@{#367078}

BUG=

Review URL: https://codereview.chromium.org/1546263002

Cr-Commit-Position: refs/heads/master@{#367077}

Add a method to check whether a BrowserState has an ActiveStateManager
to avoid unnecessary object creation during shutdown.

BUG=569515

Review URL: https://codereview.chromium.org/1547393002

Cr-Commit-Position: refs/heads/master@{#367076}

TBR=sergeyu@chromium.org
BUG=572936
NOTRY=true

Review URL: https://codereview.chromium.org/1556503002

Cr-Commit-Position: refs/heads/master@{#367075}

Another attempt at https://codereview.chromium.org/1406163003.

Sometimes when we remove a child we end up with a float or out-of-flow object beside
an anonymous block. When that happens, fold the float/out-of-flow object into the
anonymous box as that is where it would have lived if they were siblings in the
first place.

BUG=322039

Review URL: https://codereview.chromium.org/1543283002

Cr-Commit-Position: refs/heads/master@{#367074}

BUG=82385
TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/1550173003 .

Cr-Commit-Position: refs/heads/master@{#367073}

BUG=571940
TEST=manual

Review URL: https://codereview.chromium.org/1544243002

Cr-Commit-Position: refs/heads/master@{#367072}

Keep the Shutdown method as removing it will require some downstream
refactoring first.

BUG=560854

Review URL: https://codereview.chromium.org/1547403002

Cr-Commit-Position: refs/heads/master@{#367071}

Revert of WebGL 2: generate appropriate error for different dimensions of images attached to fbo (patchset #1 id:1 of https://codereview.chromium.org/1549393002/ )

Reason for revert:
This broke the WebglConformance.conformance2_rendering_draw_buffers test on mac.

Original issue's description:
> WebGL 2: generate appropriate error for different dimensions of images attached to fbo.
> This change fixed the bug in framebuffer-object-attachment.html
>
> BUG=295792
> TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
>
> Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
> Cr-Commit-Position: refs/heads/master@{#367053}

TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=295792

Review URL: https://codereview.chromium.org/1555543002

Cr-Commit-Position: refs/heads/master@{#367070}

Revert of tcmalloc: Use C++11 atomics where appropriate. (patchset #8 id:140001 of https://codereview.chromium.org/1549913002/ )

Reason for revert:
Caused performance problems (see http://crbug.com/572525 and dupes)

Original issue's description:
> tcmalloc: Use C++11 atomics where appropriate.
>
> Ports these CLs to tcmalloc:
> https://codereview.chromium.org/636783002/
> https://codereview.chromium.org/1466833002/ (except mac)
>
> No intended behavior change, but it should remove
> the static initializer in atomicops_internals_x86_gcc.h
> on Linux.  It's also less code.
>
> BUG=94925,559247
>
> Committed: https://crrev.com/e13537fe418eff11d3cab9077f6a647d7c74f103
> Cr-Commit-Position: refs/heads/master@{#366904}

TBR=jfb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=94925,559247

Review URL: https://codereview.chromium.org/1557433002

Cr-Commit-Position: refs/heads/master@{#367069}

The test started failing downstream with merge 363378. Disable the test
upstream too (was disabled downstream as part of said merge).

BUG=567736

Review URL: https://codereview.chromium.org/1550143002

Cr-Commit-Position: refs/heads/master@{#367068}

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove std::move call here
  return std::move(response);
         ^~~~~~~~~~

..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka

Review URL: https://codereview.chromium.org/1552613003 .

Cr-Commit-Position: refs/heads/master@{#367067}

Revert of linux: Lower static initializer expectations after https://codereview.chromium.org/1549913002 (patchset #3 id:40001 of https://codereview.chromium.org/1545273002/ )

Reason for revert:
Prerequisite for reverting https://codereview.chromium.org/1549913002

Original issue's description:
> linux: Lower static initializer expectations after https://codereview.chromium.org/1549913002
>
> BUG=94925
> TBR=thestig@chromium.org
>
> Committed: https://crrev.com/9bf22f89802e62ca16c8e7f2a3b34689ba71add0
> Cr-Commit-Position: refs/heads/master@{#366908}

TBR=thestig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=94925

Review URL: https://codereview.chromium.org/1548423002

Cr-Commit-Position: refs/heads/master@{#367066}

Revert of Force clang/tot bots to do clobber builds of clang for a bit. (patchset #1 id:1 of https://codereview.chromium.org/1546323004/ )

Reason for revert:
Every tot bot should have cycled with this by now.

Original issue's description:
> Force clang/tot bots to do clobber builds of clang for a bit.
>
> Apparently cmake doesn't like it if the compiler changes like it did in
> https://codereview.chromium.org/1555443002/ without a clobber build.
>
> Since this might help with issue 569337 too (who knows), do it everywhere
> for a short while instead of just on linux.
>
> BUG=509739,569337
> TBR=hans
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1c0fd1fac8ee649f5da00473e5d88565ea3ae930

TBR=hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509739,569337

Review URL: https://codereview.chromium.org/1554573002

Cr-Commit-Position: refs/heads/master@{#367065}

This patch changes SVGInlineTextMetricsIterator to keep an instanace of
LineLayoutSVGInlineText, not a pointer to. LineLayoutItem and its
subclasses are oftentimes allocated on stack that keeping pointers
should be avoided.

Additional ASSERTs in this CL fail existing tests. These existing tests
cover the fix.

BUG=572399, 499321

Review URL: https://codereview.chromium.org/1547263002

Cr-Commit-Position: refs/heads/master@{#367064}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56ce1b39..b238476a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1548413003

Cr-Commit-Position: refs/heads/master@{#367063}

Almost all consumers use already scoped_ptr
and one place is much simpler when changed to use scoped_ptr.

Review URL: https://codereview.chromium.org/1549483004

Cr-Commit-Position: refs/heads/master@{#367062}

The correct capability for v4l2 devices should be V4L2_CAP_VIDEO_M2M_MPLANE.
V4L2_CAP_VIDEO_CAPTURE_MPLANE and V4L2_CAP_VIDEO_OUTPUT_MPLANE will be
deprecated. Nyan doesn't report V4L2_CAP_VIDEO_M2M_MPLANE yet. So check
both capabilities in V4L2VDA and V4L2VEA.

BUG=chromium:572132
TEST=Run tests on nyan, peach, and veyron.

Review URL: https://codereview.chromium.org/1554543002

Cr-Commit-Position: refs/heads/master@{#367061}

Cr-Commit-Position: refs/heads/master@{#367060}

https://chromium.googlesource.com/skia.git/+log/636270245fb4..8895b72f789e

$ git log 636270245..8895b72f7 --date=short --no-merges --format='%ad %ae %s'
2015-12-28 mtklein Try using std::call_once

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1550263002

Cr-Commit-Position: refs/heads/master@{#367059}

Linux desktop gcc build is failing with below error:
In file included from ../../chrome/browser/ui/webui/interstitials/interstitial_ui.cc:12:0:
../../chrome/browser/safe_browsing/safe_browsing_blocking_page.h:143:16:
error: ‘safe_browsing::SafeBrowsingBlockingPageTest_MalwareReportsToggling_Test’
is already a friend of ‘safe_browsing::SafeBrowsingBlockingPage’ [-Werror]
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,

../../chrome/browser/safe_browsing/safe_browsing_blocking_page.h:143:87:
error: ‘safe_browsing::SafeBrowsingBlockingPageTest_DISABLED_MalwareReportsToggling_Test’
is already a friend of ‘safe_browsing::SafeBrowsingBlockingPage’ [-Werror]
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,

../../chrome/browser/safe_browsing/safe_browsing_blocking_page.h:143:167:
error: ‘safe_browsing::SafeBrowsingBlockingPageTest_FLAKY_MalwareReportsToggling_Test’
is already a friend of ‘safe_browsing::SafeBrowsingBlockingPage’ [-Werror]
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,

Android build had no issues.

BUG=NONE
TESTS=NONE

Review URL: https://codereview.chromium.org/1551583002

Cr-Commit-Position: refs/heads/master@{#367058}

The resource strings are needed only for the setup app and unit tests. Previously they were also linked into Chrome.

This clarifies the usage and renames the targets to force you to pick (previously the naming encouraged you to link to the strings, which is probably not correct for most cases.

Review URL: https://codereview.chromium.org/1545803002

Cr-Commit-Position: refs/heads/master@{#367057}

Use scoped_ptr in Files because then we can make it simpler and
everything get always deleted. Also
removed unused clone function.

Review URL: https://codereview.chromium.org/1548293002

Cr-Commit-Position: refs/heads/master@{#367056}

blink::Animation can loose compositorPlayer if Animation::m_content detached via
Animation::setEffect(nullptr)

If KeyframeEffect::cancelAnimationOnCompositor wants to clear m_compositorAnimationIds
then it shouldn't crash.

Also, note the existing comment in CompositorAnimations::cancelAnimationOnCompositor (above changed lines)

BUG=571504
R=dstockwell@chromium.org

Review URL: https://codereview.chromium.org/1543143002

Cr-Commit-Position: refs/heads/master@{#367055}

BUG=554269

Review URL: https://codereview.chromium.org/1544783002

Cr-Commit-Position: refs/heads/master@{#367054}

This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Review URL: https://codereview.chromium.org/1549393002

Cr-Commit-Position: refs/heads/master@{#367053}

Continue the refactoring from https://codereview.chromium.org/1504083002
by moving most of the detail in this function to helper functions. This
makes the behaviour of the function more explicit - namely a loop that
skips over non-whitespace and/or collapsible whitespace but returns early
if it encounters a soft or hard line-breaking opportunity.

BUG=567080

Review URL: https://codereview.chromium.org/1536443002

Cr-Commit-Position: refs/heads/master@{#367052}

This is a partial revert of:
https://codereview.chromium.org/1449953002

Most of that CL is inactive code, but it did change the way the
compositor thread was created. Instead of a base::Thread, I'd used a
WebThreadImplForWorkerScheduler and this seems to have had some
performance impact. While I try to figure out why, this CL should get
us back to our prior performance.

BUG=565789

Review URL: https://codereview.chromium.org/1550093002

Cr-Commit-Position: refs/heads/master@{#367051}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1553493002

Cr-Commit-Position: refs/heads/master@{#367050}

This reverts commit 83557154.

BUG=553569

Review URL: https://codereview.chromium.org/1538473002

Cr-Commit-Position: refs/heads/master@{#367049}

Cr-Commit-Position: refs/heads/master@{#367048}

Review URL: https://codereview.chromium.org/1547283002

Cr-Commit-Position: refs/heads/master@{#367047}

Previously, if a linearized PDF was loaded in a single callback (i.e. if
IsDocumentComplete was true in the call to LoadDocument), only the first
page of the document was visible because FPDFAvail_IsPageAvail was never
called for all other pages. This has been corrected.

BUG=572655

Review URL: https://codereview.chromium.org/1552603002

Cr-Commit-Position: refs/heads/master@{#367046}

After John's work in crbug.com/560559, telemetry project no longer depends
on pylib, hence tools/perf which is a user of telemetry must specify this
deps explictly.

BUG=572700, 560559
TBR=jbudorick@chromium.org

Review URL: https://codereview.chromium.org/1556463002

Cr-Commit-Position: refs/heads/master@{#367045}

(╯^□^)╯︵ ❄☃❄

BUG=557422
R=avi@chromium.org
TBR=lcwu@chromium.org

Review URL: https://codereview.chromium.org/1553503002

Cr-Commit-Position: refs/heads/master@{#367044}

std::move is not needed when returning local variables. This wasn't
caught in the initial commit because only Windows builds //third_party
with -Wall.

BUG=82385
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1549373004

Cr-Commit-Position: refs/heads/master@{#367043}