- 29 Oct, 2020 40 commits
-
-
Yue Li authored
Bug: b/169453041 Test: Run existing tests Change-Id: I85a2c447098602ddb6b5734af5b1bb05c343d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504596Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#822024}
-
manukh authored
Bug: 1062446 Change-Id: Ia983fd212354e0161f2a3f637b2fda2aa8e11ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505895 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#822023}
-
Thomas Guilbert authored
MediaStreamVideoSinks may disconnect from a MediaStreamVideoTrack in response to a OnReadyStateChanged() nofitication. This can lead to an invalid iterator if the sinks disconnect synchronously. This CL fixes the issue by iterating over a copy of sinks instead. Bug: 1143213 Change-Id: I71fc43696d6b239f0bc4668b85474dc713e674b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505552 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#822022}
-
Sven Zheng authored
This mainly gives me the ability to use resultdb to do some analysis because experimental steps are not stored. crbug.com/1115614. Bug: 1111979 Change-Id: Ie185dadc54d36ec6d2815652290806f477fb0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505726Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822021}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45c5d9f3ebea..5a566e7c6849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1117343,chromium:1140148 Tbr: patricialor@google.com Change-Id: Id54431127130d714d92cb68e0705a6872c531d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506387Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822020}
-
Gavin Williams authored
This change creates the basic structure of the 'Scan To' dropdown responsible for choosing the directory to save completed scans. This iteration will only have one option defaulted to the 'My files' directory and the follow up CL will let the user choose the directory through the select dialog. 'My files' needs to be created as separate string for displaying because the underlying filepath is always "../../MyFiles". Screenshot: http://screen/AZ6RRV9pPGUKEsN Bug: 1059779 Change-Id: I3f6ebff75c9a81ca8ed13c8d8cd49f5346978cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503854 Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#822019}
-
Jaeyong Bae authored
This patch means using font that allows to distinguish otherwise indistinguishable characters. e.g between O and 0 or l and 1. For this one, fonts that are applied on different platforms: macOS - Menlo Windows - Consolas Chrome OS - DejaVu Sans Mono Linux - DejaVu Sans Mono while Roboto Mono is not among the TextAppearances that Chrome on Android specifies, we can use InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD on the text view to get a similar result. Bug: 768825 Change-Id: I87146a61a8d8d681f04cbe69fd9403327f1c21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490325 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#822018}
-
Chris Whelan authored
On fuchsia, network connectivity does not guarantee that the time has synced. This change adds TimeSyncTracker in order to give fuchsia a means to block global connectivity until this process is complete. Bug: 162553428 Test: Manual Change-Id: Ied2fa293247a860ddc85b62dbbf554abb2c75be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503406 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822017}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15be7eb5cbfb..e40e5df22e17 2020-10-28 bsheedy@chromium.org [typ] Disable typ ResultSink integration If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1143021 Tbr: nuskos@google.com Change-Id: I0b999eb5b024100d246cfd9e798601f59f95cf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822016}
-
Panos Astithas authored
This changeset also adds a Value::DictClear() in order to deprecate DictionaryValue::Clear(). Bug: 646113 Change-Id: I4783407a861edab475aff1a117c8ac86a01b086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434102 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822015}
-
Yu Su authored
5G connection type is not added in network_change_notifier_mac.mm currently. It leads to crash in Cronet when testing 5G network on iOS (b/171830601). Change-Id: I781ef9a253ff0e473fba7eceaf549ef2bc011c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506300 Commit-Queue: Yu Su <yuyansu@google.com> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822014}
-
Hitoshi Yoshida authored
back-send-referrer test assumed that `window.name` refers a same object over same-site navigation including backward navigation. According to an investigation[1], it violates the spec. Chrome's behavior on this point changes if we enable same-site browsing instance swap or backward/forward cache. This CL updates the test to work with BI swap and bf cache. The new test expects to navigate following pages in order of a -> b -> c -> b. When Chromium navigates to b for the first time, its history length is 2 (a and b), but when it navigates back to b again, its history length is 3 (a, b, and c). a: back-send-referrer.html b: back-send-referrer-helper.php c: back-send-referrer-helper.php?x=42 It detects whether showing b with the referrer, which should refer a, and the length of history. [1] https://docs.google.com/document/d/1p7XNboPb-gsQ4d6oOnYbSK3WEwLWzp5DviQFAg-l388/edit# Bug: 1136383, 1132180 Change-Id: I948e6b73cc3956e95481c240b8dd43f9f47dbcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501881Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#822013}
-
Dirk Pranke authored
Currently, when a bot runs a test (say, url_unittests) on a is_chromeos_device build, it'll launch `python test_env.py bin/run_url_unittests` (roughly speaking). This CL flips that around so that the generated bin/run_ wrapper script launches url_unittests via test_env.py (and the bot will invoke bin/run_url_unittests directly). This will make ChromeOS consistent with every platform other than Android; Android will be converted to match as well in a separate CL. Note that apart from the test_env.py inversion, the location of various other command line argument injections is unchanged, so bin/run_url_unittests should run with the same args as before. Bug: 816629 Change-Id: I5d0ac2ed847acb9685b27c41df1ed616311f64a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368537 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#822012}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81a2c08d..cd60eacd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7909d67f796a5155dfb588cd76bb499efa6974ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822011}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603907949-48bee2a7f2855ac438725bf6194390f836d0af96.profdata to chrome-mac-master-1603929441-b6b34c1c4b0f9e2ddac4473f28fe820beebad5c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I61e137ef8c945a87d8d9131b1e7276cbdef540f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506601Reviewed-by:
-
Yuly Novikov authored
Not running any tests at this point. Bug: 1004356 Change-Id: Ibad14747b12121f8abb13dba001d83346f84cc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506459 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#822009}
-
Shik Chen authored
Bug: 1123783 Test: CQ Change-Id: I89fdcae6b7be07326137f2c7cc03c77ac49e7646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505360 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822008}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I317893d9411f5b0888ae696f20dabb333389c25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506611Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822007}
-
Patti authored
This reverts commit f99198c0. Reason for revert: Compile errors due the removal of this function after having reverted https://chromium-review.googlesource.com/q/commit:85415a2c689f29c97626748a688b58c56cc22f16. See crbug.com/1143504. Original change's description: > WebUI: Delete SetupBundledWebUIDataSource() > > With the update of OS settings to generate_grd, this method is no > longer used. > > Bug: 1132403 > Change-Id: Id06f6249b05bebcc72eb22b417d0334bc4d5a708 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505936 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821828} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I308bddd010b80241e99d731a0bfa0989ad655d73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403, 1143504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505359Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#822006}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603907949-21fa2a082049efb8a42fb5e981f107656277e3ad.profdata to chrome-linux-master-1603929441-de7c595584c292110f839d1296c0369f387aa3ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iae1e7d2ce3138a963780c61833a6a3100ea2e038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506600Reviewed-by:
-
Avi Drissman authored
CPU load data isn't kept for simulated processors, so early return if running under Rosetta. Fixed: 1138707 Change-Id: Iac2e84dd12cc0150edf84d3608caab82197e1b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505458 Commit-Queue: Shuliang Han <leonhsl@chromium.org> Reviewed-by:
Shuliang Han <leonhsl@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822004}
-
Toby Huang authored
The three main types of child accounts are Unicorn, Geller, and Griffin. Child account should be reserved as the umbrella term that refers to all supervised users. Bug: None Change-Id: I266aa26c5b41c812ed9f86fa9f4f8538ff11761b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459397Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822003}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/018f5f6dccd6..67e1cf4b1d81 2020-10-28 johnstiles@google.com Replace pooling mechanism with GrMemoryPool. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I715b329f5f37b80043394b1e82535c8fb45707d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506592Reviewed-by:
-
Shakti Sahu authored
This CL contains a few UX polish 1 - Bottom margin between IPH card and the next cards on NTP 2 - Loading screen - Added Loading... text 3 - Used TextButton style for buttons in the player Bug: None Change-Id: I9f38ea1dc154332fafbfd5643448a2c15a15f646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506511Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822001}
-
Shannon Chen authored
Making the vertical line and horizontal line sweep across the screen. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: I80278b756d92b085f4b6074a0443c07487066875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490274 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
David Black authored
Previously we removed all holding space item views when closing the holding space tray bubble. This was due to lifecycle concerns since it is possible for holding space item views to outlive their delegate due to the holding space bubble widget being asynchronously destroyed. Removing child views during a destruction sequence can have unintended side effects as it can trigger re-layout, as was the case in this crash. This CL removes the logic which removed child views when closing the bubble widget as item views only interact with the delegate in response to UI events which should not occur when the widget is being closed. Bug: 1143426 Change-Id: Ie0548401b8672c2c0c3b571e45c80900edd53b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506513Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821999}
-
Xing Liu authored
Delete metric Download.ParallelDownload.CreationEvent. Bug: 1142493 Change-Id: Id2fbf8c447afaa45c3bc3db3e9e42c78518d41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500449Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821998}
-
Patti authored
This reverts commit 85415a2c. Reason for revert: Suspected for tree closing compile error described in crbug.com/1143504 - optimize_webui.py failures. Original change's description: > OS Settings: Autogenerate grd files > > Bug: 1132403 > Change-Id: Ief77c7d304940fa9eec0c553d91674c0806cb790 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493991 > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821744} TBR=khorimoto@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I6aed7b6ca7003e5baf616520bf901ced8bd527a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403, 1143504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505699 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
-
Patti authored
This reverts commit b9c180c8. Reason for revert: Merge conflicts with actual revert for tree closing compile error described at crbug.com/1143504 - reverting both patches to be safe. Original change's description: > OS Settings: Move grit() target to settings/chromeos > > Followup from > https://chromium-review.googlesource.com/c/chromium/src/+/2493991 > > Bug: 1132403 > Change-Id: Idc2d9473feef2ad9746473a6bd8724a2f15616ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505955 > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821810} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I71d85c4595988a1b93aabf0ebe59e32e61c4c6fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403, 1143504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505356Reviewed-by:
-
Sammie Quon authored
This was left behind since the algorithm was changing during feature implementation, but now the core of the feature has been committed this can be addressed. Test: none Bug: 1111445 Change-Id: I0927ca46ffa8378a8d837cc32045d7c0b98e3167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493722 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#821995}
-
Jason Lin authored
Previously, we do some initialization in PluginVmManagerImpl when the primary profile is prepared. The initialization steps are: 1) reset some permissions stored as prefs 2) kill plugin vm dispatcher if chrome has crashed When a user with custom flags signs in, Chrome restarts itself, which causes the initialization steps to be run twice, which is unnecessary. What's worse, the first time they are run they don't "see" the custom flags, but we will soon need to make step 1 to be conditioned by a custom flag. Doing the initialization when the primary session is started solves these problems. Bug: b/167491603 Test: manually test that the initialization steps are still working Change-Id: I91dbb002e1f9c24ea4cb090a89e8241716a358e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503758Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I865d374b380b6c1bd5dc60380cb56a7ddb6bae16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506371Reviewed-by:
-
Mark Mentovai authored
Disk images produced with this compression can only be created and mounted on macOS 10.15 (“Catalina”) and later. This may be useful in the near term for things shipped to arm64 users, as the baseline OS for mac-arm64 is macOS 11.0 (“Big Sur”). This also adds ULFO (lzfse/lzvn) support to pkg-dmg, but that’s not interesting and I doubt we’ll ever use it. Bug: 1130557 Change-Id: I1ba54b8fcc0a69d8770af98a364123b64e24423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505683Reviewed-by:
-
Jimmy Gong authored
Bug: 1106937 Fixed: 1141604 Test: chromeos_components_unittests Change-Id: I033f8685061d9e5f2cfc30218786abcf89723f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503895 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Before the CL, ChromePaymentRequestFactory.sObserver was used before assigned in production code. To fix it, this CL null-check the observer, suffix it with "ForTest", and annotate it with @Nullable. This CL also add unit-tests for ChromePaymentRequestFactory which is able to capture this crash. Bug: 1143141 Binary-Size: Recovering after the wrong reduction of crrev.com/c/2499323 Change-Id: I6947fcee22d07c7641c9d22bb63defb1306c9079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504283Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821990}
-
Jan Wilken Dörrie authored
This change fixes up the GstaticFetchHttpResponseCode and GstaticFetchResult histograms in PasswordManager.WellKnownChangePassword to use `enum` instead of `units`. R=chromium-metrics-reviews@google.com Bug: 927473 Change-Id: I23e8838e065dd21bc433747f64a54d2a85da6f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485229 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821989}
-
Olivier Li authored
This is a change in preparation of logging hang count histograms per thread type. Bug: 1135528 Change-Id: I96dc1e114ac170f5ff9a32eedd57dd19ea97b152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505451 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#821988}
-
Ewann authored
This CL postpones the expiration of a year. Bug: 1140087 Change-Id: I58bccf3917e9e6edd3effc629918fcee44c643b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502336 Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Allows using NTP features in MostVisitedSites and related services in components/ Fixed: 1143475 Change-Id: I673bed5c25651acca3ef7c44512567599bb6b9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504639 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821986}
-
Sujie Zhu authored
Remove server nickname metrics logging since the feature is fully enabled and we don't need to maintain metrics for analysis post launch. Bug: 1059087 Change-Id: I07a6b8a0fc277bcf7634a26842930ed0d5978316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495794 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#821985}
-
