- 11 Jan, 2021 40 commits
-
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/* to override the method OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ide097c4908e4c92338e54565f8fa72cff2b0b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621752Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842076}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1670c5184b9e..99c3a691c23d 2021-01-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9bacbe1b34a3 to f51d965befa1 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic94d775c62f8e431ad16ccf57eef77f65e45baca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842075}
-
John Budorick authored
Bug: 1007101 Change-Id: I02608689ba9cb1c0aa72a146cf82c732d3949049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620678Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842074}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/348ba200aa29..009667d5f97c 2021-01-11 srisser@google.com Implement VK_EXT_separate_stencil_usage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3baebe3a58d81c790e1a401ab4e5f19ea3bae08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842073}
-
Maksim Moskvitin authored
This CL adds support for authentication factor registration with unknown epoch/last key version. If that's the case, ListSecurityDomains request is sent first in order to detect the actual security domain epoch if it already exists and ensure that "last" trusted vault key is actually the last. Afterwards, JoinSecurityDomainsRequest is sent with detected epoch or with epoch=0 if security domain doesn't exist. In latter case, actual epoch will be detected using JoinSecurityDomainsResponse. Bug: 1113598 Change-Id: Ie7bc4104e0a909b9aece077c1b9eedbbcf1e8ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567157 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842072}
-
Frédéric Wang authored
This CL removes the following methods: SchemeRegistry::RegisterURLSchemeAsLocal SchemeRegistry::RegisterURLSchemeAsSecure SchemeRegistry::ShouldTreatURLSchemeAsLocal SchemeRegistry::ShouldTreatURLSchemeAsSecure The initially registered schemes are based on the results of url::GetSecureSchemes() and url::GetLocalSchemes() when the URLSchemesRegistry instance is created but they are not updated afterwards, which can lead to inconsistencies [1]. Instead, this CL migrates to direct use of the corresponding url utils APIs. Note that the registration methods are not used outside tests, so there should be no observable behavior change in Chrome. It makes easier to compare SecurityOrigin::IsSecure and SecurityOrigin::IsPotentiallyTrustworthy with network::IsURLPotentiallyTrustworthy, to facilitate unification of all these APIs [2]. Finally, this CL adds back the test for custom schemes that was removed in [3], now that the SecurityOrigin APIs are compatible with url utils. [1] crbug.com/1153336 [2] crbug.com/1163060 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2595424 Bug: 1153336, 1163060 Change-Id: Iedf0a7ec6585ab3664712e9dfe49901f1159427a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614784 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842071}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610338418-1bf01a8f47d2b9b410b39a25bf178b364099d014.profdata to chrome-win64-master-1610365490-7c6abe53577006e61aa7c1c42d7ef337c3924953.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I137312227da2482af9d815b8b53a2b7e416831f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842070}
-
Zhenyao Mo authored
The test only runs on Mac with dual GPUs right now. Mark it as flaky to unblock CQ until we resolve the real issue underlying. BUG=1164647 TEST=bots R=kbr@chromium.org Change-Id: I0b9d2469abc6dbfd1c59809ce1c7c5455c860047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620088 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842069}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf3659d351a..fff8e7632e28 2021-01-11 simonmacm@google.com Merge "Add trace_config_pbtxt to the metadata in TraceMetadata." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I376a795d47e33a7c084c94baf31c64d32aa96359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfaba518..2779617a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9172f978ecf0a14e9f3fe24794079b35d61e452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842067}
-
Fredrik Söderqvist authored
SVGPatternElement::CollectPatternAttributes() rejects linked <pattern> elements that are not attached, so we need to make sure that they re- evaluate their attributes if a referenced element gets/loses a LayoutObject. Bug: 1164735 Change-Id: I0f1e28c890f7f91cacbfa0f8be133d919df5c7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620564Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#842066}
-
Ana SollanoKim authored
out of flow items" This is a reland of f08bc1d7 Original change: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 Revert of the original change: https://chromium-review.googlesource.com/c/chromium/src/+/2613550 Marked: virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-gaps-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-gaps-rtl-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/abspos/grid-positioned -items-within-grid-implicit-track-001.html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-column- axis-alignment-positioned-items-[012-016].html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-row- axis-alignment-positioned-items-[012-016].html virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-self- alignment-positioned-items-with-margin-border-padding-[011-016].html as failing in all builders. Original change's description: > [GridNG] Computation of static offsets edges and grid area for out of > flow items > > 1. Function ResolveOutOfFlowItemGridLines: The column and row span of > the grid area for the out of flow item is obtained through > GridPositionResolver, and the grid lines of the out of flow item are > computed. > > 2. Refactor of CacheItemSetIndices: For in flow items, computation of > the set indices remains the same. To compute the indices for out of flow > items we take into account the following: > a. If both the start and end line of the out of flow item are not > 'auto', then the indices are computed as if they were in flow items. > b. If either is 'auto', then its value is kNotFound. > c. If either is attempting to create a new line in the grid, then they > are treated as 'auto'. > > 3. Helper method ComputeOffsetAndSize: the computation of the offset and > size of each item was generalized to include the cases where either or > both of the set indices are auto in out of flow items. Additionally, > inline and block edges are computed. > > Bug: 1045599 > Change-Id: I15b680d1866cdb81b42d626bcd6948ae1b7132ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 > Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840701} Bug: 1045599 Change-Id: Ie2fee60c6717740fc70f5b0d285919b47f521bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616242 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#842065}
-
Wez authored
ICU is configured with the currently-configured locale in each WebEngine process when it starts up. In the browser process the locale is monitored and changes applied at run-time, to ensure that e.g. accept-language headers are up to date. The locale is passed by the browser process to some child processes (e.g. renderers) when they are started. Renderers in particular cannot have their locale re-configured dynamically once started. Bug: 1156404, 1157244 Bug: b/168161909 Change-Id: Id7ff526f1d371b103632c7a284bd16fa694654a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595368 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842064}
-
Sebastien Lalancette authored
SmokeTestCase/testAppLaunchManagerBackgroundAndForegroundApp is flaky on simulators. crbug.com/1164446 Bug: 1164446 Change-Id: I4b6db5a9d497a0341a43ebc6b14551e6d7f076ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617581 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#842063}
-
Adithya Srinivasan authored
Looking at the callsites of SetPageFocus, we only set is_focused for main frame RWHs. Change-Id: Ib28e28ea83d4815469484c509921dcde4143135c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611945Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#842062}
-
Josh Karlin authored
Bug: 1160263 Change-Id: I7712b046ebe6533451260bcd425ccb00300912b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597462 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842061}
-
Marc Treib authored
This adds a new feature param (and corresponding about:flags entry) which, when set to true, makes the profile store the default one for new users. Bug: 1160655 Change-Id: I549b624fdc4cf3f01fdfb0425cc12299d58ed9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599529 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#842060}
-
Peng Huang authored
Right now, chromium only supports linking ANGLE statically on Android, to make it easier to work and on related changes on Linux, we should\ support it on all platforms. Bug: 1161513 Change-Id: I9aaef20e88aa14be9881260d6d2b34c8417610a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608029Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842059}
-
Peter E Conn authored
Change-Id: I785b071c73e7006bf68b25c3fbd6f852d470299a Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621062Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842058}
-
Sean Harrison authored
This reverts commit ac58ad3c. Reason for revert: suspected source for blink_web_tests failing https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/22501/overview Original change's description: > dpwas: Setup Mojom for Window Controls Overlay (WCO) Javascript API > > This CL sets up a mojo interface and impl for the Window Controls > Overlay Javascript API and is hooked up to the local frame.The changes > are behind the flag: "WebAppWindowControlsOverlay" > > Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md > Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing > I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ > > Bug: 937121 > Change-Id: If21fa244ce48383748212de840ed7f5f64ea2080 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551285 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Hassan Talat <hatalat@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#841646} TBR=avi@chromium.org,dcheng@chromium.org,haraken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,hatalat@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937121 Change-Id: I665e9648f6e09d382aa05829d91703442b63c2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621652Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#842057}
-
Mustaq Ahmed authored
Remove unused parameters, enums, methods/destructors. Change-Id: I4d42cb9be7f76586fa66ed13a5a2927307e11ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598221Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#842056}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/3MqI5L2Z8aRLO-u-vkhjeZ2zve9gk6wTyRVsZs18jhUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: I4b14d45717caa2ea36f9383cd5a59a0beb7eedcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619227Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842055}
-
Fredrik Söderqvist authored
Move said method, mostly verbatim, to BoxPainterBase, inlining it in BoxPainterBase::PaintInsetBoxShadow. The side clipping setup is merged with the actual computation, and thus work directly with the |sides_to_include| parameter. The "hole" naming is replaced with "inner" to better match spec terms. Bug: 1159514 Change-Id: I09168a527b0978c717160b325c16d5e090be5192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620802Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#842054}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cffaf0aea477..da06e8f6bdb7 2021-01-11 perkj@webrtc.org Do not proxy VideoSendStreamImpl::OnVideoLayersAllocationUpdated 2021-01-11 nisse@webrtc.org Delete deprecated H264BitstreamParser methods If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id1ebd255a05ab39a40e3c498c20d7d6406c0e482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842053}
-
Nohemi Fernandez authored
Fixes a bug where the unified consent screen is not dismissed when interrupted by an external event (e.g. Siri search) on the Recent Tabs page. This is a follow-up fix for crrev.com/c/2600835. - Performs view controller cleanup on interrupt for non FRE sign-in. - Dismisses UnifiedConsentViewController when required in non FRE sign-in. - Releases SigninCoordinator on completion callback instead of teardown. Bug: 1115997 Change-Id: Ib90b689a55a2569a9daff25ffe1736507ddf41b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611027 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842052}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/voP4PTSduZCLb0NO9orrGSgCI4U2hRUPlz6SbHXspy4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/175515520,b/175635280 Tbr: media-app@grotations.appspotmail.com Change-Id: I9cbf81ac84af645fb1ef9d6ebf5880252788e8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621617Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842051}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 5e476061deb82ed4e6d440445f8830e1c7bccaa6`. Bug: 1164172 Change-Id: I486b1b8c9ee7f3f5f51c531f39970522ed2939df Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620646Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842050}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610338418-0a30eb701be1732e98bc8c78e37a5b6340c67f55.profdata to chrome-win32-master-1610365490-38da34638c6d32dc406b66a62fb936835a861238.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I58d32e5e657956c80b0ccc12e369d9c056dacbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d48354d5a1c..37e61b19a2f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156620 Tbr: harrisonsean@google.com Change-Id: I8323c93ab1ab67af14b3afb9a4d807b41cf33a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842048}
-
Felipe Andrade authored
Remove deprecated future tag from Kerberos policies. Also, update supported_on tag to version 87, which was on the stable channel when the feature was publicly launched (on the server side). Also, M87 already has all the fixes we added during the TT phase. BYPASS_POLICY_COMPATIBILITY_CHECK=These are launched policies with future tag. Bug: b:131255983 Change-Id: I9b99cbc540203fcc68997d6ef938b54746b7bbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616706Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#842047}
-
Scott Violet authored
Prior to this patch if there was an error in reading the session file nothing would be returned. This changes the code to return what was parsed. The hope is that we are at least able to restore some portion of the previous session rather than nothing. BUG=648266 TEST=none Change-Id: Ied629349fd1432b802e4454ab7092d420d143388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619010Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842046}
-
Joshua Pawlicki authored
Bug: 1064651 Change-Id: I9f30559a14a170652910bdbf12505c49f5c3591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617579 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842045}
-
Clemens Arbesser authored
The goal is to maket those methods reusable outside of client_android. Bug: b/174305656 Change-Id: I1e6188d0e8bf50d112bedf01b93f26b7816bd3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620805 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842044}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ac05066a00a9..c600e47812c8 2021-01-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e395b66ed41c to e59ae1af7571 (5 revisions) 2021-01-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 937395c1ed5d to 348ba200aa29 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I9b43ab49cc6ce9519644a03debe358c9dba275aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842043}
-
Benoit Lize authored
These annotation may help with performance, but beyond that, they help readers identify the common path, which is valuable given that there are many branches in the allocator, but mostly one common path. Bug: 998048 Change-Id: I449aa90f5256ca14069f36ef61d7a78d48f0d9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616324Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#842042}
-
Mike Reed authored
Bug: skia:7650 Change-Id: Iaf0c83d593ab6a11164373cc9a858d6795c6c093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613144 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842041}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/cws_widget/: - app_installer.js - cws_webview_client.js - cws_widget_container_error_dialog.js - cws_widget_container_platform_delegate.js - cws_widget_container.js Bug: 1133186 Change-Id: I66563e3ed21c99b168ab8c567f18fedcca26c5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619248 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842040}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97eede48be1e..183461f40237 2021-01-11 robertphillips@google.com Add a isDDLTarget flag to GrSurfaceProxy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I0078f67bdf4fa9c8b56bef36574ccafc7e827660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842039}
-
Mike West authored
This test is both flaky and replicated (unflakily) in WPT. Bug: 985869 Change-Id: Ied7b4760c1e497500a06a2942df335ff735e8960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621553 Commit-Queue: Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842038}
-
Thomas Tellier authored
Bug: 1160190 Change-Id: Ib9d2e1ac936137be379e8aa08dd9ac4b34414186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601486Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#842037}
-